[INFO] updating cached repository brad-rathke/pretendo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/brad-rathke/pretendo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/brad-rathke/pretendo" "work/ex/clippy-test-run/sources/stable/gh/brad-rathke/pretendo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/brad-rathke/pretendo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/brad-rathke/pretendo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brad-rathke/pretendo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brad-rathke/pretendo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9632518afb0a1f8f8805540f7e02edbbfd899d9f [INFO] sha for GitHub repo brad-rathke/pretendo: 9632518afb0a1f8f8805540f7e02edbbfd899d9f [INFO] validating manifest of brad-rathke/pretendo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brad-rathke/pretendo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brad-rathke/pretendo [INFO] finished frobbing brad-rathke/pretendo [INFO] frobbed toml for brad-rathke/pretendo written to work/ex/clippy-test-run/sources/stable/gh/brad-rathke/pretendo/Cargo.toml [INFO] started frobbing brad-rathke/pretendo [INFO] finished frobbing brad-rathke/pretendo [INFO] frobbed toml for brad-rathke/pretendo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/brad-rathke/pretendo/Cargo.toml [INFO] crate brad-rathke/pretendo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brad-rathke/pretendo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/brad-rathke/pretendo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb4817e304a0ba6759811fd651af5d23dc31d1e85f75ad542753133f675e25a2 [INFO] running `"docker" "start" "-a" "fb4817e304a0ba6759811fd651af5d23dc31d1e85f75ad542753133f675e25a2"` [INFO] [stderr] Checking pretendo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/cpu.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/cpu.rs:300:24 [INFO] [stderr] | [INFO] [stderr] 300 | cycles: cycles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cycles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/nes/cpu.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | let p: u8 = self.P; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/nes/cpu.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | let m: u8 = try!(self.instr_ram_read(addr, &instruction)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/memmap.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | ram: ram, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/memmap.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | ppu: ppu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ppu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/mapper.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/cpu.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/cpu.rs:300:24 [INFO] [stderr] | [INFO] [stderr] 300 | cycles: cycles, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cycles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/nes/cpu.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | let p: u8 = self.P; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/nes/cpu.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | let m: u8 = try!(self.instr_ram_read(addr, &instruction)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/memmap.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | ram: ram, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/memmap.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | ppu: ppu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ppu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes/mapper.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | rom: rom, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const C_FLAG = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const Z_FLAG = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const I_FLAG = 0b00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const D_FLAG = 0b00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | const B_FLAG = 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | const X_FLAG = 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | const V_FLAG = 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | const N_FLAG = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nes/cpu.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(((hi as u16) << 8) | (lo as u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(((hi as u16) << 8) | (lo as u16))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `nes::memmap::MemoryMap` [INFO] [stderr] --> src/nes/ppu.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use nes::memmap::MemoryMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/mapper.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | match (self.val >> 2) & 0b00000011 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/nes/mapper.rs:110:33 [INFO] [stderr] | [INFO] [stderr] 110 | self.load = self.load | ((val & 1)) << (self.write_count as usize); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `nes::error::NESError::*` [INFO] [stderr] --> src/nes/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use nes::error::NESError::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `nes::mapper::*` [INFO] [stderr] --> src/nes/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use nes::mapper::*; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rom::RomLoadError` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use rom::RomLoadError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const C_FLAG = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | const Z_FLAG = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const I_FLAG = 0b00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const D_FLAG = 0b00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | const B_FLAG = 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | const X_FLAG = 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | const V_FLAG = 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/cpu.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | const N_FLAG = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/nes/cpu.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(((hi as u16) << 8) | (lo as u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(((hi as u16) << 8) | (lo as u16))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `nes::memmap::MemoryMap` [INFO] [stderr] --> src/nes/ppu.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use nes::memmap::MemoryMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/nes/mapper.rs:32:33 [INFO] [stderr] | [INFO] [stderr] 32 | match (self.val >> 2) & 0b00000011 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/nes/mapper.rs:110:33 [INFO] [stderr] | [INFO] [stderr] 110 | self.load = self.load | ((val & 1)) << (self.write_count as usize); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unused import: `nes::error::NESError::*` [INFO] [stderr] --> src/nes/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use nes::error::NESError::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `nes::mapper::*` [INFO] [stderr] --> src/nes/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use nes::mapper::*; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `rom::RomLoadError` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use rom::RomLoadError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/nes/cpu.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | Err(e) => Err(StackOverflow(self.PC)), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/nes/cpu.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | let a: u8 = self.A; [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/nes/cpu.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | let x: u8 = self.X; [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/nes/cpu.rs:440:13 [INFO] [stderr] | [INFO] [stderr] 440 | let y: u8 = self.Y; [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/nes/cpu.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | let s: u8 = self.S; [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/nes/cpu.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | let m: u8 = try!(self.instr_ram_read(addr, &instruction)); [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/nes/cpu.rs:444:17 [INFO] [stderr] | [INFO] [stderr] 444 | let mut res: u8 = 0; [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/nes/memmap.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | fn store_byte(&mut self, addr: u16, val: u8) -> Result<(), MemoryError> { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/nes/memmap.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | fn store_byte(&mut self, addr: u16, val: u8) -> Result<(), MemoryError> { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/nes/cpu.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | let mut res: u8 = 0; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/nes/cpu.rs:411:17 [INFO] [stderr] | [INFO] [stderr] 411 | Err(e) => Err(StackOverflow(self.PC)), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `a` [INFO] [stderr] --> src/nes/cpu.rs:438:13 [INFO] [stderr] | [INFO] [stderr] 438 | let a: u8 = self.A; [INFO] [stderr] | ^ help: consider using `_a` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/nes/cpu.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | let x: u8 = self.X; [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/nes/cpu.rs:440:13 [INFO] [stderr] | [INFO] [stderr] 440 | let y: u8 = self.Y; [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/nes/cpu.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | let s: u8 = self.S; [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/nes/cpu.rs:443:13 [INFO] [stderr] | [INFO] [stderr] 443 | let m: u8 = try!(self.instr_ram_read(addr, &instruction)); [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/nes/cpu.rs:444:17 [INFO] [stderr] | [INFO] [stderr] 444 | let mut res: u8 = 0; [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `addr` [INFO] [stderr] --> src/nes/memmap.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | fn store_byte(&mut self, addr: u16, val: u8) -> Result<(), MemoryError> { [INFO] [stderr] | ^^^^ help: consider using `_addr` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `val` [INFO] [stderr] --> src/nes/memmap.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | fn store_byte(&mut self, addr: u16, val: u8) -> Result<(), MemoryError> { [INFO] [stderr] | ^^^ help: consider using `_val` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/nes/cpu.rs:444:13 [INFO] [stderr] | [INFO] [stderr] 444 | let mut res: u8 = 0; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FormatError` [INFO] [stderr] --> src/rom.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | FormatError, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mapper_hi` [INFO] [stderr] --> src/rom.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn mapper_hi(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop_stack` [INFO] [stderr] --> src/nes/cpu.rs:421:5 [INFO] [stderr] | [INFO] [stderr] 421 | fn pop_stack(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SCREEN_WIDTH` [INFO] [stderr] --> src/nes/ppu.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const SCREEN_WIDTH: usize = 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SCREEN_HEIGHT` [INFO] [stderr] --> src/nes/ppu.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const SCREEN_HEIGHT: usize = 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PPUError` [INFO] [stderr] --> src/nes/ppu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct PPUError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `vRAM` [INFO] [stderr] --> src/nes/ppu.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub struct vRAM { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AAX` [INFO] [stderr] --> src/nes/isa.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | AAX, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ASO` [INFO] [stderr] --> src/nes/isa.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | ASO, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AXS` [INFO] [stderr] --> src/nes/isa.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | AXS, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DCM` [INFO] [stderr] --> src/nes/isa.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | DCM, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DCP` [INFO] [stderr] --> src/nes/isa.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | DCP, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DOP` [INFO] [stderr] --> src/nes/isa.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | DOP, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `INS` [INFO] [stderr] --> src/nes/isa.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | INS, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ISB` [INFO] [stderr] --> src/nes/isa.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | ISB, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ISC` [INFO] [stderr] --> src/nes/isa.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | ISC, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LAX` [INFO] [stderr] --> src/nes/isa.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | LAX, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LSE` [INFO] [stderr] --> src/nes/isa.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | LSE, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RLA` [INFO] [stderr] --> src/nes/isa.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | RLA, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RRA` [INFO] [stderr] --> src/nes/isa.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | RRA, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SAX` [INFO] [stderr] --> src/nes/isa.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | SAX, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKB` [INFO] [stderr] --> src/nes/isa.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | SKB, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKW` [INFO] [stderr] --> src/nes/isa.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | SKW, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SLO` [INFO] [stderr] --> src/nes/isa.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | SLO, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SRE` [INFO] [stderr] --> src/nes/isa.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | SRE, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TOP` [INFO] [stderr] --> src/nes/isa.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | TOP, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | self.prg_rom_size as u16 * 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.prg_rom_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | self.chr_rom_size as u16 * 8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.chr_rom_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | try!(file.read(&mut header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | try!(file.read(&mut rom.trainer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | try!(file.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | try!(file.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FormatError` [INFO] [stderr] --> src/rom.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | FormatError, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `PC` should have a snake case name such as `pc` [INFO] [stderr] --> src/nes/cpu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | PC: u16, //Program counter [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `mapper_hi` [INFO] [stderr] --> src/rom.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn mapper_hi(&self) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `A` should have a snake case name such as `a` [INFO] [stderr] --> src/nes/cpu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | A: u8, //Accumulator [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `X` should have a snake case name such as `x` [INFO] [stderr] --> src/nes/cpu.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | X: u8, //X register [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `Y` should have a snake case name such as `y` [INFO] [stderr] --> src/nes/cpu.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Y: u8, //Y register [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name such as `s` [INFO] [stderr] --> src/nes/cpu.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | S: u8, //Stack pointer [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `P` should have a snake case name such as `p` [INFO] [stderr] --> src/nes/cpu.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | P: u8, //Status [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `pop_stack` [INFO] [stderr] --> src/nes/cpu.rs:421:5 [INFO] [stderr] | [INFO] [stderr] 421 | fn pop_stack(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SCREEN_WIDTH` [INFO] [stderr] --> src/nes/ppu.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub const SCREEN_WIDTH: usize = 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SCREEN_HEIGHT` [INFO] [stderr] --> src/nes/ppu.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub const SCREEN_HEIGHT: usize = 256; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PPUError` [INFO] [stderr] --> src/nes/ppu.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub struct PPUError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `vRAM` [INFO] [stderr] --> src/nes/ppu.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | pub struct vRAM { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AAX` [INFO] [stderr] --> src/nes/isa.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | AAX, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ASO` [INFO] [stderr] --> src/nes/isa.rs:96:5 [INFO] [stderr] | [INFO] [stderr] 96 | ASO, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AXS` [INFO] [stderr] --> src/nes/isa.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | AXS, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DCM` [INFO] [stderr] --> src/nes/isa.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | DCM, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DCP` [INFO] [stderr] --> src/nes/isa.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | DCP, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DOP` [INFO] [stderr] --> src/nes/isa.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | DOP, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `INS` [INFO] [stderr] --> src/nes/isa.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | INS, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ISB` [INFO] [stderr] --> src/nes/isa.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | ISB, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ISC` [INFO] [stderr] --> src/nes/isa.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | ISC, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LAX` [INFO] [stderr] --> src/nes/isa.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | LAX, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LSE` [INFO] [stderr] --> src/nes/isa.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | LSE, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RLA` [INFO] [stderr] --> src/nes/isa.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | RLA, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RRA` [INFO] [stderr] --> src/nes/isa.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | RRA, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SAX` [INFO] [stderr] --> src/nes/isa.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | SAX, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKB` [INFO] [stderr] --> src/nes/isa.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | SKB, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SKW` [INFO] [stderr] --> src/nes/isa.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | SKW, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SLO` [INFO] [stderr] --> src/nes/isa.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | SLO, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SRE` [INFO] [stderr] --> src/nes/isa.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | SRE, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `TOP` [INFO] [stderr] --> src/nes/isa.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | TOP, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:94:23 [INFO] [stderr] | [INFO] [stderr] 94 | let lo: u16 = try!(self.read_byte(addr)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | let lo: u16 = u16::from(match $ expr { [INFO] [stderr] 95 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 96 | :: Err ( err ) => { [INFO] [stderr] 97 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 98 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | let hi: u16 = try!(self.read_byte(addr + 1)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | let hi: u16 = u16::from(match $ expr { [INFO] [stderr] 96 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 97 | :: Err ( err ) => { [INFO] [stderr] 98 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 99 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(((hi as u16) << 8) | (lo as u16)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:106:40 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(((hi as u16) << 8) | (lo as u16)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:102:16 [INFO] [stderr] | [INFO] [stderr] 102 | self.prg_rom_size as u16 * 16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.prg_rom_size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/rom.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | self.chr_rom_size as u16 * 8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.chr_rom_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | try!(file.read(&mut header)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | try!(file.read(&mut rom.trainer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | try!(file.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/rom.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | try!(file.read(&mut buf)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nes/cpu.rs:309:51 [INFO] [stderr] | [INFO] [stderr] 309 | fn instr_address_info(&mut self, instruction: &Instruction) -> Result<(u16, u16), NESError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:314:44 [INFO] [stderr] | [INFO] [stderr] 314 | AddressMode::ZeroPageIndexX => try!(self.read_pc_byte()) as u16 + (self.X as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 314 | AddressMode::ZeroPageIndexX => u16::from(match $ expr { [INFO] [stderr] 315 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 316 | :: Err ( err ) => { [INFO] [stderr] 317 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 318 | $ crate :: convert :: From :: from ( err ) ) } }) + (self.X as u16), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:314:79 [INFO] [stderr] | [INFO] [stderr] 314 | AddressMode::ZeroPageIndexX => try!(self.read_pc_byte()) as u16 + (self.X as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:316:44 [INFO] [stderr] | [INFO] [stderr] 316 | AddressMode::ZeroPageIndexY => try!(self.read_pc_byte()) as u16 + (self.Y as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | AddressMode::ZeroPageIndexY => u16::from(match $ expr { [INFO] [stderr] 317 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 318 | :: Err ( err ) => { [INFO] [stderr] 319 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 320 | $ crate :: convert :: From :: from ( err ) ) } }) + (self.Y as u16), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:316:79 [INFO] [stderr] | [INFO] [stderr] 316 | AddressMode::ZeroPageIndexY => try!(self.read_pc_byte()) as u16 + (self.Y as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:320:38 [INFO] [stderr] | [INFO] [stderr] 320 | let addr = pc_addr + (self.X as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:327:38 [INFO] [stderr] | [INFO] [stderr] 327 | let addr = pc_addr + (self.Y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:333:37 [INFO] [stderr] | [INFO] [stderr] 333 | let indirect: u16 = try!(self.read_pc_byte()) as u16 + (self.X as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 333 | let indirect: u16 = u16::from(match $ expr { [INFO] [stderr] 334 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 335 | :: Err ( err ) => { [INFO] [stderr] 336 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 337 | $ crate :: convert :: From :: from ( err ) ) } }) + (self.X as u16); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:333:72 [INFO] [stderr] | [INFO] [stderr] 333 | let indirect: u16 = try!(self.read_pc_byte()) as u16 + (self.X as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:338:37 [INFO] [stderr] | [INFO] [stderr] 338 | let indirect: u16 = try!(self.read_pc_byte()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 338 | let indirect: u16 = u16::from(match $ expr { [INFO] [stderr] 339 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 340 | :: Err ( err ) => { [INFO] [stderr] 341 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 342 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:340:39 [INFO] [stderr] | [INFO] [stderr] 340 | let addr = ind_addr + (self.Y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | try!(self.read_pc_byte()) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | u16::from(match $ expr { [INFO] [stderr] 352 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 353 | :: Err ( err ) => { [INFO] [stderr] 354 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 355 | $ crate :: convert :: From :: from ( err ) ) } }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/nes/cpu.rs:361:51 [INFO] [stderr] | [INFO] [stderr] 361 | _ => return Err(ExecuteError(self.PC, instruction.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*instruction` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nes/cpu.rs:385:58 [INFO] [stderr] | [INFO] [stderr] 385 | fn instr_ram_read(&mut self, addr: u16, instruction: &Instruction) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:405:34 [INFO] [stderr] | [INFO] [stderr] 405 | let addr: u16 = 0x0100 | (self.S as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.S)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:426:34 [INFO] [stderr] | [INFO] [stderr] 426 | let addr: u16 = 0x0100 | (self.S as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.S)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/nes/cpu.rs:448:17 [INFO] [stderr] | [INFO] [stderr] 448 | self.push_addr_stack(pc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/nes/cpu.rs:449:17 [INFO] [stderr] | [INFO] [stderr] 449 | self.push_stack(p | B_FLAG.bits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `CTRL` should have a snake case name such as `ctrl` [INFO] [stderr] --> src/nes/ppu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub CTRL: u8, //$2000 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `MASK` should have a snake case name such as `mask` [INFO] [stderr] --> src/nes/ppu.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub MASK: u8, //$2001 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `STATUS` should have a snake case name such as `status` [INFO] [stderr] --> src/nes/ppu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub STATUS: u8, //$2002 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAMADDR` should have a snake case name such as `oamaddr` [INFO] [stderr] --> src/nes/ppu.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub OAMADDR: u8, //$2003 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAMDATA` should have a snake case name such as `oamdata` [INFO] [stderr] --> src/nes/ppu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub OAMDATA: u8, //$2004 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `SCROLL` should have a snake case name such as `scroll` [INFO] [stderr] --> src/nes/ppu.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub SCROLL: u8, //$2005 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `ADDR` should have a snake case name such as `addr` [INFO] [stderr] --> src/nes/ppu.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub ADDR: u8, //$2006 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `DATA` should have a snake case name such as `data` [INFO] [stderr] --> src/nes/ppu.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub DATA: u8, //$2007 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAMDMA` should have a snake case name such as `oamdma` [INFO] [stderr] --> src/nes/ppu.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub OAMDMA: u8, //$4014 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `vRAM` should have a camel case name such as `Vram` [INFO] [stderr] --> src/nes/ppu.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / pub struct vRAM { [INFO] [stderr] 38 | | pub nametables: [u8; 0x800], // Two nametables, 0x400 in size each. [INFO] [stderr] 39 | | pub palette: [u8; 0x20], [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `PC` should have a snake case name such as `pc` [INFO] [stderr] --> src/nes/cpu.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | PC: u16, //Program counter [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: structure field `A` should have a snake case name such as `a` [INFO] [stderr] --> src/nes/cpu.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | A: u8, //Accumulator [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `X` should have a snake case name such as `x` [INFO] [stderr] --> src/nes/cpu.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | X: u8, //X register [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `Y` should have a snake case name such as `y` [INFO] [stderr] --> src/nes/cpu.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Y: u8, //Y register [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name such as `s` [INFO] [stderr] --> src/nes/cpu.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | S: u8, //Stack pointer [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `P` should have a snake case name such as `p` [INFO] [stderr] --> src/nes/cpu.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | P: u8, //Status [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:94:23 [INFO] [stderr] | [INFO] [stderr] 94 | let lo: u16 = try!(self.read_byte(addr)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | let lo: u16 = u16::from(match $ expr { [INFO] [stderr] 95 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 96 | :: Err ( err ) => { [INFO] [stderr] 97 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 98 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:95:23 [INFO] [stderr] | [INFO] [stderr] 95 | let hi: u16 = try!(self.read_byte(addr + 1)) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 95 | let hi: u16 = u16::from(match $ expr { [INFO] [stderr] 96 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 97 | :: Err ( err ) => { [INFO] [stderr] 98 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 99 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:106:20 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(((hi as u16) << 8) | (lo as u16)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:106:40 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(((hi as u16) << 8) | (lo as u16)); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nes/cpu.rs:309:51 [INFO] [stderr] | [INFO] [stderr] 309 | fn instr_address_info(&mut self, instruction: &Instruction) -> Result<(u16, u16), NESError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:314:44 [INFO] [stderr] | [INFO] [stderr] 314 | AddressMode::ZeroPageIndexX => try!(self.read_pc_byte()) as u16 + (self.X as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 314 | AddressMode::ZeroPageIndexX => u16::from(match $ expr { [INFO] [stderr] 315 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 316 | :: Err ( err ) => { [INFO] [stderr] 317 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 318 | $ crate :: convert :: From :: from ( err ) ) } }) + (self.X as u16), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:314:79 [INFO] [stderr] | [INFO] [stderr] 314 | AddressMode::ZeroPageIndexX => try!(self.read_pc_byte()) as u16 + (self.X as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:316:44 [INFO] [stderr] | [INFO] [stderr] 316 | AddressMode::ZeroPageIndexY => try!(self.read_pc_byte()) as u16 + (self.Y as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 316 | AddressMode::ZeroPageIndexY => u16::from(match $ expr { [INFO] [stderr] 317 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 318 | :: Err ( err ) => { [INFO] [stderr] 319 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 320 | $ crate :: convert :: From :: from ( err ) ) } }) + (self.Y as u16), [INFO] [stderr] | [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/nes/mapper.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | 0...0x8000 => 0u8, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/nes/mapper.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | 0x8000...0xc000 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:316:79 [INFO] [stderr] | [INFO] [stderr] 316 | AddressMode::ZeroPageIndexY => try!(self.read_pc_byte()) as u16 + (self.Y as u16), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:320:38 [INFO] [stderr] | [INFO] [stderr] 320 | let addr = pc_addr + (self.X as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:327:38 [INFO] [stderr] | [INFO] [stderr] 327 | let addr = pc_addr + (self.Y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:333:37 [INFO] [stderr] | [INFO] [stderr] 333 | let indirect: u16 = try!(self.read_pc_byte()) as u16 + (self.X as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/nes/mapper.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | self.load = self.load | ((val & 1)) << (self.write_count as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.load |= ((val & 1)) << (self.write_count as usize)` [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 333 | let indirect: u16 = u16::from(match $ expr { [INFO] [stderr] 334 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 335 | :: Err ( err ) => { [INFO] [stderr] 336 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 337 | $ crate :: convert :: From :: from ( err ) ) } }) + (self.X as u16); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:333:72 [INFO] [stderr] | [INFO] [stderr] 333 | let indirect: u16 = try!(self.read_pc_byte()) as u16 + (self.X as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/nes/mapper.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | 0x0000...0xa000 => self.control = MMC1CtrlReg { val: self.load }, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/nes/mapper.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | 0xa000...0xc000 => self.chr_bank_0 = self.load, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:338:37 [INFO] [stderr] | [INFO] [stderr] 338 | let indirect: u16 = try!(self.read_pc_byte()) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 338 | let indirect: u16 = u16::from(match $ expr { [INFO] [stderr] 339 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 340 | :: Err ( err ) => { [INFO] [stderr] 341 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 342 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:340:39 [INFO] [stderr] | [INFO] [stderr] 340 | let addr = ind_addr + (self.Y as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.Y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:351:17 [INFO] [stderr] | [INFO] [stderr] 351 | try!(self.read_pc_byte()) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 351 | u16::from(match $ expr { [INFO] [stderr] 352 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 353 | :: Err ( err ) => { [INFO] [stderr] 354 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 355 | $ crate :: convert :: From :: from ( err ) ) } }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/nes/cpu.rs:361:51 [INFO] [stderr] | [INFO] [stderr] 361 | _ => return Err(ExecuteError(self.PC, instruction.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*instruction` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/nes/cpu.rs:385:58 [INFO] [stderr] | [INFO] [stderr] 385 | fn instr_ram_read(&mut self, addr: u16, instruction: &Instruction) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:405:34 [INFO] [stderr] | [INFO] [stderr] 405 | let addr: u16 = 0x0100 | (self.S as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.S)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/cpu.rs:426:34 [INFO] [stderr] | [INFO] [stderr] 426 | let addr: u16 = 0x0100 | (self.S as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(self.S)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match nes.run() { [INFO] [stderr] 35 | | Err(err) => panic!("{}", err), [INFO] [stderr] 36 | | _ => {} [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = nes.run() { panic!("{}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/nes/cpu.rs:448:17 [INFO] [stderr] | [INFO] [stderr] 448 | self.push_addr_stack(pc); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/nes/cpu.rs:449:17 [INFO] [stderr] | [INFO] [stderr] 449 | self.push_stack(p | B_FLAG.bits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: structure field `CTRL` should have a snake case name such as `ctrl` [INFO] [stderr] --> src/nes/ppu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | pub CTRL: u8, //$2000 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `MASK` should have a snake case name such as `mask` [INFO] [stderr] --> src/nes/ppu.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub MASK: u8, //$2001 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `STATUS` should have a snake case name such as `status` [INFO] [stderr] --> src/nes/ppu.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub STATUS: u8, //$2002 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAMADDR` should have a snake case name such as `oamaddr` [INFO] [stderr] --> src/nes/ppu.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | pub OAMADDR: u8, //$2003 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAMDATA` should have a snake case name such as `oamdata` [INFO] [stderr] --> src/nes/ppu.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub OAMDATA: u8, //$2004 [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `SCROLL` should have a snake case name such as `scroll` [INFO] [stderr] --> src/nes/ppu.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | pub SCROLL: u8, //$2005 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `ADDR` should have a snake case name such as `addr` [INFO] [stderr] --> src/nes/ppu.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub ADDR: u8, //$2006 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `DATA` should have a snake case name such as `data` [INFO] [stderr] --> src/nes/ppu.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub DATA: u8, //$2007 [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: structure field `OAMDMA` should have a snake case name such as `oamdma` [INFO] [stderr] --> src/nes/ppu.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | pub OAMDMA: u8, //$4014 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: type `vRAM` should have a camel case name such as `Vram` [INFO] [stderr] --> src/nes/ppu.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / pub struct vRAM { [INFO] [stderr] 38 | | pub nametables: [u8; 0x800], // Two nametables, 0x400 in size each. [INFO] [stderr] 39 | | pub palette: [u8; 0x20], [INFO] [stderr] 40 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pretendo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/nes/mapper.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | 0...0x8000 => 0u8, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/nes/mapper.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | 0x8000...0xc000 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/nes/mapper.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | self.load = self.load | ((val & 1)) << (self.write_count as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.load |= ((val & 1)) << (self.write_count as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/nes/mapper.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | 0x0000...0xa000 => self.control = MMC1CtrlReg { val: self.load }, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/nes/mapper.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | 0xa000...0xc000 => self.chr_bank_0 = self.load, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / match nes.run() { [INFO] [stderr] 35 | | Err(err) => panic!("{}", err), [INFO] [stderr] 36 | | _ => {} [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = nes.run() { panic!("{}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pretendo`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fb4817e304a0ba6759811fd651af5d23dc31d1e85f75ad542753133f675e25a2"` [INFO] running `"docker" "rm" "-f" "fb4817e304a0ba6759811fd651af5d23dc31d1e85f75ad542753133f675e25a2"` [INFO] [stdout] fb4817e304a0ba6759811fd651af5d23dc31d1e85f75ad542753133f675e25a2