[INFO] updating cached repository bpicolo/aoc2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bpicolo/aoc2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bpicolo/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/bpicolo/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bpicolo/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bpicolo/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpicolo/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpicolo/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 56c202ebfe4369b4ebf866ee2054277a4549c79a
[INFO] sha for GitHub repo bpicolo/aoc2018: 56c202ebfe4369b4ebf866ee2054277a4549c79a
[INFO] validating manifest of bpicolo/aoc2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bpicolo/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bpicolo/aoc2018
[INFO] finished frobbing bpicolo/aoc2018
[INFO] frobbed toml for bpicolo/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/bpicolo/aoc2018/Cargo.toml
[INFO] started frobbing bpicolo/aoc2018
[INFO] finished frobbing bpicolo/aoc2018
[INFO] frobbed toml for bpicolo/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpicolo/aoc2018/Cargo.toml
[INFO] crate bpicolo/aoc2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bpicolo/aoc2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bpicolo/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 09f0c56c47b3b6422555693a1729f9f9c38b136af43c357474d97c75c510d904
[INFO] running `"docker" "start" "-a" "09f0c56c47b3b6422555693a1729f9f9c38b136af43c357474d97c75c510d904"`
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking structopt v0.2.13
[INFO] [stderr]     Checking aoc v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             problem: problem,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `problem`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             solution: solution,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `solution`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             problem: problem,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `problem`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             solution: solution,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `solution`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return self.left + self.width;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.left + self.width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return self.top + self.height;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.top + self.height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:60:9
[INFO] [stderr]    |
[INFO] [stderr] 60 |         return self.left + self.width;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.left + self.width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/geometry.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         return self.top + self.height;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.top + self.height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day4/part2/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             time: time,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `time`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part1/main.rs:44:38
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let fill_point = Point { x: x, y: y };
[INFO] [stderr]    |                                      ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part1/main.rs:44:44
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let fill_point = Point { x: x, y: y };
[INFO] [stderr]    |                                            ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part1/main.rs:44:38
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let fill_point = Point { x: x, y: y };
[INFO] [stderr]    |                                      ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part1/main.rs:44:44
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let fill_point = Point { x: x, y: y };
[INFO] [stderr]    |                                            ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day4/part1/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             time: time,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `time`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day4/part1/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             time: time,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `time`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day4/part2/main.rs:79:34
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn find_most_slept_minute(spans: &Vec<SleepSpan>) -> (i32, i32) {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^ help: change this to: `&[SleepSpan]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/day4/part2/main.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 if !sleeping_spans_by_guard.contains_key(&current_guard_id.unwrap()) {
[INFO] [stderr] 119 | |                     sleeping_spans_by_guard.insert(current_guard_id.unwrap(), vec![]);
[INFO] [stderr] 120 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using: `sleeping_spans_by_guard.entry(current_guard_id.unwrap()).or_insert(< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day6/part1/main.rs:11:19
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn parse_point(s: &String) -> Point {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6/part1/main.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn find_bounding_box(points: &Vec<Point>) -> BoundingBox {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part2/main.rs:41:39
[INFO] [stderr]    |
[INFO] [stderr] 41 |             let check_point = Point { x: x, y: y };
[INFO] [stderr]    |                                       ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part2/main.rs:41:45
[INFO] [stderr]    |
[INFO] [stderr] 41 |             let check_point = Point { x: x, y: y };
[INFO] [stderr]    |                                             ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day4/part1/main.rs:86:34
[INFO] [stderr]    |
[INFO] [stderr] 86 | fn find_most_slept_minute(spans: &Vec<SleepSpan>) -> i32 {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^ help: change this to: `&[SleepSpan]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/day4/part1/main.rs:125:17
[INFO] [stderr]     |
[INFO] [stderr] 125 | /                 if !sleeping_spans_by_guard.contains_key(&current_guard_id.unwrap()) {
[INFO] [stderr] 126 | |                     sleeping_spans_by_guard.insert(current_guard_id.unwrap(), vec![]);
[INFO] [stderr] 127 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using: `sleeping_spans_by_guard.entry(current_guard_id.unwrap()).or_insert(< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/part1/main.rs:146:32
[INFO] [stderr]     |
[INFO] [stderr] 146 |         find_most_slept_minute(sleeping_spans_by_guard.get(&sleepiest_guard_id).unwrap());
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sleeping_spans_by_guard[&sleepiest_guard_id]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day6/part1/main.rs:11:19
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn parse_point(s: &String) -> Point {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6/part1/main.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn find_bounding_box(points: &Vec<Point>) -> BoundingBox {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `claims`.
[INFO] [stderr]   --> src/day3/part2/main.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for j in i + 1..claims.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for <item> in claims.iter().skip(i + 1) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `claims`.
[INFO] [stderr]   --> src/day3/part2/main.rs:35:14
[INFO] [stderr]    |
[INFO] [stderr] 35 |     for i in 0..claims.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 35 |     for <item> in &claims {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day4/part2/main.rs:56:13
[INFO] [stderr]    |
[INFO] [stderr] 56 |             time: time,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `time`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day4/part1/main.rs:86:34
[INFO] [stderr]    |
[INFO] [stderr] 86 | fn find_most_slept_minute(spans: &Vec<SleepSpan>) -> i32 {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^ help: change this to: `&[SleepSpan]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/day4/part1/main.rs:125:17
[INFO] [stderr]     |
[INFO] [stderr] 125 | /                 if !sleeping_spans_by_guard.contains_key(&current_guard_id.unwrap()) {
[INFO] [stderr] 126 | |                     sleeping_spans_by_guard.insert(current_guard_id.unwrap(), vec![]);
[INFO] [stderr] 127 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using: `sleeping_spans_by_guard.entry(current_guard_id.unwrap()).or_insert(< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/part1/main.rs:146:32
[INFO] [stderr]     |
[INFO] [stderr] 146 |         find_most_slept_minute(sleeping_spans_by_guard.get(&sleepiest_guard_id).unwrap());
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sleeping_spans_by_guard[&sleepiest_guard_id]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `claims`.
[INFO] [stderr]   --> src/day3/part2/main.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for j in i + 1..claims.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for <item> in claims.iter().skip(i + 1) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `claims`.
[INFO] [stderr]   --> src/day3/part2/main.rs:35:14
[INFO] [stderr]    |
[INFO] [stderr] 35 |     for i in 0..claims.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 35 |     for <item> in &claims {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/day5/part2/main.rs:18:10
[INFO] [stderr]    |
[INFO] [stderr] 18 |         .into_iter()
[INFO] [stderr]    |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day6/part2/main.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn parse_point(s: &String) -> Point {
[INFO] [stderr]   |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6/part2/main.rs:18:30
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn find_bounding_box(points: &Vec<Point>) -> BoundingBox {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day4/part2/main.rs:79:34
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn find_most_slept_minute(spans: &Vec<SleepSpan>) -> (i32, i32) {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^^^ help: change this to: `&[SleepSpan]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/day4/part2/main.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 if !sleeping_spans_by_guard.contains_key(&current_guard_id.unwrap()) {
[INFO] [stderr] 119 | |                     sleeping_spans_by_guard.insert(current_guard_id.unwrap(), vec![]);
[INFO] [stderr] 120 | |                 }
[INFO] [stderr]     | |_________________^ help: consider using: `sleeping_spans_by_guard.entry(current_guard_id.unwrap()).or_insert(< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `claims`.
[INFO] [stderr]   --> src/day3/part1/main.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for j in i + 1..claims.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for <item> in claims.iter().skip(i + 1) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/day3/part1/main.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 | /             match claim.intersecting_points(&cmp_to_claim) {
[INFO] [stderr] 33 | |                 Some(points) => {
[INFO] [stderr] 34 | |                     for point in points {
[INFO] [stderr] 35 | |                         intersecting.insert(point);
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |                 None => (),
[INFO] [stderr] 39 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 32 |             if let Some(points) = claim.intersecting_points(&cmp_to_claim) {
[INFO] [stderr] 33 |     for point in points {
[INFO] [stderr] 34 |         intersecting.insert(point);
[INFO] [stderr] 35 |     }
[INFO] [stderr] 36 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part2/main.rs:41:39
[INFO] [stderr]    |
[INFO] [stderr] 41 |             let check_point = Point { x: x, y: y };
[INFO] [stderr]    |                                       ^^^^ help: replace it with: `x`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/part2/main.rs:41:45
[INFO] [stderr]    |
[INFO] [stderr] 41 |             let check_point = Point { x: x, y: y };
[INFO] [stderr]    |                                             ^^^^ help: replace it with: `y`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day2/part2/main.rs:8:29
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn differ_by_single_char(a: &String, b: &String) -> bool {
[INFO] [stderr]   |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day2/part2/main.rs:8:41
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn differ_by_single_char(a: &String, b: &String) -> bool {
[INFO] [stderr]   |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/day5/part2/main.rs:18:10
[INFO] [stderr]    |
[INFO] [stderr] 18 |         .into_iter()
[INFO] [stderr]    |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day6/part2/main.rs:9:19
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn parse_point(s: &String) -> Point {
[INFO] [stderr]   |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6/part2/main.rs:18:30
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn find_bounding_box(points: &Vec<Point>) -> BoundingBox {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: change this to: `&[Point]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is only used to index `claims`.
[INFO] [stderr]   --> src/day3/part1/main.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for j in i + 1..claims.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 24 |         for <item> in claims.iter().skip(i + 1) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/day3/part1/main.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 | /             match claim.intersecting_points(&cmp_to_claim) {
[INFO] [stderr] 33 | |                 Some(points) => {
[INFO] [stderr] 34 | |                     for point in points {
[INFO] [stderr] 35 | |                         intersecting.insert(point);
[INFO] [stderr] ...  |
[INFO] [stderr] 38 | |                 None => (),
[INFO] [stderr] 39 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 32 |             if let Some(points) = claim.intersecting_points(&cmp_to_claim) {
[INFO] [stderr] 33 |     for point in points {
[INFO] [stderr] 34 |         intersecting.insert(point);
[INFO] [stderr] 35 |     }
[INFO] [stderr] 36 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day2/part2/main.rs:8:29
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn differ_by_single_char(a: &String, b: &String) -> bool {
[INFO] [stderr]   |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/day2/part2/main.rs:8:41
[INFO] [stderr]   |
[INFO] [stderr] 8 | fn differ_by_single_char(a: &String, b: &String) -> bool {
[INFO] [stderr]   |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 31.58s
[INFO] running `"docker" "inspect" "09f0c56c47b3b6422555693a1729f9f9c38b136af43c357474d97c75c510d904"`
[INFO] running `"docker" "rm" "-f" "09f0c56c47b3b6422555693a1729f9f9c38b136af43c357474d97c75c510d904"`
[INFO] [stdout] 09f0c56c47b3b6422555693a1729f9f9c38b136af43c357474d97c75c510d904