[INFO] updating cached repository bpglaser/maze_solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bpglaser/maze_solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bpglaser/maze_solver" "work/ex/clippy-test-run/sources/stable/gh/bpglaser/maze_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bpglaser/maze_solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bpglaser/maze_solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpglaser/maze_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpglaser/maze_solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ae3a55ae19d3e4d4e2c5b342c6af7a775b8c1f39 [INFO] sha for GitHub repo bpglaser/maze_solver: ae3a55ae19d3e4d4e2c5b342c6af7a775b8c1f39 [INFO] validating manifest of bpglaser/maze_solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bpglaser/maze_solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bpglaser/maze_solver [INFO] finished frobbing bpglaser/maze_solver [INFO] frobbed toml for bpglaser/maze_solver written to work/ex/clippy-test-run/sources/stable/gh/bpglaser/maze_solver/Cargo.toml [INFO] started frobbing bpglaser/maze_solver [INFO] finished frobbing bpglaser/maze_solver [INFO] frobbed toml for bpglaser/maze_solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpglaser/maze_solver/Cargo.toml [INFO] crate bpglaser/maze_solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bpglaser/maze_solver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bpglaser/maze_solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49ebc5b02c9ad11c0712da5cc1fc6f0e952e54f170157a377cf6546deb1812b3 [INFO] running `"docker" "start" "-a" "49ebc5b02c9ad11c0712da5cc1fc6f0e952e54f170157a377cf6546deb1812b3"` [INFO] [stderr] Compiling gdk-pixbuf v0.1.1 [INFO] [stderr] Compiling cairo-rs v0.1.1 [INFO] [stderr] Compiling gio v0.1.1 [INFO] [stderr] Compiling gdk v0.5.1 [INFO] [stderr] Compiling gtk v0.1.1 [INFO] [stderr] Compiling gio-sys v0.3.2 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.2 [INFO] [stderr] Compiling cairo-sys-rs v0.3.2 [INFO] [stderr] Compiling pango-sys v0.3.2 [INFO] [stderr] Compiling gdk-sys v0.3.2 [INFO] [stderr] Compiling gtk-sys v0.3.2 [INFO] [stderr] Checking term_size v0.2.1 [INFO] [stderr] Checking glib-sys v0.3.2 [INFO] [stderr] Checking image v0.12.1 [INFO] [stderr] Checking clap v2.19.3 [INFO] [stderr] Checking gobject-sys v0.3.2 [INFO] [stderr] Checking glib v0.1.1 [INFO] [stderr] Checking atk-sys v0.3.2 [INFO] [stderr] Checking pango v0.1.1 [INFO] [stderr] Checking maze_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathfind.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathfind.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathfind.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | goal: goal, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `goal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | Point { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathfind.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | grid: grid, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `grid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathfind.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pathfind.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | goal: goal, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `goal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `grid::Grid` [INFO] [stderr] --> src/grid.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | Grid { items: HashMap::new() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/grid.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match direction { [INFO] [stderr] 76 | | &Direction::Up => self.offset_up(), [INFO] [stderr] 77 | | &Direction::Down => self.offset_down(), [INFO] [stderr] 78 | | &Direction::Left => self.offset_left(), [INFO] [stderr] 79 | | &Direction::Right => self.offset_right(), [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *direction { [INFO] [stderr] 76 | Direction::Up => self.offset_up(), [INFO] [stderr] 77 | Direction::Down => self.offset_down(), [INFO] [stderr] 78 | Direction::Left => self.offset_left(), [INFO] [stderr] 79 | Direction::Right => self.offset_right(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `grid::Grid` [INFO] [stderr] --> src/grid.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | Grid { items: HashMap::new() } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/grid.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match direction { [INFO] [stderr] 76 | | &Direction::Up => self.offset_up(), [INFO] [stderr] 77 | | &Direction::Down => self.offset_down(), [INFO] [stderr] 78 | | &Direction::Left => self.offset_left(), [INFO] [stderr] 79 | | &Direction::Right => self.offset_right(), [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *direction { [INFO] [stderr] 76 | Direction::Up => self.offset_up(), [INFO] [stderr] 77 | Direction::Down => self.offset_down(), [INFO] [stderr] 78 | Direction::Left => self.offset_left(), [INFO] [stderr] 79 | Direction::Right => self.offset_right(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Grid`, `Point` [INFO] [stderr] --> src/main.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | use maze_solver::grid::{Point, Grid}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Grid`, `Point` [INFO] [stderr] --> src/main.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | use maze_solver::grid::{Point, Grid}; [INFO] [stderr] | ^^^^^ ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loaded_image` [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let loaded_image = open(path).expect("Error opening file").grayscale(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_loaded_image` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `loaded_image` [INFO] [stderr] --> src/main.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | let loaded_image = open(path).expect("Error opening file").grayscale(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_loaded_image` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.11s [INFO] running `"docker" "inspect" "49ebc5b02c9ad11c0712da5cc1fc6f0e952e54f170157a377cf6546deb1812b3"` [INFO] running `"docker" "rm" "-f" "49ebc5b02c9ad11c0712da5cc1fc6f0e952e54f170157a377cf6546deb1812b3"` [INFO] [stdout] 49ebc5b02c9ad11c0712da5cc1fc6f0e952e54f170157a377cf6546deb1812b3