[INFO] updating cached repository bpeel/synacor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bpeel/synacor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bpeel/synacor" "work/ex/clippy-test-run/sources/stable/gh/bpeel/synacor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bpeel/synacor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bpeel/synacor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpeel/synacor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpeel/synacor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e4285d0d66c9ced89f5ffd3f401d7236e9f6f482 [INFO] sha for GitHub repo bpeel/synacor: e4285d0d66c9ced89f5ffd3f401d7236e9f6f482 [INFO] validating manifest of bpeel/synacor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bpeel/synacor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bpeel/synacor [INFO] finished frobbing bpeel/synacor [INFO] frobbed toml for bpeel/synacor written to work/ex/clippy-test-run/sources/stable/gh/bpeel/synacor/Cargo.toml [INFO] started frobbing bpeel/synacor [INFO] finished frobbing bpeel/synacor [INFO] frobbed toml for bpeel/synacor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bpeel/synacor/Cargo.toml [INFO] crate bpeel/synacor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bpeel/synacor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bpeel/synacor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 746e3940280105f3f290987704968d45904ef7bcd53c1ca1ed7cb53dfeadaed6 [INFO] running `"docker" "start" "-a" "746e3940280105f3f290987704968d45904ef7bcd53c1ca1ed7cb53dfeadaed6"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/synacor.rs` was erroneously implicitly accepted for binary `synacor`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/diss.rs` was erroneously implicitly accepted for binary `diss`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/dumpstrings.rs` was erroneously implicitly accepted for binary `dumpstrings`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/decode.rs` was erroneously implicitly accepted for binary `decode`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/evenbytes.rs` was erroneously implicitly accepted for binary `evenbytes`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/coins.rs` was erroneously implicitly accepted for binary `coins`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/dumpencodedstrings.rs` was erroneously implicitly accepted for binary `dumpencodedstrings`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/find8th.rs` was erroneously implicitly accepted for binary `find8th`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] warning: path `/opt/crater/workdir/src/vault.rs` was erroneously implicitly accepted for binary `vault`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking synacor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/diss.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/find8th.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | eighth: eighth, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `eighth` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | char_io: char_io [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `char_io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/machine.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | char_io: char_io [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `char_io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dumpstrings.rs:9:33 [INFO] [stderr] | [INFO] [stderr] 9 | Ok(n) if n >= 2 => Some((buf[0] as u16) | ((buf[1] as u16) << 8)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dumpstrings.rs:9:52 [INFO] [stderr] | [INFO] [stderr] 9 | Ok(n) if n >= 2 => Some((buf[0] as u16) | ((buf[1] as u16) << 8)), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dumpstrings.rs:16:8 [INFO] [stderr] | [INFO] [stderr] 16 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dumpstrings.rs:41:42 [INFO] [stderr] | [INFO] [stderr] 41 | match char::from_u32(n as u32) { [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/evenbytes.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Some((buf[0] as u16) | ((buf[1] as u16) << 8))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/evenbytes.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | Ok(Some((buf[0] as u16) | ((buf[1] as u16) << 8))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/evenbytes.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | output.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/evenbytes.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / match get_evens(&mut stdin, &mut stdout) { [INFO] [stderr] 39 | | Err(e) => { [INFO] [stderr] 40 | | println_stderr!("{}", e.description()); [INFO] [stderr] 41 | | std::process::exit(1); [INFO] [stderr] 42 | | }, [INFO] [stderr] 43 | | Ok(_) => () [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Err(e) = get_evens(&mut stdin, &mut stdout) { [INFO] [stderr] 39 | println_stderr!("{}", e.description()); [INFO] [stderr] 40 | std::process::exit(1); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `synacor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this looks like you are swapping elements of `permutation` manually [INFO] [stderr] --> src/coins.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / let tmp = permutation[a]; [INFO] [stderr] 29 | | permutation[a] = permutation[b]; [INFO] [stderr] 30 | | permutation[b] = tmp; [INFO] [stderr] | |________________________^ help: try: `permutation.swap(a, b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/coins.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | if depth <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using depth == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `synacor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | Ok(Some((buf[0] as u16) | ((buf[1] as u16) << 8))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | Ok(Some((buf[0] as u16) | ((buf[1] as u16) << 8))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let square_address = ((addr as u32 * addr as u32) & [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decode.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | let square_address = ((addr as u32 * addr as u32) & [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(addr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/decode.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | output.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decode.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / match decrypt(&mut stdin, &mut stdout) { [INFO] [stderr] 49 | | Err(e) => { [INFO] [stderr] 50 | | println_stderr!("{}", e.description()); [INFO] [stderr] 51 | | std::process::exit(1); [INFO] [stderr] 52 | | }, [INFO] [stderr] 53 | | Ok(_) => () [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 48 | if let Err(e) = decrypt(&mut stdin, &mut stdout) { [INFO] [stderr] 49 | println_stderr!("{}", e.description()); [INFO] [stderr] 50 | std::process::exit(1); [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `synacor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:167:42 [INFO] [stderr] | [INFO] [stderr] 167 | 10 => arithmetic_op!(b, c, ((b as u32 * c as u32) & 0x7fff) as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:167:53 [INFO] [stderr] | [INFO] [stderr] 167 | 10 => arithmetic_op!(b, c, ((b as u32 * c as u32) & 0x7fff) as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/machine.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | if let Err(_) = self.char_io.output(value) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 206 | | Err(MachineError::InputError) [INFO] [stderr] 207 | | } else { [INFO] [stderr] 208 | | Ok(()) [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________________- help: try this: `if self.char_io.output(value).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:247:27 [INFO] [stderr] | [INFO] [stderr] 247 | memory[pos] = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:247:46 [INFO] [stderr] | [INFO] [stderr] 247 | memory[pos] = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:271:19 [INFO] [stderr] | [INFO] [stderr] 271 | self.pc = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:271:38 [INFO] [stderr] | [INFO] [stderr] 271 | self.pc = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:281:29 [INFO] [stderr] | [INFO] [stderr] 281 | self.stack.push((buf[0] as u16) | ((buf[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:281:48 [INFO] [stderr] | [INFO] [stderr] 281 | self.stack.push((buf[0] as u16) | ((buf[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `pos` is only used to index `memory`. [INFO] [stderr] --> src/machine.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | for pos in 0..length { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 290 | for in memory.iter().take(length) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/machine.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | f.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/machine.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | writer.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/machine.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | writer.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/synacor.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(buf[0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/synacor.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match char::from_u32(value as u32) { [INFO] [stderr] 59 | | Some(c) => print!("{}", c), [INFO] [stderr] 60 | | None => () [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(c) = char::from_u32(value as u32) { print!("{}", c) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/synacor.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | match char::from_u32(value as u32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/synacor.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match load_state(&mut machine, &save_state_filename) { [INFO] [stderr] 82 | | Err(e) => { [INFO] [stderr] 83 | | println_stderr!("{}", e.description()); [INFO] [stderr] 84 | | std::process::exit(1); [INFO] [stderr] 85 | | }, [INFO] [stderr] 86 | | Ok(_) => () [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | if let Err(e) = load_state(&mut machine, &save_state_filename) { [INFO] [stderr] 82 | println_stderr!("{}", e.description()); [INFO] [stderr] 83 | std::process::exit(1); [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/synacor.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / match reg8 { [INFO] [stderr] 90 | | Some(n) => { [INFO] [stderr] 91 | | let res = if n.starts_with("0x") { [INFO] [stderr] 92 | | u16::from_str_radix(&n[2..], 16) [INFO] [stderr] ... | [INFO] [stderr] 101 | | None => () [INFO] [stderr] 102 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(n) = reg8 { [INFO] [stderr] 90 | let res = if n.starts_with("0x") { [INFO] [stderr] 91 | u16::from_str_radix(&n[2..], 16) [INFO] [stderr] 92 | } else { [INFO] [stderr] 93 | u16::from_str(&n) [INFO] [stderr] 94 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `synacor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dumpencodedstrings.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | memory[pos] = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/dumpencodedstrings.rs:31:42 [INFO] [stderr] | [INFO] [stderr] 31 | memory[pos] = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:167:42 [INFO] [stderr] | [INFO] [stderr] 167 | 10 => arithmetic_op!(b, c, ((b as u32 * c as u32) & 0x7fff) as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:167:53 [INFO] [stderr] | [INFO] [stderr] 167 | 10 => arithmetic_op!(b, c, ((b as u32 * c as u32) & 0x7fff) as u16), [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dumpencodedstrings.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | let mask = ((arg_a as u32 + arg_b as u32) & 0x7fff) as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(arg_a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dumpencodedstrings.rs:69:37 [INFO] [stderr] | [INFO] [stderr] 69 | let mask = ((arg_a as u32 + arg_b as u32) & 0x7fff) as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(arg_b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/dumpencodedstrings.rs:86:41 [INFO] [stderr] | [INFO] [stderr] 86 | match char::from_u32((memory[i as usize] ^ mask) as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(memory[i as usize] ^ mask)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dumpencodedstrings.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / match read_program(&mut memory, &save_state_filename) { [INFO] [stderr] 107 | | Err(e) => { [INFO] [stderr] 108 | | println_stderr!("{}", e.description()); [INFO] [stderr] 109 | | std::process::exit(1); [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | Ok(_) => () [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Err(e) = read_program(&mut memory, &save_state_filename) { [INFO] [stderr] 107 | println_stderr!("{}", e.description()); [INFO] [stderr] 108 | std::process::exit(1); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/machine.rs:205:24 [INFO] [stderr] | [INFO] [stderr] 205 | if let Err(_) = self.char_io.output(value) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 206 | | Err(MachineError::InputError) [INFO] [stderr] 207 | | } else { [INFO] [stderr] 208 | | Ok(()) [INFO] [stderr] 209 | | } [INFO] [stderr] | |_________________- help: try this: `if self.char_io.output(value).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:247:27 [INFO] [stderr] | [INFO] [stderr] 247 | memory[pos] = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:247:46 [INFO] [stderr] | [INFO] [stderr] 247 | memory[pos] = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/diss.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(Some((buf[0] as u16) | ((buf[1] as u16) << 8))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/diss.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | Ok(Some((buf[0] as u16) | ((buf[1] as u16) << 8))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:271:19 [INFO] [stderr] | [INFO] [stderr] 271 | self.pc = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:271:38 [INFO] [stderr] | [INFO] [stderr] 271 | self.pc = (buf[0] as u16) | ((buf[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:281:29 [INFO] [stderr] | [INFO] [stderr] 281 | self.stack.push((buf[0] as u16) | ((buf[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/machine.rs:281:48 [INFO] [stderr] | [INFO] [stderr] 281 | self.stack.push((buf[0] as u16) | ((buf[1] as u16) << 8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(buf[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `pos` is only used to index `memory`. [INFO] [stderr] --> src/machine.rs:290:20 [INFO] [stderr] | [INFO] [stderr] 290 | for pos in 0..length { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 290 | for in memory.iter().take(length) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/machine.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | f.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/machine.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | writer.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/machine.rs:316:13 [INFO] [stderr] | [INFO] [stderr] 316 | writer.write(&buf)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/synacor.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(buf[0] as u16) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/synacor.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / match char::from_u32(value as u32) { [INFO] [stderr] 59 | | Some(c) => print!("{}", c), [INFO] [stderr] 60 | | None => () [INFO] [stderr] 61 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(c) = char::from_u32(value as u32) { print!("{}", c) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/synacor.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | match char::from_u32(value as u32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/synacor.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / match load_state(&mut machine, &save_state_filename) { [INFO] [stderr] 82 | | Err(e) => { [INFO] [stderr] 83 | | println_stderr!("{}", e.description()); [INFO] [stderr] 84 | | std::process::exit(1); [INFO] [stderr] 85 | | }, [INFO] [stderr] 86 | | Ok(_) => () [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | if let Err(e) = load_state(&mut machine, &save_state_filename) { [INFO] [stderr] 82 | println_stderr!("{}", e.description()); [INFO] [stderr] 83 | std::process::exit(1); [INFO] [stderr] 84 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/synacor.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / match reg8 { [INFO] [stderr] 90 | | Some(n) => { [INFO] [stderr] 91 | | let res = if n.starts_with("0x") { [INFO] [stderr] 92 | | u16::from_str_radix(&n[2..], 16) [INFO] [stderr] ... | [INFO] [stderr] 101 | | None => () [INFO] [stderr] 102 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 89 | if let Some(n) = reg8 { [INFO] [stderr] 90 | let res = if n.starts_with("0x") { [INFO] [stderr] 91 | u16::from_str_radix(&n[2..], 16) [INFO] [stderr] 92 | } else { [INFO] [stderr] 93 | u16::from_str(&n) [INFO] [stderr] 94 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/diss.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | if opcode == 19 && args.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/diss.rs:88:30 [INFO] [stderr] | [INFO] [stderr] 88 | match char::from_u32(args[0] as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(args[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/diss.rs:111:5 [INFO] [stderr] | [INFO] [stderr] 111 | / loop { [INFO] [stderr] 112 | | match fetch(&mut reader)? { [INFO] [stderr] 113 | | Some(opcode) => { [INFO] [stderr] 114 | | addr += dump_instruction(addr, &mut reader, opcode)? + 1; [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(opcode) = fetch(&mut reader)? { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/diss.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / match diss_program(&filename, start_address) { [INFO] [stderr] 154 | | Err(e) => { [INFO] [stderr] 155 | | println_stderr!("{}", e.description()); [INFO] [stderr] 156 | | std::process::exit(1); [INFO] [stderr] 157 | | }, [INFO] [stderr] 158 | | Ok(_) => () [INFO] [stderr] 159 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 153 | if let Err(e) = diss_program(&filename, start_address) { [INFO] [stderr] 154 | println_stderr!("{}", e.description()); [INFO] [stderr] 155 | std::process::exit(1); [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `synacor`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "746e3940280105f3f290987704968d45904ef7bcd53c1ca1ed7cb53dfeadaed6"` [INFO] running `"docker" "rm" "-f" "746e3940280105f3f290987704968d45904ef7bcd53c1ca1ed7cb53dfeadaed6"` [INFO] [stdout] 746e3940280105f3f290987704968d45904ef7bcd53c1ca1ed7cb53dfeadaed6