[INFO] updating cached repository boylede/aoc2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/boylede/aoc2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/boylede/aoc2018" "work/ex/clippy-test-run/sources/stable/gh/boylede/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/boylede/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/boylede/aoc2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boylede/aoc2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boylede/aoc2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d31ba687b2b0b9edae764991d8116681cfa72edd
[INFO] sha for GitHub repo boylede/aoc2018: d31ba687b2b0b9edae764991d8116681cfa72edd
[INFO] validating manifest of boylede/aoc2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of boylede/aoc2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing boylede/aoc2018
[INFO] finished frobbing boylede/aoc2018
[INFO] frobbed toml for boylede/aoc2018 written to work/ex/clippy-test-run/sources/stable/gh/boylede/aoc2018/Cargo.toml
[INFO] started frobbing boylede/aoc2018
[INFO] finished frobbing boylede/aoc2018
[INFO] frobbed toml for boylede/aoc2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boylede/aoc2018/Cargo.toml
[INFO] crate boylede/aoc2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting boylede/aoc2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/boylede/aoc2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d93e749e3cf91ab173c51171726540cea438ce5b321434cf292b45fa69a18c06
[INFO] running `"docker" "start" "-a" "d93e749e3cf91ab173c51171726540cea438ce5b321434cf292b45fa69a18c06"`
[INFO] [stderr]     Checking reqwest v0.9.5
[INFO] [stderr]     Checking aoc2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 |     res
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:118:15
[INFO] [stderr]     |
[INFO] [stderr] 118 |       let res = match request{
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 119 | |             Ok(c) => c,
[INFO] [stderr] 120 | |             Err(e) => panic!("err:{}", e)
[INFO] [stderr] 121 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/lib.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 |           let session = match args.flag_present("session") {
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 26 | |             true => args.get_string("session"),
[INFO] [stderr] 27 | |             false => "session not set in command line, TODO: get from file".to_string(),
[INFO] [stderr] 28 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if args.flag_present("session") { args.get_string("session") } else { "session not set in command line, TODO: get from file".to_string() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/lib.rs:30:15
[INFO] [stderr]    |
[INFO] [stderr] 30 |           let input = match args.flag_present("input") {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 31 | |             true => args.get_string("input"),
[INFO] [stderr] 32 | |             false => "".to_string(),
[INFO] [stderr] 33 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if args.flag_present("input") { args.get_string("input") } else { "".to_string() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:65:49
[INFO] [stderr]    |
[INFO] [stderr] 65 | pub fn get_input_file(day: i32, optional_input: &String) -> Result<File, std::io::Error> {
[INFO] [stderr]    |                                                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 65 | pub fn get_input_file(day: i32, optional_input: &str) -> Result<File, std::io::Error> {
[INFO] [stderr]    |                                                 ^^^^
[INFO] [stderr] help: change `optional_input.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 73 |             optional_input.to_string()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:125:46
[INFO] [stderr]     |
[INFO] [stderr] 125 | fn get_url_into_file(url: String,  filename: &String) {
[INFO] [stderr]     |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:122:5
[INFO] [stderr]     |
[INFO] [stderr] 122 |     res
[INFO] [stderr]     |     ^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:118:15
[INFO] [stderr]     |
[INFO] [stderr] 118 |       let res = match request{
[INFO] [stderr]     |  _______________^
[INFO] [stderr] 119 | |             Ok(c) => c,
[INFO] [stderr] 120 | |             Err(e) => panic!("err:{}", e)
[INFO] [stderr] 121 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/lib.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 |           let session = match args.flag_present("session") {
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 26 | |             true => args.get_string("session"),
[INFO] [stderr] 27 | |             false => "session not set in command line, TODO: get from file".to_string(),
[INFO] [stderr] 28 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if args.flag_present("session") { args.get_string("session") } else { "session not set in command line, TODO: get from file".to_string() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/lib.rs:30:15
[INFO] [stderr]    |
[INFO] [stderr] 30 |           let input = match args.flag_present("input") {
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 31 | |             true => args.get_string("input"),
[INFO] [stderr] 32 | |             false => "".to_string(),
[INFO] [stderr] 33 | |         };
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if args.flag_present("input") { args.get_string("input") } else { "".to_string() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:65:49
[INFO] [stderr]    |
[INFO] [stderr] 65 | pub fn get_input_file(day: i32, optional_input: &String) -> Result<File, std::io::Error> {
[INFO] [stderr]    |                                                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 65 | pub fn get_input_file(day: i32, optional_input: &str) -> Result<File, std::io::Error> {
[INFO] [stderr]    |                                                 ^^^^
[INFO] [stderr] help: change `optional_input.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 73 |             optional_input.to_string()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/lib.rs:125:46
[INFO] [stderr]     |
[INFO] [stderr] 125 | fn get_url_into_file(url: String,  filename: &String) {
[INFO] [stderr]     |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/day3/mod.rs:160:3
[INFO] [stderr]     |
[INFO] [stderr] 160 |           write!(f, "#{} @ {},{}: {}x{}\n",
[INFO] [stderr]     |  _________^
[INFO] [stderr] 161 | |             self.id,
[INFO] [stderr] 162 | |             self.left,
[INFO] [stderr] 163 | |             self.top,
[INFO] [stderr] 164 | |             self.width,
[INFO] [stderr] 165 | |             self.height
[INFO] [stderr] 166 | |             )
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/mod.rs:93:50
[INFO] [stderr]    |
[INFO] [stderr] 93 |         points_info.insert((*point).clone(), PointInfo{parent: parent, distance: distance});
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/mod.rs:93:66
[INFO] [stderr]    |
[INFO] [stderr] 93 |         points_info.insert((*point).clone(), PointInfo{parent: parent, distance: distance});
[INFO] [stderr]    |                                                                        ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/day3/mod.rs:160:3
[INFO] [stderr]     |
[INFO] [stderr] 160 |           write!(f, "#{} @ {},{}: {}x{}\n",
[INFO] [stderr]     |  _________^
[INFO] [stderr] 161 | |             self.id,
[INFO] [stderr] 162 | |             self.left,
[INFO] [stderr] 163 | |             self.top,
[INFO] [stderr] 164 | |             self.width,
[INFO] [stderr] 165 | |             self.height
[INFO] [stderr] 166 | |             )
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/mod.rs:93:50
[INFO] [stderr]    |
[INFO] [stderr] 93 |         points_info.insert((*point).clone(), PointInfo{parent: parent, distance: distance});
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^ help: replace it with: `parent`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day6/mod.rs:93:66
[INFO] [stderr]    |
[INFO] [stderr] 93 |         points_info.insert((*point).clone(), PointInfo{parent: parent, distance: distance});
[INFO] [stderr]    |                                                                        ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/day5/mod.rs:71:4
[INFO] [stderr]    |
[INFO] [stderr] 71 |               if toggled_char == prev {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 72 | |                 if toggled_char != next {
[INFO] [stderr] 73 | |                     // println!("{}: can match with previous char: {}, {}", i, current, prev);
[INFO] [stderr] 74 | |                     reactions.push(i);
[INFO] [stderr] 75 | |                 }
[INFO] [stderr] 76 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 71 |             if toggled_char == prev && toggled_char != next {
[INFO] [stderr] 72 |     // println!("{}: can match with previous char: {}, {}", i, current, prev);
[INFO] [stderr] 73 |     reactions.push(i);
[INFO] [stderr] 74 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/day5/mod.rs:71:4
[INFO] [stderr]    |
[INFO] [stderr] 71 |               if toggled_char == prev {
[INFO] [stderr]    |  _____________^
[INFO] [stderr] 72 | |                 if toggled_char != next {
[INFO] [stderr] 73 | |                     // println!("{}: can match with previous char: {}, {}", i, current, prev);
[INFO] [stderr] 74 | |                     reactions.push(i);
[INFO] [stderr] 75 | |                 }
[INFO] [stderr] 76 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 71 |             if toggled_char == prev && toggled_char != next {
[INFO] [stderr] 72 |     // println!("{}: can match with previous char: {}, {}", i, current, prev);
[INFO] [stderr] 73 |     reactions.push(i);
[INFO] [stderr] 74 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/day6/mod.rs:117:12
[INFO] [stderr]     |
[INFO] [stderr] 117 |     } else if (distance == shortest_distance) {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 | const USAGE : &'static str = "Dan Boyle's Advent of Code 2018 entries.
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    --> src/day6/mod.rs:117:12
[INFO] [stderr]     |
[INFO] [stderr] 117 |     } else if (distance == shortest_distance) {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]     |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 | const USAGE : &'static str = "Dan Boyle's Advent of Code 2018 entries.
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `lines`
[INFO] [stderr]    --> src/day6/mod.rs:134:10
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |          ^^^^^ help: consider using `_lines` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `parent`
[INFO] [stderr]    --> src/day6/mod.rs:200:7
[INFO] [stderr]     |
[INFO] [stderr] 200 |         let parent = 0;
[INFO] [stderr]     |             ^^^^^^ help: consider using `_parent` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `distance`
[INFO] [stderr]    --> src/day6/mod.rs:201:7
[INFO] [stderr]     |
[INFO] [stderr] 201 |         let distance = 0;
[INFO] [stderr]     |             ^^^^^^^^ help: consider using `_distance` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `lines`
[INFO] [stderr]    --> src/day6/mod.rs:134:10
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |          ^^^^^ help: consider using `_lines` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `parent`
[INFO] [stderr]    --> src/day6/mod.rs:200:7
[INFO] [stderr]     |
[INFO] [stderr] 200 |         let parent = 0;
[INFO] [stderr]     |             ^^^^^^ help: consider using `_parent` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `distance`
[INFO] [stderr]    --> src/day6/mod.rs:201:7
[INFO] [stderr]     |
[INFO] [stderr] 201 |         let distance = 0;
[INFO] [stderr]     |             ^^^^^^^^ help: consider using `_distance` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/day6/mod.rs:48:6
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let mut field = Grid::with_coordinates(&coordinates);
[INFO] [stderr]    |         ----^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Unoccupied`
[INFO] [stderr]   --> src/day3/mod.rs:67:2
[INFO] [stderr]    |
[INFO] [stderr] 67 |     Unoccupied,
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `parent`
[INFO] [stderr]    --> src/day6/mod.rs:159:2
[INFO] [stderr]     |
[INFO] [stderr] 159 |     parent: i32,
[INFO] [stderr]     |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `distance`
[INFO] [stderr]    --> src/day6/mod.rs:160:2
[INFO] [stderr]     |
[INFO] [stderr] 160 |     distance: i32,
[INFO] [stderr]     |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `cells`
[INFO] [stderr]    --> src/day6/mod.rs:164:2
[INFO] [stderr]     |
[INFO] [stderr] 164 |     cells: Vec<Position>,    // voronoi input points
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day1/mod.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day1/mod.rs:47:7
[INFO] [stderr]    |
[INFO] [stderr] 47 |       }).fold(0, |acc, value|{
[INFO] [stderr]    |  _______^
[INFO] [stderr] 48 | |         acc + value
[INFO] [stderr] 49 | |     });
[INFO] [stderr]    | |______^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day1/mod.rs:53:17
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day1/mod.rs:81:25
[INFO] [stderr]    |
[INFO] [stderr] 81 |     fn from_vec(vector: &'a Vec<T>) -> Self {
[INFO] [stderr]    |                         ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day2/mod.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2/mod.rs:59:36
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn count_repeats(count: i32, line: &String) -> bool {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2/mod.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 | fn count_difference(line_a: &String, line_b: &String) -> (i32, usize) {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2/mod.rs:70:46
[INFO] [stderr]    |
[INFO] [stderr] 70 | fn count_difference(line_a: &String, line_b: &String) -> (i32, usize) {
[INFO] [stderr]    |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day2/mod.rs:82:17
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3/mod.rs:45:17
[INFO] [stderr]    |
[INFO] [stderr] 45 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3/mod.rs:71:17
[INFO] [stderr]    |
[INFO] [stderr] 71 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/day3/mod.rs:101:21
[INFO] [stderr]     |
[INFO] [stderr] 101 | fn load_claim(line: &String) -> Claim {
[INFO] [stderr]     |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day4/mod.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day4/mod.rs:65:26
[INFO] [stderr]    |
[INFO] [stderr] 65 |         .filter(|record_slice| record_slice.len() > 0)
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record_slice.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `minute` is used to index `total_sleep_per_minute`
[INFO] [stderr]    --> src/day4/mod.rs:133:16
[INFO] [stderr]     |
[INFO] [stderr] 133 |     for minute in 0..59 {
[INFO] [stderr]     |                   ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 133 |     for (minute, <item>) in total_sleep_per_minute.iter().enumerate().take(59) {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day4/mod.rs:143:17
[INFO] [stderr]     |
[INFO] [stderr] 143 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/day4/mod.rs:159:26
[INFO] [stderr]     |
[INFO] [stderr] 159 |         .filter(|record_slice| record_slice.len() > 0)
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record_slice.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:274:14
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let year = tokens.get(1).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:275:15
[INFO] [stderr]     |
[INFO] [stderr] 275 |         let month = tokens.get(2).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[2]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:276:13
[INFO] [stderr]     |
[INFO] [stderr] 276 |         let day = tokens.get(3).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[3]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:277:14
[INFO] [stderr]     |
[INFO] [stderr] 277 |         let hour = tokens.get(4).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[4]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:278:16
[INFO] [stderr]     |
[INFO] [stderr] 278 |         let minute = tokens.get(5).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[5]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:290:16
[INFO] [stderr]     |
[INFO] [stderr] 290 |             let token = tokens.get(8).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/day4/mod.rs:291:15
[INFO] [stderr]     |
[INFO] [stderr] 291 |               activity = match token {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 292 | |                 &"asleep" => Activity::FallAsleep,
[INFO] [stderr] 293 | |                 &"up" => Activity::WakeUp,
[INFO] [stderr] 294 | |                 &&_ => return Err(ParseRecordError::NoActivity(token.to_string())),
[INFO] [stderr] 295 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 291 |             activity = match *token {
[INFO] [stderr] 292 |                 "asleep" => Activity::FallAsleep,
[INFO] [stderr] 293 |                 "up" => Activity::WakeUp,
[INFO] [stderr] 294 |                 &_ => return Err(ParseRecordError::NoActivity(token.to_string())),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day5/mod.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/day5/mod.rs:67:23
[INFO] [stderr]    |
[INFO] [stderr] 67 |               let toggled_char = match current.is_lowercase() {
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 68 | |                 true => current.to_ascii_uppercase(),
[INFO] [stderr] 69 | |                 false => current.to_ascii_lowercase(),
[INFO] [stderr] 70 | |             };
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if current.is_lowercase() { current.to_ascii_uppercase() } else { current.to_ascii_lowercase() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day5/mod.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6/mod.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6/mod.rs:134:17
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6/mod.rs:191:30
[INFO] [stderr]     |
[INFO] [stderr] 191 |     fn with_coordinates(coords: &Vec<Position>) -> Self {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day6/mod.rs:285:11
[INFO] [stderr]     |
[INFO] [stderr] 285 |         let x = tokens.get(0).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day6/mod.rs:286:11
[INFO] [stderr]     |
[INFO] [stderr] 286 |         let y = tokens.get(1).unwrap().trim_start().parse::<i32>()?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/day6/mod.rs:48:6
[INFO] [stderr]    |
[INFO] [stderr] 48 |     let mut field = Grid::with_coordinates(&coordinates);
[INFO] [stderr]    |         ----^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Unoccupied`
[INFO] [stderr]   --> src/day3/mod.rs:67:2
[INFO] [stderr]    |
[INFO] [stderr] 67 |     Unoccupied,
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `parent`
[INFO] [stderr]    --> src/day6/mod.rs:159:2
[INFO] [stderr]     |
[INFO] [stderr] 159 |     parent: i32,
[INFO] [stderr]     |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `distance`
[INFO] [stderr]    --> src/day6/mod.rs:160:2
[INFO] [stderr]     |
[INFO] [stderr] 160 |     distance: i32,
[INFO] [stderr]     |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `cells`
[INFO] [stderr]    --> src/day6/mod.rs:164:2
[INFO] [stderr]     |
[INFO] [stderr] 164 |     cells: Vec<Position>,    // voronoi input points
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day1/mod.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]   --> src/day1/mod.rs:47:7
[INFO] [stderr]    |
[INFO] [stderr] 47 |       }).fold(0, |acc, value|{
[INFO] [stderr]    |  _______^
[INFO] [stderr] 48 | |         acc + value
[INFO] [stderr] 49 | |     });
[INFO] [stderr]    | |______^ help: try: `.sum()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day1/mod.rs:53:17
[INFO] [stderr]    |
[INFO] [stderr] 53 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day1/mod.rs:81:25
[INFO] [stderr]    |
[INFO] [stderr] 81 |     fn from_vec(vector: &'a Vec<T>) -> Self {
[INFO] [stderr]    |                         ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day2/mod.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2/mod.rs:59:36
[INFO] [stderr]    |
[INFO] [stderr] 59 | fn count_repeats(count: i32, line: &String) -> bool {
[INFO] [stderr]    |                                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2/mod.rs:70:29
[INFO] [stderr]    |
[INFO] [stderr] 70 | fn count_difference(line_a: &String, line_b: &String) -> (i32, usize) {
[INFO] [stderr]    |                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/day2/mod.rs:70:46
[INFO] [stderr]    |
[INFO] [stderr] 70 | fn count_difference(line_a: &String, line_b: &String) -> (i32, usize) {
[INFO] [stderr]    |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day2/mod.rs:82:17
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3/mod.rs:45:17
[INFO] [stderr]    |
[INFO] [stderr] 45 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day3/mod.rs:71:17
[INFO] [stderr]    |
[INFO] [stderr] 71 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/day3/mod.rs:101:21
[INFO] [stderr]     |
[INFO] [stderr] 101 | fn load_claim(line: &String) -> Claim {
[INFO] [stderr]     |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day4/mod.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day4/mod.rs:65:26
[INFO] [stderr]    |
[INFO] [stderr] 65 |         .filter(|record_slice| record_slice.len() > 0)
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record_slice.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `minute` is used to index `total_sleep_per_minute`
[INFO] [stderr]    --> src/day4/mod.rs:133:16
[INFO] [stderr]     |
[INFO] [stderr] 133 |     for minute in 0..59 {
[INFO] [stderr]     |                   ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 133 |     for (minute, <item>) in total_sleep_per_minute.iter().enumerate().take(59) {
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day4/mod.rs:143:17
[INFO] [stderr]     |
[INFO] [stderr] 143 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/day4/mod.rs:159:26
[INFO] [stderr]     |
[INFO] [stderr] 159 |         .filter(|record_slice| record_slice.len() > 0)
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!record_slice.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:274:14
[INFO] [stderr]     |
[INFO] [stderr] 274 |         let year = tokens.get(1).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:275:15
[INFO] [stderr]     |
[INFO] [stderr] 275 |         let month = tokens.get(2).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[2]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:276:13
[INFO] [stderr]     |
[INFO] [stderr] 276 |         let day = tokens.get(3).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[3]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:277:14
[INFO] [stderr]     |
[INFO] [stderr] 277 |         let hour = tokens.get(4).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[4]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:278:16
[INFO] [stderr]     |
[INFO] [stderr] 278 |         let minute = tokens.get(5).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[5]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day4/mod.rs:290:16
[INFO] [stderr]     |
[INFO] [stderr] 290 |             let token = tokens.get(8).unwrap();
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/day4/mod.rs:291:15
[INFO] [stderr]     |
[INFO] [stderr] 291 |               activity = match token {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 292 | |                 &"asleep" => Activity::FallAsleep,
[INFO] [stderr] 293 | |                 &"up" => Activity::WakeUp,
[INFO] [stderr] 294 | |                 &&_ => return Err(ParseRecordError::NoActivity(token.to_string())),
[INFO] [stderr] 295 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 291 |             activity = match *token {
[INFO] [stderr] 292 |                 "asleep" => Activity::FallAsleep,
[INFO] [stderr] 293 |                 "up" => Activity::WakeUp,
[INFO] [stderr] 294 |                 &_ => return Err(ParseRecordError::NoActivity(token.to_string())),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day5/mod.rs:41:17
[INFO] [stderr]    |
[INFO] [stderr] 41 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/day5/mod.rs:67:23
[INFO] [stderr]    |
[INFO] [stderr] 67 |               let toggled_char = match current.is_lowercase() {
[INFO] [stderr]    |  ________________________________^
[INFO] [stderr] 68 | |                 true => current.to_ascii_uppercase(),
[INFO] [stderr] 69 | |                 false => current.to_ascii_lowercase(),
[INFO] [stderr] 70 | |             };
[INFO] [stderr]    | |_____________^ help: consider using an if/else expression: `if current.is_lowercase() { current.to_ascii_uppercase() } else { current.to_ascii_lowercase() }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day5/mod.rs:101:17
[INFO] [stderr]     |
[INFO] [stderr] 101 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day6/mod.rs:44:17
[INFO] [stderr]    |
[INFO] [stderr] 44 | fn part1(lines: &Vec<String>) {
[INFO] [stderr]    |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6/mod.rs:134:17
[INFO] [stderr]     |
[INFO] [stderr] 134 | fn part2(lines: &Vec<String>) {
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day6/mod.rs:191:30
[INFO] [stderr]     |
[INFO] [stderr] 191 |     fn with_coordinates(coords: &Vec<Position>) -> Self {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^ help: change this to: `&[Position]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day6/mod.rs:285:11
[INFO] [stderr]     |
[INFO] [stderr] 285 |         let x = tokens.get(0).unwrap().parse::<i32>()?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/day6/mod.rs:286:11
[INFO] [stderr]     |
[INFO] [stderr] 286 |         let y = tokens.get(1).unwrap().trim_start().parse::<i32>()?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 18.22s
[INFO] running `"docker" "inspect" "d93e749e3cf91ab173c51171726540cea438ce5b321434cf292b45fa69a18c06"`
[INFO] running `"docker" "rm" "-f" "d93e749e3cf91ab173c51171726540cea438ce5b321434cf292b45fa69a18c06"`
[INFO] [stdout] d93e749e3cf91ab173c51171726540cea438ce5b321434cf292b45fa69a18c06