[INFO] updating cached repository bovarysme/badquantizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bovarysme/badquantizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bovarysme/badquantizer" "work/ex/clippy-test-run/sources/stable/gh/bovarysme/badquantizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bovarysme/badquantizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bovarysme/badquantizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bovarysme/badquantizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bovarysme/badquantizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 109c7be8cd5201718c1d2e3ca2c1eab0aab11c9b [INFO] sha for GitHub repo bovarysme/badquantizer: 109c7be8cd5201718c1d2e3ca2c1eab0aab11c9b [INFO] validating manifest of bovarysme/badquantizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bovarysme/badquantizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bovarysme/badquantizer [INFO] finished frobbing bovarysme/badquantizer [INFO] frobbed toml for bovarysme/badquantizer written to work/ex/clippy-test-run/sources/stable/gh/bovarysme/badquantizer/Cargo.toml [INFO] started frobbing bovarysme/badquantizer [INFO] finished frobbing bovarysme/badquantizer [INFO] frobbed toml for bovarysme/badquantizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bovarysme/badquantizer/Cargo.toml [INFO] crate bovarysme/badquantizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bovarysme/badquantizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bovarysme/badquantizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] adc8aea2fb2f53a334c62829b5e599d4ad201e35b6a15f40ba058a14e86aedd4 [INFO] running `"docker" "start" "-a" "adc8aea2fb2f53a334c62829b5e599d4ad201e35b6a15f40ba058a14e86aedd4"` [INFO] [stderr] Checking deflate v0.7.9 [INFO] [stderr] Checking clap v2.24.0 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking badquantizer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | fn blend(color1: &Rgb, color2: &Rgb) -> Rgb { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | fn blend(color1: &Rgb, color2: &Rgb) -> Rgb { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | let value = (color1[i] as u16 * 2 + color2[i] as u16) / 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(color1[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:98:45 [INFO] [stderr] | [INFO] [stderr] 98 | let value = (color1[i] as u16 * 2 + color2[i] as u16) / 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(color2[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | let luma = pixel.to_luma()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pixel.to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | let luma = pixel.to_luma()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pixel.to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encoder.rs:111:46 [INFO] [stderr] | [INFO] [stderr] 111 | fn encode_color(buffer: &mut Vec, color: &Rgb) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | bytes = (color[0] as u16 >> 3) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(color[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | bytes |= (color[1] as u16 >> 2) << 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(color[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:116:14 [INFO] [stderr] | [INFO] [stderr] 116 | bytes |= color[2] as u16 >> 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(color[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | bytes |= (flag as u32) << (2 * i); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(flag)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | fn blend(color1: &Rgb, color2: &Rgb) -> Rgb { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoder.rs:94:36 [INFO] [stderr] | [INFO] [stderr] 94 | fn blend(color1: &Rgb, color2: &Rgb) -> Rgb { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:98:22 [INFO] [stderr] | [INFO] [stderr] 98 | let value = (color1[i] as u16 * 2 + color2[i] as u16) / 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(color1[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:98:45 [INFO] [stderr] | [INFO] [stderr] 98 | let value = (color1[i] as u16 * 2 + color2[i] as u16) / 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(color2[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | let luma = pixel.to_luma()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pixel.to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:76:24 [INFO] [stderr] | [INFO] [stderr] 76 | let luma = pixel.to_luma()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(pixel.to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encoder.rs:111:46 [INFO] [stderr] | [INFO] [stderr] 111 | fn encode_color(buffer: &mut Vec, color: &Rgb) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | bytes = (color[0] as u16 >> 3) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(color[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:115:15 [INFO] [stderr] | [INFO] [stderr] 115 | bytes |= (color[1] as u16 >> 2) << 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(color[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:116:14 [INFO] [stderr] | [INFO] [stderr] 116 | bytes |= color[2] as u16 >> 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(color[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | bytes |= (flag as u32) << (2 * i); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(flag)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.69s [INFO] running `"docker" "inspect" "adc8aea2fb2f53a334c62829b5e599d4ad201e35b6a15f40ba058a14e86aedd4"` [INFO] running `"docker" "rm" "-f" "adc8aea2fb2f53a334c62829b5e599d4ad201e35b6a15f40ba058a14e86aedd4"` [INFO] [stdout] adc8aea2fb2f53a334c62829b5e599d4ad201e35b6a15f40ba058a14e86aedd4