[INFO] updating cached repository boustrophedon/rss-downloader [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/boustrophedon/rss-downloader [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/boustrophedon/rss-downloader" "work/ex/clippy-test-run/sources/stable/gh/boustrophedon/rss-downloader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/boustrophedon/rss-downloader'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/boustrophedon/rss-downloader" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boustrophedon/rss-downloader"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boustrophedon/rss-downloader'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be1c8bf176ef2d3530914803634e44160573999b [INFO] sha for GitHub repo boustrophedon/rss-downloader: be1c8bf176ef2d3530914803634e44160573999b [INFO] validating manifest of boustrophedon/rss-downloader on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of boustrophedon/rss-downloader on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing boustrophedon/rss-downloader [INFO] finished frobbing boustrophedon/rss-downloader [INFO] frobbed toml for boustrophedon/rss-downloader written to work/ex/clippy-test-run/sources/stable/gh/boustrophedon/rss-downloader/Cargo.toml [INFO] started frobbing boustrophedon/rss-downloader [INFO] finished frobbing boustrophedon/rss-downloader [INFO] frobbed toml for boustrophedon/rss-downloader written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boustrophedon/rss-downloader/Cargo.toml [INFO] crate boustrophedon/rss-downloader has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting boustrophedon/rss-downloader against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/boustrophedon/rss-downloader:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6482c1ca19d6b7aa6080fdb0124ae86dc63df43bdef9be93ccbec1c5d6e3a465 [INFO] running `"docker" "start" "-a" "6482c1ca19d6b7aa6080fdb0124ae86dc63df43bdef9be93ccbec1c5d6e3a465"` [INFO] [stderr] Checking matches v0.1.6 [INFO] [stderr] Checking safemem v0.2.0 [INFO] [stderr] Checking siphasher v0.2.2 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Checking serde_json v1.0.11 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking fern v0.5.4 [INFO] [stderr] Compiling derive_builder_core v0.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking phf_shared v0.7.21 [INFO] [stderr] Checking base64 v0.9.0 [INFO] [stderr] Checking tokio-core v0.1.15 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Checking quick-xml v0.12.1 [INFO] [stderr] Compiling derive_builder v0.5.1 [INFO] [stderr] Checking phf v0.7.21 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking rss v1.4.0 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking hyper v0.11.22 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking rss-torrent v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | data_dir: data_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | torrent_file_cache_dir: torrent_file_cache_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `torrent_file_cache_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/add.rs:51:26 [INFO] [stderr] | [INFO] [stderr] 51 | let new_feed = Feed {url: url, last_update: None, filters: cmd.filters}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:76:53 [INFO] [stderr] | [INFO] [stderr] 76 | let new_alias = Alias {name: cmd.alias.clone(), url: url}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feed_util.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | filters: filters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feed_util.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feed_util.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | filters: filters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | data_dir: data_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | torrent_file_cache_dir: torrent_file_cache_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `torrent_file_cache_dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/add.rs:51:26 [INFO] [stderr] | [INFO] [stderr] 51 | let new_feed = Feed {url: url, last_update: None, filters: cmd.filters}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/alias.rs:76:53 [INFO] [stderr] | [INFO] [stderr] 76 | let new_alias = Alias {name: cmd.alias.clone(), url: url}; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feed_util.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | filters: filters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feed_util.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | url: url, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/feed_util.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | filters: filters, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `filters` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | return Default::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Default::default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/alias_util.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(aliases); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(aliases)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/feed_util.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(feeds); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(feeds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | return Default::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Default::default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/alias_util.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return Ok(aliases); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(aliases)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/feed_util.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(feeds); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(feeds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | let home = env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | let home = env::home_dir(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/update.rs:3:19 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn run_update(config: &RTConfig) { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delete` [INFO] [stderr] --> src/delete.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn delete_feed(delete: RTDelete, config: &RTConfig) { [INFO] [stderr] | ^^^^^^ help: consider using `_delete` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/delete.rs:4:38 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn delete_feed(delete: RTDelete, config: &RTConfig) { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/update.rs:3:19 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn run_update(config: &RTConfig) { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `delete` [INFO] [stderr] --> src/delete.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn delete_feed(delete: RTDelete, config: &RTConfig) { [INFO] [stderr] | ^^^^^^ help: consider using `_delete` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `config` [INFO] [stderr] --> src/delete.rs:4:38 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn delete_feed(delete: RTDelete, config: &RTConfig) { [INFO] [stderr] | ^^^^^^ help: consider using `_config` instead [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn to_config(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | conf_files.push(PathBuf::from(f)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/config.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn to_config(self) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/config.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | conf_files.push(PathBuf::from(f)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/alias.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn to_record(self) -> AliasRecord { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/alias.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn to_alias(self) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/alias.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn to_record(self) -> AliasRecord { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/alias.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn to_alias(self) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/alias_util.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | let result = db_file.write_all(&mut buf).map_err(|e| { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/alias_util.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(result?) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 78 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/feed_util.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_record(self) -> FeedRecord { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/feed_util.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / let filters: Option>; [INFO] [stderr] 33 | | if self.filters.len() > 0 {filters = Some(self.filters);} [INFO] [stderr] 34 | | else { filters = None; } [INFO] [stderr] | |________________________________^ help: it is more idiomatic to write: `let filters = if self.filters.len() > 0 { Some(self.filters) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/feed_util.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.filters.len() > 0 {filters = Some(self.filters);} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.filters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/feed_util.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn to_feed(self) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/alias_util.rs:70:36 [INFO] [stderr] | [INFO] [stderr] 70 | let result = db_file.write_all(&mut buf).map_err(|e| { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/alias_util.rs:78:8 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(result?) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 78 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/feed_util.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_record(self) -> FeedRecord { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/feed_util.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / let filters: Option>; [INFO] [stderr] 33 | | if self.filters.len() > 0 {filters = Some(self.filters);} [INFO] [stderr] 34 | | else { filters = None; } [INFO] [stderr] | |________________________________^ help: it is more idiomatic to write: `let filters = if self.filters.len() > 0 { Some(self.filters) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/feed_util.rs:33:12 [INFO] [stderr] | [INFO] [stderr] 33 | if self.filters.len() > 0 {filters = Some(self.filters);} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.filters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/feed_util.rs:142:36 [INFO] [stderr] | [INFO] [stderr] 142 | let result = db_file.write_all(&mut buf).map_err(|e| { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/feed_util.rs:150:8 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(result?) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 150 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:69:8 [INFO] [stderr] | [INFO] [stderr] 69 | if !logger.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `logger.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/feed_util.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn to_feed(self) -> Result> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: The function/method `write_all` doesn't need a mutable reference [INFO] [stderr] --> src/feed_util.rs:142:36 [INFO] [stderr] | [INFO] [stderr] 142 | let result = db_file.write_all(&mut buf).map_err(|e| { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/feed_util.rs:150:8 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(result?) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 150 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:69:8 [INFO] [stderr] | [INFO] [stderr] 69 | if !logger.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `logger.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.76s [INFO] running `"docker" "inspect" "6482c1ca19d6b7aa6080fdb0124ae86dc63df43bdef9be93ccbec1c5d6e3a465"` [INFO] running `"docker" "rm" "-f" "6482c1ca19d6b7aa6080fdb0124ae86dc63df43bdef9be93ccbec1c5d6e3a465"` [INFO] [stdout] 6482c1ca19d6b7aa6080fdb0124ae86dc63df43bdef9be93ccbec1c5d6e3a465