[INFO] updating cached repository boustrophedon/glium_lerp_problem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/boustrophedon/glium_lerp_problem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/boustrophedon/glium_lerp_problem" "work/ex/clippy-test-run/sources/stable/gh/boustrophedon/glium_lerp_problem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/boustrophedon/glium_lerp_problem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/boustrophedon/glium_lerp_problem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boustrophedon/glium_lerp_problem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boustrophedon/glium_lerp_problem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1129e18d3743dc1bb98b84c6a65341205a396e78 [INFO] sha for GitHub repo boustrophedon/glium_lerp_problem: 1129e18d3743dc1bb98b84c6a65341205a396e78 [INFO] validating manifest of boustrophedon/glium_lerp_problem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of boustrophedon/glium_lerp_problem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing boustrophedon/glium_lerp_problem [INFO] finished frobbing boustrophedon/glium_lerp_problem [INFO] frobbed toml for boustrophedon/glium_lerp_problem written to work/ex/clippy-test-run/sources/stable/gh/boustrophedon/glium_lerp_problem/Cargo.toml [INFO] started frobbing boustrophedon/glium_lerp_problem [INFO] finished frobbing boustrophedon/glium_lerp_problem [INFO] frobbed toml for boustrophedon/glium_lerp_problem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boustrophedon/glium_lerp_problem/Cargo.toml [INFO] crate boustrophedon/glium_lerp_problem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting boustrophedon/glium_lerp_problem against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/boustrophedon/glium_lerp_problem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab5098282f8befdb36e19b1be719275cd9fa51100dd38ff58ba43106be35ba07 [INFO] running `"docker" "start" "-a" "ab5098282f8befdb36e19b1be719275cd9fa51100dd38ff58ba43106be35ba07"` [INFO] [stderr] Compiling serde v0.8.18 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking x11-dl v2.11.0 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking nalgebra v0.10.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling serde_json v0.8.3 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-client v0.5.12 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking glutin v0.6.2 [INFO] [stderr] Checking glium v0.15.0 [INFO] [stderr] Checking rendertest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Matrix4` [INFO] [stderr] --> src/main.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | use nalgebra::{PerspectiveMatrix3, Vector3, Matrix4, Point3, Isometry3, ToHomogeneous, Translation}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | .with_title(format!("Hello world")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello world".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | progress = progress + 0.001*(dt.num_milliseconds() as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `progress += 0.001*(dt.num_milliseconds() as f32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | perspective: perspective.as_ref().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*perspective.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | / match key.unwrap() { [INFO] [stderr] 125 | | KC::Escape => { [INFO] [stderr] 126 | | return true; [INFO] [stderr] 127 | | }, [INFO] [stderr] 128 | | _ => () [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let KC::Escape = key.unwrap() { [INFO] [stderr] 125 | return true; [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Matrix4` [INFO] [stderr] --> src/main.rs:7:45 [INFO] [stderr] | [INFO] [stderr] 7 | use nalgebra::{PerspectiveMatrix3, Vector3, Matrix4, Point3, Isometry3, ToHomogeneous, Translation}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | .with_title(format!("Hello world")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Hello world".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | progress = progress + 0.001*(dt.num_milliseconds() as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `progress += 0.001*(dt.num_milliseconds() as f32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | perspective: perspective.as_ref().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*perspective.as_ref()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:124:21 [INFO] [stderr] | [INFO] [stderr] 124 | / match key.unwrap() { [INFO] [stderr] 125 | | KC::Escape => { [INFO] [stderr] 126 | | return true; [INFO] [stderr] 127 | | }, [INFO] [stderr] 128 | | _ => () [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | if let KC::Escape = key.unwrap() { [INFO] [stderr] 125 | return true; [INFO] [stderr] 126 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.46s [INFO] running `"docker" "inspect" "ab5098282f8befdb36e19b1be719275cd9fa51100dd38ff58ba43106be35ba07"` [INFO] running `"docker" "rm" "-f" "ab5098282f8befdb36e19b1be719275cd9fa51100dd38ff58ba43106be35ba07"` [INFO] [stdout] ab5098282f8befdb36e19b1be719275cd9fa51100dd38ff58ba43106be35ba07