[INFO] updating cached repository bourem/naiverusthttpserver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bourem/naiverusthttpserver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bourem/naiverusthttpserver" "work/ex/clippy-test-run/sources/stable/gh/bourem/naiverusthttpserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bourem/naiverusthttpserver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bourem/naiverusthttpserver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bourem/naiverusthttpserver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bourem/naiverusthttpserver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d1dffa52ef3c696e68addd7290e0b1f73d60624b [INFO] sha for GitHub repo bourem/naiverusthttpserver: d1dffa52ef3c696e68addd7290e0b1f73d60624b [INFO] validating manifest of bourem/naiverusthttpserver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bourem/naiverusthttpserver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bourem/naiverusthttpserver [INFO] finished frobbing bourem/naiverusthttpserver [INFO] frobbed toml for bourem/naiverusthttpserver written to work/ex/clippy-test-run/sources/stable/gh/bourem/naiverusthttpserver/Cargo.toml [INFO] started frobbing bourem/naiverusthttpserver [INFO] finished frobbing bourem/naiverusthttpserver [INFO] frobbed toml for bourem/naiverusthttpserver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bourem/naiverusthttpserver/Cargo.toml [INFO] crate bourem/naiverusthttpserver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bourem/naiverusthttpserver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bourem/naiverusthttpserver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f94a049b7e067e55d7a8bf7cbeaa1e9129833bcf72e933bf1d843b38886d0aee [INFO] running `"docker" "start" "-a" "f94a049b7e067e55d7a8bf7cbeaa1e9129833bcf72e933bf1d843b38886d0aee"` [INFO] [stderr] Checking netw v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | bytes [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | let bytes = format!("{} {} {}\r\n\ [INFO] [stderr] | _____________________^ [INFO] [stderr] 52 | | Content-Type: {}\r\n\ [INFO] [stderr] 53 | | Content-Length: {}\r\n\r\n", [INFO] [stderr] 54 | | self.http_version, [INFO] [stderr] ... | [INFO] [stderr] 58 | | content_length [INFO] [stderr] 59 | | ).into_bytes(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | bytes [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | let bytes = format!("{} {} {}\r\n\ [INFO] [stderr] | _____________________^ [INFO] [stderr] 52 | | Content-Type: {}\r\n\ [INFO] [stderr] 53 | | Content-Length: {}\r\n\r\n", [INFO] [stderr] 54 | | self.http_version, [INFO] [stderr] ... | [INFO] [stderr] 58 | | content_length [INFO] [stderr] 59 | | ).into_bytes(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | match header.find(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:154:50 [INFO] [stderr] | [INFO] [stderr] 154 | let file_type = match resource.rfind(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:172:57 [INFO] [stderr] | [INFO] [stderr] 172 | match File::open(resource.trim_left_matches("/")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:102:35 [INFO] [stderr] | [INFO] [stderr] 102 | match header.find(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:154:50 [INFO] [stderr] | [INFO] [stderr] 154 | let file_type = match resource.rfind(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:172:57 [INFO] [stderr] | [INFO] [stderr] 172 | match File::open(resource.trim_left_matches("/")) { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "f94a049b7e067e55d7a8bf7cbeaa1e9129833bcf72e933bf1d843b38886d0aee"` [INFO] running `"docker" "rm" "-f" "f94a049b7e067e55d7a8bf7cbeaa1e9129833bcf72e933bf1d843b38886d0aee"` [INFO] [stdout] f94a049b7e067e55d7a8bf7cbeaa1e9129833bcf72e933bf1d843b38886d0aee