[INFO] updating cached repository botagar/fluidsim-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/botagar/fluidsim-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/botagar/fluidsim-rs" "work/ex/clippy-test-run/sources/stable/gh/botagar/fluidsim-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/botagar/fluidsim-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/botagar/fluidsim-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/botagar/fluidsim-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/botagar/fluidsim-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7fe9e24dba1dd46c2b1e0c19c53e6cdfacf159b7 [INFO] sha for GitHub repo botagar/fluidsim-rs: 7fe9e24dba1dd46c2b1e0c19c53e6cdfacf159b7 [INFO] validating manifest of botagar/fluidsim-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of botagar/fluidsim-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing botagar/fluidsim-rs [INFO] finished frobbing botagar/fluidsim-rs [INFO] frobbed toml for botagar/fluidsim-rs written to work/ex/clippy-test-run/sources/stable/gh/botagar/fluidsim-rs/Cargo.toml [INFO] started frobbing botagar/fluidsim-rs [INFO] finished frobbing botagar/fluidsim-rs [INFO] frobbed toml for botagar/fluidsim-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/botagar/fluidsim-rs/Cargo.toml [INFO] crate botagar/fluidsim-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting botagar/fluidsim-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/botagar/fluidsim-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ac6952c2d88bec37fca2dcbbce4b211a996b06be6c9ae4966acdb880bb8a23c5 [INFO] running `"docker" "start" "-a" "ac6952c2d88bec37fca2dcbbce4b211a996b06be6c9ae4966acdb880bb8a23c5"` [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Checking ordered-float v0.5.1 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking fluidsim-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable `lineLeft` should have a snake case name such as `line_left` [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let lineLeft = line::Line::new([0.0, 0.0, 0.0, 1.0], 1.0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable `lineLeft` should have a snake case name such as `line_left` [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let lineLeft = line::Line::new([0.0, 0.0, 0.0, 1.0], 1.0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:23 [INFO] [stderr] | [INFO] [stderr] 30 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 27.86s [INFO] running `"docker" "inspect" "ac6952c2d88bec37fca2dcbbce4b211a996b06be6c9ae4966acdb880bb8a23c5"` [INFO] running `"docker" "rm" "-f" "ac6952c2d88bec37fca2dcbbce4b211a996b06be6c9ae4966acdb880bb8a23c5"` [INFO] [stdout] ac6952c2d88bec37fca2dcbbce4b211a996b06be6c9ae4966acdb880bb8a23c5