[INFO] updating cached repository boringcactus/circumvention-chronicles [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/boringcactus/circumvention-chronicles [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/boringcactus/circumvention-chronicles" "work/ex/clippy-test-run/sources/stable/gh/boringcactus/circumvention-chronicles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/boringcactus/circumvention-chronicles'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/boringcactus/circumvention-chronicles" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boringcactus/circumvention-chronicles"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boringcactus/circumvention-chronicles'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e905d9d7133b1cad818052cdc14d96961b3fedcc [INFO] sha for GitHub repo boringcactus/circumvention-chronicles: e905d9d7133b1cad818052cdc14d96961b3fedcc [INFO] validating manifest of boringcactus/circumvention-chronicles on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of boringcactus/circumvention-chronicles on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing boringcactus/circumvention-chronicles [INFO] finished frobbing boringcactus/circumvention-chronicles [INFO] frobbed toml for boringcactus/circumvention-chronicles written to work/ex/clippy-test-run/sources/stable/gh/boringcactus/circumvention-chronicles/Cargo.toml [INFO] started frobbing boringcactus/circumvention-chronicles [INFO] finished frobbing boringcactus/circumvention-chronicles [INFO] frobbed toml for boringcactus/circumvention-chronicles written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boringcactus/circumvention-chronicles/Cargo.toml [INFO] crate boringcactus/circumvention-chronicles has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting boringcactus/circumvention-chronicles against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/boringcactus/circumvention-chronicles:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be0d9150bdc211a86d8c6d80680f29be05fb583f4ecb2c81416afc8f92d1fb6e [INFO] running `"docker" "start" "-a" "be0d9150bdc211a86d8c6d80680f29be05fb583f4ecb2c81416afc8f92d1fb6e"` [INFO] [stderr] Compiling num-traits v0.2.0 [INFO] [stderr] Compiling either v1.4.0 [INFO] [stderr] Checking open v1.2.1 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking petgraph v0.4.11 [INFO] [stderr] Compiling rand v0.3.22 [INFO] [stderr] Checking num-bigint v0.1.43 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling conrod_derive v0.1.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling itertools v0.5.10 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rusttype v0.4.1 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf v0.7.21 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking daggy v0.5.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling derivative v1.0.0 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking hyper v0.11.20 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.4 [INFO] [stderr] Checking conrod v0.58.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.48.0 [INFO] [stderr] Checking piston_window v0.75.0 [INFO] [stderr] Checking circumvention-chronicles v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/level.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/level.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | let text = rng.gen_ascii_chars().take(length).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/level.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | path [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/level.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | let path = (0..path_segments) [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | .map(|_| format!("/{}", alnum())) [INFO] [stderr] 53 | | .collect::>() [INFO] [stderr] 54 | | .join("") + "." + extension; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / return GameServer { [INFO] [stderr] 20 | | state [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | GameServer { [INFO] [stderr] 20 | state [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/level.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | text [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/level.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | let text = rng.gen_ascii_chars().take(length).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/level.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | path [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/level.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | let path = (0..path_segments) [INFO] [stderr] | ________________^ [INFO] [stderr] 52 | | .map(|_| format!("/{}", alnum())) [INFO] [stderr] 53 | | .collect::>() [INFO] [stderr] 54 | | .join("") + "." + extension; [INFO] [stderr] | |___________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/http.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / return GameServer { [INFO] [stderr] 20 | | state [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 19 | GameServer { [INFO] [stderr] 20 | state [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self.approved { [INFO] [stderr] 36 | | false => "Warning!".to_string(), [INFO] [stderr] 37 | | true => self.current_level.title() [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.approved { self.current_level.title() } else { "Warning!".to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.approved { [INFO] [stderr] 43 | | false => format!("Circumvention Chronicles is only for adults. It does not contain porn, but it is \ [INFO] [stderr] 44 | | about porn. Additionally, it relies on a locally bound Web server on port {} \ [INFO] [stderr] 45 | | that may trigger firewall warnings. If you are 18 or older and you are comfortable \ [INFO] [stderr] 46 | | with this, press \"Begin\". If not, press Esc or close this window.", http::PORT), [INFO] [stderr] 47 | | true => self.current_level.description() [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 42 | if self.approved { self.current_level.description() } else { format!("Circumvention Chronicles is only for adults. It does not contain porn, but it is \ [INFO] [stderr] 43 | about porn. Additionally, it relies on a locally bound Web server on port {} \ [INFO] [stderr] 44 | that may trigger firewall warnings. If you are 18 or older and you are comfortable \ [INFO] [stderr] 45 | with this, press \"Begin\". If not, press Esc or close this window.", http::PORT) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self.approved { [INFO] [stderr] 53 | | false => "Begin", [INFO] [stderr] 54 | | true => self.current_level.button_label() [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.approved { self.current_level.button_label() } else { "Begin" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.approved { [INFO] [stderr] 73 | | false => String::new(), [INFO] [stderr] 74 | | true => self.current_level.hint() [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.approved { self.current_level.hint() } else { String::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / match self.approved { [INFO] [stderr] 80 | | false => Response::new().with_status(StatusCode::Unauthorized), [INFO] [stderr] 81 | | true => { [INFO] [stderr] 82 | | let (new_level, response) = self.current_level.handle_request(method, path); [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 79 | if self.approved { [INFO] [stderr] 80 | let (new_level, response) = self.current_level.handle_request(method, path); [INFO] [stderr] 81 | self.transition(new_level); [INFO] [stderr] 82 | match response { [INFO] [stderr] 83 | Some(result) => Response::new().with_body(result), [INFO] [stderr] 84 | None => Response::new().with_status(StatusCode::NotFound) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | let hint_label = match state.showing_hint { [INFO] [stderr] | __________________________^ [INFO] [stderr] 193 | | false => "Show Hint", [INFO] [stderr] 194 | | true => "Hide Hint" [INFO] [stderr] 195 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if state.showing_hint { "Hide Hint" } else { "Show Hint" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self { [INFO] [stderr] 139 | | &Level::TitleScreen => "Circumvention Chronicles".to_string(), [INFO] [stderr] 140 | | &Level::Tutorial(_) => "Circumvention Chronicles TUTORIAL".to_string(), [INFO] [stderr] 141 | | &Level::Offline(_) => "Circumvention Chronicles LEVEL 1".to_string(), [INFO] [stderr] 142 | | &Level::Cache(_) => "Circumvention Chronicles LEVEL 2".to_string(), [INFO] [stderr] 143 | | &Level::Credits => "Circumvention Chronicles CREDITS".to_string(), [INFO] [stderr] 144 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *self { [INFO] [stderr] 139 | Level::TitleScreen => "Circumvention Chronicles".to_string(), [INFO] [stderr] 140 | Level::Tutorial(_) => "Circumvention Chronicles TUTORIAL".to_string(), [INFO] [stderr] 141 | Level::Offline(_) => "Circumvention Chronicles LEVEL 1".to_string(), [INFO] [stderr] 142 | Level::Cache(_) => "Circumvention Chronicles LEVEL 2".to_string(), [INFO] [stderr] 143 | Level::Credits => "Circumvention Chronicles CREDITS".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self { [INFO] [stderr] 149 | | &Level::TitleScreen => "Circumvention Chronicles is a Web-based puzzle game and filter circumvention tutorial. \ [INFO] [stderr] 150 | | You'll be presented with all sorts of scenarios where your Internet access is constrained in some way. \ [INFO] [stderr] 151 | | Solve puzzles in your Web browser to find porn anyways using some of the same methods I used in my misspent adolescence.".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 170 | | Circumvention Chronicles is a game made by Melody (@boring_cactus)".to_string(), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 148 | match *self { [INFO] [stderr] 149 | Level::TitleScreen => "Circumvention Chronicles is a Web-based puzzle game and filter circumvention tutorial. \ [INFO] [stderr] 150 | You'll be presented with all sorts of scenarios where your Internet access is constrained in some way. \ [INFO] [stderr] 151 | Solve puzzles in your Web browser to find porn anyways using some of the same methods I used in my misspent adolescence.".to_string(), [INFO] [stderr] 152 | Level::Tutorial(false) => "We'll start with a very basic puzzle to make sure everything works right. \ [INFO] [stderr] 153 | Hit the \"Open Browser\" button below and follow the instructions in the page that opens.".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match self { [INFO] [stderr] 176 | | &Level::TitleScreen => "Continue", [INFO] [stderr] 177 | | &Level::Tutorial(false) => "Open Browser", [INFO] [stderr] 178 | | &Level::Tutorial(true) => "Next Puzzle", [INFO] [stderr] ... | [INFO] [stderr] 184 | | &Level::Credits => "Open\nitch.io page", [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *self { [INFO] [stderr] 176 | Level::TitleScreen => "Continue", [INFO] [stderr] 177 | Level::Tutorial(false) => "Open Browser", [INFO] [stderr] 178 | Level::Tutorial(true) => "Next Puzzle", [INFO] [stderr] 179 | Level::Offline(OfflineState::Waiting) | Level::Offline(OfflineState::Loaded) => "Go Online", [INFO] [stderr] 180 | Level::Offline(OfflineState::Busted) => "Retry Puzzle", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match self { [INFO] [stderr] 190 | | &Level::TitleScreen => Some(Level::Tutorial(false)), [INFO] [stderr] 191 | | &Level::Tutorial(false) => { [INFO] [stderr] 192 | | launch_web(); [INFO] [stderr] ... | [INFO] [stderr] 210 | | }, [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | match *self { [INFO] [stderr] 190 | Level::TitleScreen => Some(Level::Tutorial(false)), [INFO] [stderr] 191 | Level::Tutorial(false) => { [INFO] [stderr] 192 | launch_web(); [INFO] [stderr] 193 | None [INFO] [stderr] 194 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / match self { [INFO] [stderr] 217 | | &Level::TitleScreen => cont, [INFO] [stderr] 218 | | &Level::Tutorial(false) => format!("Open http://localhost:{} with the button above and click the \"Continue\" button on that page", PORT), [INFO] [stderr] 219 | | &Level::Tutorial(true) => cont, [INFO] [stderr] ... | [INFO] [stderr] 226 | | &Level::Credits => "*notices your hint* OwO what's this?".to_string(), [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | match *self { [INFO] [stderr] 217 | Level::TitleScreen => cont, [INFO] [stderr] 218 | Level::Tutorial(false) => format!("Open http://localhost:{} with the button above and click the \"Continue\" button on that page", PORT), [INFO] [stderr] 219 | Level::Tutorial(true) => cont, [INFO] [stderr] 220 | Level::Offline(OfflineState::Waiting) => "How can you load the resources on a page without looking directly at it immediately?".to_string(), [INFO] [stderr] 221 | Level::Offline(OfflineState::Loaded) => "Now that the porn is loaded, how can you gain privacy so you can look at it?".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | / match self.approved { [INFO] [stderr] 36 | | false => "Warning!".to_string(), [INFO] [stderr] 37 | | true => self.current_level.title() [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.approved { self.current_level.title() } else { "Warning!".to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / match self.approved { [INFO] [stderr] 43 | | false => format!("Circumvention Chronicles is only for adults. It does not contain porn, but it is \ [INFO] [stderr] 44 | | about porn. Additionally, it relies on a locally bound Web server on port {} \ [INFO] [stderr] 45 | | that may trigger firewall warnings. If you are 18 or older and you are comfortable \ [INFO] [stderr] 46 | | with this, press \"Begin\". If not, press Esc or close this window.", http::PORT), [INFO] [stderr] 47 | | true => self.current_level.description() [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 42 | if self.approved { self.current_level.description() } else { format!("Circumvention Chronicles is only for adults. It does not contain porn, but it is \ [INFO] [stderr] 43 | about porn. Additionally, it relies on a locally bound Web server on port {} \ [INFO] [stderr] 44 | that may trigger firewall warnings. If you are 18 or older and you are comfortable \ [INFO] [stderr] 45 | with this, press \"Begin\". If not, press Esc or close this window.", http::PORT) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self.approved { [INFO] [stderr] 53 | | false => "Begin", [INFO] [stderr] 54 | | true => self.current_level.button_label() [INFO] [stderr] 55 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.approved { self.current_level.button_label() } else { "Begin" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:56 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.approved { [INFO] [stderr] 73 | | false => String::new(), [INFO] [stderr] 74 | | true => self.current_level.hint() [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.approved { self.current_level.hint() } else { String::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | let (win_w, win_h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | / match self.approved { [INFO] [stderr] 80 | | false => Response::new().with_status(StatusCode::Unauthorized), [INFO] [stderr] 81 | | true => { [INFO] [stderr] 82 | | let (new_level, response) = self.current_level.handle_request(method, path); [INFO] [stderr] ... | [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 79 | if self.approved { [INFO] [stderr] 80 | let (new_level, response) = self.current_level.handle_request(method, path); [INFO] [stderr] 81 | self.transition(new_level); [INFO] [stderr] 82 | match response { [INFO] [stderr] 83 | Some(result) => Response::new().with_body(result), [INFO] [stderr] 84 | None => Response::new().with_status(StatusCode::NotFound) [INFO] [stderr] ... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:61 [INFO] [stderr] | [INFO] [stderr] 69 | let (win_w, win_h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | if let None = server_handle { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 104 | | let state = state_mutex.lock().unwrap(); [INFO] [stderr] 105 | | if state.approved { [INFO] [stderr] 106 | | let server_state_mutex = Arc::clone(&state_mutex); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________- help: try this: `if server_handle.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/support.rs:192:26 [INFO] [stderr] | [INFO] [stderr] 192 | let hint_label = match state.showing_hint { [INFO] [stderr] | __________________________^ [INFO] [stderr] 193 | | false => "Show Hint", [INFO] [stderr] 194 | | true => "Hide Hint" [INFO] [stderr] 195 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if state.showing_hint { "Hide Hint" } else { "Show Hint" }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / match self { [INFO] [stderr] 139 | | &Level::TitleScreen => "Circumvention Chronicles".to_string(), [INFO] [stderr] 140 | | &Level::Tutorial(_) => "Circumvention Chronicles TUTORIAL".to_string(), [INFO] [stderr] 141 | | &Level::Offline(_) => "Circumvention Chronicles LEVEL 1".to_string(), [INFO] [stderr] 142 | | &Level::Cache(_) => "Circumvention Chronicles LEVEL 2".to_string(), [INFO] [stderr] 143 | | &Level::Credits => "Circumvention Chronicles CREDITS".to_string(), [INFO] [stderr] 144 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 138 | match *self { [INFO] [stderr] 139 | Level::TitleScreen => "Circumvention Chronicles".to_string(), [INFO] [stderr] 140 | Level::Tutorial(_) => "Circumvention Chronicles TUTORIAL".to_string(), [INFO] [stderr] 141 | Level::Offline(_) => "Circumvention Chronicles LEVEL 1".to_string(), [INFO] [stderr] 142 | Level::Cache(_) => "Circumvention Chronicles LEVEL 2".to_string(), [INFO] [stderr] 143 | Level::Credits => "Circumvention Chronicles CREDITS".to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self { [INFO] [stderr] 149 | | &Level::TitleScreen => "Circumvention Chronicles is a Web-based puzzle game and filter circumvention tutorial. \ [INFO] [stderr] 150 | | You'll be presented with all sorts of scenarios where your Internet access is constrained in some way. \ [INFO] [stderr] 151 | | Solve puzzles in your Web browser to find porn anyways using some of the same methods I used in my misspent adolescence.".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 170 | | Circumvention Chronicles is a game made by Melody (@boring_cactus)".to_string(), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 148 | match *self { [INFO] [stderr] 149 | Level::TitleScreen => "Circumvention Chronicles is a Web-based puzzle game and filter circumvention tutorial. \ [INFO] [stderr] 150 | You'll be presented with all sorts of scenarios where your Internet access is constrained in some way. \ [INFO] [stderr] 151 | Solve puzzles in your Web browser to find porn anyways using some of the same methods I used in my misspent adolescence.".to_string(), [INFO] [stderr] 152 | Level::Tutorial(false) => "We'll start with a very basic puzzle to make sure everything works right. \ [INFO] [stderr] 153 | Hit the \"Open Browser\" button below and follow the instructions in the page that opens.".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / match self { [INFO] [stderr] 176 | | &Level::TitleScreen => "Continue", [INFO] [stderr] 177 | | &Level::Tutorial(false) => "Open Browser", [INFO] [stderr] 178 | | &Level::Tutorial(true) => "Next Puzzle", [INFO] [stderr] ... | [INFO] [stderr] 184 | | &Level::Credits => "Open\nitch.io page", [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *self { [INFO] [stderr] 176 | Level::TitleScreen => "Continue", [INFO] [stderr] 177 | Level::Tutorial(false) => "Open Browser", [INFO] [stderr] 178 | Level::Tutorial(true) => "Next Puzzle", [INFO] [stderr] 179 | Level::Offline(OfflineState::Waiting) | Level::Offline(OfflineState::Loaded) => "Go Online", [INFO] [stderr] 180 | Level::Offline(OfflineState::Busted) => "Retry Puzzle", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match self { [INFO] [stderr] 190 | | &Level::TitleScreen => Some(Level::Tutorial(false)), [INFO] [stderr] 191 | | &Level::Tutorial(false) => { [INFO] [stderr] 192 | | launch_web(); [INFO] [stderr] ... | [INFO] [stderr] 210 | | }, [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 189 | match *self { [INFO] [stderr] 190 | Level::TitleScreen => Some(Level::Tutorial(false)), [INFO] [stderr] 191 | Level::Tutorial(false) => { [INFO] [stderr] 192 | launch_web(); [INFO] [stderr] 193 | None [INFO] [stderr] 194 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/level.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | / match self { [INFO] [stderr] 217 | | &Level::TitleScreen => cont, [INFO] [stderr] 218 | | &Level::Tutorial(false) => format!("Open http://localhost:{} with the button above and click the \"Continue\" button on that page", PORT), [INFO] [stderr] 219 | | &Level::Tutorial(true) => cont, [INFO] [stderr] ... | [INFO] [stderr] 226 | | &Level::Credits => "*notices your hint* OwO what's this?".to_string(), [INFO] [stderr] 227 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | match *self { [INFO] [stderr] 217 | Level::TitleScreen => cont, [INFO] [stderr] 218 | Level::Tutorial(false) => format!("Open http://localhost:{} with the button above and click the \"Continue\" button on that page", PORT), [INFO] [stderr] 219 | Level::Tutorial(true) => cont, [INFO] [stderr] 220 | Level::Offline(OfflineState::Waiting) => "How can you load the resources on a page without looking directly at it immediately?".to_string(), [INFO] [stderr] 221 | Level::Offline(OfflineState::Loaded) => "Now that the porn is loaded, how can you gain privacy so you can look at it?".to_string(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:42 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:37:56 [INFO] [stderr] | [INFO] [stderr] 37 | let mut ui = conrod::UiBuilder::new([WIDTH as f64, HEIGHT as f64]) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | let (win_w, win_h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:61 [INFO] [stderr] | [INFO] [stderr] 69 | let (win_w, win_h) = (size.width as conrod::Scalar, size.height as conrod::Scalar); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(size.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/main.rs:103:16 [INFO] [stderr] | [INFO] [stderr] 103 | if let None = server_handle { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 104 | | let state = state_mutex.lock().unwrap(); [INFO] [stderr] 105 | | if state.approved { [INFO] [stderr] 106 | | let server_state_mutex = Arc::clone(&state_mutex); [INFO] [stderr] ... | [INFO] [stderr] 111 | | } [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________- help: try this: `if server_handle.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 36s [INFO] running `"docker" "inspect" "be0d9150bdc211a86d8c6d80680f29be05fb583f4ecb2c81416afc8f92d1fb6e"` [INFO] running `"docker" "rm" "-f" "be0d9150bdc211a86d8c6d80680f29be05fb583f4ecb2c81416afc8f92d1fb6e"` [INFO] [stdout] be0d9150bdc211a86d8c6d80680f29be05fb583f4ecb2c81416afc8f92d1fb6e