[INFO] updating cached repository bootandy/ray [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bootandy/ray [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bootandy/ray" "work/ex/clippy-test-run/sources/stable/gh/bootandy/ray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bootandy/ray'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bootandy/ray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bootandy/ray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bootandy/ray'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3eaf5d8986b8263964205e041cf5d8f2f6f76bc6 [INFO] sha for GitHub repo bootandy/ray: 3eaf5d8986b8263964205e041cf5d8f2f6f76bc6 [INFO] validating manifest of bootandy/ray on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bootandy/ray on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bootandy/ray [INFO] finished frobbing bootandy/ray [INFO] frobbed toml for bootandy/ray written to work/ex/clippy-test-run/sources/stable/gh/bootandy/ray/Cargo.toml [INFO] started frobbing bootandy/ray [INFO] finished frobbing bootandy/ray [INFO] frobbed toml for bootandy/ray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bootandy/ray/Cargo.toml [INFO] crate bootandy/ray has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bootandy/ray against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bootandy/ray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 649b12322e6b545df6f4bb0a9d179bebbbcc8cc38678443994a5304177c29540 [INFO] running `"docker" "start" "-a" "649b12322e6b545df6f4bb0a9d179bebbbcc8cc38678443994a5304177c29540"` [INFO] [stderr] Checking itertools v0.7.9 [INFO] [stderr] Compiling syn v0.15.20 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling derive_more v0.13.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking ray v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/data/textures.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | let mut c = [[[Point { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/data/textures.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let w = w2 * w2 * (3.0 - 2.0 * w2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/data/textures.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | let mut c = [[[Point { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/data/textures.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | let w = w2 * w2 * (3.0 - 2.0 * w2); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `PURE_COLOR` [INFO] [stderr] --> src/data/textures.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use PURE_COLOR; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data/bounding.rs:258:20 [INFO] [stderr] | [INFO] [stderr] 258 | y: 0.000001, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data/bounding.rs:259:20 [INFO] [stderr] | [INFO] [stderr] 259 | z: 0.000001, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/data/bounding.rs:273:20 [INFO] [stderr] | [INFO] [stderr] 273 | z: 0.000001, [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `PURE_COLOR` [INFO] [stderr] --> src/data/textures.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use PURE_COLOR; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data/bounding.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Leaf(BvhLeaf), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 13 | Leaf(Box), [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data/material.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | Lambertian(Lambertian), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 59 | Lambertian(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `result` [INFO] [stderr] --> src/data/textures.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for (i, ) in result.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ran_float`. [INFO] [stderr] --> src/data/textures.rs:60:14 [INFO] [stderr] | [INFO] [stderr] 60 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 60 | for in &mut ran_float { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `c` [INFO] [stderr] --> src/data/textures.rs:128:18 [INFO] [stderr] | [INFO] [stderr] 128 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 128 | for (i, ) in c.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/data/textures.rs:167:16 [INFO] [stderr] | [INFO] [stderr] 167 | r: colors[0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(colors[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/data/textures.rs:168:16 [INFO] [stderr] | [INFO] [stderr] 168 | b: colors[2] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(colors[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/data/textures.rs:169:16 [INFO] [stderr] | [INFO] [stderr] 169 | g: colors[1] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(colors[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/data/textures.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | NT(NoiseTexture), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 178 | NT(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/data/camera.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn get_camera( [INFO] [stderr] 49 | | look_from: Point, [INFO] [stderr] 50 | | look_at: Point, [INFO] [stderr] 51 | | up: Point, [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] error[E0308]: mismatched types [INFO] [stderr] --> src/data/textures.rs:209:32 [INFO] [stderr] | [INFO] [stderr] 209 | let n = NoiseTexture { ran_float }; [INFO] [stderr] | ^^^^^^^^^ expected struct `data::vec3::Point`, found u8 [INFO] [stderr] | [INFO] [stderr] = note: expected type `[data::vec3::Point; 256]` [INFO] [stderr] found type `[u8; 256]` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `scale` in initializer of `data::textures::NoiseTexture` [INFO] [stderr] --> src/data/textures.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let n = NoiseTexture { ran_float }; [INFO] [stderr] | ^^^^^^^^^^^^ missing `scale` [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0063, E0308. [INFO] [stderr] For more information about an error, try `rustc --explain E0063`. [INFO] [stderr] error: Could not compile `ray`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "649b12322e6b545df6f4bb0a9d179bebbbcc8cc38678443994a5304177c29540"` [INFO] running `"docker" "rm" "-f" "649b12322e6b545df6f4bb0a9d179bebbbcc8cc38678443994a5304177c29540"` [INFO] [stdout] 649b12322e6b545df6f4bb0a9d179bebbbcc8cc38678443994a5304177c29540