[INFO] updating cached repository bootandy/ports2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bootandy/ports2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bootandy/ports2" "work/ex/clippy-test-run/sources/stable/gh/bootandy/ports2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bootandy/ports2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bootandy/ports2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bootandy/ports2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bootandy/ports2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d655a13d44dc9a58ff18b7177a10dda242e54358 [INFO] sha for GitHub repo bootandy/ports2: d655a13d44dc9a58ff18b7177a10dda242e54358 [INFO] validating manifest of bootandy/ports2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bootandy/ports2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bootandy/ports2 [INFO] finished frobbing bootandy/ports2 [INFO] frobbed toml for bootandy/ports2 written to work/ex/clippy-test-run/sources/stable/gh/bootandy/ports2/Cargo.toml [INFO] started frobbing bootandy/ports2 [INFO] finished frobbing bootandy/ports2 [INFO] frobbed toml for bootandy/ports2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bootandy/ports2/Cargo.toml [INFO] crate bootandy/ports2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bootandy/ports2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bootandy/ports2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c8c180d204d509494826466b60b1a2bdf707fd5359941d80c787eb4a1e8e638 [INFO] running `"docker" "start" "-a" "8c8c180d204d509494826466b60b1a2bdf707fd5359941d80c787eb4a1e8e638"` [INFO] [stderr] Compiling memchr v2.0.1 [INFO] [stderr] Checking pnet_sys v0.21.0 [INFO] [stderr] Compiling log v0.3.9 [INFO] [stderr] Compiling thread_local v0.3.5 [INFO] [stderr] Checking pnet_datalink v0.21.0 [INFO] [stderr] Compiling aho-corasick v0.6.6 [INFO] [stderr] Compiling syntex_errors v0.42.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Compiling syntex_syntax v0.42.0 [INFO] [stderr] Compiling syntex v0.42.2 [INFO] [stderr] Compiling pnet_macros v0.21.0 [INFO] [stderr] Compiling pnet_packet v0.21.0 [INFO] [stderr] Checking pnet_transport v0.21.0 [INFO] [stderr] Checking pnet v0.21.0 [INFO] [stderr] Checking ports2 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::thread` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::thread; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Arp` should have an upper case name such as `ARP` [INFO] [stderr] --> src/main.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | Arp => "Arp".to_string(), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Rarp` should have an upper case name such as `RARP` [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | Rarp => "Rarp".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Vlan` should have an upper case name such as `VLAN` [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | Vlan => "Vlan".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `WakeOnLan` should have an upper case name such as `WAKE_ON_LAN` [INFO] [stderr] --> src/main.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | WakeOnLan => "WakeOnLan".to_string(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Ipv4` should have an upper case name such as `IPV4` [INFO] [stderr] --> src/main.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | Ipv4 => "Ipv4".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Ipv6` should have an upper case name such as `IPV6` [INFO] [stderr] --> src/main.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | Ipv6 => "Ipv6".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:46 [INFO] [stderr] | [INFO] [stderr] 104 | let just_me = env::args().nth(2).unwrap_or("false".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "false".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | fn doit(interface_name : &String, just_me: bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | let interface_a = interfaces.into_iter() [INFO] [stderr] | _______________________^ [INFO] [stderr] 123 | | .filter(interface_names_match) [INFO] [stderr] 124 | | .next(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(interface_names_match).next()` with `find(interface_names_match)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Arp` should have an upper case name such as `ARP` [INFO] [stderr] --> src/main.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | Arp => "Arp".to_string(), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Rarp` should have an upper case name such as `RARP` [INFO] [stderr] --> src/main.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | Rarp => "Rarp".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Vlan` should have an upper case name such as `VLAN` [INFO] [stderr] --> src/main.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | Vlan => "Vlan".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `WakeOnLan` should have an upper case name such as `WAKE_ON_LAN` [INFO] [stderr] --> src/main.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | WakeOnLan => "WakeOnLan".to_string(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Ipv4` should have an upper case name such as `IPV4` [INFO] [stderr] --> src/main.rs:67:17 [INFO] [stderr] | [INFO] [stderr] 67 | Ipv4 => "Ipv4".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant in pattern `Ipv6` should have an upper case name such as `IPV6` [INFO] [stderr] --> src/main.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | Ipv6 => "Ipv6".to_string(), [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:104:46 [INFO] [stderr] | [INFO] [stderr] 104 | let just_me = env::args().nth(2).unwrap_or("false".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "false".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:110:26 [INFO] [stderr] | [INFO] [stderr] 110 | fn doit(interface_name : &String, just_me: bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:122:23 [INFO] [stderr] | [INFO] [stderr] 122 | let interface_a = interfaces.into_iter() [INFO] [stderr] | _______________________^ [INFO] [stderr] 123 | | .filter(interface_names_match) [INFO] [stderr] 124 | | .next(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = note: replace `filter(interface_names_match).next()` with `find(interface_names_match)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "8c8c180d204d509494826466b60b1a2bdf707fd5359941d80c787eb4a1e8e638"` [INFO] running `"docker" "rm" "-f" "8c8c180d204d509494826466b60b1a2bdf707fd5359941d80c787eb4a1e8e638"` [INFO] [stdout] 8c8c180d204d509494826466b60b1a2bdf707fd5359941d80c787eb4a1e8e638