[INFO] updating cached repository bon-chi/unite_bookmark_sync
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bon-chi/unite_bookmark_sync
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bon-chi/unite_bookmark_sync" "work/ex/clippy-test-run/sources/stable/gh/bon-chi/unite_bookmark_sync"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bon-chi/unite_bookmark_sync'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bon-chi/unite_bookmark_sync" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bon-chi/unite_bookmark_sync"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bon-chi/unite_bookmark_sync'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c1d9aab6c5c369c8c47e7286d6032a5cc42fb7f2
[INFO] sha for GitHub repo bon-chi/unite_bookmark_sync: c1d9aab6c5c369c8c47e7286d6032a5cc42fb7f2
[INFO] validating manifest of bon-chi/unite_bookmark_sync on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bon-chi/unite_bookmark_sync on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bon-chi/unite_bookmark_sync
[INFO] finished frobbing bon-chi/unite_bookmark_sync
[INFO] frobbed toml for bon-chi/unite_bookmark_sync written to work/ex/clippy-test-run/sources/stable/gh/bon-chi/unite_bookmark_sync/Cargo.toml
[INFO] started frobbing bon-chi/unite_bookmark_sync
[INFO] finished frobbing bon-chi/unite_bookmark_sync
[INFO] frobbed toml for bon-chi/unite_bookmark_sync written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bon-chi/unite_bookmark_sync/Cargo.toml
[INFO] crate bon-chi/unite_bookmark_sync has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bon-chi/unite_bookmark_sync against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bon-chi/unite_bookmark_sync:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f8a5d3df217f4d8e40fb7ab78d22fb339be65181d5798c3d133d01bbf01da3b1
[INFO] running `"docker" "start" "-a" "f8a5d3df217f4d8e40fb7ab78d22fb339be65181d5798c3d133d01bbf01da3b1"`
[INFO] [stderr]     Checking unite_bookmark_sync v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:190:21
[INFO] [stderr]     |
[INFO] [stderr] 190 |                     name: name,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:191:21
[INFO] [stderr]     |
[INFO] [stderr] 191 |                     directory: directory,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:190:21
[INFO] [stderr]     |
[INFO] [stderr] 190 |                     name: name,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:191:21
[INFO] [stderr]     |
[INFO] [stderr] 191 |                     directory: directory,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:167:30
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let bookmark_sync_path = env::home_dir().ok_or("no home directory".to_owned())
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]    --> src/main.rs:167:30
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let bookmark_sync_path = env::home_dir().ok_or("no home directory".to_owned())
[INFO] [stderr]     |                              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:48:24
[INFO] [stderr]    |
[INFO] [stderr] 48 |         CliError::None(String::from(err))
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `err`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:103:37
[INFO] [stderr]     |
[INFO] [stderr] 103 | /                                     let bookmarked_file;
[INFO] [stderr] 104 | |                                     if push {
[INFO] [stderr] 105 | |                                         bookmarked_file = bookmark_info[1]
[INFO] [stderr] 106 | |                                             .to_string()
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |                                                     bookmark_info[1].to_string());
[INFO] [stderr] 113 | |                                     }
[INFO] [stderr]     | |_____________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 103 |                                     let bookmarked_file = if push { bookmark_info[1]
[INFO] [stderr] 104 |                                             .to_string()
[INFO] [stderr] 105 |                                             .replacen(project.directory.to_str().unwrap(), "", 1) } else { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:167:46
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let bookmark_sync_path = env::home_dir().ok_or("no home directory".to_owned())
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no home directory".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<yaml::YamlLoader>::load_from_str` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:178:48
[INFO] [stderr]     |
[INFO] [stderr] 178 |     let yaml = yaml::YamlLoader::load_from_str(&mut bookmark_sync_string)?;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:182:1
[INFO] [stderr]     |
[INFO] [stderr] 182 | / fn build_bookmark<'a>(yaml: &'a Yaml) -> Result<Bookmark, CliError> {
[INFO] [stderr] 183 | |     let projects = yaml["projects"].as_vec().ok_or("no project".to_owned())?;
[INFO] [stderr] 184 | |     let mut vec = Vec::new();
[INFO] [stderr] 185 | |     for pro in projects.into_iter() {
[INFO] [stderr] ...   |
[INFO] [stderr] 204 | |     })
[INFO] [stderr] 205 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:183:46
[INFO] [stderr]     |
[INFO] [stderr] 183 |     let projects = yaml["projects"].as_vec().ok_or("no project".to_owned())?;
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no project".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:185:25
[INFO] [stderr]     |
[INFO] [stderr] 185 |     for pro in projects.into_iter() {
[INFO] [stderr]     |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:48:24
[INFO] [stderr]    |
[INFO] [stderr] 48 |         CliError::None(String::from(err))
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `err`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:103:37
[INFO] [stderr]     |
[INFO] [stderr] 103 | /                                     let bookmarked_file;
[INFO] [stderr] 104 | |                                     if push {
[INFO] [stderr] 105 | |                                         bookmarked_file = bookmark_info[1]
[INFO] [stderr] 106 | |                                             .to_string()
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |                                                     bookmark_info[1].to_string());
[INFO] [stderr] 113 | |                                     }
[INFO] [stderr]     | |_____________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] help: it is more idiomatic to write
[INFO] [stderr]     |
[INFO] [stderr] 103 |                                     let bookmarked_file = if push { bookmark_info[1]
[INFO] [stderr] 104 |                                             .to_string()
[INFO] [stderr] 105 |                                             .replacen(project.directory.to_str().unwrap(), "", 1) } else { $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:167:46
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let bookmark_sync_path = env::home_dir().ok_or("no home directory".to_owned())
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no home directory".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<yaml::YamlLoader>::load_from_str` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:178:48
[INFO] [stderr]     |
[INFO] [stderr] 178 |     let yaml = yaml::YamlLoader::load_from_str(&mut bookmark_sync_string)?;
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:182:1
[INFO] [stderr]     |
[INFO] [stderr] 182 | / fn build_bookmark<'a>(yaml: &'a Yaml) -> Result<Bookmark, CliError> {
[INFO] [stderr] 183 | |     let projects = yaml["projects"].as_vec().ok_or("no project".to_owned())?;
[INFO] [stderr] 184 | |     let mut vec = Vec::new();
[INFO] [stderr] 185 | |     for pro in projects.into_iter() {
[INFO] [stderr] ...   |
[INFO] [stderr] 204 | |     })
[INFO] [stderr] 205 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/main.rs:183:46
[INFO] [stderr]     |
[INFO] [stderr] 183 |     let projects = yaml["projects"].as_vec().ok_or("no project".to_owned())?;
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "no project".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec
[INFO] [stderr]    --> src/main.rs:185:25
[INFO] [stderr]     |
[INFO] [stderr] 185 |     for pro in projects.into_iter() {
[INFO] [stderr]     |                         ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.77s
[INFO] running `"docker" "inspect" "f8a5d3df217f4d8e40fb7ab78d22fb339be65181d5798c3d133d01bbf01da3b1"`
[INFO] running `"docker" "rm" "-f" "f8a5d3df217f4d8e40fb7ab78d22fb339be65181d5798c3d133d01bbf01da3b1"`
[INFO] [stdout] f8a5d3df217f4d8e40fb7ab78d22fb339be65181d5798c3d133d01bbf01da3b1