[INFO] updating cached repository bon-chi/nes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bon-chi/nes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bon-chi/nes" "work/ex/clippy-test-run/sources/stable/gh/bon-chi/nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bon-chi/nes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bon-chi/nes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bon-chi/nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bon-chi/nes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 823a8c3518d77b0c8799a71a28ac70af2d51da86 [INFO] sha for GitHub repo bon-chi/nes: 823a8c3518d77b0c8799a71a28ac70af2d51da86 [INFO] validating manifest of bon-chi/nes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bon-chi/nes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bon-chi/nes [INFO] finished frobbing bon-chi/nes [INFO] frobbed toml for bon-chi/nes written to work/ex/clippy-test-run/sources/stable/gh/bon-chi/nes/Cargo.toml [INFO] started frobbing bon-chi/nes [INFO] finished frobbing bon-chi/nes [INFO] frobbed toml for bon-chi/nes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bon-chi/nes/Cargo.toml [INFO] crate bon-chi/nes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bon-chi/nes against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bon-chi/nes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e149b1440be4dd06e9324f3c6abab6e5eacf1d065c72b7e23a59c79071137afc [INFO] running `"docker" "start" "-a" "e149b1440be4dd06e9324f3c6abab6e5eacf1d065c72b7e23a59c79071137afc"` [INFO] [stderr] Checking nes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: field is never used: `v_ram` [INFO] [stderr] --> src/nes/cpu/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | v_ram: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cpu` [INFO] [stderr] --> src/nes/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | cpu: Cpu, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ppu` [INFO] [stderr] --> src/nes/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | ppu: Ppu, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/nes/cpu/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | f.write(&[*v]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/nes/ppu/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | f.write(&[*v]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | i_nes_data[Self::COUNT_OF_PRG_ROM_UNITS_INDEX as usize] as u16 * [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(i_nes_data[Self::COUNT_OF_PRG_ROM_UNITS_INDEX as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:57:43 [INFO] [stderr] | [INFO] [stderr] 57 | let chr_rom_end = chr_rom_start + chr_rom_banks_num as u16 * Self::SIZE_OF_CHR_ROM_UNIT - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(chr_rom_banks_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/nes/mod.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | &i_nes_data[(prg_rom_start as usize)..(prg_rom_end as usize + 1)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((prg_rom_start as usize)..=prg_rom_end as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/nes/mod.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | &i_nes_data[(chr_rom_start as usize).. [INFO] [stderr] | _________________________^ [INFO] [stderr] 91 | | (chr_rom_end as usize + [INFO] [stderr] 92 | | 1)], [INFO] [stderr] | |___________________________________^ help: use: `((chr_rom_start as usize)..=chr_rom_end as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nes`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: field is never used: `v_ram` [INFO] [stderr] --> src/nes/cpu/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | v_ram: Arc>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cpu` [INFO] [stderr] --> src/nes/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | cpu: Cpu, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ppu` [INFO] [stderr] --> src/nes/mod.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | ppu: Ppu, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/nes/cpu/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | f.write(&[*v]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/nes/ppu/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | f.write(&[*v]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | i_nes_data[Self::COUNT_OF_PRG_ROM_UNITS_INDEX as usize] as u16 * [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(i_nes_data[Self::COUNT_OF_PRG_ROM_UNITS_INDEX as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes/mod.rs:57:43 [INFO] [stderr] | [INFO] [stderr] 57 | let chr_rom_end = chr_rom_start + chr_rom_banks_num as u16 * Self::SIZE_OF_CHR_ROM_UNIT - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(chr_rom_banks_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/nes/mod.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | &i_nes_data[(prg_rom_start as usize)..(prg_rom_end as usize + 1)], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((prg_rom_start as usize)..=prg_rom_end as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/nes/mod.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | &i_nes_data[(chr_rom_start as usize).. [INFO] [stderr] | _________________________^ [INFO] [stderr] 91 | | (chr_rom_end as usize + [INFO] [stderr] 92 | | 1)], [INFO] [stderr] | |___________________________________^ help: use: `((chr_rom_start as usize)..=chr_rom_end as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `nes`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e149b1440be4dd06e9324f3c6abab6e5eacf1d065c72b7e23a59c79071137afc"` [INFO] running `"docker" "rm" "-f" "e149b1440be4dd06e9324f3c6abab6e5eacf1d065c72b7e23a59c79071137afc"` [INFO] [stdout] e149b1440be4dd06e9324f3c6abab6e5eacf1d065c72b7e23a59c79071137afc