[INFO] updating cached repository bomb20/bfck-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bomb20/bfck-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bomb20/bfck-rust" "work/ex/clippy-test-run/sources/stable/gh/bomb20/bfck-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bomb20/bfck-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bomb20/bfck-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bomb20/bfck-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bomb20/bfck-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e0efad4f0fce8772230ac044c68260b549f5d90d [INFO] sha for GitHub repo bomb20/bfck-rust: e0efad4f0fce8772230ac044c68260b549f5d90d [INFO] validating manifest of bomb20/bfck-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bomb20/bfck-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bomb20/bfck-rust [INFO] finished frobbing bomb20/bfck-rust [INFO] frobbed toml for bomb20/bfck-rust written to work/ex/clippy-test-run/sources/stable/gh/bomb20/bfck-rust/Cargo.toml [INFO] started frobbing bomb20/bfck-rust [INFO] finished frobbing bomb20/bfck-rust [INFO] frobbed toml for bomb20/bfck-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bomb20/bfck-rust/Cargo.toml [INFO] crate bomb20/bfck-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bomb20/bfck-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bomb20/bfck-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 098e5dc0e46787350b6f3633e79aaed1459798e123c47ab12559c743ca3c9507 [INFO] running `"docker" "start" "-a" "098e5dc0e46787350b6f3633e79aaed1459798e123c47ab12559c743ca3c9507"` [INFO] [stderr] Checking bfck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bfck/runtime.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn run(&mut self, instructions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bfck/runtime.rs:38:39 [INFO] [stderr] | [INFO] [stderr] 38 | Instruction::WRITE => match io::stdin().bytes().next().expect("IO error") { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 39 | | Ok(value) => self.tape.store(value), [INFO] [stderr] 40 | | Err(_) => {}, [INFO] [stderr] 41 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let Ok(value) = io::stdin().bytes().next().expect("IO error") { self.tape.store(value) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bfck/runtime.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn compile(program_code: &Vec, instructions: &mut Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program_code` [INFO] [stderr] --> src/bfck/runtime.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | for i in 0..program_code.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for (i, ) in program_code.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bfck/runtime.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | fn optimize(instructions: &Vec, opt_instructions: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bfck/runtime.rs:18:41 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn run(&mut self, instructions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bfck/runtime.rs:38:39 [INFO] [stderr] | [INFO] [stderr] 38 | Instruction::WRITE => match io::stdin().bytes().next().expect("IO error") { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 39 | | Ok(value) => self.tape.store(value), [INFO] [stderr] 40 | | Err(_) => {}, [INFO] [stderr] 41 | | }, [INFO] [stderr] | |_________________^ help: try this: `if let Ok(value) = io::stdin().bytes().next().expect("IO error") { self.tape.store(value) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bfck/runtime.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn compile(program_code: &Vec, instructions: &mut Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `program_code` [INFO] [stderr] --> src/bfck/runtime.rs:56:18 [INFO] [stderr] | [INFO] [stderr] 56 | for i in 0..program_code.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 56 | for (i, ) in program_code.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bfck/runtime.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | fn optimize(instructions: &Vec, opt_instructions: &mut Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "098e5dc0e46787350b6f3633e79aaed1459798e123c47ab12559c743ca3c9507"` [INFO] running `"docker" "rm" "-f" "098e5dc0e46787350b6f3633e79aaed1459798e123c47ab12559c743ca3c9507"` [INFO] [stdout] 098e5dc0e46787350b6f3633e79aaed1459798e123c47ab12559c743ca3c9507