[INFO] updating cached repository bokuweb/lcs-image-diff-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bokuweb/lcs-image-diff-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bokuweb/lcs-image-diff-rs" "work/ex/clippy-test-run/sources/stable/gh/bokuweb/lcs-image-diff-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bokuweb/lcs-image-diff-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bokuweb/lcs-image-diff-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/lcs-image-diff-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/lcs-image-diff-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2351847c2a59a68ee5d735c973d16b3ad596769f
[INFO] sha for GitHub repo bokuweb/lcs-image-diff-rs: 2351847c2a59a68ee5d735c973d16b3ad596769f
[INFO] validating manifest of bokuweb/lcs-image-diff-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bokuweb/lcs-image-diff-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bokuweb/lcs-image-diff-rs
[INFO] finished frobbing bokuweb/lcs-image-diff-rs
[INFO] frobbed toml for bokuweb/lcs-image-diff-rs written to work/ex/clippy-test-run/sources/stable/gh/bokuweb/lcs-image-diff-rs/Cargo.toml
[INFO] started frobbing bokuweb/lcs-image-diff-rs
[INFO] finished frobbing bokuweb/lcs-image-diff-rs
[INFO] frobbed toml for bokuweb/lcs-image-diff-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bokuweb/lcs-image-diff-rs/Cargo.toml
[INFO] crate bokuweb/lcs-image-diff-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bokuweb/lcs-image-diff-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bokuweb/lcs-image-diff-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 157f6fff0626c28036a5b968d84cf09b4f286c5bc9675185c434728d5f5e3e6f
[INFO] running `"docker" "start" "-a" "157f6fff0626c28036a5b968d84cf09b4f286c5bc9675185c434728d5f5e3e6f"`
[INFO] [stderr]     Checking lcs-diff v0.1.1
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking lcs-image-diff v0.1.6 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/image_creator.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     return Rgba {
[INFO] [stderr] 55 | |         data: [
[INFO] [stderr] 56 | |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr] 57 | |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |         ],
[INFO] [stderr] 61 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 54 |     Rgba {
[INFO] [stderr] 55 |         data: [
[INFO] [stderr] 56 |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr] 57 |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr] 58 |             (base.data[2] as f32 * (1.0 - rate) + rgb.2 as f32 * (rate)) as u8,
[INFO] [stderr] 59 |             base.data[3],
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/image_creator.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     return Rgba {
[INFO] [stderr] 55 | |         data: [
[INFO] [stderr] 56 | |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr] 57 | |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr] ...  |
[INFO] [stderr] 60 | |         ],
[INFO] [stderr] 61 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 54 |     Rgba {
[INFO] [stderr] 55 |         data: [
[INFO] [stderr] 56 |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr] 57 |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr] 58 |             (base.data[2] as f32 * (1.0 - rate) + rgb.2 as f32 * (rate)) as u8,
[INFO] [stderr] 59 |             base.data[3],
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/image_creator.rs:9:21
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn compute_range(r: &Vec<usize>) -> Vec<(usize, usize)> {
[INFO] [stderr]   |                     ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/image_creator.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |         for y in y1..(y2 + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: use: `y1..=y2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:56:14
[INFO] [stderr]    |
[INFO] [stderr] 56 |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base.data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:56:51
[INFO] [stderr]    |
[INFO] [stderr] 56 |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^ help: try: `f32::from(rgb.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:57:14
[INFO] [stderr]    |
[INFO] [stderr] 57 |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base.data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:57:51
[INFO] [stderr]    |
[INFO] [stderr] 57 |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^ help: try: `f32::from(rgb.1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:58:14
[INFO] [stderr]    |
[INFO] [stderr] 58 |             (base.data[2] as f32 * (1.0 - rate) + rgb.2 as f32 * (rate)) as u8,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base.data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:58:51
[INFO] [stderr]    |
[INFO] [stderr] 58 |             (base.data[2] as f32 * (1.0 - rate) + rgb.2 as f32 * (rate)) as u8,
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^ help: try: `f32::from(rgb.2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/image_creator.rs:68:11
[INFO] [stderr]    |
[INFO] [stderr] 68 |     data: &String,
[INFO] [stderr]    |           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/image_creator.rs:91:14
[INFO] [stderr]    |
[INFO] [stderr] 91 |     indexes: &Vec<usize>,
[INFO] [stderr]    |              ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/image_creator.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let ref mut fout = File::create(filename).unwrap();
[INFO] [stderr]    |     ----^^^^^^^^^^^^----------------------------------- help: try: `let fout = &mut File::create(filename).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/image_creator.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |     result: &Vec<DiffResult<String>>,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DiffResult<String>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/image_creator.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 | /         match d {
[INFO] [stderr] 115 | |             &DiffResult::Added(ref a) => {
[INFO] [stderr] 116 | |                 put_diff_pixels(y, &mut img, after_width, &a.data, (99, 195, 99), rate)
[INFO] [stderr] 117 | |             }
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |             }
[INFO] [stderr] 124 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |         match *d {
[INFO] [stderr] 115 |             DiffResult::Added(ref a) => {
[INFO] [stderr] 116 |                 put_diff_pixels(y, &mut img, after_width, &a.data, (99, 195, 99), rate)
[INFO] [stderr] 117 |             }
[INFO] [stderr] 118 |             DiffResult::Removed(ref r) => {
[INFO] [stderr] 119 |                 put_diff_pixels(y, &mut img, before_width, &r.data, (255, 119, 119), rate)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/image_creator.rs:126:9
[INFO] [stderr]     |
[INFO] [stderr] 126 |     let ref mut fout = File::create(filename).unwrap();
[INFO] [stderr]     |     ----^^^^^^^^^^^^----------------------------------- help: try: `let fout = &mut File::create(filename).unwrap();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 | /         match d {
[INFO] [stderr] 60 | |             &lcs_diff::DiffResult::Added(ref a) => added.push(a.new_index.unwrap()),
[INFO] [stderr] 61 | |             &lcs_diff::DiffResult::Removed(ref r) => removed.push(r.old_index.unwrap()),
[INFO] [stderr] 62 | |             _ => (),
[INFO] [stderr] 63 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 59 |         match *d {
[INFO] [stderr] 60 |             lcs_diff::DiffResult::Added(ref a) => added.push(a.new_index.unwrap()),
[INFO] [stderr] 61 |             lcs_diff::DiffResult::Removed(ref r) => removed.push(r.old_index.unwrap()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/image_creator.rs:9:21
[INFO] [stderr]   |
[INFO] [stderr] 9 | fn compute_range(r: &Vec<usize>) -> Vec<(usize, usize)> {
[INFO] [stderr]   |                     ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/image_creator.rs:43:18
[INFO] [stderr]    |
[INFO] [stderr] 43 |         for y in y1..(y2 + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: use: `y1..=y2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:56:14
[INFO] [stderr]    |
[INFO] [stderr] 56 |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base.data[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:56:51
[INFO] [stderr]    |
[INFO] [stderr] 56 |             (base.data[0] as f32 * (1.0 - rate) + rgb.0 as f32 * (rate)) as u8,
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^ help: try: `f32::from(rgb.0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:57:14
[INFO] [stderr]    |
[INFO] [stderr] 57 |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base.data[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:57:51
[INFO] [stderr]    |
[INFO] [stderr] 57 |             (base.data[1] as f32 * (1.0 - rate) + rgb.1 as f32 * (rate)) as u8,
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^ help: try: `f32::from(rgb.1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:58:14
[INFO] [stderr]    |
[INFO] [stderr] 58 |             (base.data[2] as f32 * (1.0 - rate) + rgb.2 as f32 * (rate)) as u8,
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(base.data[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/image_creator.rs:58:51
[INFO] [stderr]    |
[INFO] [stderr] 58 |             (base.data[2] as f32 * (1.0 - rate) + rgb.2 as f32 * (rate)) as u8,
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^ help: try: `f32::from(rgb.2)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/image_creator.rs:68:11
[INFO] [stderr]    |
[INFO] [stderr] 68 |     data: &String,
[INFO] [stderr]    |           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/image_creator.rs:91:14
[INFO] [stderr]    |
[INFO] [stderr] 91 |     indexes: &Vec<usize>,
[INFO] [stderr]    |              ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/image_creator.rs:97:9
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let ref mut fout = File::create(filename).unwrap();
[INFO] [stderr]    |     ----^^^^^^^^^^^^----------------------------------- help: try: `let fout = &mut File::create(filename).unwrap();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/image_creator.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |     result: &Vec<DiffResult<String>>,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[DiffResult<String>]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/image_creator.rs:114:9
[INFO] [stderr]     |
[INFO] [stderr] 114 | /         match d {
[INFO] [stderr] 115 | |             &DiffResult::Added(ref a) => {
[INFO] [stderr] 116 | |                 put_diff_pixels(y, &mut img, after_width, &a.data, (99, 195, 99), rate)
[INFO] [stderr] 117 | |             }
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |             }
[INFO] [stderr] 124 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 114 |         match *d {
[INFO] [stderr] 115 |             DiffResult::Added(ref a) => {
[INFO] [stderr] 116 |                 put_diff_pixels(y, &mut img, after_width, &a.data, (99, 195, 99), rate)
[INFO] [stderr] 117 |             }
[INFO] [stderr] 118 |             DiffResult::Removed(ref r) => {
[INFO] [stderr] 119 |                 put_diff_pixels(y, &mut img, before_width, &r.data, (255, 119, 119), rate)
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/image_creator.rs:126:9
[INFO] [stderr]     |
[INFO] [stderr] 126 |     let ref mut fout = File::create(filename).unwrap();
[INFO] [stderr]     |     ----^^^^^^^^^^^^----------------------------------- help: try: `let fout = &mut File::create(filename).unwrap();`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:59:9
[INFO] [stderr]    |
[INFO] [stderr] 59 | /         match d {
[INFO] [stderr] 60 | |             &lcs_diff::DiffResult::Added(ref a) => added.push(a.new_index.unwrap()),
[INFO] [stderr] 61 | |             &lcs_diff::DiffResult::Removed(ref r) => removed.push(r.old_index.unwrap()),
[INFO] [stderr] 62 | |             _ => (),
[INFO] [stderr] 63 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 59 |         match *d {
[INFO] [stderr] 60 |             lcs_diff::DiffResult::Added(ref a) => added.push(a.new_index.unwrap()),
[INFO] [stderr] 61 |             lcs_diff::DiffResult::Removed(ref r) => removed.push(r.old_index.unwrap()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 11.29s
[INFO] running `"docker" "inspect" "157f6fff0626c28036a5b968d84cf09b4f286c5bc9675185c434728d5f5e3e6f"`
[INFO] running `"docker" "rm" "-f" "157f6fff0626c28036a5b968d84cf09b4f286c5bc9675185c434728d5f5e3e6f"`
[INFO] [stdout] 157f6fff0626c28036a5b968d84cf09b4f286c5bc9675185c434728d5f5e3e6f