[INFO] updating cached repository boiding/boid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/boiding/boid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/boiding/boid" "work/ex/clippy-test-run/sources/stable/gh/boiding/boid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/boiding/boid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/boiding/boid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boiding/boid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boiding/boid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 20da2e5611010ef3d71e18370f56b9539f286fa8 [INFO] sha for GitHub repo boiding/boid: 20da2e5611010ef3d71e18370f56b9539f286fa8 [INFO] validating manifest of boiding/boid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of boiding/boid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing boiding/boid [INFO] finished frobbing boiding/boid [INFO] frobbed toml for boiding/boid written to work/ex/clippy-test-run/sources/stable/gh/boiding/boid/Cargo.toml [INFO] started frobbing boiding/boid [INFO] finished frobbing boiding/boid [INFO] frobbed toml for boiding/boid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/boiding/boid/Cargo.toml [INFO] crate boiding/boid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting boiding/boid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/boiding/boid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9115b68046261fe25b69cc3ff3e57a70b697f386002c73d119cb68573c939565 [INFO] running `"docker" "start" "-a" "9115b68046261fe25b69cc3ff3e57a70b697f386002c73d119cb68573c939565"` [INFO] [stderr] Checking serde v1.0.18 [INFO] [stderr] Compiling rand v0.3.17 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Compiling serde_derive v1.0.18 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.49.0 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking glutin v0.10.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking boid v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/model/mod.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | velocity [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/model/mod.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | let velocity = self.velocity.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/brain/mod.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | velocity [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/brain/mod.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | let velocity = Velocity::new(heading, speed) * (1.0/n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | let xl = self.speed * self.heading.cos(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | let yl = self.speed * self.heading.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | let xr = rhs.speed * rhs.heading.cos(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | let yr = rhs.speed * rhs.heading.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model/mod.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | let width = width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model/mod.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let height = height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `model::BoidConfigFactory` [INFO] [stderr] --> src/model/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / pub fn new() -> Self { [INFO] [stderr] 106 | | BoidConfigFactory { max_x: 100f64, max_y: 100f64, min_speed: 200f64, max_speed: 300f64, agility: 0.1, group_size: 20, size: 10f64 } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:10:35 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn brain(boid: &Boid, clique: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | fn average_velocity(clique: &Vec) -> Velocity { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:44:39 [INFO] [stderr] | [INFO] [stderr] 44 | fn avoid_closest(boid: &Boid, clique: &Vec) -> Velocity { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | fn closest_boid(boid: &Boid, clique: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | fn seek_center(boid: &Boid, clique: &Vec) -> Velocity { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/app/mod.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let boids: Vec = self.boids.iter().map(|b| b.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.boids.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app/mod.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / match brain(boid, &clique) { [INFO] [stderr] 61 | | Some(velocity) => { [INFO] [stderr] 62 | | boid.velocity = velocity; [INFO] [stderr] 63 | | }, [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | if let Some(velocity) = brain(boid, &clique) { [INFO] [stderr] 61 | boid.velocity = velocity; [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `boid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/model/mod.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | velocity [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/model/mod.rs:33:32 [INFO] [stderr] | [INFO] [stderr] 33 | let velocity = self.velocity.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/brain/mod.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | velocity [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/brain/mod.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | let velocity = Velocity::new(heading, speed) * (1.0/n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | let xl = self.speed * self.heading.cos(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | let yl = self.speed * self.heading.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | let xr = rhs.speed * rhs.heading.cos(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Add` impl [INFO] [stderr] --> src/model/velocity.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | let yr = rhs.speed * rhs.heading.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model/mod.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | let width = width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/model/mod.rs:44:22 [INFO] [stderr] | [INFO] [stderr] 44 | let height = height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `model::BoidConfigFactory` [INFO] [stderr] --> src/model/mod.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | / pub fn new() -> Self { [INFO] [stderr] 106 | | BoidConfigFactory { max_x: 100f64, max_y: 100f64, min_speed: 200f64, max_speed: 300f64, agility: 0.1, group_size: 20, size: 10f64 } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 94 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:10:35 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn brain(boid: &Boid, clique: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | fn average_velocity(clique: &Vec) -> Velocity { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:44:39 [INFO] [stderr] | [INFO] [stderr] 44 | fn avoid_closest(boid: &Boid, clique: &Vec) -> Velocity { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:62:38 [INFO] [stderr] | [INFO] [stderr] 62 | fn closest_boid(boid: &Boid, clique: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/brain/mod.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | fn seek_center(boid: &Boid, clique: &Vec) -> Velocity { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Boid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/app/mod.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | let boids: Vec = self.boids.iter().map(|b| b.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.boids.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app/mod.rs:50:36 [INFO] [stderr] | [INFO] [stderr] 50 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/app/mod.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / match brain(boid, &clique) { [INFO] [stderr] 61 | | Some(velocity) => { [INFO] [stderr] 62 | | boid.velocity = velocity; [INFO] [stderr] 63 | | }, [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 60 | if let Some(velocity) = brain(boid, &clique) { [INFO] [stderr] 61 | boid.velocity = velocity; [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `boid`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9115b68046261fe25b69cc3ff3e57a70b697f386002c73d119cb68573c939565"` [INFO] running `"docker" "rm" "-f" "9115b68046261fe25b69cc3ff3e57a70b697f386002c73d119cb68573c939565"` [INFO] [stdout] 9115b68046261fe25b69cc3ff3e57a70b697f386002c73d119cb68573c939565