[INFO] updating cached repository bohdantrotsenko/rust-kalaha [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bohdantrotsenko/rust-kalaha [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bohdantrotsenko/rust-kalaha" "work/ex/clippy-test-run/sources/stable/gh/bohdantrotsenko/rust-kalaha"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bohdantrotsenko/rust-kalaha'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bohdantrotsenko/rust-kalaha" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bohdantrotsenko/rust-kalaha"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bohdantrotsenko/rust-kalaha'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 07e0e593baebb957453873d4186a82dc87ea89d2 [INFO] sha for GitHub repo bohdantrotsenko/rust-kalaha: 07e0e593baebb957453873d4186a82dc87ea89d2 [INFO] validating manifest of bohdantrotsenko/rust-kalaha on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bohdantrotsenko/rust-kalaha on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bohdantrotsenko/rust-kalaha [INFO] finished frobbing bohdantrotsenko/rust-kalaha [INFO] frobbed toml for bohdantrotsenko/rust-kalaha written to work/ex/clippy-test-run/sources/stable/gh/bohdantrotsenko/rust-kalaha/Cargo.toml [INFO] started frobbing bohdantrotsenko/rust-kalaha [INFO] finished frobbing bohdantrotsenko/rust-kalaha [INFO] frobbed toml for bohdantrotsenko/rust-kalaha written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bohdantrotsenko/rust-kalaha/Cargo.toml [INFO] crate bohdantrotsenko/rust-kalaha has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bohdantrotsenko/rust-kalaha against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bohdantrotsenko/rust-kalaha:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f0876d790d3733bbb64313a7c132327b6a420703df6dde4a4924c1e575ec0de6 [INFO] running `"docker" "start" "-a" "f0876d790d3733bbb64313a7c132327b6a420703df6dde4a4924c1e575ec0de6"` [INFO] [stderr] Checking rust-kalaha v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 138 | | if p0full < p1full { [INFO] [stderr] 139 | | State::Win(1) [INFO] [stderr] 140 | | } else if p0full > p1full { [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | } else if p0full < p1full { [INFO] [stderr] 138 | State::Win(1) [INFO] [stderr] 139 | } else if p0full > p1full { [INFO] [stderr] 140 | State::Win(0) [INFO] [stderr] 141 | } else { [INFO] [stderr] 142 | State::Draw [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 138 | | if p0full < p1full { [INFO] [stderr] 139 | | State::Win(1) [INFO] [stderr] 140 | | } else if p0full > p1full { [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 137 | } else if p0full < p1full { [INFO] [stderr] 138 | State::Win(1) [INFO] [stderr] 139 | } else if p0full > p1full { [INFO] [stderr] 140 | State::Win(0) [INFO] [stderr] 141 | } else { [INFO] [stderr] 142 | State::Draw [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | *t = *t << 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | *t = *t | 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `*t |= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | *t = *t << 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t <<= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | *t = *t >> 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | *t = *t >> 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | let mut n: Game = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | g = possibilities[rng.gen_range(0, n)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possibilities[rng.gen_range(0, n)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | g = possibilities[rng.gen_range(0, n)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possibilities[rng.gen_range(0, n)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:329:22 [INFO] [stderr] | [INFO] [stderr] 329 | knowledge = Some((current.clone(), outcome.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | g = possibilities[rng.gen_range(0, n)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possibilities[rng.gen_range(0, n)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | *t = *t << 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | *t = *t | 1; [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `*t |= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | *t = *t << 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t <<= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | *t = *t >> 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | *t = *t >> 1; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `*t >>= 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:151:27 [INFO] [stderr] | [INFO] [stderr] 151 | let mut n: Game = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | g = possibilities[rng.gen_range(0, n)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possibilities[rng.gen_range(0, n)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | g = possibilities[rng.gen_range(0, n)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possibilities[rng.gen_range(0, n)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:329:22 [INFO] [stderr] | [INFO] [stderr] 329 | knowledge = Some((current.clone(), outcome.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:452:13 [INFO] [stderr] | [INFO] [stderr] 452 | g = possibilities[rng.gen_range(0, n)].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `possibilities[rng.gen_range(0, n)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.54s [INFO] running `"docker" "inspect" "f0876d790d3733bbb64313a7c132327b6a420703df6dde4a4924c1e575ec0de6"` [INFO] running `"docker" "rm" "-f" "f0876d790d3733bbb64313a7c132327b6a420703df6dde4a4924c1e575ec0de6"` [INFO] [stdout] f0876d790d3733bbb64313a7c132327b6a420703df6dde4a4924c1e575ec0de6