[INFO] updating cached repository bobtwinkles/msdfgen-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bobtwinkles/msdfgen-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bobtwinkles/msdfgen-rs" "work/ex/clippy-test-run/sources/stable/gh/bobtwinkles/msdfgen-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bobtwinkles/msdfgen-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bobtwinkles/msdfgen-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bobtwinkles/msdfgen-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bobtwinkles/msdfgen-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 222dd13f06421e44da5ec12b146c59daa1c87915 [INFO] sha for GitHub repo bobtwinkles/msdfgen-rs: 222dd13f06421e44da5ec12b146c59daa1c87915 [INFO] validating manifest of bobtwinkles/msdfgen-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bobtwinkles/msdfgen-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bobtwinkles/msdfgen-rs [INFO] finished frobbing bobtwinkles/msdfgen-rs [INFO] frobbed toml for bobtwinkles/msdfgen-rs written to work/ex/clippy-test-run/sources/stable/gh/bobtwinkles/msdfgen-rs/Cargo.toml [INFO] started frobbing bobtwinkles/msdfgen-rs [INFO] finished frobbing bobtwinkles/msdfgen-rs [INFO] frobbed toml for bobtwinkles/msdfgen-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bobtwinkles/msdfgen-rs/Cargo.toml [INFO] crate bobtwinkles/msdfgen-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bobtwinkles/msdfgen-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bobtwinkles/msdfgen-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 276bddda57731f7ce4f561f8c8d4aeac35a41c6f59c001752208f991121bd547 [INFO] running `"docker" "start" "-a" "276bddda57731f7ce4f561f8c8d4aeac35a41c6f59c001752208f991121bd547"` [INFO] [stderr] Checking float-ord v0.2.0 [INFO] [stderr] Compiling servo-fontconfig-sys v4.0.7 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Compiling servo-freetype-sys v4.0.3 [INFO] [stderr] Checking euclid v0.19.2 [INFO] [stderr] Compiling glium v0.22.0 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking lyon_geom v0.12.2 [INFO] [stderr] Checking lyon_path v0.12.0 [INFO] [stderr] Checking glutin v0.17.0 [INFO] [stderr] Checking freetype v0.4.1 [INFO] [stderr] Checking servo-fontconfig v0.4.0 [INFO] [stderr] Checking font-kit v0.1.0 [INFO] [stderr] Checking msdfgen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/path.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let d = self.elements[1].sample(0.5); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/path.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | let d = qa.dot(ab); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/path.rs:220:25 [INFO] [stderr] | [INFO] [stderr] 220 | let mut f = -qa.dot(ab) / ab.dot(ab); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/path.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | let d = self.elements[1].sample(0.5); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/path.rs:215:21 [INFO] [stderr] | [INFO] [stderr] 215 | let d = qa.dot(ab); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/path.rs:220:25 [INFO] [stderr] | [INFO] [stderr] 220 | let mut f = -qa.dot(ab) / ab.dot(ab); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `path::PathCollector` [INFO] [stderr] --> src/path.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / pub fn new() -> Self { [INFO] [stderr] 317 | | Self { [INFO] [stderr] 318 | | contour_start: Point::new(0.0, 0.0), [INFO] [stderr] 319 | | pen: Point::new(0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 315 | impl Default for path::PathCollector { [INFO] [stderr] 316 | fn default() -> Self { [INFO] [stderr] 317 | Self::new() [INFO] [stderr] 318 | } [INFO] [stderr] 319 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/path.rs:393:12 [INFO] [stderr] | [INFO] [stderr] 393 | if self.elements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/path.rs:406:12 [INFO] [stderr] | [INFO] [stderr] 406 | if elements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/utils.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | pub(crate) fn to_pseudodistance(&mut self, p: Vector) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self.edge { [INFO] [stderr] 26 | | Some(edge) => self.dist = edge.to_psuedodistance(self.dist, p, self.nearest_approach), [INFO] [stderr] 27 | | None => {} [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(edge) = self.edge { self.dist = edge.to_psuedodistance(self.dist, p, self.nearest_approach) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | if contours.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contours.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | if median(sr.dist.distance, sg.dist.distance, sb.dist.distance) == mmsd.med { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(median(sr.dist.distance, sg.dist.distance, sb.dist.distance) - mmsd.med).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | if median(sr.dist.distance, sg.dist.distance, sb.dist.distance) == mmsd.med { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:198:24 [INFO] [stderr] | [INFO] [stderr] 198 | if contours.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contours.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:378:29 [INFO] [stderr] | [INFO] [stderr] 378 | spline = spline + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `spline += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `msdfgen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `path::PathCollector` [INFO] [stderr] --> src/path.rs:316:5 [INFO] [stderr] | [INFO] [stderr] 316 | / pub fn new() -> Self { [INFO] [stderr] 317 | | Self { [INFO] [stderr] 318 | | contour_start: Point::new(0.0, 0.0), [INFO] [stderr] 319 | | pen: Point::new(0.0, 0.0), [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 315 | impl Default for path::PathCollector { [INFO] [stderr] 316 | fn default() -> Self { [INFO] [stderr] 317 | Self::new() [INFO] [stderr] 318 | } [INFO] [stderr] 319 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/path.rs:393:12 [INFO] [stderr] | [INFO] [stderr] 393 | if self.elements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/path.rs:406:12 [INFO] [stderr] | [INFO] [stderr] 406 | if elements.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/utils.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | pub(crate) fn to_pseudodistance(&mut self, p: Vector) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self.edge { [INFO] [stderr] 26 | | Some(edge) => self.dist = edge.to_psuedodistance(self.dist, p, self.nearest_approach), [INFO] [stderr] 27 | | None => {} [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(edge) = self.edge { self.dist = edge.to_psuedodistance(self.dist, p, self.nearest_approach) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | if contours.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contours.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | if median(sr.dist.distance, sg.dist.distance, sb.dist.distance) == mmsd.med { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(median(sr.dist.distance, sg.dist.distance, sb.dist.distance) - mmsd.med).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | if median(sr.dist.distance, sg.dist.distance, sb.dist.distance) == mmsd.med { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:198:24 [INFO] [stderr] | [INFO] [stderr] 198 | if contours.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contours.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:378:29 [INFO] [stderr] | [INFO] [stderr] 378 | spline = spline + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `spline += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `msdfgen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "276bddda57731f7ce4f561f8c8d4aeac35a41c6f59c001752208f991121bd547"` [INFO] running `"docker" "rm" "-f" "276bddda57731f7ce4f561f8c8d4aeac35a41c6f59c001752208f991121bd547"` [INFO] [stdout] 276bddda57731f7ce4f561f8c8d4aeac35a41c6f59c001752208f991121bd547