[INFO] updating cached repository bobbo/scrobble-tool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bobbo/scrobble-tool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bobbo/scrobble-tool" "work/ex/clippy-test-run/sources/stable/gh/bobbo/scrobble-tool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bobbo/scrobble-tool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bobbo/scrobble-tool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bobbo/scrobble-tool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bobbo/scrobble-tool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1e84c9d7279ec8106b69c1607dd4b7b5ff71cda6 [INFO] sha for GitHub repo bobbo/scrobble-tool: 1e84c9d7279ec8106b69c1607dd4b7b5ff71cda6 [INFO] validating manifest of bobbo/scrobble-tool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bobbo/scrobble-tool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bobbo/scrobble-tool [INFO] finished frobbing bobbo/scrobble-tool [INFO] frobbed toml for bobbo/scrobble-tool written to work/ex/clippy-test-run/sources/stable/gh/bobbo/scrobble-tool/Cargo.toml [INFO] started frobbing bobbo/scrobble-tool [INFO] finished frobbing bobbo/scrobble-tool [INFO] frobbed toml for bobbo/scrobble-tool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bobbo/scrobble-tool/Cargo.toml [INFO] crate bobbo/scrobble-tool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bobbo/scrobble-tool against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bobbo/scrobble-tool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e875589d18643d36b5ec061039618619c3400dd35ca00692814dffb4b7f388d [INFO] running `"docker" "start" "-a" "2e875589d18643d36b5ec061039618619c3400dd35ca00692814dffb4b7f388d"` [INFO] [stderr] Compiling crc-core v0.1.0 [INFO] [stderr] Checking build_const v0.2.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking itertools v0.5.10 [INFO] [stderr] Compiling wrapped-vec v0.2.1 [INFO] [stderr] Checking openssl v0.9.20 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Compiling crc v1.5.0 [INFO] [stderr] Checking hyper v0.11.7 [INFO] [stderr] Checking libflate v0.1.12 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking discogs v0.2.1 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking reqwest v0.7.3 [INFO] [stderr] Checking rustfm-scrobble v0.9.1 [INFO] [stderr] Checking scrobble-tool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | scrobble_type: scrobble_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scrobble_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | scrobble_type: scrobble_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scrobble_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | const API_KEY:&'static str = "65eeafc3adfdb1c1dbad47332014ccbc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | const API_SECRET:&'static str = "799127ee2d8a5a7099bff73bbc7b9a8e"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let source = DiscogsInfoSource { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `discogs` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | discogs: Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:160:43 [INFO] [stderr] | [INFO] [stderr] 160 | let info_source: &InfoSource = if let Some(_) = opts.discogs_id { [INFO] [stderr] | ____________________________________- ^^^^^^^ [INFO] [stderr] 161 | | &DiscogsInfoSource{discogs: None} [INFO] [stderr] 162 | | } else { [INFO] [stderr] 163 | | &OptsInfoSource{} [INFO] [stderr] 164 | | }; [INFO] [stderr] | |_____- help: try this: `if opts.discogs_id.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | const API_KEY:&'static str = "65eeafc3adfdb1c1dbad47332014ccbc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | const API_SECRET:&'static str = "799127ee2d8a5a7099bff73bbc7b9a8e"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source` [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | let source = DiscogsInfoSource { [INFO] [stderr] | ^^^^^^ help: consider using `_source` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `discogs` [INFO] [stderr] --> src/main.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | discogs: Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | env_logger::init(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/main.rs:160:43 [INFO] [stderr] | [INFO] [stderr] 160 | let info_source: &InfoSource = if let Some(_) = opts.discogs_id { [INFO] [stderr] | ____________________________________- ^^^^^^^ [INFO] [stderr] 161 | | &DiscogsInfoSource{discogs: None} [INFO] [stderr] 162 | | } else { [INFO] [stderr] 163 | | &OptsInfoSource{} [INFO] [stderr] 164 | | }; [INFO] [stderr] | |_____- help: try this: `if opts.discogs_id.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.78s [INFO] running `"docker" "inspect" "2e875589d18643d36b5ec061039618619c3400dd35ca00692814dffb4b7f388d"` [INFO] running `"docker" "rm" "-f" "2e875589d18643d36b5ec061039618619c3400dd35ca00692814dffb4b7f388d"` [INFO] [stdout] 2e875589d18643d36b5ec061039618619c3400dd35ca00692814dffb4b7f388d