[INFO] updating cached repository bn3t/coda-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bn3t/coda-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bn3t/coda-rs" "work/ex/clippy-test-run/sources/stable/gh/bn3t/coda-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bn3t/coda-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bn3t/coda-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bn3t/coda-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bn3t/coda-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 61ece689081f93e95eca354e476acca73cc4397b [INFO] sha for GitHub repo bn3t/coda-rs: 61ece689081f93e95eca354e476acca73cc4397b [INFO] validating manifest of bn3t/coda-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bn3t/coda-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bn3t/coda-rs [INFO] finished frobbing bn3t/coda-rs [INFO] frobbed toml for bn3t/coda-rs written to work/ex/clippy-test-run/sources/stable/gh/bn3t/coda-rs/Cargo.toml [INFO] started frobbing bn3t/coda-rs [INFO] finished frobbing bn3t/coda-rs [INFO] frobbed toml for bn3t/coda-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bn3t/coda-rs/Cargo.toml [INFO] crate bn3t/coda-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bn3t/coda-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bn3t/coda-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 012b3217bea64d98aa83c504061a3d26cb7436b3d6e7f71b5abb3cfcd3436af8 [INFO] running `"docker" "start" "-a" "012b3217bea64d98aa83c504061a3d26cb7436b3d6e7f71b5abb3cfcd3436af8"` [INFO] [stderr] Compiling time v0.1.39 [INFO] [stderr] Compiling num-integer v0.1.36 [INFO] [stderr] Compiling chrono v0.4.1 [INFO] [stderr] Compiling coda-rs v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coda.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | movements: movements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `movements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coda.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | free_communications: free_communications, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `free_communications` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coda.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | movements: movements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `movements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/coda.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | free_communications: free_communications, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `free_communications` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return s.serialize_str(&format!("{}", date.format("%Y-%m-%d"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.serialize_str(&format!("{}", date.format("%Y-%m-%d")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/coda.rs:549:43 [INFO] [stderr] | [INFO] [stderr] 549 | NaiveDate::from_ymd(2006, 12, 06), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 549 | NaiveDate::from_ymd(2006, 12, 6), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 549 | NaiveDate::from_ymd(2006, 12, 0o6), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coda.rs:664:13 [INFO] [stderr] | [INFO] [stderr] 664 | 9405296990, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `9_405_296_990` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/coda.rs:669:43 [INFO] [stderr] | [INFO] [stderr] 669 | NaiveDate::from_ymd(2006, 12, 07), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 669 | NaiveDate::from_ymd(2006, 12, 7), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 669 | NaiveDate::from_ymd(2006, 12, 0o7), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coda.rs:690:13 [INFO] [stderr] | [INFO] [stderr] 690 | 3085871600, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_085_871_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coda.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | 12491168590, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `12_491_168_590` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/coda.rs:729:13 [INFO] [stderr] | [INFO] [stderr] 729 | 1000000002578250, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_000_000_002_578_250` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:189:37 [INFO] [stderr] | [INFO] [stderr] 189 | assert_eq!(actual.unwrap(), 200000, "u32 '200000' should be 200000"); [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/json.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return s.serialize_str(&format!("{}", date.format("%Y-%m-%d"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `s.serialize_str(&format!("{}", date.format("%Y-%m-%d")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/json.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | old_balance: 100000, [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/json.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | new_balance: 200000, [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/json.rs:85:30 [INFO] [stderr] | [INFO] [stderr] 85 | total_debit: 4321000, [INFO] [stderr] | ^^^^^^^ help: consider: `4_321_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/json.rs:86:31 [INFO] [stderr] | [INFO] [stderr] 86 | total_credit: 123400, [INFO] [stderr] | ^^^^^^ help: consider: `123_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/json.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn serialize(date: &NaiveDate, s: S) -> Result [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/json.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn serialize(date: &NaiveDate, s: S) -> Result [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.44s [INFO] running `"docker" "inspect" "012b3217bea64d98aa83c504061a3d26cb7436b3d6e7f71b5abb3cfcd3436af8"` [INFO] running `"docker" "rm" "-f" "012b3217bea64d98aa83c504061a3d26cb7436b3d6e7f71b5abb3cfcd3436af8"` [INFO] [stdout] 012b3217bea64d98aa83c504061a3d26cb7436b3d6e7f71b5abb3cfcd3436af8