[INFO] updating cached repository bmac/text_editor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bmac/text_editor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bmac/text_editor" "work/ex/clippy-test-run/sources/stable/gh/bmac/text_editor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bmac/text_editor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bmac/text_editor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmac/text_editor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmac/text_editor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1c27cd73646c22aa20c0bbc61c202f122892b2e4 [INFO] sha for GitHub repo bmac/text_editor: 1c27cd73646c22aa20c0bbc61c202f122892b2e4 [INFO] validating manifest of bmac/text_editor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bmac/text_editor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bmac/text_editor [INFO] finished frobbing bmac/text_editor [INFO] frobbed toml for bmac/text_editor written to work/ex/clippy-test-run/sources/stable/gh/bmac/text_editor/Cargo.toml [INFO] started frobbing bmac/text_editor [INFO] finished frobbing bmac/text_editor [INFO] frobbed toml for bmac/text_editor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bmac/text_editor/Cargo.toml [INFO] crate bmac/text_editor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bmac/text_editor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bmac/text_editor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4da5bb7b88b72093a21389cc8ee2dbe31f44092d7b8fbd20ece97b27daaa2ac4 [INFO] running `"docker" "start" "-a" "4da5bb7b88b72093a21389cc8ee2dbe31f44092d7b8fbd20ece97b27daaa2ac4"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking text_editor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | print!("{}\r\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | print!("{}\r\n", line); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return match key { [INFO] [stderr] 77 | | Ok(Key::Ctrl('c')) => true, [INFO] [stderr] 78 | | Ok(Key::Ctrl('q')) => true, [INFO] [stderr] 79 | | _ => false, [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | match key { [INFO] [stderr] 77 | Ok(Key::Ctrl('c')) => true, [INFO] [stderr] 78 | Ok(Key::Ctrl('q')) => true, [INFO] [stderr] 79 | _ => false, [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return self.lines.len() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.lines.len() as i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return self.lines[row as usize].len() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.lines[row as usize].len() as i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return Buffer { lines }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Buffer { lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Buffer { lines }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Buffer { lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return Buffer { lines }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Buffer { lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / return Cursor { [INFO] [stderr] 147 | | row: self.row + 1, [INFO] [stderr] 148 | | col: self.col, [INFO] [stderr] 149 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | Cursor { [INFO] [stderr] 147 | row: self.row + 1, [INFO] [stderr] 148 | col: self.col, [INFO] [stderr] 149 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / return Cursor { [INFO] [stderr] 154 | | row: self.row - 1, [INFO] [stderr] 155 | | col: self.col, [INFO] [stderr] 156 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 153 | Cursor { [INFO] [stderr] 154 | row: self.row - 1, [INFO] [stderr] 155 | col: self.col, [INFO] [stderr] 156 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / return Cursor { [INFO] [stderr] 161 | | row: self.row, [INFO] [stderr] 162 | | col: self.col - 1, [INFO] [stderr] 163 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 160 | Cursor { [INFO] [stderr] 161 | row: self.row, [INFO] [stderr] 162 | col: self.col - 1, [INFO] [stderr] 163 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / return Cursor { [INFO] [stderr] 168 | | row: self.row, [INFO] [stderr] 169 | | col: self.col + 1, [INFO] [stderr] 170 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 167 | Cursor { [INFO] [stderr] 168 | row: self.row, [INFO] [stderr] 169 | col: self.col + 1, [INFO] [stderr] 170 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / return Cursor { [INFO] [stderr] 181 | | row, [INFO] [stderr] 182 | | col, [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | Cursor { [INFO] [stderr] 181 | row, [INFO] [stderr] 182 | col, [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | / return Cursor { [INFO] [stderr] 188 | | row: self.row, [INFO] [stderr] 189 | | col, [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 187 | Cursor { [INFO] [stderr] 188 | row: self.row, [INFO] [stderr] 189 | col, [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / return match key { [INFO] [stderr] 77 | | Ok(Key::Ctrl('c')) => true, [INFO] [stderr] 78 | | Ok(Key::Ctrl('q')) => true, [INFO] [stderr] 79 | | _ => false, [INFO] [stderr] 80 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 76 | match key { [INFO] [stderr] 77 | Ok(Key::Ctrl('c')) => true, [INFO] [stderr] 78 | Ok(Key::Ctrl('q')) => true, [INFO] [stderr] 79 | _ => false, [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return self.lines.len() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.lines.len() as i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return self.lines[row as usize].len() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.lines[row as usize].len() as i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | return Buffer { lines }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Buffer { lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Buffer { lines }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Buffer { lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | return Buffer { lines }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Buffer { lines }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | / return Cursor { [INFO] [stderr] 147 | | row: self.row + 1, [INFO] [stderr] 148 | | col: self.col, [INFO] [stderr] 149 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | Cursor { [INFO] [stderr] 147 | row: self.row + 1, [INFO] [stderr] 148 | col: self.col, [INFO] [stderr] 149 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / return Cursor { [INFO] [stderr] 154 | | row: self.row - 1, [INFO] [stderr] 155 | | col: self.col, [INFO] [stderr] 156 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 153 | Cursor { [INFO] [stderr] 154 | row: self.row - 1, [INFO] [stderr] 155 | col: self.col, [INFO] [stderr] 156 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / return Cursor { [INFO] [stderr] 161 | | row: self.row, [INFO] [stderr] 162 | | col: self.col - 1, [INFO] [stderr] 163 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 160 | Cursor { [INFO] [stderr] 161 | row: self.row, [INFO] [stderr] 162 | col: self.col - 1, [INFO] [stderr] 163 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / return Cursor { [INFO] [stderr] 168 | | row: self.row, [INFO] [stderr] 169 | | col: self.col + 1, [INFO] [stderr] 170 | | }.clamp(buffer) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 167 | Cursor { [INFO] [stderr] 168 | row: self.row, [INFO] [stderr] 169 | col: self.col + 1, [INFO] [stderr] 170 | }.clamp(buffer) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / return Cursor { [INFO] [stderr] 181 | | row, [INFO] [stderr] 182 | | col, [INFO] [stderr] 183 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 180 | Cursor { [INFO] [stderr] 181 | row, [INFO] [stderr] 182 | col, [INFO] [stderr] 183 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | / return Cursor { [INFO] [stderr] 188 | | row: self.row, [INFO] [stderr] 189 | | col, [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 187 | Cursor { [INFO] [stderr] 188 | row: self.row, [INFO] [stderr] 189 | col, [INFO] [stderr] 190 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:123:35 [INFO] [stderr] | [INFO] [stderr] 123 | lines[row as usize].drain(start..start+1); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:123:35 [INFO] [stderr] | [INFO] [stderr] 123 | lines[row as usize].drain(start..start+1); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `start..=start` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "4da5bb7b88b72093a21389cc8ee2dbe31f44092d7b8fbd20ece97b27daaa2ac4"` [INFO] running `"docker" "rm" "-f" "4da5bb7b88b72093a21389cc8ee2dbe31f44092d7b8fbd20ece97b27daaa2ac4"` [INFO] [stdout] 4da5bb7b88b72093a21389cc8ee2dbe31f44092d7b8fbd20ece97b27daaa2ac4