[INFO] updating cached repository bluecereal/t-render [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bluecereal/t-render [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bluecereal/t-render" "work/ex/clippy-test-run/sources/stable/gh/bluecereal/t-render"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bluecereal/t-render'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bluecereal/t-render" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bluecereal/t-render"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bluecereal/t-render'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ceb96730fd1c05bd8c9dc386c328f22dfe67fc62 [INFO] sha for GitHub repo bluecereal/t-render: ceb96730fd1c05bd8c9dc386c328f22dfe67fc62 [INFO] validating manifest of bluecereal/t-render on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bluecereal/t-render on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bluecereal/t-render [INFO] finished frobbing bluecereal/t-render [INFO] frobbed toml for bluecereal/t-render written to work/ex/clippy-test-run/sources/stable/gh/bluecereal/t-render/Cargo.toml [INFO] started frobbing bluecereal/t-render [INFO] finished frobbing bluecereal/t-render [INFO] frobbed toml for bluecereal/t-render written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bluecereal/t-render/Cargo.toml [INFO] crate bluecereal/t-render has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bluecereal/t-render against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bluecereal/t-render:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70c27ba56b7c53606dd8232d241f32dd52937e9d40d57642f5663f019c9d7217 [INFO] running `"docker" "start" "-a" "70c27ba56b7c53606dd8232d241f32dd52937e9d40d57642f5663f019c9d7217"` [INFO] [stderr] Checking t-render v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::fmt::Display` [INFO] [stderr] --> src/execution.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::fmt::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/vertex.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let mut x_distance = this.get_x() - other.get_x(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/vertex.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let mut y_distance = this.get_y() - other.get_y(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `distance_between` [INFO] [stderr] --> src/vertex.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn distance_between(this: &Vertex, other: &Vertex) -> (u32, u32) where C: Copy + Clone + Color { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Comparer` [INFO] [stderr] --> src/compare.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub struct Comparer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/compare.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(things: Vec) -> Comparer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/compare.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn update(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Display` [INFO] [stderr] --> src/execution.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::fmt::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/execution.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | write!(self.out, "{clear}", clear = termion::clear::All); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/execution.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / write!(self.out, "{}{color}!!{color_reset}", termion::cursor::Goto(vertex.get_x() as u16, vertex.get_y() as u16), [INFO] [stderr] 29 | | color = color::Fg(vertex.get_color()), [INFO] [stderr] 30 | | color_reset = color::Fg(color::Reset) [INFO] [stderr] 31 | | ); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/execution.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | write!(self.out, "{}", termion::cursor::Goto(1, 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compare.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | while self.untouched.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.untouched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/vertex.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | let mut x_distance = this.get_x() - other.get_x(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/vertex.rs:5:9 [INFO] [stderr] | [INFO] [stderr] 5 | let mut y_distance = this.get_y() - other.get_y(); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `distance_between` [INFO] [stderr] --> src/vertex.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn distance_between(this: &Vertex, other: &Vertex) -> (u32, u32) where C: Copy + Clone + Color { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Comparer` [INFO] [stderr] --> src/compare.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub struct Comparer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/compare.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(things: Vec) -> Comparer { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update` [INFO] [stderr] --> src/compare.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn update(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/execution.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | write!(self.out, "{clear}", clear = termion::clear::All); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/execution.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / write!(self.out, "{}{color}!!{color_reset}", termion::cursor::Goto(vertex.get_x() as u16, vertex.get_y() as u16), [INFO] [stderr] 29 | | color = color::Fg(vertex.get_color()), [INFO] [stderr] 30 | | color_reset = color::Fg(color::Reset) [INFO] [stderr] 31 | | ); [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/execution.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | write!(self.out, "{}", termion::cursor::Goto(1, 1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compare.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | while self.untouched.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.untouched.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "70c27ba56b7c53606dd8232d241f32dd52937e9d40d57642f5663f019c9d7217"` [INFO] running `"docker" "rm" "-f" "70c27ba56b7c53606dd8232d241f32dd52937e9d40d57642f5663f019c9d7217"` [INFO] [stdout] 70c27ba56b7c53606dd8232d241f32dd52937e9d40d57642f5663f019c9d7217