[INFO] updating cached repository blorente/RustikGB [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blorente/RustikGB [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blorente/RustikGB" "work/ex/clippy-test-run/sources/stable/gh/blorente/RustikGB"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blorente/RustikGB'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blorente/RustikGB" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blorente/RustikGB"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blorente/RustikGB'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 396425da4971100839f4118bc79f6ca6085af797 [INFO] sha for GitHub repo blorente/RustikGB: 396425da4971100839f4118bc79f6ca6085af797 [INFO] validating manifest of blorente/RustikGB on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blorente/RustikGB on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blorente/RustikGB [INFO] finished frobbing blorente/RustikGB [INFO] frobbed toml for blorente/RustikGB written to work/ex/clippy-test-run/sources/stable/gh/blorente/RustikGB/Cargo.toml [INFO] started frobbing blorente/RustikGB [INFO] finished frobbing blorente/RustikGB [INFO] frobbed toml for blorente/RustikGB written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blorente/RustikGB/Cargo.toml [INFO] crate blorente/RustikGB has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blorente/RustikGB against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/blorente/RustikGB:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47e5a0c6630cddb944331d527e208534954c5323c5a5f10afafa65c52bcc2e95 [INFO] running `"docker" "start" "-a" "47e5a0c6630cddb944331d527e208534954c5323c5a5f10afafa65c52bcc2e95"` [INFO] [stderr] Compiling itoa v0.3.2 [INFO] [stderr] Checking text_io v0.1.6 [INFO] [stderr] Checking gfx_core v0.5.1 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking gfx v0.13.0 [INFO] [stderr] Checking gfx_device_gl v0.12.0 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking RustikGB v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/cpu.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | bus: bus, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/instructions.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | dissassembly: dissassembly, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dissassembly` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/bus.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/video/screen.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/cpu.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | bus: bus, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/instructions.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | dissassembly: dissassembly, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dissassembly` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/bus.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/memory/plain_ram.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hardware/video/screen.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | texture: texture, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `texture` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::debugger` [INFO] [stderr] --> src/hardware/cpu.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use hardware::debugger; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::video::screen::Screen` [INFO] [stderr] --> src/hardware/cpu.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use hardware::video::screen::Screen; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::interrupts::Interrupts` [INFO] [stderr] --> src/hardware/cpu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use hardware::interrupts::Interrupts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | Z = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | N = 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | H = 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | C = 0b00010000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/hardware/mod.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | if (QUICK_FIXES_ACTIVE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/cartridge.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / quick_fix!({ [INFO] [stderr] 127 | | println!("Writing byte {:2X} to cartridge addres {:4X}", val, addr); [INFO] [stderr] 128 | | }, [INFO] [stderr] 129 | | "Probably shouldn't be writing to the cartridge ROM"); [INFO] [stderr] | |______________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:311:43 [INFO] [stderr] | [INFO] [stderr] 311 | cpu.set_flag(CPUFlags::C, (original & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:336:43 [INFO] [stderr] | [INFO] [stderr] 336 | cpu.set_flag(CPUFlags::C, (original & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:345:43 [INFO] [stderr] | [INFO] [stderr] 345 | cpu.set_flag(CPUFlags::C, (original & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:369:43 [INFO] [stderr] | [INFO] [stderr] 369 | cpu.set_flag(CPUFlags::C, (original & 0b00000001) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 499 | / pushall!( [INFO] [stderr] 500 | | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] 501 | | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] 502 | | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] ... | [INFO] [stderr] 752 | | [0xFF, inst!("RST 0x38", |cpu, op|{reset(op, cpu); 8})] [INFO] [stderr] 753 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 499 | / pushall!( [INFO] [stderr] 500 | | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] 501 | | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] 502 | | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] ... | [INFO] [stderr] 752 | | [0xFF, inst!("RST 0x38", |cpu, op|{reset(op, cpu); 8})] [INFO] [stderr] 753 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 500 | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 500 | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 501 | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 501 | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 502 | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 502 | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 503 | [0x03, inst!("INC BC", |cpu, op|{inc_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 503 | [0x03, inst!("INC BC", |cpu, op|{inc_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 504 | [0x04, inst!("INC B", |cpu, op| {inc!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 504 | [0x04, inst!("INC B", |cpu, op| {inc!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 505 | [0x05, inst!("DEC B", |cpu, op|{dec!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 505 | [0x05, inst!("DEC B", |cpu, op|{dec!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 506 | [0x06, inst!("LD B,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 506 | [0x06, inst!("LD B,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 507 | [0x07, inst!("RLCA", |cpu, op|{rl_no_carry_reg!(cpu.regs.a, cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 507 | [0x07, inst!("RLCA", |cpu, op|{rl_no_carry_reg!(cpu.regs.a, cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 509 | [0x09, inst!("ADD HL,BC", |cpu, op|{add_16("HL", cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 509 | [0x09, inst!("ADD HL,BC", |cpu, op|{add_16("HL", cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | [0x19, inst!("ADD HL,DE", |cpu, op|{add_16("HL", cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | [0x19, inst!("ADD HL,DE", |cpu, op|{add_16("HL", cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 511 | [0x29, inst!("ADD HL,HL", |cpu, op|{add_16("HL", cpu.regs.hl(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 511 | [0x29, inst!("ADD HL,HL", |cpu, op|{add_16("HL", cpu.regs.hl(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 512 | [0x39, inst!("ADD HL,SP", |cpu, op|{add_16("HL", cpu.sp.r(), cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 512 | [0x39, inst!("ADD HL,SP", |cpu, op|{add_16("HL", cpu.sp.r(), cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 514 | [0x0A, inst!("LD A,(BC)", |cpu, op|{let addr = cpu.regs.bc(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 514 | [0x0A, inst!("LD A,(BC)", |cpu, op|{let addr = cpu.regs.bc(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 515 | [0x0B, inst!("DEC BC", |cpu, op|{dec_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 515 | [0x0B, inst!("DEC BC", |cpu, op|{dec_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 516 | [0x0C, inst!("INC C", |cpu, op| {inc!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 516 | [0x0C, inst!("INC C", |cpu, op| {inc!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 517 | [0x0D, inst!("DEC C", |cpu, op|{dec!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 517 | [0x0D, inst!("DEC C", |cpu, op|{dec!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 518 | [0x0E, inst!("LD C,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 518 | [0x0E, inst!("LD C,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 520 | [0x11, inst!("LD DE,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.d, cpu.regs.e, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 520 | [0x11, inst!("LD DE,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.d, cpu.regs.e, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 521 | [0x12, inst!("LD (DE),A", |cpu, op|{ld_from_a_ind(cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 521 | [0x12, inst!("LD (DE),A", |cpu, op|{ld_from_a_ind(cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 522 | [0x13, inst!("INC DE", |cpu, op|{inc_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 522 | [0x13, inst!("INC DE", |cpu, op|{inc_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 523 | [0x14, inst!("INC D", |cpu, op| {inc!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 523 | [0x14, inst!("INC D", |cpu, op| {inc!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 524 | [0x15, inst!("DEC D", |cpu, op|{dec!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 524 | [0x15, inst!("DEC D", |cpu, op|{dec!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 525 | [0x16, inst!("LD D,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 525 | [0x16, inst!("LD D,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 526 | [0x17, inst!("RLA", |cpu, op|{rla(cpu); 1})], [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 526 | [0x17, inst!("RLA", |cpu, op|{rla(cpu); 1})], [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 528 | [0x18, inst!("JR n", |cpu, op|{jump_cond_imm(cpu, JumpImmCond::None, JumpImmMode::IntOffset); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 528 | [0x18, inst!("JR n", |cpu, op|{jump_cond_imm(cpu, JumpImmCond::None, JumpImmMode::IntOffset); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 529 | [0x1A, inst!("LD A,(DE)", |cpu, op|{let addr = cpu.regs.de(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 529 | [0x1A, inst!("LD A,(DE)", |cpu, op|{let addr = cpu.regs.de(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 530 | [0x1B, inst!("DEC DE", |cpu, op|{dec_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 530 | [0x1B, inst!("DEC DE", |cpu, op|{dec_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 531 | [0x1C, inst!("INC E", |cpu, op| {inc!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 531 | [0x1C, inst!("INC E", |cpu, op| {inc!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 532 | [0x1D, inst!("DEC E", |cpu, op|{dec!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 532 | [0x1D, inst!("DEC E", |cpu, op|{dec!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 533 | [0x1E, inst!("LD E,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 533 | [0x1E, inst!("LD E,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 535 | [0x20, inst!("JR NZ,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::NZ, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 535 | [0x20, inst!("JR NZ,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::NZ, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 536 | [0x21, inst!("LD HL,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.h, cpu.regs.l, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 536 | [0x21, inst!("LD HL,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.h, cpu.regs.l, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 537 | [0x22, inst!("LDI (HL+), A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 537 | [0x22, inst!("LDI (HL+), A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 538 | [0x23, inst!("INC HL", |cpu, op|{inc_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 538 | [0x23, inst!("INC HL", |cpu, op|{inc_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 539 | [0x24, inst!("INC H", |cpu, op| {inc!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 539 | [0x24, inst!("INC H", |cpu, op| {inc!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 540 | [0x25, inst!("DEC H", |cpu, op|{dec!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 540 | [0x25, inst!("DEC H", |cpu, op|{dec!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 541 | [0x26, inst!("LD H,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 541 | [0x26, inst!("LD H,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 542 | [0x27, inst!("DAA", |cpu, op| {daa(cpu); 1})], [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 542 | [0x27, inst!("DAA", |cpu, op| {daa(cpu); 1})], [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 544 | [0x28, inst!("JR Z,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::Z, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 544 | [0x28, inst!("JR Z,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::Z, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 545 | [0x2A, inst!("LDI A,(HL+)", |cpu, op|{store_hl_into_a(cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 545 | [0x2A, inst!("LDI A,(HL+)", |cpu, op|{store_hl_into_a(cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 546 | [0x2B, inst!("DEC HL", |cpu, op|{dec_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 546 | [0x2B, inst!("DEC HL", |cpu, op|{dec_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 547 | [0x2C, inst!("INC L", |cpu, op| {inc!(cpu.regs.l, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 547 | [0x2C, inst!("INC L", |cpu, op| {inc!(cpu.regs.l, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 548 | [0x2D, inst!("DEC L", |cpu, op|{dec!(cpu.regs.l, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 548 | [0x2D, inst!("DEC L", |cpu, op|{dec!(cpu.regs.l, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 549 | [0x2E, inst!("LD L,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 549 | [0x2E, inst!("LD L,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 550 | [0x2F, inst!("CPL A", |cpu, op|{complement!(cpu.regs.a, cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 550 | [0x2F, inst!("CPL A", |cpu, op|{complement!(cpu.regs.a, cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 552 | [0x30, inst!("JR NC,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::NC, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 552 | [0x30, inst!("JR NC,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::NC, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 553 | [0x31, inst!("LD SP,nn", |cpu, op|{load_word_imm_u16!(cpu.sp, cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 553 | [0x31, inst!("LD SP,nn", |cpu, op|{load_word_imm_u16!(cpu.sp, cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 554 | [0x32, inst!("LDD (HL-),A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); dec_16!("HL", cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 554 | [0x32, inst!("LDD (HL-),A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); dec_16!("HL", cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 555 | [0x33, inst!("INC SP", |cpu, op|{inc_16!("SP", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 555 | [0x33, inst!("INC SP", |cpu, op|{inc_16!("SP", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 556 | [0x34, inst!("INC (HL)", |cpu, op| {inc!(cpu.regs.l, cpu, true); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 556 | [0x34, inst!("INC (HL)", |cpu, op| {inc!(cpu.regs.l, cpu, true); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 557 | [0x35, inst!("DEC (HL)", |cpu, op|{dec!(cpu.regs.l, cpu, true); 3})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 557 | [0x35, inst!("DEC (HL)", |cpu, op|{dec!(cpu.regs.l, cpu, true); 3})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 559 | [0x36, inst!("LD (HL),#", |cpu, op|{store_into_hl(cpu.fetch_byte_immediate(), cpu); 3})], [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 559 | [0x36, inst!("LD (HL),#", |cpu, op|{store_into_hl(cpu.fetch_byte_immediate(), cpu); 3})], [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 560 | [0x38, inst!("JR C,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::C, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 560 | [0x38, inst!("JR C,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::C, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 561 | [0x3A, inst!("LDD A,(HL-)", |cpu, op|{store_hl_into_a(cpu); dec_16!("HL", cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 561 | [0x3A, inst!("LDD A,(HL-)", |cpu, op|{store_hl_into_a(cpu); dec_16!("HL", cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 562 | [0x3B, inst!("DEC SP", |cpu, op|{dec_16!("SP", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 562 | [0x3B, inst!("DEC SP", |cpu, op|{dec_16!("SP", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 563 | [0x3C, inst!("INC A", |cpu, op| {inc!(cpu.regs.a, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 563 | [0x3C, inst!("INC A", |cpu, op| {inc!(cpu.regs.a, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 564 | [0x3D, inst!("DEC L", |cpu, op|{dec!(cpu.regs.a, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 564 | [0x3D, inst!("DEC L", |cpu, op|{dec!(cpu.regs.a, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 565 | [0x3E, inst!("LD A,n", |cpu, op|{let val = cpu.fetch_byte_immediate(); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 565 | [0x3E, inst!("LD A,n", |cpu, op|{let val = cpu.fetch_byte_immediate(); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 567 | [0x40, inst!("LD B,B", |cpu, op|{let val = cpu.regs.b.r(); ld_into_reg!(val, cpu.regs.b); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 567 | [0x40, inst!("LD B,B", |cpu, op|{let val = cpu.regs.b.r(); ld_into_reg!(val, cpu.regs.b); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 568 | [0x41, inst!("LD B,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 568 | [0x41, inst!("LD B,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 569 | [0x42, inst!("LD B,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 569 | [0x42, inst!("LD B,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 570 | [0x43, inst!("LD B,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 570 | [0x43, inst!("LD B,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | [0x44, inst!("LD B,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | [0x44, inst!("LD B,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 572 | [0x45, inst!("LD B,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 572 | [0x45, inst!("LD B,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 573 | [0x46, inst!("LD B,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.b); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 573 | [0x46, inst!("LD B,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.b); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 574 | [0x47, inst!("LD B,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 574 | [0x47, inst!("LD B,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.b); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 576 | [0x48, inst!("LD C,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 576 | [0x48, inst!("LD C,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 577 | [0x49, inst!("LD C,C", |cpu, op|{let val = cpu.regs.c.r(); ld_into_reg!(val, cpu.regs.c); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 577 | [0x49, inst!("LD C,C", |cpu, op|{let val = cpu.regs.c.r(); ld_into_reg!(val, cpu.regs.c); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 578 | [0x4A, inst!("LD C,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 578 | [0x4A, inst!("LD C,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 579 | [0x4B, inst!("LD C,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 579 | [0x4B, inst!("LD C,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 580 | [0x4C, inst!("LD C,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 580 | [0x4C, inst!("LD C,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 581 | [0x4D, inst!("LD C,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 581 | [0x4D, inst!("LD C,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 582 | [0x4E, inst!("LD C,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.c); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 582 | [0x4E, inst!("LD C,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.c); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 583 | [0x4F, inst!("LD C,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 583 | [0x4F, inst!("LD C,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.c); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 585 | [0x50, inst!("LD D,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 585 | [0x50, inst!("LD D,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 586 | [0x51, inst!("LD D,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 586 | [0x51, inst!("LD D,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 587 | [0x52, inst!("LD D,D", |cpu, op|{let val = cpu.regs.d.r(); ld_into_reg!(val, cpu.regs.d); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 587 | [0x52, inst!("LD D,D", |cpu, op|{let val = cpu.regs.d.r(); ld_into_reg!(val, cpu.regs.d); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 588 | [0x53, inst!("LD D,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 588 | [0x53, inst!("LD D,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 589 | [0x54, inst!("LD D,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 589 | [0x54, inst!("LD D,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 590 | [0x55, inst!("LD D,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 590 | [0x55, inst!("LD D,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 591 | [0x56, inst!("LD D,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.d); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 591 | [0x56, inst!("LD D,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.d); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 592 | [0x57, inst!("LD D,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 592 | [0x57, inst!("LD D,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.d); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 594 | [0x58, inst!("LD E,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 594 | [0x58, inst!("LD E,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 595 | [0x59, inst!("LD E,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 595 | [0x59, inst!("LD E,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 596 | [0x5A, inst!("LD E,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 596 | [0x5A, inst!("LD E,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 597 | [0x5B, inst!("LD E,E", |cpu, op|{let val = cpu.regs.e.r(); ld_into_reg!(val, cpu.regs.e); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 597 | [0x5B, inst!("LD E,E", |cpu, op|{let val = cpu.regs.e.r(); ld_into_reg!(val, cpu.regs.e); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 598 | [0x5C, inst!("LD E,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 598 | [0x5C, inst!("LD E,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 599 | [0x5D, inst!("LD E,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 599 | [0x5D, inst!("LD E,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 600 | [0x5E, inst!("LD E,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.e); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 600 | [0x5E, inst!("LD E,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.e); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 601 | [0x5F, inst!("LD E,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 601 | [0x5F, inst!("LD E,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.e); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 603 | [0x60, inst!("LD H,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 603 | [0x60, inst!("LD H,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 604 | [0x61, inst!("LD H,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 604 | [0x61, inst!("LD H,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 605 | [0x62, inst!("LD H,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 605 | [0x62, inst!("LD H,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 606 | [0x63, inst!("LD H,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 606 | [0x63, inst!("LD H,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 607 | [0x64, inst!("LD H,H", |cpu, op|{let val = cpu.regs.h.r(); ld_into_reg!(val, cpu.regs.h); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 607 | [0x64, inst!("LD H,H", |cpu, op|{let val = cpu.regs.h.r(); ld_into_reg!(val, cpu.regs.h); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 608 | [0x65, inst!("LD H,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 608 | [0x65, inst!("LD H,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 609 | [0x66, inst!("LD H,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.h); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 609 | [0x66, inst!("LD H,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.h); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 610 | [0x67, inst!("LD H,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 610 | [0x67, inst!("LD H,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.h); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 612 | [0x68, inst!("LD L,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 612 | [0x68, inst!("LD L,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 613 | [0x69, inst!("LD L,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 613 | [0x69, inst!("LD L,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 614 | [0x6A, inst!("LD L,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 614 | [0x6A, inst!("LD L,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 615 | [0x6B, inst!("LD L,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 615 | [0x6B, inst!("LD L,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 616 | [0x6C, inst!("LD L,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 616 | [0x6C, inst!("LD L,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 617 | [0x6D, inst!("LD L,L", |cpu, op|{let val = cpu.regs.l.r(); ld_into_reg!(val, cpu.regs.l); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 617 | [0x6D, inst!("LD L,L", |cpu, op|{let val = cpu.regs.l.r(); ld_into_reg!(val, cpu.regs.l); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 618 | [0x6E, inst!("LD L,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.l); 1})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 618 | [0x6E, inst!("LD L,(HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); ld_into_reg!(val, cpu.regs.l); 1})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 619 | [0x6F, inst!("LD L,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 619 | [0x6F, inst!("LD L,A", |cpu, op|{ld_into_reg!(cpu.regs.a.r(), cpu.regs.l); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 621 | [0x70, inst!("LD (HL),B", |cpu, op|{store_into_hl(cpu.regs.b.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 621 | [0x70, inst!("LD (HL),B", |cpu, op|{store_into_hl(cpu.regs.b.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 622 | [0x71, inst!("LD (HL),C", |cpu, op|{store_into_hl(cpu.regs.c.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 622 | [0x71, inst!("LD (HL),C", |cpu, op|{store_into_hl(cpu.regs.c.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 623 | [0x72, inst!("LD (HL),D", |cpu, op|{store_into_hl(cpu.regs.d.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 623 | [0x72, inst!("LD (HL),D", |cpu, op|{store_into_hl(cpu.regs.d.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 624 | [0x73, inst!("LD (HL),E", |cpu, op|{store_into_hl(cpu.regs.e.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 624 | [0x73, inst!("LD (HL),E", |cpu, op|{store_into_hl(cpu.regs.e.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 625 | [0x74, inst!("LD (HL),H", |cpu, op|{store_into_hl(cpu.regs.h.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 625 | [0x74, inst!("LD (HL),H", |cpu, op|{store_into_hl(cpu.regs.h.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 626 | [0x75, inst!("LD (HL),L", |cpu, op|{store_into_hl(cpu.regs.l.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 626 | [0x75, inst!("LD (HL),L", |cpu, op|{store_into_hl(cpu.regs.l.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 627 | [0x77, inst!("LD (HL),A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 627 | [0x77, inst!("LD (HL),A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 629 | [0x78, inst!("LD A,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 629 | [0x78, inst!("LD A,B", |cpu, op|{ld_into_reg!(cpu.regs.b.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 630 | [0x79, inst!("LD A,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 630 | [0x79, inst!("LD A,C", |cpu, op|{ld_into_reg!(cpu.regs.c.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 631 | [0x7A, inst!("LD A,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 631 | [0x7A, inst!("LD A,D", |cpu, op|{ld_into_reg!(cpu.regs.d.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 632 | [0x7B, inst!("LD A,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 632 | [0x7B, inst!("LD A,E", |cpu, op|{ld_into_reg!(cpu.regs.e.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 633 | [0x7C, inst!("LD A,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 633 | [0x7C, inst!("LD A,H", |cpu, op|{ld_into_reg!(cpu.regs.h.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 634 | [0x7D, inst!("LD A,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 634 | [0x7D, inst!("LD A,L", |cpu, op|{ld_into_reg!(cpu.regs.l.r(), cpu.regs.a); 1})], [INFO] [stderr] | ----------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 635 | [0x7E, inst!("LD A,(HL)", |cpu, op|{let addr = cpu.regs.hl(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 635 | [0x7E, inst!("LD A,(HL)", |cpu, op|{let addr = cpu.regs.hl(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 636 | [0x7F, inst!("LD A,A", |cpu, op|{let val = cpu.regs.a.r(); ld_into_reg!(val, cpu.regs.a); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 636 | [0x7F, inst!("LD A,A", |cpu, op|{let val = cpu.regs.a.r(); ld_into_reg!(val, cpu.regs.a); 1})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 638 | [0x80, inst!("ADD A,B", |cpu, op|{add_to_a(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 638 | [0x80, inst!("ADD A,B", |cpu, op|{add_to_a(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 639 | [0x81, inst!("ADD A,C", |cpu, op|{add_to_a(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 639 | [0x81, inst!("ADD A,C", |cpu, op|{add_to_a(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 640 | [0x82, inst!("ADD A,D", |cpu, op|{add_to_a(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 640 | [0x82, inst!("ADD A,D", |cpu, op|{add_to_a(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 641 | [0x83, inst!("ADD A,E", |cpu, op|{add_to_a(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 641 | [0x83, inst!("ADD A,E", |cpu, op|{add_to_a(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 642 | [0x84, inst!("ADD A,H", |cpu, op|{add_to_a(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 642 | [0x84, inst!("ADD A,H", |cpu, op|{add_to_a(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 643 | [0x85, inst!("ADD A,L", |cpu, op|{add_to_a(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 643 | [0x85, inst!("ADD A,L", |cpu, op|{add_to_a(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 644 | [0x86, inst!("ADD A,(HL)", |cpu, op|{let addr = cpu.regs.hl(); add_to_a(cpu.read_byte(addr), cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 644 | [0x86, inst!("ADD A,(HL)", |cpu, op|{let addr = cpu.regs.hl(); add_to_a(cpu.read_byte(addr), cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 645 | [0x87, inst!("ADD A,A", |cpu, op|{add_to_a(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 645 | [0x87, inst!("ADD A,A", |cpu, op|{add_to_a(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 647 | [0x88, inst!("ADC A,B", |cpu, op|{add_carry(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 647 | [0x88, inst!("ADC A,B", |cpu, op|{add_carry(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 648 | [0x89, inst!("ADC A,C", |cpu, op|{add_carry(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 648 | [0x89, inst!("ADC A,C", |cpu, op|{add_carry(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 649 | [0x8A, inst!("ADC A,D", |cpu, op|{add_carry(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 649 | [0x8A, inst!("ADC A,D", |cpu, op|{add_carry(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 650 | [0x8B, inst!("ADC A,E", |cpu, op|{add_carry(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 650 | [0x8B, inst!("ADC A,E", |cpu, op|{add_carry(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 651 | [0x8C, inst!("ADC A,H", |cpu, op|{add_carry(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 651 | [0x8C, inst!("ADC A,H", |cpu, op|{add_carry(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 652 | [0x8D, inst!("ADC A,L", |cpu, op|{add_carry(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 652 | [0x8D, inst!("ADC A,L", |cpu, op|{add_carry(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 653 | [0x8E, inst!("ADC A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); add_carry(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 653 | [0x8E, inst!("ADC A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); add_carry(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 654 | [0x8F, inst!("ADC A,A", |cpu, op|{add_carry(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 654 | [0x8F, inst!("ADC A,A", |cpu, op|{add_carry(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 656 | [0x90, inst!("SUB A,B", |cpu, op|{sub_to_a(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 656 | [0x90, inst!("SUB A,B", |cpu, op|{sub_to_a(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 657 | [0x91, inst!("SUB A,C", |cpu, op|{sub_to_a(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 657 | [0x91, inst!("SUB A,C", |cpu, op|{sub_to_a(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 658 | [0x92, inst!("SUB A,D", |cpu, op|{sub_to_a(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 658 | [0x92, inst!("SUB A,D", |cpu, op|{sub_to_a(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 659 | [0x93, inst!("SUB A,E", |cpu, op|{sub_to_a(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 659 | [0x93, inst!("SUB A,E", |cpu, op|{sub_to_a(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 660 | [0x94, inst!("SUB A,H", |cpu, op|{sub_to_a(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 660 | [0x94, inst!("SUB A,H", |cpu, op|{sub_to_a(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 661 | [0x95, inst!("SUB A,L", |cpu, op|{sub_to_a(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 661 | [0x95, inst!("SUB A,L", |cpu, op|{sub_to_a(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 662 | [0x96, inst!("SUB A,(HL)", |cpu, op|{let addr = cpu.regs.hl(); sub_to_a(cpu.read_byte(addr), cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 662 | [0x96, inst!("SUB A,(HL)", |cpu, op|{let addr = cpu.regs.hl(); sub_to_a(cpu.read_byte(addr), cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | [0x97, inst!("SUB A,A", |cpu, op|{sub_to_a(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 663 | [0x97, inst!("SUB A,A", |cpu, op|{sub_to_a(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 665 | [0xA0, inst!("AND A,B", |cpu, op|{and(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 665 | [0xA0, inst!("AND A,B", |cpu, op|{and(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 666 | [0xA1, inst!("AND A,C", |cpu, op|{and(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 666 | [0xA1, inst!("AND A,C", |cpu, op|{and(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 667 | [0xA2, inst!("AND A,D", |cpu, op|{and(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 667 | [0xA2, inst!("AND A,D", |cpu, op|{and(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 668 | [0xA3, inst!("AND A,E", |cpu, op|{and(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 668 | [0xA3, inst!("AND A,E", |cpu, op|{and(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 669 | [0xA4, inst!("AND A,H", |cpu, op|{and(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 669 | [0xA4, inst!("AND A,H", |cpu, op|{and(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 670 | [0xA5, inst!("AND A,L", |cpu, op|{and(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 670 | [0xA5, inst!("AND A,L", |cpu, op|{and(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 671 | [0xA6, inst!("AND A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); and(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 671 | [0xA6, inst!("AND A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); and(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 672 | [0xA7, inst!("AND A,A", |cpu, op|{and(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 672 | [0xA7, inst!("AND A,A", |cpu, op|{and(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 674 | [0xA8, inst!("XOR A,B", |cpu, op|{xor(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 674 | [0xA8, inst!("XOR A,B", |cpu, op|{xor(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 675 | [0xA9, inst!("XOR A,C", |cpu, op|{xor(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 675 | [0xA9, inst!("XOR A,C", |cpu, op|{xor(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 676 | [0xAA, inst!("XOR A,D", |cpu, op|{xor(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 676 | [0xAA, inst!("XOR A,D", |cpu, op|{xor(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 677 | [0xAB, inst!("XOR A,E", |cpu, op|{xor(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 677 | [0xAB, inst!("XOR A,E", |cpu, op|{xor(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 678 | [0xAC, inst!("XOR A,H", |cpu, op|{xor(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 678 | [0xAC, inst!("XOR A,H", |cpu, op|{xor(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 679 | [0xAD, inst!("XOR A,L", |cpu, op|{xor(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 679 | [0xAD, inst!("XOR A,L", |cpu, op|{xor(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 680 | [0xAE, inst!("XOR A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); xor(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 680 | [0xAE, inst!("XOR A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); xor(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 681 | [0xAF, inst!("XOR A,A", |cpu, op|{xor(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 681 | [0xAF, inst!("XOR A,A", |cpu, op|{xor(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 683 | [0xB0, inst!("OR A,B", |cpu, op|{or(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 683 | [0xB0, inst!("OR A,B", |cpu, op|{or(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 684 | [0xB1, inst!("OR A,C", |cpu, op|{or(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 684 | [0xB1, inst!("OR A,C", |cpu, op|{or(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 685 | [0xB2, inst!("OR A,D", |cpu, op|{or(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 685 | [0xB2, inst!("OR A,D", |cpu, op|{or(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 686 | [0xB3, inst!("OR A,E", |cpu, op|{or(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 686 | [0xB3, inst!("OR A,E", |cpu, op|{or(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 687 | [0xB4, inst!("OR A,H", |cpu, op|{or(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 687 | [0xB4, inst!("OR A,H", |cpu, op|{or(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 688 | [0xB5, inst!("OR A,L", |cpu, op|{or(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 688 | [0xB5, inst!("OR A,L", |cpu, op|{or(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 689 | [0xB6, inst!("OR A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); or(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 689 | [0xB6, inst!("OR A,(HL)", |cpu, op|{let hl = cpu.regs.hl(); or(cpu.read_byte(hl), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 690 | [0xB7, inst!("OR A,A", |cpu, op|{or(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 690 | [0xB7, inst!("OR A,A", |cpu, op|{or(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 692 | [0xB8, inst!("CP B", |cpu, op|{compare_with_a(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 692 | [0xB8, inst!("CP B", |cpu, op|{compare_with_a(cpu.regs.b.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 693 | [0xB9, inst!("CP C", |cpu, op|{compare_with_a(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 693 | [0xB9, inst!("CP C", |cpu, op|{compare_with_a(cpu.regs.c.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 694 | [0xBA, inst!("CP D", |cpu, op|{compare_with_a(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 694 | [0xBA, inst!("CP D", |cpu, op|{compare_with_a(cpu.regs.d.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 695 | [0xBB, inst!("CP E", |cpu, op|{compare_with_a(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 695 | [0xBB, inst!("CP E", |cpu, op|{compare_with_a(cpu.regs.e.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 696 | [0xBC, inst!("CP H", |cpu, op|{compare_with_a(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 696 | [0xBC, inst!("CP H", |cpu, op|{compare_with_a(cpu.regs.h.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 697 | [0xBD, inst!("CP L", |cpu, op|{compare_with_a(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 697 | [0xBD, inst!("CP L", |cpu, op|{compare_with_a(cpu.regs.l.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 698 | [0xBE, inst!("CP (HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); compare_with_a(val, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 698 | [0xBE, inst!("CP (HL)", |cpu, op|{let val = cpu.read_byte(cpu.regs.hl()); compare_with_a(val, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 699 | [0xBF, inst!("CP A", |cpu, op|{compare_with_a(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 699 | [0xBF, inst!("CP A", |cpu, op|{compare_with_a(cpu.regs.a.r(), cpu); 1})], [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 701 | [0xC0, inst!("RET NZ", |cpu, op|{ret_cond(cpu, JumpImmCond::NZ); 2})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 701 | [0xC0, inst!("RET NZ", |cpu, op|{ret_cond(cpu, JumpImmCond::NZ); 2})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 702 | [0xC1, inst!("POP BC", |cpu, op|{pop_into!(cpu.regs.b, cpu.regs.c, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 702 | [0xC1, inst!("POP BC", |cpu, op|{pop_into!(cpu.regs.b, cpu.regs.c, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 703 | [0xC2, inst!("JP NZ,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::NZ, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 703 | [0xC2, inst!("JP NZ,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::NZ, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 704 | [0xC3, inst!("JP nn", |cpu, op|{jump_cond_imm(cpu, JumpImmCond::None, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 704 | [0xC3, inst!("JP nn", |cpu, op|{jump_cond_imm(cpu, JumpImmCond::None, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 705 | [0xC4, inst!("CALL NZ,nn", |cpu, op|{call_cond(cpu, JumpImmCond::NZ);3})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 705 | [0xC4, inst!("CALL NZ,nn", |cpu, op|{call_cond(cpu, JumpImmCond::NZ);3})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 706 | [0xC5, inst!("PUSH BC", |cpu, op|{let val = cpu.regs.bc();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 706 | [0xC5, inst!("PUSH BC", |cpu, op|{let val = cpu.regs.bc();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 707 | [0xC6, inst!("ADD A,#", |cpu, op|{add_to_a(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 707 | [0xC6, inst!("ADD A,#", |cpu, op|{add_to_a(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 708 | [0xC7, inst!("RST 0x00", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 708 | [0xC7, inst!("RST 0x00", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 710 | [0xC8, inst!("RET Z", |cpu, op|{ret_cond(cpu, JumpImmCond::Z); 2})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 710 | [0xC8, inst!("RET Z", |cpu, op|{ret_cond(cpu, JumpImmCond::Z); 2})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 711 | [0xC9, inst!("RET", |cpu, op|{ret_cond(cpu, JumpImmCond::None); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 711 | [0xC9, inst!("RET", |cpu, op|{ret_cond(cpu, JumpImmCond::None); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 712 | [0xCA, inst!("JP Z,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::Z, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 712 | [0xCA, inst!("JP Z,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::Z, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 713 | [0xCC, inst!("CALL Z,nn", |cpu, op|{call_cond(cpu, JumpImmCond::Z);3})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 713 | [0xCC, inst!("CALL Z,nn", |cpu, op|{call_cond(cpu, JumpImmCond::Z);3})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 714 | [0xCD, inst!("CALL nn", |cpu, op|{call_cond(cpu, JumpImmCond::None); 3})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 714 | [0xCD, inst!("CALL nn", |cpu, op|{call_cond(cpu, JumpImmCond::None); 3})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 715 | [0xCF, inst!("RST 0x08", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 715 | [0xCF, inst!("RST 0x08", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 717 | [0xD0, inst!("RET NC", |cpu, op|{ret_cond(cpu, JumpImmCond::NC); 2})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 717 | [0xD0, inst!("RET NC", |cpu, op|{ret_cond(cpu, JumpImmCond::NC); 2})], [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 718 | [0xD1, inst!("POP DE", |cpu, op|{pop_into!(cpu.regs.d, cpu.regs.e, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 718 | [0xD1, inst!("POP DE", |cpu, op|{pop_into!(cpu.regs.d, cpu.regs.e, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 719 | [0xD2, inst!("JP NC,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::NC, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 719 | [0xD2, inst!("JP NC,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::NC, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 720 | [0xD4, inst!("CALL NC,nn", |cpu, op|{call_cond(cpu, JumpImmCond::NC);3})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 720 | [0xD4, inst!("CALL NC,nn", |cpu, op|{call_cond(cpu, JumpImmCond::NC);3})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 721 | [0xD5, inst!("PUSH DE", |cpu, op|{let val = cpu.regs.de();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 721 | [0xD5, inst!("PUSH DE", |cpu, op|{let val = cpu.regs.de();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 722 | [0xD6, inst!("SUB A,#", |cpu, op|{sub_to_a(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 722 | [0xD6, inst!("SUB A,#", |cpu, op|{sub_to_a(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 723 | [0xD7, inst!("RST 0x10", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 723 | [0xD7, inst!("RST 0x10", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 725 | [0xD8, inst!("RET C", |cpu, op|{ret_cond(cpu, JumpImmCond::C); 2})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 725 | [0xD8, inst!("RET C", |cpu, op|{ret_cond(cpu, JumpImmCond::C); 2})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 726 | [0xD9, inst!("RETI", |cpu, op|{ret_cond(cpu, JumpImmCond::None); cpu.enable_interrupts_delayed(); 2})], [INFO] [stderr] | ---------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 726 | [0xD9, inst!("RETI", |cpu, op|{ret_cond(cpu, JumpImmCond::None); cpu.enable_interrupts_delayed(); 2})], [INFO] [stderr] | ---------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 727 | [0xDA, inst!("JP C,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::C, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 727 | [0xDA, inst!("JP C,nn", |cpu,op|{jump_cond_imm(cpu, JumpImmCond::C, JumpImmMode::Immediate); 3})], [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 728 | [0xDC, inst!("CALL C,nn", |cpu, op|{call_cond(cpu, JumpImmCond::C);3})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 728 | [0xDC, inst!("CALL C,nn", |cpu, op|{call_cond(cpu, JumpImmCond::C);3})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 729 | [0xDF, inst!("RST 0x18", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 729 | [0xDF, inst!("RST 0x18", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 731 | [0xE0, inst!("LD (0xFF00+n),A", |cpu, op|{let off = cpu.fetch_byte_immediate();ldh(cpu, off, false);3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 731 | [0xE0, inst!("LD (0xFF00+n),A", |cpu, op|{let off = cpu.fetch_byte_immediate();ldh(cpu, off, false);3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 732 | [0xE1, inst!("POP HL", |cpu, op|{pop_into!(cpu.regs.h, cpu.regs.l, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 732 | [0xE1, inst!("POP HL", |cpu, op|{pop_into!(cpu.regs.h, cpu.regs.l, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 733 | [0xE2, inst!("LD (0xFF00+C),A", |cpu, op|{let off = cpu.regs.c.r(); ldh(cpu, off, false);3})], [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 733 | [0xE2, inst!("LD (0xFF00+C),A", |cpu, op|{let off = cpu.regs.c.r(); ldh(cpu, off, false);3})], [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 734 | [0xE5, inst!("PUSH HL", |cpu, op|{let val = cpu.regs.hl();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 734 | [0xE5, inst!("PUSH HL", |cpu, op|{let val = cpu.regs.hl();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 735 | [0xE6, inst!("AND A,#", |cpu, op|{and(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 735 | [0xE6, inst!("AND A,#", |cpu, op|{and(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 736 | [0xE7, inst!("RST 0x20", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 736 | [0xE7, inst!("RST 0x20", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 737 | [0xE9, inst!("JP (HL)", |cpu, op|{jump(cpu.regs.hl(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 737 | [0xE9, inst!("JP (HL)", |cpu, op|{jump(cpu.regs.hl(), cpu); 1})], [INFO] [stderr] | -------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 738 | [0xEA, inst!("LD (nn),A", |cpu, op|{let addr = cpu.fetch_word_immediate(); ld_from_a_ind(addr, cpu); 4})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 738 | [0xEA, inst!("LD (nn),A", |cpu, op|{let addr = cpu.fetch_word_immediate(); ld_from_a_ind(addr, cpu); 4})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 739 | [0xEF, inst!("RST 0x28", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 739 | [0xEF, inst!("RST 0x28", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 740 | [0xEE, inst!("XOR A,#", |cpu, op|{let val = cpu.fetch_byte_immediate(); xor(val, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 740 | [0xEE, inst!("XOR A,#", |cpu, op|{let val = cpu.fetch_byte_immediate(); xor(val, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 742 | [0xF0, inst!("LD A,(0xFF00+n)", |cpu, op|{let off = cpu.fetch_byte_immediate(); ldh(cpu, off, true); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 742 | [0xF0, inst!("LD A,(0xFF00+n)", |cpu, op|{let off = cpu.fetch_byte_immediate(); ldh(cpu, off, true); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 743 | [0xF1, inst!("POP AF", |cpu, op|{pop_into!(cpu.regs.a, cpu.regs.f, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 743 | [0xF1, inst!("POP AF", |cpu, op|{pop_into!(cpu.regs.a, cpu.regs.f, cpu);3})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 744 | [0xF2, inst!("LD A,(0xFF00+C)", |cpu, op|{let off = cpu.regs.c.r(); ldh(cpu, off, true); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 744 | [0xF2, inst!("LD A,(0xFF00+C)", |cpu, op|{let off = cpu.regs.c.r(); ldh(cpu, off, true); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 745 | [0xF3, inst!("DI", |cpu, op|{cpu.disable_interrupts_delayed(); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 745 | [0xF3, inst!("DI", |cpu, op|{cpu.disable_interrupts_delayed(); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 746 | [0xF5, inst!("PUSH AF", |cpu, op|{let val = cpu.regs.af();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 746 | [0xF5, inst!("PUSH AF", |cpu, op|{let val = cpu.regs.af();cpu.push_word(val); 4})], [INFO] [stderr] | -------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 747 | [0xF6, inst!("OR A,#", |cpu, op|{or(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 747 | [0xF6, inst!("OR A,#", |cpu, op|{or(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 748 | [0xF7, inst!("RST 0x30", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 748 | [0xF7, inst!("RST 0x30", |cpu, op|{reset(op, cpu); 8})], [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 749 | [0xFA, inst!("LD A,(nn)", |cpu, op|{let addr = cpu.fetch_word_immediate(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 4})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 749 | [0xFA, inst!("LD A,(nn)", |cpu, op|{let addr = cpu.fetch_word_immediate(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 4})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 750 | [0xFB, inst!("EI", |cpu, op|{cpu.enable_interrupts_delayed(); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 750 | [0xFB, inst!("EI", |cpu, op|{cpu.enable_interrupts_delayed(); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 751 | [0xFE, inst!("CP n", |cpu, op|{compare_with_a(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 751 | [0xFE, inst!("CP n", |cpu, op|{compare_with_a(cpu.fetch_byte_immediate(), cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 752 | [0xFF, inst!("RST 0x38", |cpu, op|{reset(op, cpu); 8})] [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 752 | [0xFF, inst!("RST 0x38", |cpu, op|{reset(op, cpu); 8})] [INFO] [stderr] | ----------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:757:33 [INFO] [stderr] | [INFO] [stderr] 757 | let bit_to_test = (opcode & 0b00111000) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/hardware/instructions.rs:758:20 [INFO] [stderr] | [INFO] [stderr] 758 | let register = (opcode & 0b00000111); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:758:30 [INFO] [stderr] | [INFO] [stderr] 758 | let register = (opcode & 0b00000111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:780:34 [INFO] [stderr] | [INFO] [stderr] 780 | let bit_to_reset = (opcode & 0b00111000) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/hardware/instructions.rs:781:20 [INFO] [stderr] | [INFO] [stderr] 781 | let register = (opcode & 0b00000111); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:781:30 [INFO] [stderr] | [INFO] [stderr] 781 | let register = (opcode & 0b00000111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:801:34 [INFO] [stderr] | [INFO] [stderr] 801 | let bit_to_reset = (opcode & 0b00111000) >> 3; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/hardware/instructions.rs:802:20 [INFO] [stderr] | [INFO] [stderr] 802 | let register = (opcode & 0b00000111); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:802:30 [INFO] [stderr] | [INFO] [stderr] 802 | let register = (opcode & 0b00000111); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 848 | / pushall!( [INFO] [stderr] 849 | | [INFO] [stderr] 850 | | [0x10, inst!("RL B", |cpu, op|{rotate_left!(cpu.regs.b, cpu); 2})], [INFO] [stderr] 851 | | [0x11, inst!("RL C", |cpu, op|{rotate_left!(cpu.regs.c, cpu); 2})], [INFO] [stderr] ... | [INFO] [stderr] 1100 | | [0xFF, inst!("SET 7,A", |cpu,op|{set_bit(op, cpu);2})] [INFO] [stderr] 1101 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 848 | / pushall!( [INFO] [stderr] 849 | | [INFO] [stderr] 850 | | [0x10, inst!("RL B", |cpu, op|{rotate_left!(cpu.regs.b, cpu); 2})], [INFO] [stderr] 851 | | [0x11, inst!("RL C", |cpu, op|{rotate_left!(cpu.regs.c, cpu); 2})], [INFO] [stderr] ... | [INFO] [stderr] 1100 | | [0xFF, inst!("SET 7,A", |cpu,op|{set_bit(op, cpu);2})] [INFO] [stderr] 1101 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 850 | [0x10, inst!("RL B", |cpu, op|{rotate_left!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 850 | [0x10, inst!("RL B", |cpu, op|{rotate_left!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 851 | [0x11, inst!("RL C", |cpu, op|{rotate_left!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 851 | [0x11, inst!("RL C", |cpu, op|{rotate_left!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 852 | [0x12, inst!("RL D", |cpu, op|{rotate_left!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 852 | [0x12, inst!("RL D", |cpu, op|{rotate_left!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 853 | [0x13, inst!("RL E", |cpu, op|{rotate_left!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 853 | [0x13, inst!("RL E", |cpu, op|{rotate_left!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 854 | [0x14, inst!("RL H", |cpu, op|{rotate_left!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 854 | [0x14, inst!("RL H", |cpu, op|{rotate_left!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 855 | [0x15, inst!("RL L", |cpu, op|{rotate_left!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 855 | [0x15, inst!("RL L", |cpu, op|{rotate_left!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 856 | [0x16, inst!("RL (HL)", |cpu, op|{rotate_left_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 856 | [0x16, inst!("RL (HL)", |cpu, op|{rotate_left_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 857 | [0x17, inst!("RL A", |cpu, op|{rotate_left!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 857 | [0x17, inst!("RL A", |cpu, op|{rotate_left!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 859 | [0x20, inst!("SLA B", |cpu, op|{rl_no_carry_reg!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 859 | [0x20, inst!("SLA B", |cpu, op|{rl_no_carry_reg!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 860 | [0x21, inst!("SLA C", |cpu, op|{rl_no_carry_reg!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 860 | [0x21, inst!("SLA C", |cpu, op|{rl_no_carry_reg!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 861 | [0x22, inst!("SLA D", |cpu, op|{rl_no_carry_reg!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 861 | [0x22, inst!("SLA D", |cpu, op|{rl_no_carry_reg!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 862 | [0x23, inst!("SLA E", |cpu, op|{rl_no_carry_reg!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 862 | [0x23, inst!("SLA E", |cpu, op|{rl_no_carry_reg!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 863 | [0x24, inst!("SLA H", |cpu, op|{rl_no_carry_reg!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 863 | [0x24, inst!("SLA H", |cpu, op|{rl_no_carry_reg!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 864 | [0x25, inst!("SLA L", |cpu, op|{rl_no_carry_reg!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 864 | [0x25, inst!("SLA L", |cpu, op|{rl_no_carry_reg!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 865 | [0x26, inst!("SLA (HL)", |cpu, op|{rl_no_carry_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 865 | [0x26, inst!("SLA (HL)", |cpu, op|{rl_no_carry_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 866 | [0x27, inst!("SLA A", |cpu, op|{rl_no_carry_reg!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 866 | [0x27, inst!("SLA A", |cpu, op|{rl_no_carry_reg!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 868 | [0x30, inst!("SWAP B", |cpu, op|{swap_halves!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 868 | [0x30, inst!("SWAP B", |cpu, op|{swap_halves!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 869 | [0x31, inst!("SWAP C", |cpu, op|{swap_halves!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 869 | [0x31, inst!("SWAP C", |cpu, op|{swap_halves!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 870 | [0x32, inst!("SWAP D", |cpu, op|{swap_halves!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 870 | [0x32, inst!("SWAP D", |cpu, op|{swap_halves!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 871 | [0x33, inst!("SWAP E", |cpu, op|{swap_halves!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 871 | [0x33, inst!("SWAP E", |cpu, op|{swap_halves!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 872 | [0x34, inst!("SWAP H", |cpu, op|{swap_halves!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 872 | [0x34, inst!("SWAP H", |cpu, op|{swap_halves!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 873 | [0x35, inst!("SWAP L", |cpu, op|{swap_halves!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 873 | [0x35, inst!("SWAP L", |cpu, op|{swap_halves!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 874 | [0x36, inst!("SWAP (HL)", |cpu, op|{swap_halves_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 874 | [0x36, inst!("SWAP (HL)", |cpu, op|{swap_halves_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | --------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 875 | [0x37, inst!("SWAP A", |cpu, op|{swap_halves!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 875 | [0x37, inst!("SWAP A", |cpu, op|{swap_halves!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 877 | [0x38, inst!("SRL B", |cpu, op|{rr_no_carry_reg!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 877 | [0x38, inst!("SRL B", |cpu, op|{rr_no_carry_reg!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 878 | [0x39, inst!("SRL C", |cpu, op|{rr_no_carry_reg!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 878 | [0x39, inst!("SRL C", |cpu, op|{rr_no_carry_reg!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 879 | [0x3A, inst!("SRL D", |cpu, op|{rr_no_carry_reg!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 879 | [0x3A, inst!("SRL D", |cpu, op|{rr_no_carry_reg!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 880 | [0x3B, inst!("SRL E", |cpu, op|{rr_no_carry_reg!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 880 | [0x3B, inst!("SRL E", |cpu, op|{rr_no_carry_reg!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 881 | [0x3C, inst!("SRL H", |cpu, op|{rr_no_carry_reg!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 881 | [0x3C, inst!("SRL H", |cpu, op|{rr_no_carry_reg!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 882 | [0x3D, inst!("SRL L", |cpu, op|{rr_no_carry_reg!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 882 | [0x3D, inst!("SRL L", |cpu, op|{rr_no_carry_reg!(cpu.regs.l, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 883 | [0x3E, inst!("SRL (HL)", |cpu, op|{rr_no_carry_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 883 | [0x3E, inst!("SRL (HL)", |cpu, op|{rr_no_carry_ind(cpu.regs.hl(), cpu); 4})], [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 884 | [0x3F, inst!("SRL A", |cpu, op|{rr_no_carry_reg!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 884 | [0x3F, inst!("SRL A", |cpu, op|{rr_no_carry_reg!(cpu.regs.a, cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 886 | [0x40, inst!("BIT 0,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 886 | [0x40, inst!("BIT 0,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 887 | [0x41, inst!("BIT 0,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 887 | [0x41, inst!("BIT 0,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 888 | [0x42, inst!("BIT 0,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 888 | [0x42, inst!("BIT 0,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 889 | [0x43, inst!("BIT 0,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 889 | [0x43, inst!("BIT 0,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 890 | [0x44, inst!("BIT 0,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 890 | [0x44, inst!("BIT 0,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 891 | [0x45, inst!("BIT 0,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 891 | [0x45, inst!("BIT 0,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 892 | [0x46, inst!("BIT 0,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 892 | [0x46, inst!("BIT 0,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 893 | [0x47, inst!("BIT 0,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 893 | [0x47, inst!("BIT 0,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 895 | [0x48, inst!("BIT 1,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 895 | [0x48, inst!("BIT 1,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 896 | [0x49, inst!("BIT 1,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 896 | [0x49, inst!("BIT 1,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 897 | [0x4A, inst!("BIT 1,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 897 | [0x4A, inst!("BIT 1,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 898 | [0x4B, inst!("BIT 1,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 898 | [0x4B, inst!("BIT 1,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 899 | [0x4C, inst!("BIT 1,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 899 | [0x4C, inst!("BIT 1,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 900 | [0x4D, inst!("BIT 1,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 900 | [0x4D, inst!("BIT 1,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 901 | [0x4E, inst!("BIT 1,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 901 | [0x4E, inst!("BIT 1,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 902 | [0x4F, inst!("BIT 1,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 902 | [0x4F, inst!("BIT 1,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 904 | [0x50, inst!("BIT 2,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 904 | [0x50, inst!("BIT 2,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 905 | [0x51, inst!("BIT 2,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 905 | [0x51, inst!("BIT 2,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 906 | [0x52, inst!("BIT 2,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 906 | [0x52, inst!("BIT 2,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 907 | [0x53, inst!("BIT 2,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 907 | [0x53, inst!("BIT 2,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 908 | [0x54, inst!("BIT 2,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 908 | [0x54, inst!("BIT 2,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 909 | [0x55, inst!("BIT 2,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 909 | [0x55, inst!("BIT 2,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 910 | [0x56, inst!("BIT 2,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 910 | [0x56, inst!("BIT 2,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 911 | [0x57, inst!("BIT 2,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 911 | [0x57, inst!("BIT 2,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 913 | [0x58, inst!("BIT 3,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 913 | [0x58, inst!("BIT 3,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 914 | [0x59, inst!("BIT 3,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 914 | [0x59, inst!("BIT 3,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 915 | [0x5A, inst!("BIT 3,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 915 | [0x5A, inst!("BIT 3,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 916 | [0x5B, inst!("BIT 3,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 916 | [0x5B, inst!("BIT 3,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 917 | [0x5C, inst!("BIT 3,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 917 | [0x5C, inst!("BIT 3,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 918 | [0x5D, inst!("BIT 3,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 918 | [0x5D, inst!("BIT 3,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 919 | [0x5E, inst!("BIT 3,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 919 | [0x5E, inst!("BIT 3,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 920 | [0x5F, inst!("BIT 3,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 920 | [0x5F, inst!("BIT 3,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 922 | [0x60, inst!("BIT 4,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 922 | [0x60, inst!("BIT 4,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 923 | [0x61, inst!("BIT 4,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 923 | [0x61, inst!("BIT 4,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 924 | [0x62, inst!("BIT 4,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 924 | [0x62, inst!("BIT 4,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 925 | [0x63, inst!("BIT 4,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 925 | [0x63, inst!("BIT 4,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 926 | [0x64, inst!("BIT 4,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 926 | [0x64, inst!("BIT 4,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 927 | [0x65, inst!("BIT 4,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 927 | [0x65, inst!("BIT 4,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 928 | [0x66, inst!("BIT 4,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 928 | [0x66, inst!("BIT 4,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 929 | [0x67, inst!("BIT 4,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 929 | [0x67, inst!("BIT 4,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 931 | [0x68, inst!("BIT 5,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 931 | [0x68, inst!("BIT 5,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 932 | [0x69, inst!("BIT 5,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 932 | [0x69, inst!("BIT 5,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 933 | [0x6A, inst!("BIT 5,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 933 | [0x6A, inst!("BIT 5,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 934 | [0x6B, inst!("BIT 5,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 934 | [0x6B, inst!("BIT 5,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 935 | [0x6C, inst!("BIT 5,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 935 | [0x6C, inst!("BIT 5,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 936 | [0x6D, inst!("BIT 5,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 936 | [0x6D, inst!("BIT 5,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 937 | [0x6E, inst!("BIT 5,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 937 | [0x6E, inst!("BIT 5,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 938 | [0x6F, inst!("BIT 5,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 938 | [0x6F, inst!("BIT 5,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 940 | [0x70, inst!("BIT 6,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 940 | [0x70, inst!("BIT 6,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 941 | [0x71, inst!("BIT 6,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 941 | [0x71, inst!("BIT 6,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 942 | [0x72, inst!("BIT 6,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 942 | [0x72, inst!("BIT 6,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 943 | [0x73, inst!("BIT 6,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 943 | [0x73, inst!("BIT 6,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 944 | [0x74, inst!("BIT 6,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 944 | [0x74, inst!("BIT 6,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 945 | [0x75, inst!("BIT 6,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 945 | [0x75, inst!("BIT 6,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 946 | [0x76, inst!("BIT 6,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 946 | [0x76, inst!("BIT 6,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 947 | [0x77, inst!("BIT 6,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 947 | [0x77, inst!("BIT 6,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 949 | [0x78, inst!("BIT 7,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 949 | [0x78, inst!("BIT 7,B", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 950 | [0x79, inst!("BIT 7,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 950 | [0x79, inst!("BIT 7,C", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 951 | [0x7A, inst!("BIT 7,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 951 | [0x7A, inst!("BIT 7,D", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 952 | [0x7B, inst!("BIT 7,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 952 | [0x7B, inst!("BIT 7,E", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 953 | [0x7C, inst!("BIT 7,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 953 | [0x7C, inst!("BIT 7,H", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 954 | [0x7D, inst!("BIT 7,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 954 | [0x7D, inst!("BIT 7,L", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 955 | [0x7E, inst!("BIT 7,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 955 | [0x7E, inst!("BIT 7,(HL)", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ---------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 956 | [0x7F, inst!("BIT 7,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 956 | [0x7F, inst!("BIT 7,A", |cpu, op|{test_bit(op, cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 958 | [0x80, inst!("RES 0,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 958 | [0x80, inst!("RES 0,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 959 | [0x81, inst!("RES 0,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 959 | [0x81, inst!("RES 0,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 960 | [0x82, inst!("RES 0,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 960 | [0x82, inst!("RES 0,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 961 | [0x83, inst!("RES 0,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 961 | [0x83, inst!("RES 0,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 962 | [0x84, inst!("RES 0,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 962 | [0x84, inst!("RES 0,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 963 | [0x85, inst!("RES 0,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 963 | [0x85, inst!("RES 0,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 964 | [0x86, inst!("RES 0,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 964 | [0x86, inst!("RES 0,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 965 | [0x87, inst!("RES 0,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 965 | [0x87, inst!("RES 0,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 967 | [0x88, inst!("RES 1,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 967 | [0x88, inst!("RES 1,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 968 | [0x89, inst!("RES 1,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 968 | [0x89, inst!("RES 1,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 969 | [0x8A, inst!("RES 1,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 969 | [0x8A, inst!("RES 1,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 970 | [0x8B, inst!("RES 1,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 970 | [0x8B, inst!("RES 1,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 971 | [0x8C, inst!("RES 1,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 971 | [0x8C, inst!("RES 1,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 972 | [0x8D, inst!("RES 1,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 972 | [0x8D, inst!("RES 1,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 973 | [0x8E, inst!("RES 1,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 973 | [0x8E, inst!("RES 1,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 974 | [0x8F, inst!("RES 1,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 974 | [0x8F, inst!("RES 1,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 976 | [0x90, inst!("RES 2,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 976 | [0x90, inst!("RES 2,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 977 | [0x91, inst!("RES 2,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 977 | [0x91, inst!("RES 2,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 978 | [0x92, inst!("RES 2,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 978 | [0x92, inst!("RES 2,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 979 | [0x93, inst!("RES 2,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 979 | [0x93, inst!("RES 2,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 980 | [0x94, inst!("RES 2,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 980 | [0x94, inst!("RES 2,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 981 | [0x95, inst!("RES 2,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 981 | [0x95, inst!("RES 2,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 982 | [0x96, inst!("RES 2,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 982 | [0x96, inst!("RES 2,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 983 | [0x97, inst!("RES 2,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 983 | [0x97, inst!("RES 2,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 985 | [0x98, inst!("RES 3,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 985 | [0x98, inst!("RES 3,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 986 | [0x99, inst!("RES 3,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 986 | [0x99, inst!("RES 3,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 987 | [0x9A, inst!("RES 3,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 987 | [0x9A, inst!("RES 3,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 988 | [0x9B, inst!("RES 3,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 988 | [0x9B, inst!("RES 3,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 989 | [0x9C, inst!("RES 3,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 989 | [0x9C, inst!("RES 3,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 990 | [0x9D, inst!("RES 3,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 990 | [0x9D, inst!("RES 3,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 991 | [0x9E, inst!("RES 3,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 991 | [0x9E, inst!("RES 3,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 992 | [0x9F, inst!("RES 3,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 992 | [0x9F, inst!("RES 3,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 994 | [0xA0, inst!("RES 4,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 994 | [0xA0, inst!("RES 4,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::debugger` [INFO] [stderr] --> src/hardware/cpu.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use hardware::debugger; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::video::screen::Screen` [INFO] [stderr] --> src/hardware/cpu.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use hardware::video::screen::Screen; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::interrupts::Interrupts` [INFO] [stderr] --> src/hardware/cpu.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use hardware::interrupts::Interrupts; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | Z = 0b10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | N = 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | H = 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/cpu.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | C = 0b00010000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/hardware/mod.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | if (QUICK_FIXES_ACTIVE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/cartridge.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / quick_fix!({ [INFO] [stderr] 127 | | println!("Writing byte {:2X} to cartridge addres {:4X}", val, addr); [INFO] [stderr] 128 | | }, [INFO] [stderr] 129 | | "Probably shouldn't be writing to the cartridge ROM"); [INFO] [stderr] | |______________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:311:43 [INFO] [stderr] | [INFO] [stderr] 311 | cpu.set_flag(CPUFlags::C, (original & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:336:43 [INFO] [stderr] | [INFO] [stderr] 336 | cpu.set_flag(CPUFlags::C, (original & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:345:43 [INFO] [stderr] | [INFO] [stderr] 345 | cpu.set_flag(CPUFlags::C, (original & 0b10000000) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/hardware/instructions.rs:369:43 [INFO] [stderr] | [INFO] [stderr] 369 | cpu.set_flag(CPUFlags::C, (original & 0b00000001) > 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 499 | / pushall!( [INFO] [stderr] 500 | | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] 501 | | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] 502 | | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] ... | [INFO] [stderr] 752 | | [0xFF, inst!("RST 0x38", |cpu, op|{reset(op, cpu); 8})] [INFO] [stderr] 753 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 499 | / pushall!( [INFO] [stderr] 500 | | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] 501 | | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] 502 | | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] ... | [INFO] [stderr] 752 | | [0xFF, inst!("RST 0x38", |cpu, op|{reset(op, cpu); 8})] [INFO] [stderr] 753 | | ) [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 500 | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 500 | [0x00, inst!("NOP", |cpu, op|{1})], [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 995 | [0xA1, inst!("RES 4,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 995 | [0xA1, inst!("RES 4,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 996 | [0xA2, inst!("RES 4,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 996 | [0xA2, inst!("RES 4,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 997 | [0xA3, inst!("RES 4,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 997 | [0xA3, inst!("RES 4,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 998 | [0xA4, inst!("RES 4,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 998 | [0xA4, inst!("RES 4,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 501 | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 999 | [0xA5, inst!("RES 4,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 501 | [0x01, inst!("LD BC,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.b, cpu.regs.c, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 999 | [0xA5, inst!("RES 4,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1000 | [0xA6, inst!("RES 4,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 502 | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 502 | [0x02, inst!("LD (BC),A", |cpu, op|{ld_from_a_ind(cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1000 | [0xA6, inst!("RES 4,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 503 | [0x03, inst!("INC BC", |cpu, op|{inc_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 503 | [0x03, inst!("INC BC", |cpu, op|{inc_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1001 | [0xA7, inst!("RES 4,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1001 | [0xA7, inst!("RES 4,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1003 | [0xA8, inst!("RES 5,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 504 | [0x04, inst!("INC B", |cpu, op| {inc!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 504 | [0x04, inst!("INC B", |cpu, op| {inc!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1003 | [0xA8, inst!("RES 5,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1004 | [0xA9, inst!("RES 5,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1004 | [0xA9, inst!("RES 5,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 505 | [0x05, inst!("DEC B", |cpu, op|{dec!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 505 | [0x05, inst!("DEC B", |cpu, op|{dec!(cpu.regs.b, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1005 | [0xAA, inst!("RES 5,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1005 | [0xAA, inst!("RES 5,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 506 | [0x06, inst!("LD B,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] | [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1006 | [0xAB, inst!("RES 5,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1006 | [0xAB, inst!("RES 5,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 506 | [0x06, inst!("LD B,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.b, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1007 | [0xAC, inst!("RES 5,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1007 | [0xAC, inst!("RES 5,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1008 | [0xAD, inst!("RES 5,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1008 | [0xAD, inst!("RES 5,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 507 | [0x07, inst!("RLCA", |cpu, op|{rl_no_carry_reg!(cpu.regs.a, cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1009 | [0xAE, inst!("RES 5,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 507 | [0x07, inst!("RLCA", |cpu, op|{rl_no_carry_reg!(cpu.regs.a, cpu); 1})], [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1009 | [0xAE, inst!("RES 5,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1010 | [0xAF, inst!("RES 5,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1010 | [0xAF, inst!("RES 5,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] | ^^^^ [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] ... [INFO] [stderr] 1012 | [0xB0, inst!("RES 6,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 509 | [0x09, inst!("ADD HL,BC", |cpu, op|{add_16("HL", cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1012 | [0xB0, inst!("RES 6,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 509 | [0x09, inst!("ADD HL,BC", |cpu, op|{add_16("HL", cpu.regs.bc(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1013 | [0xB1, inst!("RES 6,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1013 | [0xB1, inst!("RES 6,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1014 | [0xB2, inst!("RES 6,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1014 | [0xB2, inst!("RES 6,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | [0x19, inst!("ADD HL,DE", |cpu, op|{add_16("HL", cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1015 | [0xB3, inst!("RES 6,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1015 | [0xB3, inst!("RES 6,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 510 | [0x19, inst!("ADD HL,DE", |cpu, op|{add_16("HL", cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1016 | [0xB4, inst!("RES 6,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1016 | [0xB4, inst!("RES 6,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1017 | [0xB5, inst!("RES 6,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] ... [INFO] [stderr] | [INFO] [stderr] 511 | [0x29, inst!("ADD HL,HL", |cpu, op|{add_16("HL", cpu.regs.hl(), cpu); 2})], [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1017 | [0xB5, inst!("RES 6,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] 511 | [0x29, inst!("ADD HL,HL", |cpu, op|{add_16("HL", cpu.regs.hl(), cpu); 2})], [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1018 | [0xB6, inst!("RES 6,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1018 | [0xB6, inst!("RES 6,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1019 | [0xB7, inst!("RES 6,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1019 | [0xB7, inst!("RES 6,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 512 | [0x39, inst!("ADD HL,SP", |cpu, op|{add_16("HL", cpu.sp.r(), cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] | [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1021 | [0xB8, inst!("RES 7,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1021 | [0xB8, inst!("RES 7,B", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 512 | [0x39, inst!("ADD HL,SP", |cpu, op|{add_16("HL", cpu.sp.r(), cpu); 2})], [INFO] [stderr] | --------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1022 | [0xB9, inst!("RES 7,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1022 | [0xB9, inst!("RES 7,C", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1023 | [0xBA, inst!("RES 7,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1023 | [0xBA, inst!("RES 7,D", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 514 | [0x0A, inst!("LD A,(BC)", |cpu, op|{let addr = cpu.regs.bc(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1024 | [0xBB, inst!("RES 7,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] ... [INFO] [stderr] 1024 | [0xBB, inst!("RES 7,E", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] 514 | [0x0A, inst!("LD A,(BC)", |cpu, op|{let addr = cpu.regs.bc(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1025 | [0xBC, inst!("RES 7,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1025 | [0xBC, inst!("RES 7,H", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1026 | [0xBD, inst!("RES 7,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] 63 | inst [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] | [INFO] [stderr] 515 | [0x0B, inst!("DEC BC", |cpu, op|{dec_16!("BC", cpu); 2})], [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1026 | [0xBD, inst!("RES 7,L", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 515 | [0x0B, inst!("DEC BC", |cpu, op|{dec_16!("BC", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1027 | [0xBE, inst!("RES 7,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1027 | [0xBE, inst!("RES 7,(HL)", |cpu, op|{reset_bit(op, cpu); 4})], [INFO] [stderr] | ----------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1028 | [0xBF, inst!("RES 7,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1028 | [0xBF, inst!("RES 7,A", |cpu, op|{reset_bit(op, cpu); 2})], [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 516 | [0x0C, inst!("INC C", |cpu, op| {inc!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 516 | [0x0C, inst!("INC C", |cpu, op| {inc!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1030 | [0xC0, inst!("SET 0,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1030 | [0xC0, inst!("SET 0,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1031 | [0xC1, inst!("SET 0,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1031 | [0xC1, inst!("SET 0,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1032 | [0xC2, inst!("SET 0,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1032 | [0xC2, inst!("SET 0,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1033 | [0xC3, inst!("SET 0,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1033 | [0xC3, inst!("SET 0,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1034 | [0xC4, inst!("SET 0,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1034 | [0xC4, inst!("SET 0,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1035 | [0xC5, inst!("SET 0,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1035 | [0xC5, inst!("SET 0,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1036 | [0xC6, inst!("SET 0,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1036 | [0xC6, inst!("SET 0,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1037 | [0xC7, inst!("SET 0,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1037 | [0xC7, inst!("SET 0,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1039 | [0xC8, inst!("SET 1,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1039 | [0xC8, inst!("SET 1,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1040 | [0xC9, inst!("SET 1,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1040 | [0xC9, inst!("SET 1,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1041 | [0xCA, inst!("SET 1,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1041 | [0xCA, inst!("SET 1,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1042 | [0xCB, inst!("SET 1,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1042 | [0xCB, inst!("SET 1,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1043 | [0xCC, inst!("SET 1,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1043 | [0xCC, inst!("SET 1,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1044 | [0xCD, inst!("SET 1,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1044 | [0xCD, inst!("SET 1,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1045 | [0xCE, inst!("SET 1,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1045 | [0xCE, inst!("SET 1,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1046 | [0xCF, inst!("SET 1,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1046 | [0xCF, inst!("SET 1,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1048 | [0xD0, inst!("SET 2,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1048 | [0xD0, inst!("SET 2,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1049 | [0xD1, inst!("SET 2,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1049 | [0xD1, inst!("SET 2,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1050 | [0xD2, inst!("SET 2,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1050 | [0xD2, inst!("SET 2,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1051 | [0xD3, inst!("SET 2,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1051 | [0xD3, inst!("SET 2,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1052 | [0xD4, inst!("SET 2,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1052 | [0xD4, inst!("SET 2,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1053 | [0xD5, inst!("SET 2,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1053 | [0xD5, inst!("SET 2,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1054 | [0xD6, inst!("SET 2,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1054 | [0xD6, inst!("SET 2,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1055 | [0xD7, inst!("SET 2,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1055 | [0xD7, inst!("SET 2,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1057 | [0xD8, inst!("SET 3,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1057 | [0xD8, inst!("SET 3,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1058 | [0xD9, inst!("SET 3,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1058 | [0xD9, inst!("SET 3,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1059 | [0xDA, inst!("SET 3,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1059 | [0xDA, inst!("SET 3,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1060 | [0xDB, inst!("SET 3,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1060 | [0xDB, inst!("SET 3,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1061 | [0xDC, inst!("SET 3,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1061 | [0xDC, inst!("SET 3,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1062 | [0xDD, inst!("SET 3,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1062 | [0xDD, inst!("SET 3,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1063 | [0xDE, inst!("SET 3,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1063 | [0xDE, inst!("SET 3,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1064 | [0xDF, inst!("SET 3,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1064 | [0xDF, inst!("SET 3,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1066 | [0xE0, inst!("SET 4,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1066 | [0xE0, inst!("SET 4,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 517 | [0x0D, inst!("DEC C", |cpu, op|{dec!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 517 | [0x0D, inst!("DEC C", |cpu, op|{dec!(cpu.regs.c, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1067 | [0xE1, inst!("SET 4,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1067 | [0xE1, inst!("SET 4,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 518 | [0x0E, inst!("LD C,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1068 | [0xE2, inst!("SET 4,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 518 | [0x0E, inst!("LD C,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.c, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1068 | [0xE2, inst!("SET 4,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 520 | [0x11, inst!("LD DE,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.d, cpu.regs.e, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 520 | [0x11, inst!("LD DE,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.d, cpu.regs.e, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1069 | [0xE3, inst!("SET 4,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1069 | [0xE3, inst!("SET 4,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 521 | [0x12, inst!("LD (DE),A", |cpu, op|{ld_from_a_ind(cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 521 | [0x12, inst!("LD (DE),A", |cpu, op|{ld_from_a_ind(cpu.regs.de(), cpu); 2})], [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1070 | [0xE4, inst!("SET 4,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 522 | [0x13, inst!("INC DE", |cpu, op|{inc_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 522 | [0x13, inst!("INC DE", |cpu, op|{inc_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1070 | [0xE4, inst!("SET 4,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1071 | [0xE5, inst!("SET 4,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 523 | [0x14, inst!("INC D", |cpu, op| {inc!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 523 | [0x14, inst!("INC D", |cpu, op| {inc!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1071 | [0xE5, inst!("SET 4,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 524 | [0x15, inst!("DEC D", |cpu, op|{dec!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 524 | [0x15, inst!("DEC D", |cpu, op|{dec!(cpu.regs.d, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1072 | [0xE6, inst!("SET 4,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1072 | [0xE6, inst!("SET 4,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 525 | [0x16, inst!("LD D,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 525 | [0x16, inst!("LD D,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.d, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1073 | [0xE7, inst!("SET 4,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 526 | [0x17, inst!("RLA", |cpu, op|{rla(cpu); 1})], [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 526 | [0x17, inst!("RLA", |cpu, op|{rla(cpu); 1})], [INFO] [stderr] | ------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1073 | [0xE7, inst!("SET 4,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 528 | [0x18, inst!("JR n", |cpu, op|{jump_cond_imm(cpu, JumpImmCond::None, JumpImmMode::IntOffset); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 528 | [0x18, inst!("JR n", |cpu, op|{jump_cond_imm(cpu, JumpImmCond::None, JumpImmMode::IntOffset); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 529 | [0x1A, inst!("LD A,(DE)", |cpu, op|{let addr = cpu.regs.de(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 529 | [0x1A, inst!("LD A,(DE)", |cpu, op|{let addr = cpu.regs.de(); let val = cpu.read_byte(addr); ld_into_reg!(val, cpu.regs.a); 2})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1075 | [0xE8, inst!("SET 5,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 530 | [0x1B, inst!("DEC DE", |cpu, op|{dec_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 530 | [0x1B, inst!("DEC DE", |cpu, op|{dec_16!("DE", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1075 | [0xE8, inst!("SET 5,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 531 | [0x1C, inst!("INC E", |cpu, op| {inc!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 531 | [0x1C, inst!("INC E", |cpu, op| {inc!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1076 | [0xE9, inst!("SET 5,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1076 | [0xE9, inst!("SET 5,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 532 | [0x1D, inst!("DEC E", |cpu, op|{dec!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 532 | [0x1D, inst!("DEC E", |cpu, op|{dec!(cpu.regs.e, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1077 | [0xEA, inst!("SET 5,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1077 | [0xEA, inst!("SET 5,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 533 | [0x1E, inst!("LD E,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 533 | [0x1E, inst!("LD E,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.e, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1078 | [0xEB, inst!("SET 5,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1078 | [0xEB, inst!("SET 5,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1079 | [0xEC, inst!("SET 5,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1079 | [0xEC, inst!("SET 5,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1080 | [0xED, inst!("SET 5,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1080 | [0xED, inst!("SET 5,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1081 | [0xEE, inst!("SET 5,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1081 | [0xEE, inst!("SET 5,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1082 | [0xEF, inst!("SET 5,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1082 | [0xEF, inst!("SET 5,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 535 | [0x20, inst!("JR NZ,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::NZ, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1084 | [0xF0, inst!("SET 6,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1084 | [0xF0, inst!("SET 6,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 535 | [0x20, inst!("JR NZ,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::NZ, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1085 | [0xF1, inst!("SET 6,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1085 | [0xF1, inst!("SET 6,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 536 | [0x21, inst!("LD HL,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.h, cpu.regs.l, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1086 | [0xF2, inst!("SET 6,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 536 | [0x21, inst!("LD HL,nn", |cpu, op|{load_word_imm_u8!(cpu.regs.h, cpu.regs.l, cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1086 | [0xF2, inst!("SET 6,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 537 | [0x22, inst!("LDI (HL+), A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1087 | [0xF3, inst!("SET 6,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] 537 | [0x22, inst!("LDI (HL+), A", |cpu, op|{store_into_hl(cpu.regs.a.r(), cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | ------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1087 | [0xF3, inst!("SET 6,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1088 | [0xF4, inst!("SET 6,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1088 | [0xF4, inst!("SET 6,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 538 | [0x23, inst!("INC HL", |cpu, op|{inc_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 538 | [0x23, inst!("INC HL", |cpu, op|{inc_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1089 | [0xF5, inst!("SET 6,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1089 | [0xF5, inst!("SET 6,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1090 | [0xF6, inst!("SET 6,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 539 | [0x24, inst!("INC H", |cpu, op| {inc!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 539 | [0x24, inst!("INC H", |cpu, op| {inc!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1090 | [0xF6, inst!("SET 6,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1091 | [0xF7, inst!("SET 6,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 540 | [0x25, inst!("DEC H", |cpu, op|{dec!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 540 | [0x25, inst!("DEC H", |cpu, op|{dec!(cpu.regs.h, cpu, false); 1})], [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1091 | [0xF7, inst!("SET 6,A", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1093 | [0xF8, inst!("SET 7,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1093 | [0xF8, inst!("SET 7,B", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 541 | [0x26, inst!("LD H,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1094 | [0xF9, inst!("SET 7,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1094 | [0xF9, inst!("SET 7,C", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 541 | [0x26, inst!("LD H,n", |cpu, op|{load_byte_imm_u8!(cpu.regs.h, cpu); 2})], [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1095 | [0xFA, inst!("SET 7,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1095 | [0xFA, inst!("SET 7,D", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1096 | [0xFB, inst!("SET 7,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1096 | [0xFB, inst!("SET 7,E", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1097 | [0xFC, inst!("SET 7,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1097 | [0xFC, inst!("SET 7,H", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1098 | [0xFD, inst!("SET 7,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1098 | [0xFD, inst!("SET 7,L", |cpu,op|{set_bit(op, cpu);2})], [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1099 | [0xFE, inst!("SET 7,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1099 | [0xFE, inst!("SET 7,(HL)", |cpu,op|{set_bit(op, cpu);4})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 1100 | [0xFF, inst!("SET 7,A", |cpu,op|{set_bit(op, cpu);2})] [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 1100 | [0xFF, inst!("SET 7,A", |cpu,op|{set_bit(op, cpu);2})] [INFO] [stderr] | ---------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::interrupts::InterruptType` [INFO] [stderr] --> src/hardware/memory/bus.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use hardware::interrupts::InterruptType; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hardware::video::gpu_constants::*` [INFO] [stderr] --> src/hardware/memory/bus.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use hardware::video::gpu_constants::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/hardware/mod.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | if (QUICK_FIXES_ACTIVE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/memory/bus.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / quick_fix!({ [INFO] [stderr] 93 | | if self.io_registers.boot_rom_enabled() && self.boot_rom.in_region(addr) { [INFO] [stderr] 94 | | return self.boot_rom.read_byte(addr); [INFO] [stderr] 95 | | } else if self.cartridge.in_region(addr) { [INFO] [stderr] ... | [INFO] [stderr] 118 | | if the HRAM ifelse comes before it). [INFO] [stderr] 119 | | It shouldn't be order-dependant. Fix it."); [INFO] [stderr] | |____________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 542 | [0x27, inst!("DAA", |cpu, op| {daa(cpu); 1})], [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 542 | [0x27, inst!("DAA", |cpu, op| {daa(cpu); 1})], [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/memory/bus.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | return self.cartridge.write_byte(addr, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cartridge.write_byte(addr, val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 544 | [0x28, inst!("JR Z,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::Z, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/memory/bus.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | return self.unused_memory.write_byte(addr, val) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.unused_memory.write_byte(addr, val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 544 | [0x28, inst!("JR Z,n", |cpu, op|{if jump_cond_imm(cpu, JumpImmCond::Z, JumpImmMode::IntOffset){3} else {2}})], [INFO] [stderr] | ----------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] --> src/hardware/mod.rs:4:12 [INFO] [stderr] 63 | inst [INFO] [stderr] | [INFO] [stderr] | ^^^^ [INFO] [stderr] 4 | if (QUICK_FIXES_ACTIVE) { [INFO] [stderr] ... [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] 545 | [0x2A, inst!("LDI A,(HL+)", |cpu, op|{store_hl_into_a(cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] ::: src/hardware/memory/bus.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / quick_fix!({ [INFO] [stderr] 124 | | [INFO] [stderr] 125 | | if self.cartridge.in_region(addr) { [INFO] [stderr] 126 | | return self.cartridge.write_byte(addr, val); [INFO] [stderr] ... | [INFO] [stderr] 149 | | if the HRAM ifelse comes before it). [INFO] [stderr] 150 | | It shouldn't be order-dependant. Fix it."); [INFO] [stderr] | |___________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 545 | [0x2A, inst!("LDI A,(HL+)", |cpu, op|{store_hl_into_a(cpu); inc_16!("HL", cpu); 3})], [INFO] [stderr] | ---------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/hardware/mod.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | if (QUICK_FIXES_ACTIVE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/memory/ioregs.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / quick_fix!({ [INFO] [stderr] 17 | | if addr == BOOT_ROM_ENABLE { [INFO] [stderr] 18 | | self.boot_rom_enable.r() [INFO] [stderr] 19 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | }, "IORegs should be gone at some point") [INFO] [stderr] | |_________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/hardware/mod.rs:4:12 [INFO] [stderr] | [INFO] [stderr] 4 | if (QUICK_FIXES_ACTIVE) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] ::: src/hardware/memory/ioregs.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / quick_fix!({ [INFO] [stderr] 28 | | if addr == BOOT_ROM_ENABLE { [INFO] [stderr] 29 | | self.boot_rom_enable.w(val) [INFO] [stderr] 30 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | }, "IORegs should be gone at some point"); [INFO] [stderr] | |__________________________________________________- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/debugger.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | temp_vec [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 127 | / hash![ [INFO] [stderr] 128 | | //0x0100 [INFO] [stderr] 129 | | //0x25D [INFO] [stderr] 130 | | ] [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 546 | [0x2B, inst!("DEC HL", |cpu, op|{dec_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] | [INFO] [stderr] --> src/hardware/debugger.rs:117:32 [INFO] [stderr] | [INFO] [stderr] 117 | let mut temp_vec = HashSet::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 127 | / hash![ [INFO] [stderr] 128 | | //0x0100 [INFO] [stderr] 129 | | //0x25D [INFO] [stderr] 130 | | ] [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/instructions.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | let inst = Instruction::new($x, $f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 546 | [0x2B, inst!("DEC HL", |cpu, op|{dec_16!("HL", cpu); 2})], [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/registers.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hardware/registers.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | let ret = self.val; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/registers.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return (self.val & ((1 as u8) << bit)) > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.val & ((1 as u8) << bit)) > 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hardware/instructions.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | inst [INFO] [stderr] | ^^^^ [INFO] [stderr] ... [INFO] [stderr] 547 | [0x2C, inst!("INC L", |cpu, op| {inc!(cpu.regs.l, cpu, false); 1})], [INFO] [stderr] | ----------------------------------------------------------- in this macro invocation [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hardware/registers.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return (self.val & ((1 as u16) << bit)) > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.val & ((1 as u16) << bit)) > 0` [INFO] [stderr] | [WARN] too many lines in the log, truncating it