[INFO] updating cached repository blinry/habitctl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blinry/habitctl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blinry/habitctl" "work/ex/clippy-test-run/sources/stable/gh/blinry/habitctl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blinry/habitctl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blinry/habitctl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blinry/habitctl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blinry/habitctl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77c2a9295ed9fbc0fdc36ddc47c68ac959005f71 [INFO] sha for GitHub repo blinry/habitctl: 77c2a9295ed9fbc0fdc36ddc47c68ac959005f71 [INFO] validating manifest of blinry/habitctl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blinry/habitctl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blinry/habitctl [INFO] finished frobbing blinry/habitctl [INFO] frobbed toml for blinry/habitctl written to work/ex/clippy-test-run/sources/stable/gh/blinry/habitctl/Cargo.toml [INFO] started frobbing blinry/habitctl [INFO] finished frobbing blinry/habitctl [INFO] frobbed toml for blinry/habitctl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blinry/habitctl/Cargo.toml [INFO] crate blinry/habitctl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blinry/habitctl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/blinry/habitctl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88917fe31c96a9863fe2b33b0a044b0a42a7438128dbb605379e7ae5b03b2257 [INFO] running `"docker" "start" "-a" "88917fe31c96a9863fe2b33b0a044b0a42a7438128dbb605379e7ae5b03b2257"` [INFO] [stderr] Checking dirs v1.0.3 [INFO] [stderr] Checking habitctl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / write!( [INFO] [stderr] 134 | | &file, [INFO] [stderr] 135 | | "# The numbers specifies how often you want to do a habit:\n" [INFO] [stderr] 136 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / write!( [INFO] [stderr] 138 | | &file, [INFO] [stderr] 139 | | "# 1 means daily, 7 means weekly, 0 means you're just tracking the habit. Some examples:\n" [INFO] [stderr] 140 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | write!(&file, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / write!( [INFO] [stderr] 182 | | &file, [INFO] [stderr] 183 | | "{}\t{}\t{}\n", [INFO] [stderr] 184 | | &entry.date.format("%F"), [INFO] [stderr] 185 | | &entry.habit, [INFO] [stderr] 186 | | &entry.value [INFO] [stderr] 187 | | ).unwrap(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / write!( [INFO] [stderr] 134 | | &file, [INFO] [stderr] 135 | | "# The numbers specifies how often you want to do a habit:\n" [INFO] [stderr] 136 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / write!( [INFO] [stderr] 138 | | &file, [INFO] [stderr] 139 | | "# 1 means daily, 7 means weekly, 0 means you're just tracking the habit. Some examples:\n" [INFO] [stderr] 140 | | ); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | write!(&file, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / write!( [INFO] [stderr] 182 | | &file, [INFO] [stderr] 183 | | "{}\t{}\t{}\n", [INFO] [stderr] 184 | | &entry.date.format("%F"), [INFO] [stderr] 185 | | &entry.habit, [INFO] [stderr] 186 | | &entry.value [INFO] [stderr] 187 | | ).unwrap(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / write!( [INFO] [stderr] 134 | | &file, [INFO] [stderr] 135 | | "# The numbers specifies how often you want to do a habit:\n" [INFO] [stderr] 136 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / write!( [INFO] [stderr] 138 | | &file, [INFO] [stderr] 139 | | "# 1 means daily, 7 means weekly, 0 means you're just tracking the habit. Some examples:\n" [INFO] [stderr] 140 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / write!( [INFO] [stderr] 142 | | &file, [INFO] [stderr] 143 | | "\n# 1 Meditated\n# 7 Cleaned the apartment\n# 0 Had a headache\n# 1 Used habitctl\n" [INFO] [stderr] 144 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | fn log(&self, filters: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:292:63 [INFO] [stderr] | [INFO] [stderr] 292 | self.print_habit_row(&habit, log_from.date(), current.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:293:25 [INFO] [stderr] | [INFO] [stderr] 293 | let l = format!("[y/n/-] "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"[y/n/-] ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:297:29 [INFO] [stderr] | [INFO] [stderr] 297 | value = String::from(rprompt::prompt_reply_stdout(&l).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `rprompt::prompt_reply_stdout(&l).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:307:31 [INFO] [stderr] | [INFO] [stderr] 307 | date: current.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:339:35 [INFO] [stderr] | [INFO] [stderr] 339 | fn get_todo(&self, todo_date: &Date) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:386:52 [INFO] [stderr] | [INFO] [stderr] 386 | fn get_entry(&self, date: &Date, habit: &String) -> Option<&Entry> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:386:31 [INFO] [stderr] | [INFO] [stderr] 386 | fn get_entry(&self, date: &Date, habit: &String) -> Option<&Entry> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:392:47 [INFO] [stderr] | [INFO] [stderr] 392 | fn day_status(&self, habit: &Habit, date: &Date) -> DayStatus { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:416:52 [INFO] [stderr] | [INFO] [stderr] 416 | fn habit_satisfied(&self, habit: &Habit, date: &Date) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:456:36 [INFO] [stderr] | [INFO] [stderr] 456 | .and_then(|entry| Some(entry.date.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `entry.date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:462:36 [INFO] [stderr] | [INFO] [stderr] 462 | .and_then(|entry| Some(entry.date.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `entry.date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:465:37 [INFO] [stderr] | [INFO] [stderr] 465 | fn get_score(&self, score_date: &Date) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | / write!( [INFO] [stderr] 134 | | &file, [INFO] [stderr] 135 | | "# The numbers specifies how often you want to do a habit:\n" [INFO] [stderr] 136 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | / write!( [INFO] [stderr] 138 | | &file, [INFO] [stderr] 139 | | "# 1 means daily, 7 means weekly, 0 means you're just tracking the habit. Some examples:\n" [INFO] [stderr] 140 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | / write!( [INFO] [stderr] 142 | | &file, [INFO] [stderr] 143 | | "\n# 1 Meditated\n# 7 Cleaned the apartment\n# 0 Had a headache\n# 1 Used habitctl\n" [INFO] [stderr] 144 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | fn log(&self, filters: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:292:63 [INFO] [stderr] | [INFO] [stderr] 292 | self.print_habit_row(&habit, log_from.date(), current.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:293:25 [INFO] [stderr] | [INFO] [stderr] 293 | let l = format!("[y/n/-] "); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"[y/n/-] ".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:297:29 [INFO] [stderr] | [INFO] [stderr] 297 | value = String::from(rprompt::prompt_reply_stdout(&l).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `rprompt::prompt_reply_stdout(&l).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:307:31 [INFO] [stderr] | [INFO] [stderr] 307 | date: current.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `current` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:339:35 [INFO] [stderr] | [INFO] [stderr] 339 | fn get_todo(&self, todo_date: &Date) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:386:52 [INFO] [stderr] | [INFO] [stderr] 386 | fn get_entry(&self, date: &Date, habit: &String) -> Option<&Entry> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:386:31 [INFO] [stderr] | [INFO] [stderr] 386 | fn get_entry(&self, date: &Date, habit: &String) -> Option<&Entry> { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:392:47 [INFO] [stderr] | [INFO] [stderr] 392 | fn day_status(&self, habit: &Habit, date: &Date) -> DayStatus { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:416:52 [INFO] [stderr] | [INFO] [stderr] 416 | fn habit_satisfied(&self, habit: &Habit, date: &Date) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:456:36 [INFO] [stderr] | [INFO] [stderr] 456 | .and_then(|entry| Some(entry.date.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `entry.date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:462:36 [INFO] [stderr] | [INFO] [stderr] 462 | .and_then(|entry| Some(entry.date.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `entry.date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:465:37 [INFO] [stderr] | [INFO] [stderr] 465 | fn get_score(&self, score_date: &Date) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Date` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.05s [INFO] running `"docker" "inspect" "88917fe31c96a9863fe2b33b0a044b0a42a7438128dbb605379e7ae5b03b2257"` [INFO] running `"docker" "rm" "-f" "88917fe31c96a9863fe2b33b0a044b0a42a7438128dbb605379e7ae5b03b2257"` [INFO] [stdout] 88917fe31c96a9863fe2b33b0a044b0a42a7438128dbb605379e7ae5b03b2257