[INFO] updating cached repository blakehawkins/rota-korpuss-gen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blakehawkins/rota-korpuss-gen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blakehawkins/rota-korpuss-gen" "work/ex/clippy-test-run/sources/stable/gh/blakehawkins/rota-korpuss-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blakehawkins/rota-korpuss-gen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blakehawkins/rota-korpuss-gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blakehawkins/rota-korpuss-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blakehawkins/rota-korpuss-gen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0a5b4095daedf13deed8681b35193ea2c92b536d [INFO] sha for GitHub repo blakehawkins/rota-korpuss-gen: 0a5b4095daedf13deed8681b35193ea2c92b536d [INFO] validating manifest of blakehawkins/rota-korpuss-gen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blakehawkins/rota-korpuss-gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blakehawkins/rota-korpuss-gen [INFO] finished frobbing blakehawkins/rota-korpuss-gen [INFO] frobbed toml for blakehawkins/rota-korpuss-gen written to work/ex/clippy-test-run/sources/stable/gh/blakehawkins/rota-korpuss-gen/Cargo.toml [INFO] started frobbing blakehawkins/rota-korpuss-gen [INFO] finished frobbing blakehawkins/rota-korpuss-gen [INFO] frobbed toml for blakehawkins/rota-korpuss-gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blakehawkins/rota-korpuss-gen/Cargo.toml [INFO] crate blakehawkins/rota-korpuss-gen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blakehawkins/rota-korpuss-gen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/blakehawkins/rota-korpuss-gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4fa149f03d19af0cfebb56b1ff59d7367c442c15103fc7f0721f753941f6a17a [INFO] running `"docker" "start" "-a" "4fa149f03d19af0cfebb56b1ff59d7367c442c15103fc7f0721f753941f6a17a"` [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking structopt v0.1.6 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking rota-korpuss-gen v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | ErrorKind::InvalidDate(cfg.dates.end.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cfg.dates.end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:212:46 [INFO] [stderr] | [INFO] [stderr] 212 | .position(|r| r == &&dates.start_day) [INFO] [stderr] | ^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&dates.start_day` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:216:14 [INFO] [stderr] | [INFO] [stderr] 216 | for i in dates.start..(dates.end + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `dates.start..=dates.end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:241:46 [INFO] [stderr] | [INFO] [stderr] 241 | .position(|r| r == &&cfg.dates.start_day) [INFO] [stderr] | ^^^^^--------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&cfg.dates.start_day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | (cfg.dates.start..(cfg.dates.end + 1)).for_each(|dom| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(cfg.dates.start..=cfg.dates.end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:266:57 [INFO] [stderr] | [INFO] [stderr] 266 | let job_room_sep = cfg.job_room_sep.clone().unwrap_or(" ".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| " ".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:338:46 [INFO] [stderr] | [INFO] [stderr] 338 | .position(|r| r == &&cfg.dates.start_day) [INFO] [stderr] | ^^^^^--------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&cfg.dates.start_day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | (cfg.dates.start..(cfg.dates.end + 1)).for_each(|dom| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(cfg.dates.start..=cfg.dates.end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:367:37 [INFO] [stderr] | [INFO] [stderr] 367 | (*its_vec).push(format!("{}", next_job)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `next_job.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | ErrorKind::InvalidDate(cfg.dates.end.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cfg.dates.end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:212:46 [INFO] [stderr] | [INFO] [stderr] 212 | .position(|r| r == &&dates.start_day) [INFO] [stderr] | ^^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&dates.start_day` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:216:14 [INFO] [stderr] | [INFO] [stderr] 216 | for i in dates.start..(dates.end + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `dates.start..=dates.end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:241:46 [INFO] [stderr] | [INFO] [stderr] 241 | .position(|r| r == &&cfg.dates.start_day) [INFO] [stderr] | ^^^^^--------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&cfg.dates.start_day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:247:5 [INFO] [stderr] | [INFO] [stderr] 247 | (cfg.dates.start..(cfg.dates.end + 1)).for_each(|dom| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(cfg.dates.start..=cfg.dates.end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:266:57 [INFO] [stderr] | [INFO] [stderr] 266 | let job_room_sep = cfg.job_room_sep.clone().unwrap_or(" ".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| " ".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:338:46 [INFO] [stderr] | [INFO] [stderr] 338 | .position(|r| r == &&cfg.dates.start_day) [INFO] [stderr] | ^^^^^--------------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `&cfg.dates.start_day` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:344:5 [INFO] [stderr] | [INFO] [stderr] 344 | (cfg.dates.start..(cfg.dates.end + 1)).for_each(|dom| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(cfg.dates.start..=cfg.dates.end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:367:37 [INFO] [stderr] | [INFO] [stderr] 367 | (*its_vec).push(format!("{}", next_job)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `next_job.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.13s [INFO] running `"docker" "inspect" "4fa149f03d19af0cfebb56b1ff59d7367c442c15103fc7f0721f753941f6a17a"` [INFO] running `"docker" "rm" "-f" "4fa149f03d19af0cfebb56b1ff59d7367c442c15103fc7f0721f753941f6a17a"` [INFO] [stdout] 4fa149f03d19af0cfebb56b1ff59d7367c442c15103fc7f0721f753941f6a17a