[INFO] updating cached repository blakehawkins/project-euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/blakehawkins/project-euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/blakehawkins/project-euler" "work/ex/clippy-test-run/sources/stable/gh/blakehawkins/project-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blakehawkins/project-euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/blakehawkins/project-euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blakehawkins/project-euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blakehawkins/project-euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c36b2ff3265ae96a661e234d481b1f49264d705f [INFO] sha for GitHub repo blakehawkins/project-euler: c36b2ff3265ae96a661e234d481b1f49264d705f [INFO] validating manifest of blakehawkins/project-euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blakehawkins/project-euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blakehawkins/project-euler [INFO] finished frobbing blakehawkins/project-euler [INFO] frobbed toml for blakehawkins/project-euler written to work/ex/clippy-test-run/sources/stable/gh/blakehawkins/project-euler/Cargo.toml [INFO] started frobbing blakehawkins/project-euler [INFO] finished frobbing blakehawkins/project-euler [INFO] frobbed toml for blakehawkins/project-euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blakehawkins/project-euler/Cargo.toml [INFO] crate blakehawkins/project-euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blakehawkins/project-euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/blakehawkins/project-euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c060ba58eda51f02c662337a493008153b792d3b70a7b99eb9099771bd2f3c8 [INFO] running `"docker" "start" "-a" "5c060ba58eda51f02c662337a493008153b792d3b70a7b99eb9099771bd2f3c8"` [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking clap-verbosity-flag v0.1.0 [INFO] [stderr] Checking quicli v0.3.0 [INFO] [stderr] Checking project-euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / if repr == repr.chars().rev().collect::() { [INFO] [stderr] 92 | | if v > biggest { [INFO] [stderr] 93 | | biggest = v; [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | if repr == repr.chars().rev().collect::() && v > biggest { [INFO] [stderr] 92 | biggest = v; [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | / if repr == repr.chars().rev().collect::() { [INFO] [stderr] 92 | | if v > biggest { [INFO] [stderr] 93 | | biggest = v; [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | if repr == repr.chars().rev().collect::() && v > biggest { [INFO] [stderr] 92 | biggest = v; [INFO] [stderr] 93 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / (3..n) [INFO] [stderr] 33 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(3..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:53:35 [INFO] [stderr] | [INFO] [stderr] 53 | let mut scratch: Vec = (2..z).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(2..z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:107:39 [INFO] [stderr] | [INFO] [stderr] 107 | let mut scratch: Vec = (try..(try * 2)).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(try..(try * 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | for sieve in 11..(upper + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `11..=upper` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | soln = scratch.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*scratch.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | soln = scratch.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&scratch[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:131:39 [INFO] [stderr] | [INFO] [stderr] 131 | TriangleGenerator { nth, val: (1..(nth + 1)).sum() } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=nth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | for v in 2..(_val + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `2..=_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / (3..n) [INFO] [stderr] 33 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `(3..n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:53:35 [INFO] [stderr] | [INFO] [stderr] 53 | let mut scratch: Vec = (2..z).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(2..z)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:107:39 [INFO] [stderr] | [INFO] [stderr] 107 | let mut scratch: Vec = (try..(try * 2)).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(try..(try * 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:108:22 [INFO] [stderr] | [INFO] [stderr] 108 | for sieve in 11..(upper + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `11..=upper` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | soln = scratch.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*scratch.get(0).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | soln = scratch.get(0).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&scratch[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:131:39 [INFO] [stderr] | [INFO] [stderr] 131 | TriangleGenerator { nth, val: (1..(nth + 1)).sum() } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `(1..=nth)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:151:18 [INFO] [stderr] | [INFO] [stderr] 151 | for v in 2..(_val + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `2..=_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.29s [INFO] running `"docker" "inspect" "5c060ba58eda51f02c662337a493008153b792d3b70a7b99eb9099771bd2f3c8"` [INFO] running `"docker" "rm" "-f" "5c060ba58eda51f02c662337a493008153b792d3b70a7b99eb9099771bd2f3c8"` [INFO] [stdout] 5c060ba58eda51f02c662337a493008153b792d3b70a7b99eb9099771bd2f3c8