[INFO] updating cached repository blackxparade/RUST-Chip-8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/blackxparade/RUST-Chip-8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/blackxparade/RUST-Chip-8" "work/ex/clippy-test-run/sources/stable/gh/blackxparade/RUST-Chip-8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/blackxparade/RUST-Chip-8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/blackxparade/RUST-Chip-8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blackxparade/RUST-Chip-8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blackxparade/RUST-Chip-8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e4b105caa4668357283a5cdc37a93c39f553a95b
[INFO] sha for GitHub repo blackxparade/RUST-Chip-8: e4b105caa4668357283a5cdc37a93c39f553a95b
[INFO] validating manifest of blackxparade/RUST-Chip-8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of blackxparade/RUST-Chip-8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing blackxparade/RUST-Chip-8
[INFO] finished frobbing blackxparade/RUST-Chip-8
[INFO] frobbed toml for blackxparade/RUST-Chip-8 written to work/ex/clippy-test-run/sources/stable/gh/blackxparade/RUST-Chip-8/Cargo.toml
[INFO] started frobbing blackxparade/RUST-Chip-8
[INFO] finished frobbing blackxparade/RUST-Chip-8
[INFO] frobbed toml for blackxparade/RUST-Chip-8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/blackxparade/RUST-Chip-8/Cargo.toml
[INFO] crate blackxparade/RUST-Chip-8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting blackxparade/RUST-Chip-8 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/blackxparade/RUST-Chip-8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e52a61a901f3820eb164c9024a2070662a5376186124e36a71d68d7419d36b42
[INFO] running `"docker" "start" "-a" "e52a61a901f3820eb164c9024a2070662a5376186124e36a71d68d7419d36b42"`
[INFO] [stderr]    Compiling gcc v0.3.51
[INFO] [stderr]     Checking colored v1.5.1
[INFO] [stderr]    Compiling minifb v0.9.1
[INFO] [stderr]     Checking RUST-Chip-8 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:465:39
[INFO] [stderr]     |
[INFO] [stderr] 465 |                 if cpu.v_memory[coord((vx as usize + j as usize),
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:466:17
[INFO] [stderr]     |
[INFO] [stderr] 466 |                 (vy as usize + i as usize))] != 0 {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:469:36
[INFO] [stderr]     |
[INFO] [stderr] 469 |                 cpu.v_memory[coord((vx as usize + j as usize),
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:470:17
[INFO] [stderr]     |
[INFO] [stderr] 470 |                 (vy as usize + i as usize))] ^= 0xFFFFFFFF;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/opcode.rs:470:49
[INFO] [stderr]     |
[INFO] [stderr] 470 |                 (vy as usize + i as usize))] ^= 0xFFFFFFFF;
[INFO] [stderr]     |                                                 ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/cpu/mod.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub mod cpu;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:465:39
[INFO] [stderr]     |
[INFO] [stderr] 465 |                 if cpu.v_memory[coord((vx as usize + j as usize),
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:466:17
[INFO] [stderr]     |
[INFO] [stderr] 466 |                 (vy as usize + i as usize))] != 0 {
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:469:36
[INFO] [stderr]     |
[INFO] [stderr] 469 |                 cpu.v_memory[coord((vx as usize + j as usize),
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]    --> src/cpu/opcode.rs:470:17
[INFO] [stderr]     |
[INFO] [stderr] 470 |                 (vy as usize + i as usize))] ^= 0xFFFFFFFF;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/cpu/opcode.rs:470:49
[INFO] [stderr]     |
[INFO] [stderr] 470 |                 (vy as usize + i as usize))] ^= 0xFFFFFFFF;
[INFO] [stderr]     |                                                 ^^^^^^^^^^ help: consider: `0xFFFF_FFFF`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/cpu/mod.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub mod cpu;
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: crate `RUST_Chip_8` should have a snake case name such as `rust_chip_8`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.opcode`
[INFO] [stderr]   --> src/cpu/opcode.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |      if cpu.opcode & 0xFFFF == 0x00e0 { _00e0(cpu); return; }
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.opcode`
[INFO] [stderr]   --> src/cpu/opcode.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |      if cpu.opcode & 0xFFFF == 0x00ee { _00ee(cpu); return; }
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cpu/opcode.rs:93:8
[INFO] [stderr]    |
[INFO] [stderr] 93 |     if cpu.stack.len() > 0 && cpu.sp > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cpu.stack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:202:27
[INFO] [stderr]     |
[INFO] [stderr] 202 |     let mut value : u16 = cpu.v_regs[x as usize] as u16 + kk as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:202:59
[INFO] [stderr]     |
[INFO] [stderr] 202 |     let mut value : u16 = cpu.v_regs[x as usize] as u16 + kk as u16;
[INFO] [stderr]     |                                                           ^^^^^^^^^ help: try: `u16::from(kk)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:203:5
[INFO] [stderr]     |
[INFO] [stderr] 203 |     value = value % 256;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: replace it with: `value %= 256`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:286:20
[INFO] [stderr]     |
[INFO] [stderr] 286 |     let xy : u16 = cpu.v_regs[x as usize] as u16 +
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:287:21
[INFO] [stderr]     |
[INFO] [stderr] 287 |                     cpu.v_regs[y as usize] as u16 ;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[y as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:330:9
[INFO] [stderr]     |
[INFO] [stderr] 330 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] >> 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] >>= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:333:9
[INFO] [stderr]     |
[INFO] [stderr] 333 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] >> 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] >>= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:369:9
[INFO] [stderr]     |
[INFO] [stderr] 369 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] << 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] <<= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:372:9
[INFO] [stderr]     |
[INFO] [stderr] 372 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] << 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] <<= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:413:20
[INFO] [stderr]     |
[INFO] [stderr] 413 |     cpu.pc = nnn + cpu.v_regs[0] as u16;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:553:18
[INFO] [stderr]     |
[INFO] [stderr] 553 |     cpu.i_reg += cpu.v_regs[x as usize] as u16;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu/opcode.rs:581:14
[INFO] [stderr]     |
[INFO] [stderr] 581 |     for i in 0..(x+1) {
[INFO] [stderr]     |              ^^^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu/opcode.rs:596:14
[INFO] [stderr]     |
[INFO] [stderr] 596 |     for i in 0..(x+1) {
[INFO] [stderr]     |              ^^^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::cpu::Cpu`
[INFO] [stderr]   --> src/cpu/cpu.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> Cpu {
[INFO] [stderr] 27 | |
[INFO] [stderr] 28 | |         Cpu {
[INFO] [stderr] 29 | |             rom_buffer : Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     } // fn new
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 25 | impl Default for cpu::cpu::Cpu {
[INFO] [stderr] 26 |     fn default() -> Self {
[INFO] [stderr] 27 |         Self::new()
[INFO] [stderr] 28 |     }
[INFO] [stderr] 29 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/cpu/cpu.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..self.rom_buffer.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[512..(self.rom_buffer.len() + 512)].clone_from_slice(&self.rom_buffer[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `font_set`
[INFO] [stderr]   --> src/cpu/cpu.rs:80:18
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for (i, <item>) in font_set.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/cpu/cpu.rs:80:18
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^ help: try replacing the loop by: `self.memory[..80].clone_from_slice(&font_set[..80])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu.rs:96:25
[INFO] [stderr]    |
[INFO] [stderr] 96 |         let diff = 16 - ((stop.nsec - start.nsec)/1000) as i64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((stop.nsec - start.nsec)/1000)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |            window.get_keys().map(|keys| {
[INFO] [stderr]    |   _________^
[INFO] [stderr]    |  |_________|
[INFO] [stderr]    | ||
[INFO] [stderr] 26 | ||             for t in keys {
[INFO] [stderr] 27 | ||                 match t {
[INFO] [stderr] 28 | ||                     Key::Key1 => chip8.keypad[0] = 1,
[INFO] [stderr] ...  ||
[INFO] [stderr] 46 | ||             }
[INFO] [stderr] 47 | ||         });
[INFO] [stderr]    | ||__________^- help: try this: `if let Some(keys) = window.get_keys() { ... }`
[INFO] [stderr]    | |___________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: crate `RUST_Chip_8` should have a snake case name such as `rust_chip_8`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.opcode`
[INFO] [stderr]   --> src/cpu/opcode.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |      if cpu.opcode & 0xFFFF == 0x00e0 { _00e0(cpu); return; }
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cpu.opcode`
[INFO] [stderr]   --> src/cpu/opcode.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 |      if cpu.opcode & 0xFFFF == 0x00ee { _00ee(cpu); return; }
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/cpu/opcode.rs:93:8
[INFO] [stderr]    |
[INFO] [stderr] 93 |     if cpu.stack.len() > 0 && cpu.sp > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cpu.stack.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:202:27
[INFO] [stderr]     |
[INFO] [stderr] 202 |     let mut value : u16 = cpu.v_regs[x as usize] as u16 + kk as u16;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:202:59
[INFO] [stderr]     |
[INFO] [stderr] 202 |     let mut value : u16 = cpu.v_regs[x as usize] as u16 + kk as u16;
[INFO] [stderr]     |                                                           ^^^^^^^^^ help: try: `u16::from(kk)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:203:5
[INFO] [stderr]     |
[INFO] [stderr] 203 |     value = value % 256;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^ help: replace it with: `value %= 256`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:286:20
[INFO] [stderr]     |
[INFO] [stderr] 286 |     let xy : u16 = cpu.v_regs[x as usize] as u16 +
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:287:21
[INFO] [stderr]     |
[INFO] [stderr] 287 |                     cpu.v_regs[y as usize] as u16 ;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[y as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:330:9
[INFO] [stderr]     |
[INFO] [stderr] 330 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] >> 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] >>= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:333:9
[INFO] [stderr]     |
[INFO] [stderr] 333 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] >> 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] >>= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:369:9
[INFO] [stderr]     |
[INFO] [stderr] 369 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] << 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] <<= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/cpu/opcode.rs:372:9
[INFO] [stderr]     |
[INFO] [stderr] 372 |         cpu.v_regs[x as usize] = cpu.v_regs[x as usize] << 1;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.v_regs[x as usize] <<= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:413:20
[INFO] [stderr]     |
[INFO] [stderr] 413 |     cpu.pc = nnn + cpu.v_regs[0] as u16;
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu/opcode.rs:553:18
[INFO] [stderr]     |
[INFO] [stderr] 553 |     cpu.i_reg += cpu.v_regs[x as usize] as u16;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(cpu.v_regs[x as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu/opcode.rs:581:14
[INFO] [stderr]     |
[INFO] [stderr] 581 |     for i in 0..(x+1) {
[INFO] [stderr]     |              ^^^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/cpu/opcode.rs:596:14
[INFO] [stderr]     |
[INFO] [stderr] 596 |     for i in 0..(x+1) {
[INFO] [stderr]     |              ^^^^^^^^ help: use: `0..=x`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `cpu::cpu::Cpu`
[INFO] [stderr]   --> src/cpu/cpu.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 | /     pub fn new() -> Cpu {
[INFO] [stderr] 27 | |
[INFO] [stderr] 28 | |         Cpu {
[INFO] [stderr] 29 | |             rom_buffer : Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 40 | |         }
[INFO] [stderr] 41 | |     } // fn new
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 25 | impl Default for cpu::cpu::Cpu {
[INFO] [stderr] 26 |     fn default() -> Self {
[INFO] [stderr] 27 |         Self::new()
[INFO] [stderr] 28 |     }
[INFO] [stderr] 29 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/cpu/cpu.rs:58:18
[INFO] [stderr]    |
[INFO] [stderr] 58 |         for i in 0..self.rom_buffer.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self.memory[512..(self.rom_buffer.len() + 512)].clone_from_slice(&self.rom_buffer[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `font_set`
[INFO] [stderr]   --> src/cpu/cpu.rs:80:18
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for (i, <item>) in font_set.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/cpu/cpu.rs:80:18
[INFO] [stderr]    |
[INFO] [stderr] 80 |         for i in 0..80 {
[INFO] [stderr]    |                  ^^^^^ help: try replacing the loop by: `self.memory[..80].clone_from_slice(&font_set[..80])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/cpu/cpu.rs:96:25
[INFO] [stderr]    |
[INFO] [stderr] 96 |         let diff = 16 - ((stop.nsec - start.nsec)/1000) as i64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((stop.nsec - start.nsec)/1000)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/main.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |            window.get_keys().map(|keys| {
[INFO] [stderr]    |   _________^
[INFO] [stderr]    |  |_________|
[INFO] [stderr]    | ||
[INFO] [stderr] 26 | ||             for t in keys {
[INFO] [stderr] 27 | ||                 match t {
[INFO] [stderr] 28 | ||                     Key::Key1 => chip8.keypad[0] = 1,
[INFO] [stderr] ...  ||
[INFO] [stderr] 46 | ||             }
[INFO] [stderr] 47 | ||         });
[INFO] [stderr]    | ||__________^- help: try this: `if let Some(keys) = window.get_keys() { ... }`
[INFO] [stderr]    | |___________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.79s
[INFO] running `"docker" "inspect" "e52a61a901f3820eb164c9024a2070662a5376186124e36a71d68d7419d36b42"`
[INFO] running `"docker" "rm" "-f" "e52a61a901f3820eb164c9024a2070662a5376186124e36a71d68d7419d36b42"`
[INFO] [stdout] e52a61a901f3820eb164c9024a2070662a5376186124e36a71d68d7419d36b42