[INFO] updating cached repository bl4ck5un/p2sh-examples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bl4ck5un/p2sh-examples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bl4ck5un/p2sh-examples" "work/ex/clippy-test-run/sources/stable/gh/bl4ck5un/p2sh-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bl4ck5un/p2sh-examples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bl4ck5un/p2sh-examples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bl4ck5un/p2sh-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bl4ck5un/p2sh-examples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be453d5bbfb6a4b966f8a6e90b7f9d2d2e5c0b0a [INFO] sha for GitHub repo bl4ck5un/p2sh-examples: be453d5bbfb6a4b966f8a6e90b7f9d2d2e5c0b0a [INFO] validating manifest of bl4ck5un/p2sh-examples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bl4ck5un/p2sh-examples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bl4ck5un/p2sh-examples [INFO] finished frobbing bl4ck5un/p2sh-examples [INFO] frobbed toml for bl4ck5un/p2sh-examples written to work/ex/clippy-test-run/sources/stable/gh/bl4ck5un/p2sh-examples/Cargo.toml [INFO] started frobbing bl4ck5un/p2sh-examples [INFO] finished frobbing bl4ck5un/p2sh-examples [INFO] frobbed toml for bl4ck5un/p2sh-examples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bl4ck5un/p2sh-examples/Cargo.toml [INFO] crate bl4ck5un/p2sh-examples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bl4ck5un/p2sh-examples against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bl4ck5un/p2sh-examples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df2ed844d7b6748a9ab541089fede3dace6b1d44987cb1068c2f1793d3863b69 [INFO] running `"docker" "start" "-a" "df2ed844d7b6748a9ab541089fede3dace6b1d44987cb1068c2f1793d3863b69"` [INFO] [stderr] Checking termcolor v1.0.3 [INFO] [stderr] Checking bech32 v0.5.0 [INFO] [stderr] Compiling secp256k1 v0.11.1 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking bitcoin-bech32 v0.8.0 [INFO] [stderr] Checking pretty_env_logger v0.2.4 [INFO] [stderr] Checking bitcoin v0.14.1 [INFO] [stderr] Checking big-transactions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | value: redeem.utxo.value - 10000000, // FIXME: a fixed fee is used [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:157:44 [INFO] [stderr] | [INFO] [stderr] 157 | value: redeem.utxo.value - 10000000, // FIXME: a fixed fee is used [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | .push_int(cltv as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(cltv)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:204:19 [INFO] [stderr] | [INFO] [stderr] 204 | .push_int(cltv as i64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(cltv)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `redeems` [INFO] [stderr] --> src/main.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | for i in 0..unsigned_transaction.input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 263 | for (i, ) in redeems.iter().enumerate().take(unsigned_transaction.input.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `redeems` [INFO] [stderr] --> src/main.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | for i in 0..unsigned_transaction.input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 263 | for (i, ) in redeems.iter().enumerate().take(unsigned_transaction.input.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.82s [INFO] running `"docker" "inspect" "df2ed844d7b6748a9ab541089fede3dace6b1d44987cb1068c2f1793d3863b69"` [INFO] running `"docker" "rm" "-f" "df2ed844d7b6748a9ab541089fede3dace6b1d44987cb1068c2f1793d3863b69"` [INFO] [stdout] df2ed844d7b6748a9ab541089fede3dace6b1d44987cb1068c2f1793d3863b69