[INFO] updating cached repository birkenfeld/fddf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/birkenfeld/fddf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/birkenfeld/fddf" "work/ex/clippy-test-run/sources/stable/gh/birkenfeld/fddf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/birkenfeld/fddf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/birkenfeld/fddf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/fddf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/fddf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 075fc8b05fbad748769ab2d55f473ba8c008606c [INFO] sha for GitHub repo birkenfeld/fddf: 075fc8b05fbad748769ab2d55f473ba8c008606c [INFO] validating manifest of birkenfeld/fddf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of birkenfeld/fddf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing birkenfeld/fddf [INFO] finished frobbing birkenfeld/fddf [INFO] frobbed toml for birkenfeld/fddf written to work/ex/clippy-test-run/sources/stable/gh/birkenfeld/fddf/Cargo.toml [INFO] started frobbing birkenfeld/fddf [INFO] finished frobbing birkenfeld/fddf [INFO] frobbed toml for birkenfeld/fddf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/fddf/Cargo.toml [INFO] crate birkenfeld/fddf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting birkenfeld/fddf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/birkenfeld/fddf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11ec7266e1e339f09f57d17a7bb47eb694933acf5d9cdecee106d544086c0f24 [INFO] running `"docker" "start" "-a" "11ec7266e1e339f09f57d17a7bb47eb694933acf5d9cdecee106d544086c0f24"` [INFO] [stderr] Checking scopeguard v0.1.2 [INFO] [stderr] Checking variance v0.1.3 [INFO] [stderr] Checking unbytify v0.2.0 [INFO] [stderr] Compiling structopt-derive v0.2.13 [INFO] [stderr] Checking scoped-pool v1.0.0 [INFO] [stderr] Checking structopt v0.2.13 [INFO] [stderr] Checking fddf v1.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | const GAPSIZE: i64 = 102400; [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:304:37 [INFO] [stderr] | [INFO] [stderr] 304 | / if fsize >= minsize && fsize <= maxsize { [INFO] [stderr] 305 | | if check_inode(&mut inodes, &dir_entry) { [INFO] [stderr] 306 | | if matches_pattern(&dir_entry) { [INFO] [stderr] 307 | | process(fsize, dir_entry); [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 304 | if fsize >= minsize && fsize <= maxsize && check_inode(&mut inodes, &dir_entry) { [INFO] [stderr] 305 | if matches_pattern(&dir_entry) { [INFO] [stderr] 306 | process(fsize, dir_entry); [INFO] [stderr] 307 | } [INFO] [stderr] 308 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:305:41 [INFO] [stderr] | [INFO] [stderr] 305 | / if check_inode(&mut inodes, &dir_entry) { [INFO] [stderr] 306 | | if matches_pattern(&dir_entry) { [INFO] [stderr] 307 | | process(fsize, dir_entry); [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 305 | if check_inode(&mut inodes, &dir_entry) && matches_pattern(&dir_entry) { [INFO] [stderr] 306 | process(fsize, dir_entry); [INFO] [stderr] 307 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | const GAPSIZE: i64 = 102400; [INFO] [stderr] | ^^^^^^ help: consider: `102_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:304:37 [INFO] [stderr] | [INFO] [stderr] 304 | / if fsize >= minsize && fsize <= maxsize { [INFO] [stderr] 305 | | if check_inode(&mut inodes, &dir_entry) { [INFO] [stderr] 306 | | if matches_pattern(&dir_entry) { [INFO] [stderr] 307 | | process(fsize, dir_entry); [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] 310 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 304 | if fsize >= minsize && fsize <= maxsize && check_inode(&mut inodes, &dir_entry) { [INFO] [stderr] 305 | if matches_pattern(&dir_entry) { [INFO] [stderr] 306 | process(fsize, dir_entry); [INFO] [stderr] 307 | } [INFO] [stderr] 308 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:305:41 [INFO] [stderr] | [INFO] [stderr] 305 | / if check_inode(&mut inodes, &dir_entry) { [INFO] [stderr] 306 | | if matches_pattern(&dir_entry) { [INFO] [stderr] 307 | | process(fsize, dir_entry); [INFO] [stderr] 308 | | } [INFO] [stderr] 309 | | } [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 305 | if check_inode(&mut inodes, &dir_entry) && matches_pattern(&dir_entry) { [INFO] [stderr] 306 | process(fsize, dir_entry); [INFO] [stderr] 307 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.69s [INFO] running `"docker" "inspect" "11ec7266e1e339f09f57d17a7bb47eb694933acf5d9cdecee106d544086c0f24"` [INFO] running `"docker" "rm" "-f" "11ec7266e1e339f09f57d17a7bb47eb694933acf5d9cdecee106d544086c0f24"` [INFO] [stdout] 11ec7266e1e339f09f57d17a7bb47eb694933acf5d9cdecee106d544086c0f24