[INFO] updating cached repository birkenfeld/ads_forwarder_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/birkenfeld/ads_forwarder_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/birkenfeld/ads_forwarder_rs" "work/ex/clippy-test-run/sources/stable/gh/birkenfeld/ads_forwarder_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/birkenfeld/ads_forwarder_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/birkenfeld/ads_forwarder_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/ads_forwarder_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/ads_forwarder_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04b62b3c13491d0090f6f0f3cfe7be6382397f37 [INFO] sha for GitHub repo birkenfeld/ads_forwarder_rs: 04b62b3c13491d0090f6f0f3cfe7be6382397f37 [INFO] validating manifest of birkenfeld/ads_forwarder_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of birkenfeld/ads_forwarder_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing birkenfeld/ads_forwarder_rs [INFO] finished frobbing birkenfeld/ads_forwarder_rs [INFO] frobbed toml for birkenfeld/ads_forwarder_rs written to work/ex/clippy-test-run/sources/stable/gh/birkenfeld/ads_forwarder_rs/Cargo.toml [INFO] started frobbing birkenfeld/ads_forwarder_rs [INFO] finished frobbing birkenfeld/ads_forwarder_rs [INFO] frobbed toml for birkenfeld/ads_forwarder_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/birkenfeld/ads_forwarder_rs/Cargo.toml [INFO] crate birkenfeld/ads_forwarder_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting birkenfeld/ads_forwarder_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/birkenfeld/ads_forwarder_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6d67f73ee671fc131478d31054f7fd62a93a7c951dbb91ac95c5422fc3a5244 [INFO] running `"docker" "start" "-a" "b6d67f73ee671fc131478d31054f7fd62a93a7c951dbb91ac95c5422fc3a5244"` [INFO] [stderr] Compiling pest v0.3.3 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling serde v1.0.81 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking dns-lookup v0.9.1 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Compiling aho-corasick v0.6.9 [INFO] [stderr] Checking parking_lot v0.7.0 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking crossbeam-channel v0.3.3 [INFO] [stderr] Checking mlzlog v0.5.1 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking signalbool v0.2.2 [INFO] [stderr] Compiling serde_json v1.0.33 [INFO] [stderr] Compiling handlebars v0.29.1 [INFO] [stderr] Compiling interfaces v0.0.4 [INFO] [stderr] Checking mlzutil v0.1.1 [INFO] [stderr] Checking ads_forwarder_rs v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/forwarder.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 261 | | if let Ok(ReadEvent::Msg(msg)) = event.recv(bh_chan) { [INFO] [stderr] 262 | | DistEvent::BeckhoffMessage(msg) [INFO] [stderr] 263 | | } else { [INFO] [stderr] 264 | | DistEvent::BeckhoffQuit [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 260 | } else if let Ok(ReadEvent::Msg(msg)) = event.recv(bh_chan) { [INFO] [stderr] 261 | DistEvent::BeckhoffMessage(msg) [INFO] [stderr] 262 | } else { [INFO] [stderr] 263 | DistEvent::BeckhoffQuit [INFO] [stderr] 264 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/forwarder.rs:260:20 [INFO] [stderr] | [INFO] [stderr] 260 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 261 | | if let Ok(ReadEvent::Msg(msg)) = event.recv(bh_chan) { [INFO] [stderr] 262 | | DistEvent::BeckhoffMessage(msg) [INFO] [stderr] 263 | | } else { [INFO] [stderr] 264 | | DistEvent::BeckhoffQuit [INFO] [stderr] 265 | | } [INFO] [stderr] 266 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 260 | } else if let Ok(ReadEvent::Msg(msg)) = event.recv(bh_chan) { [INFO] [stderr] 261 | DistEvent::BeckhoffMessage(msg) [INFO] [stderr] 262 | } else { [INFO] [stderr] 263 | DistEvent::BeckhoffQuit [INFO] [stderr] 264 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/scanner.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | name, ver[0], ver[1], ver[2] as u16 | (ver[3] as u16) << 8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(ver[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/scanner.rs:150:61 [INFO] [stderr] | [INFO] [stderr] 150 | name, ver[0], ver[1], ver[2] as u16 | (ver[3] as u16) << 8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(ver[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/forwarder.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | fn add_route(&self, netid: &AmsNetId, name: &str) -> FwdResult<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn is_zero(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn new(dstid: &AmsNetId, dstport: u16, srcid: &AmsNetId, srcport: u16, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:98:55 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn new(dstid: &AmsNetId, dstport: u16, srcid: &AmsNetId, srcport: u16, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:126:41 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn patch_dest_id(&mut self, id: &AmsNetId) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:130:43 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn patch_source_id(&mut self, id: &AmsNetId) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:160:32 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn new(op: u32, srcid: &AmsNetId, srcport: u16) -> UdpMessage> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/scanner.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | name, ver[0], ver[1], ver[2] as u16 | (ver[3] as u16) << 8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(ver[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/scanner.rs:150:61 [INFO] [stderr] | [INFO] [stderr] 150 | name, ver[0], ver[1], ver[2] as u16 | (ver[3] as u16) << 8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(ver[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/forwarder.rs:59:32 [INFO] [stderr] | [INFO] [stderr] 59 | fn add_route(&self, netid: &AmsNetId, name: &str) -> FwdResult<()> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn is_zero(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:98:23 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn new(dstid: &AmsNetId, dstport: u16, srcid: &AmsNetId, srcport: u16, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:98:55 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn new(dstid: &AmsNetId, dstport: u16, srcid: &AmsNetId, srcport: u16, [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:126:41 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn patch_dest_id(&mut self, id: &AmsNetId) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:130:43 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn patch_source_id(&mut self, id: &AmsNetId) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:160:32 [INFO] [stderr] | [INFO] [stderr] 160 | pub fn new(op: u32, srcid: &AmsNetId, srcport: u16) -> UdpMessage> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `AmsNetId` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 56.50s [INFO] running `"docker" "inspect" "b6d67f73ee671fc131478d31054f7fd62a93a7c951dbb91ac95c5422fc3a5244"` [INFO] running `"docker" "rm" "-f" "b6d67f73ee671fc131478d31054f7fd62a93a7c951dbb91ac95c5422fc3a5244"` [INFO] [stdout] b6d67f73ee671fc131478d31054f7fd62a93a7c951dbb91ac95c5422fc3a5244