[INFO] updating cached repository binary132/rlua-repl-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/binary132/rlua-repl-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/binary132/rlua-repl-test" "work/ex/clippy-test-run/sources/stable/gh/binary132/rlua-repl-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/binary132/rlua-repl-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/binary132/rlua-repl-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binary132/rlua-repl-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binary132/rlua-repl-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 860dd7cc4c09f4ca48e1f02f44356b4cec22212a [INFO] sha for GitHub repo binary132/rlua-repl-test: 860dd7cc4c09f4ca48e1f02f44356b4cec22212a [INFO] validating manifest of binary132/rlua-repl-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of binary132/rlua-repl-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing binary132/rlua-repl-test [INFO] finished frobbing binary132/rlua-repl-test [INFO] frobbed toml for binary132/rlua-repl-test written to work/ex/clippy-test-run/sources/stable/gh/binary132/rlua-repl-test/Cargo.toml [INFO] started frobbing binary132/rlua-repl-test [INFO] finished frobbing binary132/rlua-repl-test [INFO] frobbed toml for binary132/rlua-repl-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/binary132/rlua-repl-test/Cargo.toml [INFO] crate binary132/rlua-repl-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting binary132/rlua-repl-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/binary132/rlua-repl-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78f81703f23d7fad9b70b1ab44fc5a72b9432834395f82350f33b80acafb65f9 [INFO] running `"docker" "start" "-a" "78f81703f23d7fad9b70b1ab44fc5a72b9432834395f82350f33b80acafb65f9"` [INFO] [stderr] Compiling rlua v0.9.7 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Compiling structopt-derive v0.1.5 [INFO] [stderr] Checking structopt v0.1.5 [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:45:65 [INFO] [stderr] | [INFO] [stderr] 45 | Err(rlua::Error::RuntimeError(e)) => Ok(MultiLine::Done(format!("{}", e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if accum.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `accum.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if accum.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `accum.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | Err(format!("C-d")) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"C-d".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | Err(ReadlineError::Interrupted) => Err(format!("C-c")), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"C-c".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | format!("") [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:45:65 [INFO] [stderr] | [INFO] [stderr] 45 | Err(rlua::Error::RuntimeError(e)) => Ok(MultiLine::Done(format!("{}", e))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if accum.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `accum.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if accum.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `accum.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | Err(format!("C-d")) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"C-d".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:103:48 [INFO] [stderr] | [INFO] [stderr] 103 | Err(ReadlineError::Interrupted) => Err(format!("C-c")), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"C-c".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.64s [INFO] running `"docker" "inspect" "78f81703f23d7fad9b70b1ab44fc5a72b9432834395f82350f33b80acafb65f9"` [INFO] running `"docker" "rm" "-f" "78f81703f23d7fad9b70b1ab44fc5a72b9432834395f82350f33b80acafb65f9"` [INFO] [stdout] 78f81703f23d7fad9b70b1ab44fc5a72b9432834395f82350f33b80acafb65f9