[INFO] updating cached repository bike-barn/hermit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bike-barn/hermit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bike-barn/hermit" "work/ex/clippy-test-run/sources/stable/gh/bike-barn/hermit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bike-barn/hermit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bike-barn/hermit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bike-barn/hermit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bike-barn/hermit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 122d769ff06ff0efd49e2ecffabf03f3ff84abbd [INFO] sha for GitHub repo bike-barn/hermit: 122d769ff06ff0efd49e2ecffabf03f3ff84abbd [INFO] validating manifest of bike-barn/hermit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bike-barn/hermit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bike-barn/hermit [INFO] finished frobbing bike-barn/hermit [INFO] frobbed toml for bike-barn/hermit written to work/ex/clippy-test-run/sources/stable/gh/bike-barn/hermit/Cargo.toml [INFO] started frobbing bike-barn/hermit [INFO] finished frobbing bike-barn/hermit [INFO] frobbed toml for bike-barn/hermit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bike-barn/hermit/Cargo.toml [INFO] crate bike-barn/hermit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bike-barn/hermit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bike-barn/hermit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f18e0b1771b162640d4709a8fc9fc6fcadcb988d2811c747bbe131fc30a7b0ad [INFO] running `"docker" "start" "-a" "f18e0b1771b162640d4709a8fc9fc6fcadcb988d2811c747bbe131fc30a7b0ad"` [INFO] [stderr] Checking matches v0.1.2 [INFO] [stderr] Compiling metadeps v1.1.2 [INFO] [stderr] Compiling libz-sys v1.0.6 [INFO] [stderr] Compiling cmake v0.1.17 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.4 [INFO] [stderr] Compiling openssl-sys v0.9.6 [INFO] [stderr] Checking idna v0.1.4 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking url v1.6.0 [INFO] [stderr] Checking git2 v0.7.2 [INFO] [stderr] Checking hermit v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/main.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | pub use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | env::home_dir().map(|home| home.join(".config/hermit")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | let home_dir = env::home_dir().expect("Could not determine home directory."); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `let_and_return` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:86:44 [INFO] [stderr] | [INFO] [stderr] 86 | #[cfg_attr(feature = "cargo-clippy", allow(let_and_return))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::let_and_return` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env.rs:4:9 [INFO] [stderr] | [INFO] [stderr] 4 | pub use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/env.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | env::home_dir().map(|home| home.join(".config/hermit")) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | let home_dir = env::home_dir().expect("Could not determine home directory."); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `path_for` [INFO] [stderr] --> src/shell.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn path_for(&self, filename: &str) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MkDir` [INFO] [stderr] --> src/file_operations.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | MkDir(PathBuf), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `operations` [INFO] [stderr] --> src/file_operations.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn operations(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `create_dir` [INFO] [stderr] --> src/file_operations.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | pub fn create_dir(&mut self, name: impl AsRef) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: missing documentation for crate [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / #![warn(missing_docs)] [INFO] [stderr] 2 | | extern crate clap; [INFO] [stderr] 3 | | extern crate failure; [INFO] [stderr] 4 | | #[macro_use] [INFO] [stderr] ... | [INFO] [stderr] 253 | | Err(Error::SubcommandNotImplemented(name)) [INFO] [stderr] 254 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![warn(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/test_helpers/filesystem.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | / write!(io::stderr(), [INFO] [stderr] 12 | | "\nRemove didn't find dir '{}'", [INFO] [stderr] 13 | | test_root.display()) [INFO] [stderr] 14 | | .unwrap(); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> src/test_helpers/filesystem.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | / write!(io::stderr(), [INFO] [stderr] 34 | | "\nDir '{}' was already present\n", [INFO] [stderr] 35 | | test_root.display()) [INFO] [stderr] 36 | | .unwrap(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 09s [INFO] running `"docker" "inspect" "f18e0b1771b162640d4709a8fc9fc6fcadcb988d2811c747bbe131fc30a7b0ad"` [INFO] running `"docker" "rm" "-f" "f18e0b1771b162640d4709a8fc9fc6fcadcb988d2811c747bbe131fc30a7b0ad"` [INFO] [stdout] f18e0b1771b162640d4709a8fc9fc6fcadcb988d2811c747bbe131fc30a7b0ad