[INFO] updating cached repository bielr/biotrees-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bielr/biotrees-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bielr/biotrees-rs" "work/ex/clippy-test-run/sources/stable/gh/bielr/biotrees-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bielr/biotrees-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bielr/biotrees-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bielr/biotrees-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bielr/biotrees-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f832804f9a4d4dc24e1c165cf0362387a4115d60
[INFO] sha for GitHub repo bielr/biotrees-rs: f832804f9a4d4dc24e1c165cf0362387a4115d60
[INFO] validating manifest of bielr/biotrees-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bielr/biotrees-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bielr/biotrees-rs
[INFO] finished frobbing bielr/biotrees-rs
[INFO] frobbed toml for bielr/biotrees-rs written to work/ex/clippy-test-run/sources/stable/gh/bielr/biotrees-rs/Cargo.toml
[INFO] started frobbing bielr/biotrees-rs
[INFO] finished frobbing bielr/biotrees-rs
[INFO] frobbed toml for bielr/biotrees-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bielr/biotrees-rs/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bielr/biotrees-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bielr/biotrees-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aa90629f70c1eed43df2f4c2780a5442ad630eab9efd187b1b26f32e7521604e
[INFO] running `"docker" "start" "-a" "aa90629f70c1eed43df2f4c2780a5442ad630eab9efd187b1b26f32e7521604e"`
[INFO] [stderr]    Compiling autocfg v0.1.2
[INFO] [stderr]     Checking rand_core v0.4.0
[INFO] [stderr]    Compiling arrayvec v0.4.10
[INFO] [stderr]     Checking lock_api v0.1.5
[INFO] [stderr]     Checking num_cpus v1.9.0
[INFO] [stderr]    Compiling rand_chacha v0.1.1
[INFO] [stderr]    Compiling rand v0.6.5
[INFO] [stderr]     Checking rand_core v0.3.1
[INFO] [stderr]     Checking rand_jitter v0.1.0
[INFO] [stderr]     Checking rand_hc v0.1.0
[INFO] [stderr]     Checking rand_os v0.1.1
[INFO] [stderr]     Checking rand_xorshift v0.1.1
[INFO] [stderr]     Checking rand_isaac v0.1.1
[INFO] [stderr]     Checking rand_pcg v0.1.1
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking rayon v1.0.3
[INFO] [stderr]     Checking parking_lot_core v0.4.0
[INFO] [stderr]     Checking parking_lot v0.7.1
[INFO] [stderr]     Checking once_cell v0.1.7
[INFO] [stderr]     Checking cached v0.8.0
[INFO] [stderr]     Checking biotrees v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/shape/balance.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |             quartets: quartets,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `quartets`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/shape/balance.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             triplets: triplets,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `triplets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/shape/balance.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             kappa: kappa
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `kappa`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/shape/balance.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |             quartets: quartets,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `quartets`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/shape/balance.rs:172:13
[INFO] [stderr]     |
[INFO] [stderr] 172 |             triplets: triplets,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `triplets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/shape/balance.rs:173:13
[INFO] [stderr]     |
[INFO] [stderr] 173 |             kappa: kappa
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `kappa`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/phylo/mod.rs:108:25
[INFO] [stderr]     |
[INFO] [stderr] 108 |                         return Ordering::Equal;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/shape/balance.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |         return r.quartets;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r.quartets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/phylo/mod.rs:108:25
[INFO] [stderr]     |
[INFO] [stderr] 108 |                         return Ordering::Equal;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ordering::Equal`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/shape/balance.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |         return r.quartets;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `r.quartets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/phylo/mod.rs:68:17
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 [x].iter().map(|&x| x).collect()
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[x].iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/phylo/mod.rs:68:17
[INFO] [stderr]    |
[INFO] [stderr] 68 |                 [x].iter().map(|&x| x).collect()
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `[x].iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/phylo/mod.rs:172:25
[INFO] [stderr]     |
[INFO] [stderr] 172 | /                         ts1.iter().zip(ts2.iter())
[INFO] [stderr] 173 | |                             .map(|(t1, t2)| t1.cmp(t2))
[INFO] [stderr] 174 | |                             .filter(|&o| o != Ordering::Equal)
[INFO] [stderr] 175 | |                             .next()
[INFO] [stderr]     | |___________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|&o| o != Ordering::Equal).next()` with `find(|&o| o != Ordering::Equal)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/phylo/mod.rs:172:25
[INFO] [stderr]     |
[INFO] [stderr] 172 | /                         ts1.iter().zip(ts2.iter())
[INFO] [stderr] 173 | |                             .map(|(t1, t2)| t1.cmp(t2))
[INFO] [stderr] 174 | |                             .filter(|&o| o != Ordering::Equal)
[INFO] [stderr] 175 | |                             .next()
[INFO] [stderr]     | |___________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|&o| o != Ordering::Equal).next()` with `find(|&o| o != Ordering::Equal)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/shape/generator.rs:22:44
[INFO] [stderr]    |
[INFO] [stderr] 22 |     match ts.iter().enumerate().find(|i_t| i_t.1 >= &t2).map(|i_t| i_t.0) {
[INFO] [stderr]    |                                            ^^^^^^^^^---
[INFO] [stderr]    |                                                     |
[INFO] [stderr]    |                                                     help: use the right value directly: `t2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/shape/generator.rs:22:44
[INFO] [stderr]    |
[INFO] [stderr] 22 |     match ts.iter().enumerate().find(|i_t| i_t.1 >= &t2).map(|i_t| i_t.0) {
[INFO] [stderr]    |                                            ^^^^^^^^^---
[INFO] [stderr]    |                                                     |
[INFO] [stderr]    |                                                     help: use the right value directly: `t2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> examples/enum_balance.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     avg
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> examples/enum_balance.rs:50:15
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let avg = depths.iter().sum::<u32>() as f64 / depths.len() as f64;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> examples/enum_balance.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 |     var
[INFO] [stderr]    |     ^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> examples/enum_balance.rs:58:15
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let var = depths.iter().map(|depth| (*depth as f64 - avg).powi(2)).sum::<f64>() / depths.len() as f64;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `sym_desc_half`
[INFO] [stderr]   --> examples/enum_balance.rs:10:1
[INFO] [stderr]    |
[INFO] [stderr] 10 | fn sym_desc_half(t: &Shape) -> u32 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `sym_desc`
[INFO] [stderr]   --> examples/enum_balance.rs:29:1
[INFO] [stderr]    |
[INFO] [stderr] 29 | fn sym_desc(t: &Shape) -> u32 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `depth_avg`
[INFO] [stderr]   --> examples/enum_balance.rs:48:1
[INFO] [stderr]    |
[INFO] [stderr] 48 | fn depth_avg<T>(t: &Phylo<T>) -> f64 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `depth_var`
[INFO] [stderr]   --> examples/enum_balance.rs:55:1
[INFO] [stderr]    |
[INFO] [stderr] 55 | fn depth_var<T>(t: &Phylo<T>) -> f64 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> examples/enum_balance.rs:50:15
[INFO] [stderr]    |
[INFO] [stderr] 50 |     let avg = depths.iter().sum::<u32>() as f64 / depths.len() as f64;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(depths.iter().sum::<u32>())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> examples/enum_balance.rs:57:15
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let avg = depths.iter().sum::<u32>() as f64 / depths.len() as f64;
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(depths.iter().sum::<u32>())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> examples/enum_balance.rs:58:42
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let var = depths.iter().map(|depth| (*depth as f64 - avg).powi(2)).sum::<f64>() / depths.len() as f64;
[INFO] [stderr]    |                                          ^^^^^^^^^^^^^ help: try: `f64::from(*depth)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.95s
[INFO] running `"docker" "inspect" "aa90629f70c1eed43df2f4c2780a5442ad630eab9efd187b1b26f32e7521604e"`
[INFO] running `"docker" "rm" "-f" "aa90629f70c1eed43df2f4c2780a5442ad630eab9efd187b1b26f32e7521604e"`
[INFO] [stdout] aa90629f70c1eed43df2f4c2780a5442ad630eab9efd187b1b26f32e7521604e