[INFO] updating cached repository bidipeppercrap/spelltest.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bidipeppercrap/spelltest.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bidipeppercrap/spelltest.rs" "work/ex/clippy-test-run/sources/stable/gh/bidipeppercrap/spelltest.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bidipeppercrap/spelltest.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bidipeppercrap/spelltest.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bidipeppercrap/spelltest.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bidipeppercrap/spelltest.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da9c8ff30b2aae74af948881218b4a42266cb9e9 [INFO] sha for GitHub repo bidipeppercrap/spelltest.rs: da9c8ff30b2aae74af948881218b4a42266cb9e9 [INFO] validating manifest of bidipeppercrap/spelltest.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bidipeppercrap/spelltest.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bidipeppercrap/spelltest.rs [INFO] finished frobbing bidipeppercrap/spelltest.rs [INFO] frobbed toml for bidipeppercrap/spelltest.rs written to work/ex/clippy-test-run/sources/stable/gh/bidipeppercrap/spelltest.rs/Cargo.toml [INFO] started frobbing bidipeppercrap/spelltest.rs [INFO] finished frobbing bidipeppercrap/spelltest.rs [INFO] frobbed toml for bidipeppercrap/spelltest.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bidipeppercrap/spelltest.rs/Cargo.toml [INFO] crate bidipeppercrap/spelltest.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bidipeppercrap/spelltest.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bidipeppercrap/spelltest.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d85278c5f7cbb2cd15f231f5d4134d7db1dc5892d9559675233023e87f6d1b54 [INFO] running `"docker" "start" "-a" "d85278c5f7cbb2cd15f231f5d4134d7db1dc5892d9559675233023e87f6d1b54"` [INFO] [stderr] Checking spelltest v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/character.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | fn attacked(&mut self, damage: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/attack.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | fn damage_multiplier(defense: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/attack.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn damage_dealt(damage: &f64, defense: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/attack.rs:5:44 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn damage_dealt(damage: &f64, defense: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/character.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | fn attacked(&mut self, damage: &f64) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/attack.rs:1:31 [INFO] [stderr] | [INFO] [stderr] 1 | fn damage_multiplier(defense: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/attack.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn damage_dealt(damage: &f64, defense: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/attack.rs:5:44 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn damage_dealt(damage: &f64, defense: &f64) -> f64 { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "d85278c5f7cbb2cd15f231f5d4134d7db1dc5892d9559675233023e87f6d1b54"` [INFO] running `"docker" "rm" "-f" "d85278c5f7cbb2cd15f231f5d4134d7db1dc5892d9559675233023e87f6d1b54"` [INFO] [stdout] d85278c5f7cbb2cd15f231f5d4134d7db1dc5892d9559675233023e87f6d1b54