[INFO] updating cached repository bgmarx/recommender
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bgmarx/recommender
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bgmarx/recommender" "work/ex/clippy-test-run/sources/stable/gh/bgmarx/recommender"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bgmarx/recommender'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bgmarx/recommender" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bgmarx/recommender"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bgmarx/recommender'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] db93a013d779f4cbfc6146ebca9045c0f19a84c4
[INFO] sha for GitHub repo bgmarx/recommender: db93a013d779f4cbfc6146ebca9045c0f19a84c4
[INFO] validating manifest of bgmarx/recommender on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bgmarx/recommender on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bgmarx/recommender
[INFO] finished frobbing bgmarx/recommender
[INFO] frobbed toml for bgmarx/recommender written to work/ex/clippy-test-run/sources/stable/gh/bgmarx/recommender/Cargo.toml
[INFO] started frobbing bgmarx/recommender
[INFO] finished frobbing bgmarx/recommender
[INFO] frobbed toml for bgmarx/recommender written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bgmarx/recommender/Cargo.toml
[INFO] crate bgmarx/recommender has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bgmarx/recommender against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bgmarx/recommender:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2d02a851258b04b5a41213331735c71fa3d243c6934d5f9895cefc7a1daeaf39
[INFO] running `"docker" "start" "-a" "2d02a851258b04b5a41213331735c71fa3d243c6934d5f9895cefc7a1daeaf39"`
[INFO] [stderr]    Compiling serde v1.0.70
[INFO] [stderr]    Compiling ndarray v0.11.2
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking tokio-reactor v0.1.2
[INFO] [stderr]     Checking tokio-threadpool v0.1.5
[INFO] [stderr]     Checking failure v0.1.2
[INFO] [stderr]     Checking hibitset v0.5.1
[INFO] [stderr]     Checking csv-core v0.1.4
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.1
[INFO] [stderr]     Checking tokio-fs v0.1.2
[INFO] [stderr]     Checking tokio v0.1.7
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking hyper v0.11.27
[INFO] [stderr]     Checking rand_core v0.2.1
[INFO] [stderr]     Checking smallvec v0.5.1
[INFO] [stderr]     Checking serde_urlencoded v0.5.2
[INFO] [stderr]     Checking serde_json v1.0.24
[INFO] [stderr]     Checking bincode v0.9.2
[INFO] [stderr]     Checking csv v1.0.0
[INFO] [stderr]     Checking rand v0.5.4
[INFO] [stderr]     Checking hyper-tls v0.1.4
[INFO] [stderr]     Checking reqwest v0.8.7
[INFO] [stderr]     Checking wyrm v0.9.1
[INFO] [stderr]     Checking sbr v0.4.0
[INFO] [stderr]     Checking goodbooks-recommender v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/main.rs:219:16
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return ();
[INFO] [stderr]     |                ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/main.rs:325:16
[INFO] [stderr]     |
[INFO] [stderr] 325 |         return ();
[INFO] [stderr]     |                ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/main.rs:219:16
[INFO] [stderr]     |
[INFO] [stderr] 219 |         return ();
[INFO] [stderr]     |                ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded `()`
[INFO] [stderr]    --> src/main.rs:325:16
[INFO] [stderr]     |
[INFO] [stderr] 325 |         return ();
[INFO] [stderr]     |                ^^ help: remove the `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `title_to_id`
[INFO] [stderr]    --> src/main.rs:226:10
[INFO] [stderr]     |
[INFO] [stderr] 226 |          title_to_id) = deserialize_books(books_path).unwrap();
[INFO] [stderr]     |          ^^^^^^^^^^^ help: consider using `_title_to_id` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `title_to_id`
[INFO] [stderr]    --> src/main.rs:226:10
[INFO] [stderr]     |
[INFO] [stderr] 226 |          title_to_id) = deserialize_books(books_path).unwrap();
[INFO] [stderr]     |          ^^^^^^^^^^^ help: consider using `_title_to_id` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/main.rs:94:7
[INFO] [stderr]    |
[INFO] [stderr] 94 |      -> Result<(HashMap<usize, String>,
[INFO] [stderr]    |  _______^
[INFO] [stderr] 95 | |               HashMap<String, usize>), failure::Error> {
[INFO] [stderr]    | |______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/main.rs:204:8
[INFO] [stderr]     |
[INFO] [stderr] 204 |     Ok(serde_json::to_writer(&mut writer, model)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 204 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:302:24
[INFO] [stderr]     |
[INFO] [stderr] 302 |        .map(|(idx, _)| id_to_title.get(idx).unwrap())
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&id_to_title[idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/main.rs:94:7
[INFO] [stderr]    |
[INFO] [stderr] 94 |      -> Result<(HashMap<usize, String>,
[INFO] [stderr]    |  _______^
[INFO] [stderr] 95 | |               HashMap<String, usize>), failure::Error> {
[INFO] [stderr]    | |______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/main.rs:204:8
[INFO] [stderr]     |
[INFO] [stderr] 204 |     Ok(serde_json::to_writer(&mut writer, model)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 204 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/main.rs:302:24
[INFO] [stderr]     |
[INFO] [stderr] 302 |        .map(|(idx, _)| id_to_title.get(idx).unwrap())
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&id_to_title[idx]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 51.87s
[INFO] running `"docker" "inspect" "2d02a851258b04b5a41213331735c71fa3d243c6934d5f9895cefc7a1daeaf39"`
[INFO] running `"docker" "rm" "-f" "2d02a851258b04b5a41213331735c71fa3d243c6934d5f9895cefc7a1daeaf39"`
[INFO] [stdout] 2d02a851258b04b5a41213331735c71fa3d243c6934d5f9895cefc7a1daeaf39