[INFO] updating cached repository bgermann/offwall
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bgermann/offwall
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bgermann/offwall" "work/ex/clippy-test-run/sources/stable/gh/bgermann/offwall"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bgermann/offwall'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bgermann/offwall" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bgermann/offwall"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bgermann/offwall'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bb7fed1639b9623a82bb577a4b8ae77add2c94a1
[INFO] sha for GitHub repo bgermann/offwall: bb7fed1639b9623a82bb577a4b8ae77add2c94a1
[INFO] validating manifest of bgermann/offwall on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bgermann/offwall on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bgermann/offwall
[INFO] finished frobbing bgermann/offwall
[INFO] frobbed toml for bgermann/offwall written to work/ex/clippy-test-run/sources/stable/gh/bgermann/offwall/Cargo.toml
[INFO] started frobbing bgermann/offwall
[INFO] finished frobbing bgermann/offwall
[INFO] frobbed toml for bgermann/offwall written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bgermann/offwall/Cargo.toml
[INFO] crate bgermann/offwall has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bgermann/offwall against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bgermann/offwall:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c0b5edcfd5cc4a0f0de0b85ab4756914d5ce50155d576c0aa3abd54fa70d6912
[INFO] running `"docker" "start" "-a" "c0b5edcfd5cc4a0f0de0b85ab4756914d5ce50155d576c0aa3abd54fa70d6912"`
[INFO] [stderr]     Checking tls-api v0.1.20
[INFO] [stderr]     Checking log-panics v2.0.0
[INFO] [stderr]     Checking simple_logger v0.5.0
[INFO] [stderr]     Checking syslog v4.0.1
[INFO] [stderr]     Checking ipnetwork v0.13.1
[INFO] [stderr]     Checking inotify v0.6.1
[INFO] [stderr]     Checking notify v4.0.6
[INFO] [stderr]     Checking offwall v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::fs::File`
[INFO] [stderr]   --> src/conf.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 | use std::fs::File;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Read`
[INFO] [stderr]   --> src/conf.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | use std::io::Read;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `tls_api`
[INFO] [stderr]   --> src/conf.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 | use tls_api;
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `tls_api::TlsAcceptorBuilder`
[INFO] [stderr]   --> src/conf.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | use tls_api::TlsAcceptorBuilder;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fs::File`
[INFO] [stderr]   --> src/conf.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 | use std::fs::File;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::io::Read`
[INFO] [stderr]   --> src/conf.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | use std::io::Read;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `tls_api`
[INFO] [stderr]   --> src/conf.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 | use tls_api;
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `tls_api::TlsAcceptorBuilder`
[INFO] [stderr]   --> src/conf.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | use tls_api::TlsAcceptorBuilder;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/openflow/messages/deserialize.rs:150:18
[INFO] [stderr]     |
[INFO] [stderr] 150 |             xid: 0x12345678,
[INFO] [stderr]     |                  ^^^^^^^^^^ help: consider: `0x1234_5678`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/openflow/messages/serialize.rs:329:45
[INFO] [stderr]     |
[INFO] [stderr] 329 |         let testee = OfpOxmTlv::new_in_port(0x11223344);
[INFO] [stderr]     |                                             ^^^^^^^^^^ help: consider: `0x1122_3344`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/openflow/messages/serialize.rs:348:43
[INFO] [stderr]     |
[INFO] [stderr] 348 |         let testee = OfpActionOutput::new(0x11223344);
[INFO] [stderr]     |                                           ^^^^^^^^^^ help: consider: `0x1122_3344`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `P12_KEY`
[INFO] [stderr]   --> src/conf.rs:65:1
[INFO] [stderr]    |
[INFO] [stderr] 65 | const P12_KEY: &str = "pkcs12";
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `PASS_KEY`
[INFO] [stderr]   --> src/conf.rs:66:1
[INFO] [stderr]    |
[INFO] [stderr] 66 | const PASS_KEY: &str = "passwd";
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Tls`
[INFO] [stderr]   --> src/openflow/mod.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 |     Tls(TlsStream<TcpStream>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/openflow/messages/deserialize.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn deserialize(bytes: &[u8; 8]) -> OfpHeader {
[INFO] [stderr]    |                               ^^^^^^^^ help: consider passing by value instead: `[u8; 8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/openflow/messages/mod.rs:329:32
[INFO] [stderr]     |
[INFO] [stderr] 329 |     pub fn new_ip_proto(proto: &IpProtocol) -> OfpOxmTlv {
[INFO] [stderr]     |                                ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/openflow/messages/mod.rs:337:27
[INFO] [stderr]     |
[INFO] [stderr] 337 |     pub fn new_ipv4(cidr: &Ipv4Network, endpoint: &ProtocolEndpoint) -> OfpOxmTlv {
[INFO] [stderr]     |                           ^^^^^^^^^^^^ help: consider passing by value instead: `Ipv4Network`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/openflow/messages/mod.rs:354:16
[INFO] [stderr]     |
[INFO] [stderr] 354 |         proto: &IpProtocol,
[INFO] [stderr]     |                ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `P12_KEY`
[INFO] [stderr]   --> src/conf.rs:65:1
[INFO] [stderr]    |
[INFO] [stderr] 65 | const P12_KEY: &str = "pkcs12";
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `PASS_KEY`
[INFO] [stderr]   --> src/conf.rs:66:1
[INFO] [stderr]    |
[INFO] [stderr] 66 | const PASS_KEY: &str = "passwd";
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Tls`
[INFO] [stderr]   --> src/openflow/mod.rs:47:5
[INFO] [stderr]    |
[INFO] [stderr] 47 |     Tls(TlsStream<TcpStream>),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/openflow/messages/deserialize.rs:17:31
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn deserialize(bytes: &[u8; 8]) -> OfpHeader {
[INFO] [stderr]    |                               ^^^^^^^^ help: consider passing by value instead: `[u8; 8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/openflow/messages/mod.rs:329:32
[INFO] [stderr]     |
[INFO] [stderr] 329 |     pub fn new_ip_proto(proto: &IpProtocol) -> OfpOxmTlv {
[INFO] [stderr]     |                                ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/openflow/messages/mod.rs:337:27
[INFO] [stderr]     |
[INFO] [stderr] 337 |     pub fn new_ipv4(cidr: &Ipv4Network, endpoint: &ProtocolEndpoint) -> OfpOxmTlv {
[INFO] [stderr]     |                           ^^^^^^^^^^^^ help: consider passing by value instead: `Ipv4Network`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/openflow/messages/mod.rs:354:16
[INFO] [stderr]     |
[INFO] [stderr] 354 |         proto: &IpProtocol,
[INFO] [stderr]     |                ^^^^^^^^^^^ help: consider passing by value instead: `IpProtocol`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.72s
[INFO] running `"docker" "inspect" "c0b5edcfd5cc4a0f0de0b85ab4756914d5ce50155d576c0aa3abd54fa70d6912"`
[INFO] running `"docker" "rm" "-f" "c0b5edcfd5cc4a0f0de0b85ab4756914d5ce50155d576c0aa3abd54fa70d6912"`
[INFO] [stdout] c0b5edcfd5cc4a0f0de0b85ab4756914d5ce50155d576c0aa3abd54fa70d6912