[INFO] updating cached repository bestrauc/Advent-of-Code-2018
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bestrauc/Advent-of-Code-2018
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bestrauc/Advent-of-Code-2018" "work/ex/clippy-test-run/sources/stable/gh/bestrauc/Advent-of-Code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bestrauc/Advent-of-Code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bestrauc/Advent-of-Code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bestrauc/Advent-of-Code-2018"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bestrauc/Advent-of-Code-2018'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 17ecbeb446ec7d2fcddcf62c3f1d9f46c4b2200a
[INFO] sha for GitHub repo bestrauc/Advent-of-Code-2018: 17ecbeb446ec7d2fcddcf62c3f1d9f46c4b2200a
[INFO] validating manifest of bestrauc/Advent-of-Code-2018 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bestrauc/Advent-of-Code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bestrauc/Advent-of-Code-2018
[INFO] finished frobbing bestrauc/Advent-of-Code-2018
[INFO] frobbed toml for bestrauc/Advent-of-Code-2018 written to work/ex/clippy-test-run/sources/stable/gh/bestrauc/Advent-of-Code-2018/Cargo.toml
[INFO] started frobbing bestrauc/Advent-of-Code-2018
[INFO] finished frobbing bestrauc/Advent-of-Code-2018
[INFO] frobbed toml for bestrauc/Advent-of-Code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bestrauc/Advent-of-Code-2018/Cargo.toml
[INFO] crate bestrauc/Advent-of-Code-2018 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bestrauc/Advent-of-Code-2018 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bestrauc/Advent-of-Code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1543bfda79c5f761701562299b87948d9e5de4d6691074013b89d57d4e45f15b
[INFO] running `"docker" "start" "-a" "1543bfda79c5f761701562299b87948d9e5de4d6691074013b89d57d4e45f15b"`
[INFO] [stderr]     Checking linked-list v0.0.3
[INFO] [stderr]     Checking binary-heap-plus v0.1.4
[INFO] [stderr]     Checking aoc_2018 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent1.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent1.rs:91:18
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let result = sum_frequencies(&freq_vector);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent1.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent1.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |     let result = get_repeated_freq(&freq_vector);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent3.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     val_count
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent3.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |       let val_count = count_matrix.iter()
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 52 | |         .flatten()
[INFO] [stderr] 53 | |         .map(|&count| (count > 1) as u32)
[INFO] [stderr] 54 | |         .sum();
[INFO] [stderr]    | |______________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent4.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 | pub fn solution1() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent4.rs:107:20
[INFO] [stderr]     |
[INFO] [stderr] 107 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent5.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     filtered_polys
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent5.rs:41:26
[INFO] [stderr]    |
[INFO] [stderr] 41 |       let filtered_polys = character_set.iter().map(|ref_c| {
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 42 | |         let filtered_polymer = polymer
[INFO] [stderr] 43 | |             .chars()
[INFO] [stderr] 44 | |             .filter(|c| c.to_ascii_uppercase() != *ref_c)
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |             (*ref_c, filtered_polymer)
[INFO] [stderr] 48 | |     }).collect::<Vec<_>>();
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent5.rs:56:20
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn solution1() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent5.rs:64:20
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn solution2() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/advent6.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return (b-a) as u32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(b-a) as u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/advent6.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return (a-b) as u32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a-b) as u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent6.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     dists_to_coords
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent6.rs:44:27
[INFO] [stderr]    |
[INFO] [stderr] 44 |       let dists_to_coords = coords.iter()
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 45 | |         .map(|ipos| (ipos.clone(), dist(ipos, pos)))
[INFO] [stderr] 46 | |         .collect::<Vec<_>>();
[INFO] [stderr]    | |____________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent6.rs:146:20
[INFO] [stderr]     |
[INFO] [stderr] 146 | pub fn solution1() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent6.rs:157:20
[INFO] [stderr]     |
[INFO] [stderr] 157 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `MinComparator`
[INFO] [stderr]  --> src/solutions/advent7.rs:3:36
[INFO] [stderr]   |
[INFO] [stderr] 3 | use binary_heap_plus::{BinaryHeap, MinComparator};
[INFO] [stderr]   |                                    ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::cmp`
[INFO] [stderr]  --> src/solutions/advent7.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::cmp;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent7.rs:143:20
[INFO] [stderr]     |
[INFO] [stderr] 143 | pub fn solution1() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent7.rs:152:20
[INFO] [stderr]     |
[INFO] [stderr] 152 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent8.rs:81:20
[INFO] [stderr]    |
[INFO] [stderr] 81 | pub fn solution1() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent8.rs:94:20
[INFO] [stderr]    |
[INFO] [stderr] 94 | pub fn solution2() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `solutions::utils`
[INFO] [stderr]  --> src/solutions/advent9.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use solutions::utils;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent9.rs:101:20
[INFO] [stderr]     |
[INFO] [stderr] 101 | pub fn solution1() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent9.rs:110:20
[INFO] [stderr]     |
[INFO] [stderr] 110 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent1.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent1.rs:91:18
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let result = sum_frequencies(&freq_vector);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent1.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent1.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |     let result = get_repeated_freq(&freq_vector);
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent3.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     val_count
[INFO] [stderr]    |     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent3.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |       let val_count = count_matrix.iter()
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 52 | |         .flatten()
[INFO] [stderr] 53 | |         .map(|&count| (count > 1) as u32)
[INFO] [stderr] 54 | |         .sum();
[INFO] [stderr]    | |______________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent4.rs:86:20
[INFO] [stderr]    |
[INFO] [stderr] 86 | pub fn solution1() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent4.rs:107:20
[INFO] [stderr]     |
[INFO] [stderr] 107 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]    --> src/solutions/advent4.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |     use super::*;
[INFO] [stderr]     |         ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent5.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     filtered_polys
[INFO] [stderr]    |     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent5.rs:41:26
[INFO] [stderr]    |
[INFO] [stderr] 41 |       let filtered_polys = character_set.iter().map(|ref_c| {
[INFO] [stderr]    |  __________________________^
[INFO] [stderr] 42 | |         let filtered_polymer = polymer
[INFO] [stderr] 43 | |             .chars()
[INFO] [stderr] 44 | |             .filter(|c| c.to_ascii_uppercase() != *ref_c)
[INFO] [stderr] ...  |
[INFO] [stderr] 47 | |             (*ref_c, filtered_polymer)
[INFO] [stderr] 48 | |     }).collect::<Vec<_>>();
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent5.rs:56:20
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn solution1() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent5.rs:64:20
[INFO] [stderr]    |
[INFO] [stderr] 64 | pub fn solution2() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/advent6.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return (b-a) as u32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(b-a) as u32`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solutions/advent6.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return (a-b) as u32;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a-b) as u32`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/solutions/advent6.rs:48:5
[INFO] [stderr]    |
[INFO] [stderr] 48 |     dists_to_coords
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/solutions/advent6.rs:44:27
[INFO] [stderr]    |
[INFO] [stderr] 44 |       let dists_to_coords = coords.iter()
[INFO] [stderr]    |  ___________________________^
[INFO] [stderr] 45 | |         .map(|ipos| (ipos.clone(), dist(ipos, pos)))
[INFO] [stderr] 46 | |         .collect::<Vec<_>>();
[INFO] [stderr]    | |____________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent6.rs:146:20
[INFO] [stderr]     |
[INFO] [stderr] 146 | pub fn solution1() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent6.rs:157:20
[INFO] [stderr]     |
[INFO] [stderr] 157 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `MinComparator`
[INFO] [stderr]  --> src/solutions/advent7.rs:3:36
[INFO] [stderr]   |
[INFO] [stderr] 3 | use binary_heap_plus::{BinaryHeap, MinComparator};
[INFO] [stderr]   |                                    ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::cmp`
[INFO] [stderr]  --> src/solutions/advent7.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use std::cmp;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent7.rs:143:20
[INFO] [stderr]     |
[INFO] [stderr] 143 | pub fn solution1() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent7.rs:152:20
[INFO] [stderr]     |
[INFO] [stderr] 152 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent8.rs:81:20
[INFO] [stderr]    |
[INFO] [stderr] 81 | pub fn solution1() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]   --> src/solutions/advent8.rs:94:20
[INFO] [stderr]    |
[INFO] [stderr] 94 | pub fn solution2() -> () {
[INFO] [stderr]    |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `solutions::utils`
[INFO] [stderr]  --> src/solutions/advent9.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 | use solutions::utils;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent9.rs:101:20
[INFO] [stderr]     |
[INFO] [stderr] 101 | pub fn solution1() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit return type
[INFO] [stderr]    --> src/solutions/advent9.rs:110:20
[INFO] [stderr]     |
[INFO] [stderr] 110 | pub fn solution2() -> () {
[INFO] [stderr]     |                    ^^^^^ help: remove the `-> ()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `num_workers`
[INFO] [stderr]   --> src/solutions/advent7.rs:85:27
[INFO] [stderr]    |
[INFO] [stderr] 85 |                           num_workers: usize) -> (u32, String) {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider using `_num_workers` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `active_marble`
[INFO] [stderr]   --> src/solutions/advent9.rs:23:22
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn print_game_state2(active_marble: &Cursor<usize>, circle: &mut LinkedList<usize>) {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^ help: consider using `_active_marble` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `num_workers`
[INFO] [stderr]   --> src/solutions/advent7.rs:85:27
[INFO] [stderr]    |
[INFO] [stderr] 85 |                           num_workers: usize) -> (u32, String) {
[INFO] [stderr]    |                           ^^^^^^^^^^^ help: consider using `_num_workers` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `active_marble`
[INFO] [stderr]   --> src/solutions/advent9.rs:23:22
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn print_game_state2(active_marble: &Cursor<usize>, circle: &mut LinkedList<usize>) {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^ help: consider using `_active_marble` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `print_game_state`
[INFO] [stderr]   --> src/solutions/advent9.rs:11:1
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn print_game_state(active_marble: usize, circle: &VecDeque<usize>) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `print_game_state2`
[INFO] [stderr]   --> src/solutions/advent9.rs:23:1
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn print_game_state2(active_marble: &Cursor<usize>, circle: &mut LinkedList<usize>) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `play_marble_game_old`
[INFO] [stderr]   --> src/solutions/advent9.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn play_marble_game_old(players: usize, last_marble: usize) -> usize {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `print_circle`
[INFO] [stderr]   --> src/solutions/advent9.rs:61:1
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn print_circle(test: LinkedList<usize>) -> LinkedList<usize> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent1.rs:21:27
[INFO] [stderr]    |
[INFO] [stderr] 21 | fn sum_frequencies(freqs: &Vec<i32>) -> i32 {
[INFO] [stderr]    |                           ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent1.rs:67:29
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn get_repeated_freq(freqs: &Vec<i32>) -> i32 {
[INFO] [stderr]    |                             ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent3.rs:35:34
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn compute_square_cover(squares: &Vec<Square>) -> Vec<Vec<u32>> {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^ help: change this to: `&[Square]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent4.rs:51:31
[INFO] [stderr]    |
[INFO] [stderr] 51 | fn count_sleeps(line_actions: &Vec<(NaiveDateTime, LineAction)>) -> HashMap<String, Vec<u32>> {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(NaiveDateTime, LineAction)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/solutions/advent4.rs:65:22
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     .or_insert(vec![0; 60]);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![0; 60])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `print_game_state`
[INFO] [stderr]   --> src/solutions/advent9.rs:11:1
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn print_game_state(active_marble: usize, circle: &VecDeque<usize>) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `print_game_state2`
[INFO] [stderr]   --> src/solutions/advent9.rs:23:1
[INFO] [stderr]    |
[INFO] [stderr] 23 | fn print_game_state2(active_marble: &Cursor<usize>, circle: &mut LinkedList<usize>) {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `play_marble_game_old`
[INFO] [stderr]   --> src/solutions/advent9.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn play_marble_game_old(players: usize, last_marble: usize) -> usize {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `print_circle`
[INFO] [stderr]   --> src/solutions/advent9.rs:61:1
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn print_circle(test: LinkedList<usize>) -> LinkedList<usize> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent1.rs:21:27
[INFO] [stderr]    |
[INFO] [stderr] 21 | fn sum_frequencies(freqs: &Vec<i32>) -> i32 {
[INFO] [stderr]    |                           ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent1.rs:67:29
[INFO] [stderr]    |
[INFO] [stderr] 67 | fn get_repeated_freq(freqs: &Vec<i32>) -> i32 {
[INFO] [stderr]    |                             ^^^^^^^^^ help: change this to: `&[i32]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent6.rs:43:46
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn get_coord_distance_map(pos: &Pos, coords: &Vec<Pos>) -> Vec<(Pos, u32)> {
[INFO] [stderr]    |                                              ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/solutions/advent6.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |         .map(|ipos| (ipos.clone(), dist(ipos, pos)))
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: try dereferencing it: `*ipos`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent6.rs:54:39
[INFO] [stderr]    |
[INFO] [stderr] 54 | fn get_closest_pos(pos: &Pos, coords: &Vec<Pos>) -> Option<usize> {
[INFO] [stderr]    |                                       ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent6.rs:82:29
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn get_largest_area(coords: &Vec<Pos>) -> i32 {
[INFO] [stderr]    |                             ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent3.rs:35:34
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn compute_square_cover(squares: &Vec<Square>) -> Vec<Vec<u32>> {
[INFO] [stderr]    |                                  ^^^^^^^^^^^^ help: change this to: `&[Square]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/solutions/advent6.rs:116:26
[INFO] [stderr]     |
[INFO] [stderr] 116 | fn get_safe_area(coords: &Vec<Pos>) -> u32 {
[INFO] [stderr]     |                          ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/solutions/advent7.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     ((str_bytes[0] - 64) as u32)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(str_bytes[0] - 64)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/solutions/advent7.rs:48:18
[INFO] [stderr]    |
[INFO] [stderr] 48 |                 .or_insert(RefCell::new(StepNode::new()));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| RefCell::new(StepNode::new()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/solutions/advent7.rs:56:18
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 .or_insert(RefCell::new(StepNode::new()));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| RefCell::new(StepNode::new()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent4.rs:51:31
[INFO] [stderr]    |
[INFO] [stderr] 51 | fn count_sleeps(line_actions: &Vec<(NaiveDateTime, LineAction)>) -> HashMap<String, Vec<u32>> {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(NaiveDateTime, LineAction)]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/solutions/advent4.rs:65:22
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     .or_insert(vec![0; 60]);
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![0; 60])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/solutions/advent7.rs:99:33
[INFO] [stderr]    |
[INFO] [stderr] 99 |         let removed_sink_node = step_graph.get(&sink_node_id).unwrap();
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&step_graph[&sink_node_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/solutions/advent7.rs:103:34
[INFO] [stderr]     |
[INFO] [stderr] 103 |             let dependent_node = step_graph.get(dependent_node_id).unwrap();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&step_graph[dependent_node_id]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent6.rs:43:46
[INFO] [stderr]    |
[INFO] [stderr] 43 | fn get_coord_distance_map(pos: &Pos, coords: &Vec<Pos>) -> Vec<(Pos, u32)> {
[INFO] [stderr]    |                                              ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/solutions/advent6.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |         .map(|ipos| (ipos.clone(), dist(ipos, pos)))
[INFO] [stderr]    |                      ^^^^^^^^^^^^ help: try dereferencing it: `*ipos`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent6.rs:54:39
[INFO] [stderr]    |
[INFO] [stderr] 54 | fn get_closest_pos(pos: &Pos, coords: &Vec<Pos>) -> Option<usize> {
[INFO] [stderr]    |                                       ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/solutions/advent6.rs:82:29
[INFO] [stderr]    |
[INFO] [stderr] 82 | fn get_largest_area(coords: &Vec<Pos>) -> i32 {
[INFO] [stderr]    |                             ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `tree_spec`.
[INFO] [stderr]   --> src/solutions/advent8.rs:67:18
[INFO] [stderr]    |
[INFO] [stderr] 67 |         for i in child_offset..(child_offset + metadata) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 67 |         for <item> in tree_spec.iter().skip(child_offset).take(metadata) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/solutions/advent6.rs:116:26
[INFO] [stderr]     |
[INFO] [stderr] 116 | fn get_safe_area(coords: &Vec<Pos>) -> u32 {
[INFO] [stderr]     |                          ^^^^^^^^^ help: change this to: `&[Pos]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/solutions/advent9.rs:38:29
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for (marble, player) in (1..last_marble+1).zip((0..players).cycle()) {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^ help: use: `(1..=last_marble)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/solutions/advent7.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     ((str_bytes[0] - 64) as u32)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(str_bytes[0] - 64)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/solutions/advent7.rs:48:18
[INFO] [stderr]    |
[INFO] [stderr] 48 |                 .or_insert(RefCell::new(StepNode::new()));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| RefCell::new(StepNode::new()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or_insert` followed by a function call
[INFO] [stderr]   --> src/solutions/advent7.rs:56:18
[INFO] [stderr]    |
[INFO] [stderr] 56 |                 .or_insert(RefCell::new(StepNode::new()));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| RefCell::new(StepNode::new()))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/solutions/advent9.rs:72:29
[INFO] [stderr]    |
[INFO] [stderr] 72 |     for (marble, player) in (1..last_marble + 1).zip((0..players).cycle()) {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=last_marble)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/solutions/advent7.rs:99:33
[INFO] [stderr]    |
[INFO] [stderr] 99 |         let removed_sink_node = step_graph.get(&sink_node_id).unwrap();
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&step_graph[&sink_node_id]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/solutions/advent7.rs:103:34
[INFO] [stderr]     |
[INFO] [stderr] 103 |             let dependent_node = step_graph.get(dependent_node_id).unwrap();
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&step_graph[dependent_node_id]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `tree_spec`.
[INFO] [stderr]   --> src/solutions/advent8.rs:67:18
[INFO] [stderr]    |
[INFO] [stderr] 67 |         for i in child_offset..(child_offset + metadata) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 67 |         for <item> in tree_spec.iter().skip(child_offset).take(metadata) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/solutions/advent9.rs:38:29
[INFO] [stderr]    |
[INFO] [stderr] 38 |     for (marble, player) in (1..last_marble+1).zip((0..players).cycle()) {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^ help: use: `(1..=last_marble)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/solutions/advent9.rs:72:29
[INFO] [stderr]    |
[INFO] [stderr] 72 |     for (marble, player) in (1..last_marble + 1).zip((0..players).cycle()) {
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=last_marble)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.01s
[INFO] running `"docker" "inspect" "1543bfda79c5f761701562299b87948d9e5de4d6691074013b89d57d4e45f15b"`
[INFO] running `"docker" "rm" "-f" "1543bfda79c5f761701562299b87948d9e5de4d6691074013b89d57d4e45f15b"`
[INFO] [stdout] 1543bfda79c5f761701562299b87948d9e5de4d6691074013b89d57d4e45f15b