[INFO] updating cached repository beolnix/leobot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/beolnix/leobot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/beolnix/leobot" "work/ex/clippy-test-run/sources/stable/gh/beolnix/leobot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/beolnix/leobot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/beolnix/leobot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beolnix/leobot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beolnix/leobot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 892ca3ef328576bd3423a58966c9fe145f10bd57 [INFO] sha for GitHub repo beolnix/leobot: 892ca3ef328576bd3423a58966c9fe145f10bd57 [INFO] validating manifest of beolnix/leobot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of beolnix/leobot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing beolnix/leobot [INFO] finished frobbing beolnix/leobot [INFO] frobbed toml for beolnix/leobot written to work/ex/clippy-test-run/sources/stable/gh/beolnix/leobot/Cargo.toml [INFO] started frobbing beolnix/leobot [INFO] finished frobbing beolnix/leobot [INFO] frobbed toml for beolnix/leobot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/beolnix/leobot/Cargo.toml [INFO] crate beolnix/leobot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting beolnix/leobot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/beolnix/leobot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 863fdfde5f55050b52818402e44635fed22b46fc5d83880725f392dff4caba1a [INFO] running `"docker" "start" "-a" "863fdfde5f55050b52818402e44635fed22b46fc5d83880725f392dff4caba1a"` [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking telegram-bot-raw v0.6.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking telegram-bot v0.6.1 [INFO] [stderr] Checking leobot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | fortune [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | let fortune = &self.data[choice as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | fortune [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:28:23 [INFO] [stderr] | [INFO] [stderr] 28 | let fortune = &self.data[choice as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.40s [INFO] running `"docker" "inspect" "863fdfde5f55050b52818402e44635fed22b46fc5d83880725f392dff4caba1a"` [INFO] running `"docker" "rm" "-f" "863fdfde5f55050b52818402e44635fed22b46fc5d83880725f392dff4caba1a"` [INFO] [stdout] 863fdfde5f55050b52818402e44635fed22b46fc5d83880725f392dff4caba1a