[INFO] updating cached repository benweedon/reudh [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benweedon/reudh [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benweedon/reudh" "work/ex/clippy-test-run/sources/stable/gh/benweedon/reudh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benweedon/reudh'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benweedon/reudh" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benweedon/reudh"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benweedon/reudh'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e52366a89785d3db044addd1ee3ae94c908ea8f8 [INFO] sha for GitHub repo benweedon/reudh: e52366a89785d3db044addd1ee3ae94c908ea8f8 [INFO] validating manifest of benweedon/reudh on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benweedon/reudh on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benweedon/reudh [INFO] finished frobbing benweedon/reudh [INFO] frobbed toml for benweedon/reudh written to work/ex/clippy-test-run/sources/stable/gh/benweedon/reudh/Cargo.toml [INFO] started frobbing benweedon/reudh [INFO] finished frobbing benweedon/reudh [INFO] frobbed toml for benweedon/reudh written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benweedon/reudh/Cargo.toml [INFO] crate benweedon/reudh has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benweedon/reudh against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benweedon/reudh:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19ecd53a733d52b0473765dbbb87b41263e18441ccbaf05606f70a68590eea95 [INFO] running `"docker" "start" "-a" "19ecd53a733d52b0473765dbbb87b41263e18441ccbaf05606f70a68590eea95"` [INFO] [stderr] Compiling num-traits v0.1.42 [INFO] [stderr] Checking dtoa-short v0.3.1 [INFO] [stderr] Checking servo_arc v0.1.0 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking chan v0.1.21 [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Compiling cssparser v0.23.2 [INFO] [stderr] Compiling string_cache_codegen v0.4.0 [INFO] [stderr] Compiling cssparser-macros v0.3.0 [INFO] [stderr] Compiling selectors v0.19.0 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking hyper v0.11.16 [INFO] [stderr] Compiling serde_json v1.0.9 [INFO] [stderr] Compiling string_cache v0.7.1 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking html5ever v0.22.0 [INFO] [stderr] Checking kuchiki v0.7.0 [INFO] [stderr] Checking reudh v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Error { s: s } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetch.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetch.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | definition: definition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `definition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Error { s: s } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetch.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fetch.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | definition: definition, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `definition` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | fn initialize(&mut self, bar: &ProgressBar) -> Result<(), Error> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fetch.rs:68:58 [INFO] [stderr] | [INFO] [stderr] 68 | fn update_page_count(&mut self, url: String, letter: &char) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | .ok_or(Error::new("Link is not element".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("Link is not element".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or(Error::new("title attribute not found".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("title attribute not found".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | .ok_or(Error::new("maximum page number not found".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("maximum page number not found".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | .ok_or(Error::new("Failed to parse number of words".to_owned()))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("Failed to parse number of words".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fetch.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | let bar = Arc::new(ProgressBar::new(26)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let bar = Arc::clone(&bar); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | bar: &ProgressBar, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | .ok_or(Error::new("Link is not element".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("Link is not element".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | .ok_or(Error::new("href attribute not found on link".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("href attribute not found on link".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fetch.rs:227:31 [INFO] [stderr] | [INFO] [stderr] 227 | fn write_etyms_to_file(etyms: &Vec, cache_dir: &PathBuf) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Etym]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fetch.rs:228:8 [INFO] [stderr] | [INFO] [stderr] 228 | if etyms.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!etyms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fetch.rs:242:10 [INFO] [stderr] | [INFO] [stderr] 242 | url: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | fn initialize(&mut self, bar: &ProgressBar) -> Result<(), Error> { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/fetch.rs:68:58 [INFO] [stderr] | [INFO] [stderr] 68 | fn update_page_count(&mut self, url: String, letter: &char) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:78:22 [INFO] [stderr] | [INFO] [stderr] 78 | .ok_or(Error::new("Link is not element".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("Link is not element".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:82:22 [INFO] [stderr] | [INFO] [stderr] 82 | .ok_or(Error::new("title attribute not found".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("title attribute not found".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | .ok_or(Error::new("maximum page number not found".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("maximum page number not found".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:99:14 [INFO] [stderr] | [INFO] [stderr] 99 | .ok_or(Error::new("Failed to parse number of words".to_owned()))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("Failed to parse number of words".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fetch.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | let bar = Arc::new(ProgressBar::new(26)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:158:13 [INFO] [stderr] | [INFO] [stderr] 158 | let bar = Arc::clone(&bar); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/fetch.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | bar: &ProgressBar, [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:200:14 [INFO] [stderr] | [INFO] [stderr] 200 | .ok_or(Error::new("Link is not element".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("Link is not element".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/fetch.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | .ok_or(Error::new("href attribute not found on link".to_owned()))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::new("href attribute not found on link".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fetch.rs:227:31 [INFO] [stderr] | [INFO] [stderr] 227 | fn write_etyms_to_file(etyms: &Vec, cache_dir: &PathBuf) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Etym]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fetch.rs:228:8 [INFO] [stderr] | [INFO] [stderr] 228 | if etyms.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!etyms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/fetch.rs:242:10 [INFO] [stderr] | [INFO] [stderr] 242 | url: &String, [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | let reudh_dir = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | let reudh_dir = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.36s [INFO] running `"docker" "inspect" "19ecd53a733d52b0473765dbbb87b41263e18441ccbaf05606f70a68590eea95"` [INFO] running `"docker" "rm" "-f" "19ecd53a733d52b0473765dbbb87b41263e18441ccbaf05606f70a68590eea95"` [INFO] [stdout] 19ecd53a733d52b0473765dbbb87b41263e18441ccbaf05606f70a68590eea95