[INFO] updating cached repository benwebber/tunnelblickctl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/benwebber/tunnelblickctl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/benwebber/tunnelblickctl" "work/ex/clippy-test-run/sources/stable/gh/benwebber/tunnelblickctl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benwebber/tunnelblickctl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/benwebber/tunnelblickctl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwebber/tunnelblickctl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwebber/tunnelblickctl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] fc5df6ecf2a00ad622d5b5f7860e348393691c68
[INFO] sha for GitHub repo benwebber/tunnelblickctl: fc5df6ecf2a00ad622d5b5f7860e348393691c68
[INFO] validating manifest of benwebber/tunnelblickctl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of benwebber/tunnelblickctl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing benwebber/tunnelblickctl
[INFO] finished frobbing benwebber/tunnelblickctl
[INFO] frobbed toml for benwebber/tunnelblickctl written to work/ex/clippy-test-run/sources/stable/gh/benwebber/tunnelblickctl/Cargo.toml
[INFO] started frobbing benwebber/tunnelblickctl
[INFO] finished frobbing benwebber/tunnelblickctl
[INFO] frobbed toml for benwebber/tunnelblickctl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwebber/tunnelblickctl/Cargo.toml
[INFO] crate benwebber/tunnelblickctl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting benwebber/tunnelblickctl against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benwebber/tunnelblickctl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 426f112655f9d9cff9889c808e978d0a7b26fae6e65d0817a870f8f8312ed64c
[INFO] running `"docker" "start" "-a" "426f112655f9d9cff9889c808e978d0a7b26fae6e65d0817a870f8f8312ed64c"`
[INFO] [stderr]     Checking term_size v0.2.3
[INFO] [stderr]     Checking clap v2.19.3
[INFO] [stderr]     Checking tunnelblickctl v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/applescript.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return Ok(s);
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/tunnelblick.rs:5:28
[INFO] [stderr]   |
[INFO] [stderr] 5 | const TUNNELBLICK_SCRIPT: &'static str = include_str!("tunnelblick.applescript");
[INFO] [stderr]   |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     return match shell {
[INFO] [stderr] 50 | |         _ => include_str!("../contrib/tunnelblick.bash"),
[INFO] [stderr] 51 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 49 |     match shell {
[INFO] [stderr] 50 |         _ => include_str!("../contrib/tunnelblick.bash"),
[INFO] [stderr] 51 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     return Ok(format!("{} {}\nTunnelblick {}\n",
[INFO] [stderr] 59 | |                       env!("CARGO_PKG_NAME"),
[INFO] [stderr] 60 | |                       cli_version,
[INFO] [stderr] 61 | |                       app_version));
[INFO] [stderr]    | |____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 58 |     Ok(format!("{} {}\nTunnelblick {}\n",
[INFO] [stderr] 59 |                       env!("CARGO_PKG_NAME"),
[INFO] [stderr] 60 |                       cli_version,
[INFO] [stderr] 61 |                       app_version))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 | /     return HumanConfiguration {
[INFO] [stderr] 67 | |         autoconnect: config.autoconnect,
[INFO] [stderr] 68 | |         state: config.state,
[INFO] [stderr] 69 | |         name: config.name,
[INFO] [stderr] 70 | |         bytesin: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr] 71 | |         bytesout: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 66 |     HumanConfiguration {
[INFO] [stderr] 67 |         autoconnect: config.autoconnect,
[INFO] [stderr] 68 |         state: config.state,
[INFO] [stderr] 69 |         name: config.name,
[INFO] [stderr] 70 |         bytesin: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr] 71 |         bytesout: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/applescript.rs:48:9
[INFO] [stderr]    |
[INFO] [stderr] 48 |         return Ok(s);
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/tunnelblick.rs:5:28
[INFO] [stderr]   |
[INFO] [stderr] 5 | const TUNNELBLICK_SCRIPT: &'static str = include_str!("tunnelblick.applescript");
[INFO] [stderr]   |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 | /     return match shell {
[INFO] [stderr] 50 | |         _ => include_str!("../contrib/tunnelblick.bash"),
[INFO] [stderr] 51 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 49 |     match shell {
[INFO] [stderr] 50 |         _ => include_str!("../contrib/tunnelblick.bash"),
[INFO] [stderr] 51 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 | /     return Ok(format!("{} {}\nTunnelblick {}\n",
[INFO] [stderr] 59 | |                       env!("CARGO_PKG_NAME"),
[INFO] [stderr] 60 | |                       cli_version,
[INFO] [stderr] 61 | |                       app_version));
[INFO] [stderr]    | |____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 58 |     Ok(format!("{} {}\nTunnelblick {}\n",
[INFO] [stderr] 59 |                       env!("CARGO_PKG_NAME"),
[INFO] [stderr] 60 |                       cli_version,
[INFO] [stderr] 61 |                       app_version))
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:66:5
[INFO] [stderr]    |
[INFO] [stderr] 66 | /     return HumanConfiguration {
[INFO] [stderr] 67 | |         autoconnect: config.autoconnect,
[INFO] [stderr] 68 | |         state: config.state,
[INFO] [stderr] 69 | |         name: config.name,
[INFO] [stderr] 70 | |         bytesin: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr] 71 | |         bytesout: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr] 72 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 66 |     HumanConfiguration {
[INFO] [stderr] 67 |         autoconnect: config.autoconnect,
[INFO] [stderr] 68 |         state: config.state,
[INFO] [stderr] 69 |         name: config.name,
[INFO] [stderr] 70 |         bytesin: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr] 71 |         bytesout: config.bytesin.file_size(file_size_opts::BINARY).unwrap(),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/tunnelblick.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         match self {
[INFO] [stderr] 26 | |             &Connect(ref t) => rpc_format!(script, "connect", t),
[INFO] [stderr] 27 | |             &ConnectAll => rpc_format!(script, "connectAll"),
[INFO] [stderr] 28 | |             &Disconnect(ref t) => rpc_format!(script, "disconnect", t),
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |             &Quit => rpc_format!(script, "quit"),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         match *self {
[INFO] [stderr] 26 |             Connect(ref t) => rpc_format!(script, "connect", t),
[INFO] [stderr] 27 |             ConnectAll => rpc_format!(script, "connectAll"),
[INFO] [stderr] 28 |             Disconnect(ref t) => rpc_format!(script, "disconnect", t),
[INFO] [stderr] 29 |             DisconnectAll => rpc_format!(script, "disconnectAll"),
[INFO] [stderr] 30 |             GetConfigurations => rpc_format!(script, "getConfigurations"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:154:17
[INFO] [stderr]     |
[INFO] [stderr] 154 | /                 match print_status(reader, bytes) {
[INFO] [stderr] 155 | |                     Err(v) => panic!(v.to_string()),
[INFO] [stderr] 156 | |                     _ => (),
[INFO] [stderr] 157 | |                 }
[INFO] [stderr]     | |_________________^ help: try this: `if let Err(v) = print_status(reader, bytes) { panic!(v.to_string()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/tunnelblick.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 | /         match self {
[INFO] [stderr] 26 | |             &Connect(ref t) => rpc_format!(script, "connect", t),
[INFO] [stderr] 27 | |             &ConnectAll => rpc_format!(script, "connectAll"),
[INFO] [stderr] 28 | |             &Disconnect(ref t) => rpc_format!(script, "disconnect", t),
[INFO] [stderr] ...  |
[INFO] [stderr] 35 | |             &Quit => rpc_format!(script, "quit"),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |         match *self {
[INFO] [stderr] 26 |             Connect(ref t) => rpc_format!(script, "connect", t),
[INFO] [stderr] 27 |             ConnectAll => rpc_format!(script, "connectAll"),
[INFO] [stderr] 28 |             Disconnect(ref t) => rpc_format!(script, "disconnect", t),
[INFO] [stderr] 29 |             DisconnectAll => rpc_format!(script, "disconnectAll"),
[INFO] [stderr] 30 |             GetConfigurations => rpc_format!(script, "getConfigurations"),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:154:17
[INFO] [stderr]     |
[INFO] [stderr] 154 | /                 match print_status(reader, bytes) {
[INFO] [stderr] 155 | |                     Err(v) => panic!(v.to_string()),
[INFO] [stderr] 156 | |                     _ => (),
[INFO] [stderr] 157 | |                 }
[INFO] [stderr]     | |_________________^ help: try this: `if let Err(v) = print_status(reader, bytes) { panic!(v.to_string()) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.52s
[INFO] running `"docker" "inspect" "426f112655f9d9cff9889c808e978d0a7b26fae6e65d0817a870f8f8312ed64c"`
[INFO] running `"docker" "rm" "-f" "426f112655f9d9cff9889c808e978d0a7b26fae6e65d0817a870f8f8312ed64c"`
[INFO] [stdout] 426f112655f9d9cff9889c808e978d0a7b26fae6e65d0817a870f8f8312ed64c