[INFO] updating cached repository benwebber/duiker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benwebber/duiker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benwebber/duiker" "work/ex/clippy-test-run/sources/stable/gh/benwebber/duiker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benwebber/duiker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benwebber/duiker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwebber/duiker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwebber/duiker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1251ea56f958223a8a7bb08b1aa00ccbb5433075 [INFO] sha for GitHub repo benwebber/duiker: 1251ea56f958223a8a7bb08b1aa00ccbb5433075 [INFO] validating manifest of benwebber/duiker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benwebber/duiker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benwebber/duiker [INFO] finished frobbing benwebber/duiker [INFO] frobbed toml for benwebber/duiker written to work/ex/clippy-test-run/sources/stable/gh/benwebber/duiker/Cargo.toml [INFO] started frobbing benwebber/duiker [INFO] finished frobbing benwebber/duiker [INFO] frobbed toml for benwebber/duiker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwebber/duiker/Cargo.toml [INFO] crate benwebber/duiker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benwebber/duiker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benwebber/duiker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddbfe3e220f24b9c02f25f4f4b77693f12f91facde0152eb73d7f6b24dde82ae [INFO] running `"docker" "start" "-a" "ddbfe3e220f24b9c02f25f4f4b77693f12f91facde0152eb73d7f6b24dde82ae"` [INFO] [stderr] Compiling gcc v0.3.48 [INFO] [stderr] Compiling num-integer v0.1.34 [INFO] [stderr] Compiling memchr v1.0.1 [INFO] [stderr] Compiling thread-id v3.1.0 [INFO] [stderr] Compiling time v0.1.37 [INFO] [stderr] Compiling thread_local v0.3.3 [INFO] [stderr] Compiling aho-corasick v0.6.3 [INFO] [stderr] Compiling num-iter v0.1.33 [INFO] [stderr] Compiling num v0.1.37 [INFO] [stderr] Compiling regex v0.2.2 [INFO] [stderr] Compiling libsqlite3-sys v0.8.0 [INFO] [stderr] Compiling chrono v0.3.1 [INFO] [stderr] Compiling dotenv v0.9.0 [INFO] [stderr] Checking diesel v0.13.0 [INFO] [stderr] Compiling diesel_infer_schema v0.13.0 [INFO] [stderr] Compiling diesel_codegen v0.13.0 [INFO] [stderr] Checking duiker v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(models::NewCommand{timestamp: timestamp, command: &command}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/commands.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(models::NewCommand{timestamp: timestamp, command: &command}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | const MAGIC: &'static str = include_str!("magic.bash"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | const PACKAGE: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return database_path.to_str().unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `database_path.to_str().unwrap().to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/commands.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | const MAGIC: &'static str = include_str!("magic.bash"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:4:17 [INFO] [stderr] | [INFO] [stderr] 4 | const PACKAGE: &'static str = env!("CARGO_PKG_NAME"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return database_path.to_str().unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `database_path.to_str().unwrap().to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / match RE.is_match(line) { [INFO] [stderr] 34 | | true => { [INFO] [stderr] 35 | | let caps = RE.captures(line).unwrap(); [INFO] [stderr] 36 | | let timestamp = caps.name("timestamp").unwrap().as_str().parse::().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => Err(Error::InvalidHistoryLine) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 33 | if RE.is_match(line) { [INFO] [stderr] 34 | let caps = RE.captures(line).unwrap(); [INFO] [stderr] 35 | let timestamp = caps.name("timestamp").unwrap().as_str().parse::().unwrap(); [INFO] [stderr] 36 | let command = caps.name("command").unwrap().as_str().trim(); [INFO] [stderr] 37 | Ok(models::NewCommand{timestamp: timestamp, command: &command}) [INFO] [stderr] 38 | } else { Err(Error::InvalidHistoryLine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/commands.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / match RE.is_match(line) { [INFO] [stderr] 34 | | true => { [INFO] [stderr] 35 | | let caps = RE.captures(line).unwrap(); [INFO] [stderr] 36 | | let timestamp = caps.name("timestamp").unwrap().as_str().parse::().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 40 | | _ => Err(Error::InvalidHistoryLine) [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 33 | if RE.is_match(line) { [INFO] [stderr] 34 | let caps = RE.captures(line).unwrap(); [INFO] [stderr] 35 | let timestamp = caps.name("timestamp").unwrap().as_str().parse::().unwrap(); [INFO] [stderr] 36 | let command = caps.name("command").unwrap().as_str().trim(); [INFO] [stderr] 37 | Ok(models::NewCommand{timestamp: timestamp, command: &command}) [INFO] [stderr] 38 | } else { Err(Error::InvalidHistoryLine) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | let timestamp = UTC.timestamp(command.timestamp as i64, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(command.timestamp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn output_commands(commands: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[models::History]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | / let mut quiet = false; [INFO] [stderr] 78 | | if m.is_present("quiet") { [INFO] [stderr] 79 | | quiet = true; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let quiet = if m.is_present("quiet") { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:46:43 [INFO] [stderr] | [INFO] [stderr] 46 | let timestamp = UTC.timestamp(command.timestamp as i64, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(command.timestamp)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / let mut verbose = false; [INFO] [stderr] 133 | | if m.is_present("verbose") { [INFO] [stderr] 134 | | verbose = true; [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let verbose = if m.is_present("verbose") { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:54:34 [INFO] [stderr] | [INFO] [stderr] 54 | pub fn output_commands(commands: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[models::History]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | / let mut quiet = false; [INFO] [stderr] 78 | | if m.is_present("quiet") { [INFO] [stderr] 79 | | quiet = true; [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let quiet = if m.is_present("quiet") { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / let mut verbose = false; [INFO] [stderr] 133 | | if m.is_present("verbose") { [INFO] [stderr] 134 | | verbose = true; [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let verbose = if m.is_present("verbose") { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.44s [INFO] running `"docker" "inspect" "ddbfe3e220f24b9c02f25f4f4b77693f12f91facde0152eb73d7f6b24dde82ae"` [INFO] running `"docker" "rm" "-f" "ddbfe3e220f24b9c02f25f4f4b77693f12f91facde0152eb73d7f6b24dde82ae"` [INFO] [stdout] ddbfe3e220f24b9c02f25f4f4b77693f12f91facde0152eb73d7f6b24dde82ae