[INFO] updating cached repository benwaffle/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benwaffle/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benwaffle/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/benwaffle/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benwaffle/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benwaffle/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwaffle/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwaffle/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5108d720bfb1f81fc3980eca4e81efc14ac6c2bc [INFO] sha for GitHub repo benwaffle/advent-of-code-2018: 5108d720bfb1f81fc3980eca4e81efc14ac6c2bc [INFO] validating manifest of benwaffle/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benwaffle/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benwaffle/advent-of-code-2018 [INFO] finished frobbing benwaffle/advent-of-code-2018 [INFO] frobbed toml for benwaffle/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/benwaffle/advent-of-code-2018/Cargo.toml [INFO] started frobbing benwaffle/advent-of-code-2018 [INFO] finished frobbing benwaffle/advent-of-code-2018 [INFO] frobbed toml for benwaffle/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benwaffle/advent-of-code-2018/Cargo.toml [INFO] crate benwaffle/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benwaffle/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benwaffle/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3bb6e78988bdc94eaab6b12c476663958eb99975b039cabd6674edfdeadf928b [INFO] running `"docker" "start" "-a" "3bb6e78988bdc94eaab6b12c476663958eb99975b039cabd6674edfdeadf928b"` [INFO] [stderr] Checking advent-of-code-2018 v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/p2.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | for (_, cnt) in &chars { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 19 | for cnt in chars.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/p2.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | for (_, cnt) in &chars { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 26 | for cnt in chars.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/p2.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | index.map(|i| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 50 | || if diff == 1 { [INFO] [stderr] 51 | || println!( [INFO] [stderr] 52 | || "Part 2: {}{}", [INFO] [stderr] ... || [INFO] [stderr] 56 | || } [INFO] [stderr] 57 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(i) = index { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/p2.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | for (_, cnt) in &chars { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 19 | for cnt in chars.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/bin/p2.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | for (_, cnt) in &chars { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 26 | for cnt in chars.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/bin/p2.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | index.map(|i| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 50 | || if diff == 1 { [INFO] [stderr] 51 | || println!( [INFO] [stderr] 52 | || "Part 2: {}{}", [INFO] [stderr] ... || [INFO] [stderr] 56 | || } [INFO] [stderr] 57 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(i) = index { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.12s [INFO] running `"docker" "inspect" "3bb6e78988bdc94eaab6b12c476663958eb99975b039cabd6674edfdeadf928b"` [INFO] running `"docker" "rm" "-f" "3bb6e78988bdc94eaab6b12c476663958eb99975b039cabd6674edfdeadf928b"` [INFO] [stdout] 3bb6e78988bdc94eaab6b12c476663958eb99975b039cabd6674edfdeadf928b