[INFO] updating cached repository bennyyip/plug2pack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bennyyip/plug2pack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bennyyip/plug2pack" "work/ex/clippy-test-run/sources/stable/gh/bennyyip/plug2pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bennyyip/plug2pack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bennyyip/plug2pack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bennyyip/plug2pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bennyyip/plug2pack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 29ccb6cd58919007380d790864331c1762f1e924 [INFO] sha for GitHub repo bennyyip/plug2pack: 29ccb6cd58919007380d790864331c1762f1e924 [INFO] validating manifest of bennyyip/plug2pack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bennyyip/plug2pack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bennyyip/plug2pack [INFO] finished frobbing bennyyip/plug2pack [INFO] frobbed toml for bennyyip/plug2pack written to work/ex/clippy-test-run/sources/stable/gh/bennyyip/plug2pack/Cargo.toml [INFO] started frobbing bennyyip/plug2pack [INFO] finished frobbing bennyyip/plug2pack [INFO] frobbed toml for bennyyip/plug2pack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bennyyip/plug2pack/Cargo.toml [INFO] crate bennyyip/plug2pack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bennyyip/plug2pack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bennyyip/plug2pack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29cc4ae5e89415bee4f71485044fd3d9b3b5bc39efc3e1806758f8a2ad78becf [INFO] running `"docker" "start" "-a" "29cc4ae5e89415bee4f71485044fd3d9b3b5bc39efc3e1806758f8a2ad78becf"` [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking serde_yaml v0.7.1 [INFO] [stderr] Compiling structopt-derive v0.1.1 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking structopt v0.1.1 [INFO] [stderr] Checking plug2pack v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | load_command: load_command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `load_command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | for_types: for_types, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `for_types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | build_command: build_command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | opt: opt, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `opt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | load_command: load_command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `load_command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | for_types: for_types, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `for_types` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | build_command: build_command, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parser.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | h.entry("for").or_insert(Value::Str("python".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Value::Str("python".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.73s [INFO] running `"docker" "inspect" "29cc4ae5e89415bee4f71485044fd3d9b3b5bc39efc3e1806758f8a2ad78becf"` [INFO] running `"docker" "rm" "-f" "29cc4ae5e89415bee4f71485044fd3d9b3b5bc39efc3e1806758f8a2ad78becf"` [INFO] [stdout] 29cc4ae5e89415bee4f71485044fd3d9b3b5bc39efc3e1806758f8a2ad78becf