[INFO] updating cached repository bennetyee/cryptoquip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/bennetyee/cryptoquip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/bennetyee/cryptoquip" "work/ex/clippy-test-run/sources/stable/gh/bennetyee/cryptoquip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bennetyee/cryptoquip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/bennetyee/cryptoquip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bennetyee/cryptoquip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bennetyee/cryptoquip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b1df4fb6f037bf8d7c2900e929def482f39c96b [INFO] sha for GitHub repo bennetyee/cryptoquip: 0b1df4fb6f037bf8d7c2900e929def482f39c96b [INFO] validating manifest of bennetyee/cryptoquip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bennetyee/cryptoquip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bennetyee/cryptoquip [INFO] finished frobbing bennetyee/cryptoquip [INFO] frobbed toml for bennetyee/cryptoquip written to work/ex/clippy-test-run/sources/stable/gh/bennetyee/cryptoquip/Cargo.toml [INFO] started frobbing bennetyee/cryptoquip [INFO] finished frobbing bennetyee/cryptoquip [INFO] frobbed toml for bennetyee/cryptoquip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bennetyee/cryptoquip/Cargo.toml [INFO] crate bennetyee/cryptoquip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bennetyee/cryptoquip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bennetyee/cryptoquip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f88309b2f21b16a45a8574225d9168ab554709f8831c8df3c58fbbbf93efa951 [INFO] running `"docker" "start" "-a" "f88309b2f21b16a45a8574225d9168ab554709f8831c8df3c58fbbbf93efa951"` [INFO] [stderr] Checking cryptoquip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | if !c.is_alphabetic() && !(expect_post && c == '.') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(expect_post && c == '.' || c.is_alphabetic())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | if line.starts_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:144:40 [INFO] [stderr] | [INFO] [stderr] 144 | } else if line.starts_with("p") { [INFO] [stderr] | ^^^ help: try using a char instead: `'p'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:146:40 [INFO] [stderr] | [INFO] [stderr] 146 | } else if line.starts_with("q") { [INFO] [stderr] | ^^^ help: try using a char instead: `'q'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:148:40 [INFO] [stderr] | [INFO] [stderr] 148 | } else if line.starts_with("N") { [INFO] [stderr] | ^^^ help: try using a char instead: `'N'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:151:40 [INFO] [stderr] | [INFO] [stderr] 151 | } else if line.starts_with("c") { [INFO] [stderr] | ^^^ help: try using a char instead: `'c'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:154:40 [INFO] [stderr] | [INFO] [stderr] 154 | } else if line.starts_with("r") { [INFO] [stderr] | ^^^ help: try using a char instead: `'r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | } else if line.starts_with("s") { [INFO] [stderr] | ^^^ help: try using a char instead: `'s'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | if !c.is_alphabetic() && !(expect_post && c == '.') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(expect_post && c == '.' || c.is_alphabetic())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | if line.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | if line.starts_with("?") { [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:144:40 [INFO] [stderr] | [INFO] [stderr] 144 | } else if line.starts_with("p") { [INFO] [stderr] | ^^^ help: try using a char instead: `'p'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:146:40 [INFO] [stderr] | [INFO] [stderr] 146 | } else if line.starts_with("q") { [INFO] [stderr] | ^^^ help: try using a char instead: `'q'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:148:40 [INFO] [stderr] | [INFO] [stderr] 148 | } else if line.starts_with("N") { [INFO] [stderr] | ^^^ help: try using a char instead: `'N'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:151:40 [INFO] [stderr] | [INFO] [stderr] 151 | } else if line.starts_with("c") { [INFO] [stderr] | ^^^ help: try using a char instead: `'c'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:154:40 [INFO] [stderr] | [INFO] [stderr] 154 | } else if line.starts_with("r") { [INFO] [stderr] | ^^^ help: try using a char instead: `'r'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:175:40 [INFO] [stderr] | [INFO] [stderr] 175 | } else if line.starts_with("s") { [INFO] [stderr] | ^^^ help: try using a char instead: `'s'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "f88309b2f21b16a45a8574225d9168ab554709f8831c8df3c58fbbbf93efa951"` [INFO] running `"docker" "rm" "-f" "f88309b2f21b16a45a8574225d9168ab554709f8831c8df3c58fbbbf93efa951"` [INFO] [stdout] f88309b2f21b16a45a8574225d9168ab554709f8831c8df3c58fbbbf93efa951