[INFO] updating cached repository benmp/twrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benmp/twrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benmp/twrust" "work/ex/clippy-test-run/sources/stable/gh/benmp/twrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benmp/twrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benmp/twrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benmp/twrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benmp/twrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd1edbdb907671893f4fd83ca70f953098e96ead [INFO] sha for GitHub repo benmp/twrust: fd1edbdb907671893f4fd83ca70f953098e96ead [INFO] validating manifest of benmp/twrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benmp/twrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benmp/twrust [INFO] finished frobbing benmp/twrust [INFO] frobbed toml for benmp/twrust written to work/ex/clippy-test-run/sources/stable/gh/benmp/twrust/Cargo.toml [INFO] started frobbing benmp/twrust [INFO] finished frobbing benmp/twrust [INFO] frobbed toml for benmp/twrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benmp/twrust/Cargo.toml [INFO] crate benmp/twrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benmp/twrust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benmp/twrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c22efd8b1d5d62ade165deca2c48c085fc4e16bd1fad02ad398e524ed4234fbb [INFO] running `"docker" "start" "-a" "c22efd8b1d5d62ade165deca2c48c085fc4e16bd1fad02ad398e524ed4234fbb"` [INFO] [stderr] Compiling openssl-sys v0.9.33 [INFO] [stderr] Checking regex v1.0.1 [INFO] [stderr] Checking input_buffer v0.1.1 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tungstenite v0.5.4 [INFO] [stderr] Checking twrust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/twitchparser.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const PRIVMSG: &'static str = "PRIVMSG"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/twitchparser.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const BADGES: &'static str = "@badges="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/twitchparser.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | const MSG: &'static str = "@badges=moderator/1,subscriber/6,turbo/1;color=#CC008D;display-name=KushyLife;emotes=;id=4fc69423-4845-483d-93e5-c193be554965;mod=1;room-id=110690086;subscriber=1;tmi-sent-ts=1531789918256;turbo=1;user-id=37734410;user-type=mod :kushylife!kushylife@kushylife.tmi.twitch.tv PRIVMSG #tsm_myth :@saucymike01 obv not banned"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/twitchparser.rs:5:17 [INFO] [stderr] | [INFO] [stderr] 5 | const PRIVMSG: &'static str = "PRIVMSG"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/twitchparser.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | const BADGES: &'static str = "@badges="; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/twitchparser.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/twitchparser.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if self.tokens.len() > 0 && self.tokens[0].starts_with(BADGES) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::len_zero)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/twitchparser.rs:89:42 [INFO] [stderr] | [INFO] [stderr] 89 | for badge in badges[0].split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/twitchparser.rs:93:50 [INFO] [stderr] | [INFO] [stderr] 93 | let kvp: Vec<&str> = badge.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/twitchparser.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/twitchparser.rs:84:12 [INFO] [stderr] | [INFO] [stderr] 84 | if self.tokens.len() > 0 && self.tokens[0].starts_with(BADGES) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:9 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::len_zero)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/twitchparser.rs:89:42 [INFO] [stderr] | [INFO] [stderr] 89 | for badge in badges[0].split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/twitchparser.rs:93:50 [INFO] [stderr] | [INFO] [stderr] 93 | let kvp: Vec<&str> = badge.split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.26s [INFO] running `"docker" "inspect" "c22efd8b1d5d62ade165deca2c48c085fc4e16bd1fad02ad398e524ed4234fbb"` [INFO] running `"docker" "rm" "-f" "c22efd8b1d5d62ade165deca2c48c085fc4e16bd1fad02ad398e524ed4234fbb"` [INFO] [stdout] c22efd8b1d5d62ade165deca2c48c085fc4e16bd1fad02ad398e524ed4234fbb