[INFO] updating cached repository benjgibbs/aoc2017
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/benjgibbs/aoc2017
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/benjgibbs/aoc2017" "work/ex/clippy-test-run/sources/stable/gh/benjgibbs/aoc2017"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benjgibbs/aoc2017'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/benjgibbs/aoc2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjgibbs/aoc2017"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjgibbs/aoc2017'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a931ce2d30ec219db4c5f173b5c50d6d75536868
[INFO] sha for GitHub repo benjgibbs/aoc2017: a931ce2d30ec219db4c5f173b5c50d6d75536868
[INFO] validating manifest of benjgibbs/aoc2017 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of benjgibbs/aoc2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing benjgibbs/aoc2017
[INFO] finished frobbing benjgibbs/aoc2017
[INFO] frobbed toml for benjgibbs/aoc2017 written to work/ex/clippy-test-run/sources/stable/gh/benjgibbs/aoc2017/Cargo.toml
[INFO] started frobbing benjgibbs/aoc2017
[INFO] finished frobbing benjgibbs/aoc2017
[INFO] frobbed toml for benjgibbs/aoc2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjgibbs/aoc2017/Cargo.toml
[INFO] crate benjgibbs/aoc2017 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting benjgibbs/aoc2017 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benjgibbs/aoc2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a6931da5f05d86c9d26c78243c782c05c4afbc5012769445eeeb1888814ce671
[INFO] running `"docker" "start" "-a" "a6931da5f05d86c9d26c78243c782c05c4afbc5012769445eeeb1888814ce671"`
[INFO] [stderr]     Checking aoc2017 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day20.rs:26:44
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 let xs :Vec<i64> = s.split(",").map(|t| i64::from_str(t).unwrap()).collect();
[INFO] [stderr]    |                                            ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/day20.rs:54:33
[INFO] [stderr]    |
[INFO] [stderr] 54 |     let file = File::open(file).expect(&format!("File not found {}", file));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File not found {}", file))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day20.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 | fn collisions(particles: &Vec<Particle>) -> HashSet<usize> {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: change this to: `&[Particle]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day20.rs:75:33
[INFO] [stderr]    |
[INFO] [stderr] 75 | fn remove_collisions(particles: &Vec<Particle>, collisions: HashSet<usize>) -> Vec<Particle> {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^ help: change this to: `&[Particle]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `particles`
[INFO] [stderr]   --> src/day20.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for i in 0..particles.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for (i, <item>) in particles.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day20.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn part2(particles: &Vec<Particle>){
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn part2(particles: &[Particle]){
[INFO] [stderr]    |                     ^^^^^^^^^^^
[INFO] [stderr] help: change `particles.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 88 |     let mut particles = particles.to_owned();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day20.rs:91:11
[INFO] [stderr]    |
[INFO] [stderr] 91 |     while particles.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!particles.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day20.rs:95:12
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if collisions.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!collisions.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day20.rs:110:21
[INFO] [stderr]     |
[INFO] [stderr] 110 | fn part1(particles: &Vec<Particle>){
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: change this to: `&[Particle]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `particles`
[INFO] [stderr]    --> src/day20.rs:113:14
[INFO] [stderr]     |
[INFO] [stderr] 113 |     for i in 0..particles.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 113 |     for (i, <item>) in particles.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/day20.rs:26:44
[INFO] [stderr]    |
[INFO] [stderr] 26 |                 let xs :Vec<i64> = s.split(",").map(|t| i64::from_str(t).unwrap()).collect();
[INFO] [stderr]    |                                            ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/day20.rs:54:33
[INFO] [stderr]    |
[INFO] [stderr] 54 |     let file = File::open(file).expect(&format!("File not found {}", file));
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("File not found {}", file))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day20.rs:62:26
[INFO] [stderr]    |
[INFO] [stderr] 62 | fn collisions(particles: &Vec<Particle>) -> HashSet<usize> {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: change this to: `&[Particle]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day20.rs:75:33
[INFO] [stderr]    |
[INFO] [stderr] 75 | fn remove_collisions(particles: &Vec<Particle>, collisions: HashSet<usize>) -> Vec<Particle> {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^ help: change this to: `&[Particle]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `particles`
[INFO] [stderr]   --> src/day20.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for i in 0..particles.len() {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 79 |     for (i, <item>) in particles.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day20.rs:87:21
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn part2(particles: &Vec<Particle>){
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 87 | fn part2(particles: &[Particle]){
[INFO] [stderr]    |                     ^^^^^^^^^^^
[INFO] [stderr] help: change `particles.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 88 |     let mut particles = particles.to_owned();
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day20.rs:91:11
[INFO] [stderr]    |
[INFO] [stderr] 91 |     while particles.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!particles.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/day20.rs:95:12
[INFO] [stderr]    |
[INFO] [stderr] 95 |         if collisions.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!collisions.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day20.rs:110:21
[INFO] [stderr]     |
[INFO] [stderr] 110 | fn part1(particles: &Vec<Particle>){
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^ help: change this to: `&[Particle]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `particles`
[INFO] [stderr]    --> src/day20.rs:113:14
[INFO] [stderr]     |
[INFO] [stderr] 113 |     for i in 0..particles.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 113 |     for (i, <item>) in particles.iter().enumerate() {
[INFO] [stderr]     |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.95s
[INFO] running `"docker" "inspect" "a6931da5f05d86c9d26c78243c782c05c4afbc5012769445eeeb1888814ce671"`
[INFO] running `"docker" "rm" "-f" "a6931da5f05d86c9d26c78243c782c05c4afbc5012769445eeeb1888814ce671"`
[INFO] [stdout] a6931da5f05d86c9d26c78243c782c05c4afbc5012769445eeeb1888814ce671