[INFO] updating cached repository benjaminboxler/convex_hull_challenge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/benjaminboxler/convex_hull_challenge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/benjaminboxler/convex_hull_challenge" "work/ex/clippy-test-run/sources/stable/gh/benjaminboxler/convex_hull_challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/benjaminboxler/convex_hull_challenge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/benjaminboxler/convex_hull_challenge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminboxler/convex_hull_challenge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminboxler/convex_hull_challenge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1bab37964f586d8b8dc2699be9572e7513fd5e23 [INFO] sha for GitHub repo benjaminboxler/convex_hull_challenge: 1bab37964f586d8b8dc2699be9572e7513fd5e23 [INFO] validating manifest of benjaminboxler/convex_hull_challenge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of benjaminboxler/convex_hull_challenge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing benjaminboxler/convex_hull_challenge [INFO] finished frobbing benjaminboxler/convex_hull_challenge [INFO] frobbed toml for benjaminboxler/convex_hull_challenge written to work/ex/clippy-test-run/sources/stable/gh/benjaminboxler/convex_hull_challenge/Cargo.toml [INFO] started frobbing benjaminboxler/convex_hull_challenge [INFO] finished frobbing benjaminboxler/convex_hull_challenge [INFO] frobbed toml for benjaminboxler/convex_hull_challenge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/benjaminboxler/convex_hull_challenge/Cargo.toml [INFO] crate benjaminboxler/convex_hull_challenge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting benjaminboxler/convex_hull_challenge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/benjaminboxler/convex_hull_challenge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77b200cbb3399e6010241499a22cd0a02f539764940266ad4de770b60f54ebf8 [INFO] running `"docker" "start" "-a" "77b200cbb3399e6010241499a22cd0a02f539764940266ad4de770b60f54ebf8"` [INFO] [stderr] Checking convex_hull v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return ((p.y-self.y) as f64).atan2((p.x-self.x) as f64) // Using atan2 because atan kept giving incorrect results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((p.y-self.y) as f64).atan2((p.x-self.x) as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return CrossProduct::Right [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CrossProduct::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return CrossProduct::Left [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CrossProduct::Left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return CrossProduct::Collinear [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CrossProduct::Collinear` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return points [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return ((p.y-self.y) as f64).atan2((p.x-self.x) as f64) // Using atan2 because atan kept giving incorrect results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((p.y-self.y) as f64).atan2((p.x-self.x) as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | return CrossProduct::Right [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CrossProduct::Right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return CrossProduct::Left [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CrossProduct::Left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utilities.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return CrossProduct::Collinear [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CrossProduct::Collinear` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return points [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn angle_with(&self, p: &Point) -> f64{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn angle_with(&self, p: &Point) -> f64{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | return ((p.y-self.y) as f64).atan2((p.x-self.x) as f64) // Using atan2 because atan kept giving incorrect results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.y-self.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | return ((p.y-self.y) as f64).atan2((p.x-self.x) as f64) // Using atan2 because atan kept giving incorrect results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.x-self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn direction_from(&self, p1: &Point, p2: &Point) -> CrossProduct{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn direction_from(&self, p1: &Point, p2: &Point) -> CrossProduct{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn direction_from(&self, p1: &Point, p2: &Point) -> CrossProduct{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/utilities.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if p.angle_with(&a[i-1]) == p.angle_with(&a[i]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(p.angle_with(&a[i-1]) - p.angle_with(&a[i])).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/utilities.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if p.angle_with(&a[i-1]) == p.angle_with(&a[i]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/utilities.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | let r1 = ((&a[i-1].x - p.x + &a[i-1].y - p.y) as f32).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a[i-1].y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/utilities.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | let r1 = ((&a[i-1].x - p.x + &a[i-1].y - p.y) as f32).sqrt(); [INFO] [stderr] | ---------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `a[i-1].x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/utilities.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | let r2 = ((&a[i].x - p.x + &a[i].y - p.y) as f32).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a[i].y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/utilities.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | let r2 = ((&a[i].x - p.x + &a[i].y - p.y) as f32).sqrt(); [INFO] [stderr] | -------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `a[i].x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utilities.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | n = n -1; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let mut min = points[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `points[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `points`. [INFO] [stderr] --> src/main.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in points.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | path.push(points[i].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `points[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | for (i,p) in points[..].into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `convex_hull`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn angle_with(&self, p: &Point) -> f64{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn angle_with(&self, p: &Point) -> f64{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:45:16 [INFO] [stderr] | [INFO] [stderr] 45 | return ((p.y-self.y) as f64).atan2((p.x-self.x) as f64) // Using atan2 because atan kept giving incorrect results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.y-self.y)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/utilities.rs:45:44 [INFO] [stderr] | [INFO] [stderr] 45 | return ((p.y-self.y) as f64).atan2((p.x-self.x) as f64) // Using atan2 because atan kept giving incorrect results [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(p.x-self.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:49:27 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn direction_from(&self, p1: &Point, p2: &Point) -> CrossProduct{ [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:49:38 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn direction_from(&self, p1: &Point, p2: &Point) -> CrossProduct{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/utilities.rs:49:50 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn direction_from(&self, p1: &Point, p2: &Point) -> CrossProduct{ [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/utilities.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if p.angle_with(&a[i-1]) == p.angle_with(&a[i]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(p.angle_with(&a[i-1]) - p.angle_with(&a[i])).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/utilities.rs:98:16 [INFO] [stderr] | [INFO] [stderr] 98 | if p.angle_with(&a[i-1]) == p.angle_with(&a[i]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/utilities.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | let r1 = ((&a[i-1].x - p.x + &a[i-1].y - p.y) as f32).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a[i-1].y` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/utilities.rs:99:28 [INFO] [stderr] | [INFO] [stderr] 99 | let r1 = ((&a[i-1].x - p.x + &a[i-1].y - p.y) as f32).sqrt(); [INFO] [stderr] | ---------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `a[i-1].x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/utilities.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | let r2 = ((&a[i].x - p.x + &a[i].y - p.y) as f32).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a[i].y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/utilities.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | let r2 = ((&a[i].x - p.x + &a[i].y - p.y) as f32).sqrt(); [INFO] [stderr] | -------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `a[i].x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/utilities.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | n = n -1; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `n -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:30:19 [INFO] [stderr] | [INFO] [stderr] 30 | let mut min = points[0].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `points[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `points`. [INFO] [stderr] --> src/main.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in points.iter().take(3) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:52:19 [INFO] [stderr] | [INFO] [stderr] 52 | path.push(points[i].clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `points[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:57:29 [INFO] [stderr] | [INFO] [stderr] 57 | for (i,p) in points[..].into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `convex_hull`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "77b200cbb3399e6010241499a22cd0a02f539764940266ad4de770b60f54ebf8"` [INFO] running `"docker" "rm" "-f" "77b200cbb3399e6010241499a22cd0a02f539764940266ad4de770b60f54ebf8"` [INFO] [stdout] 77b200cbb3399e6010241499a22cd0a02f539764940266ad4de770b60f54ebf8