[INFO] updating cached repository bencromwell/rust-pwgen
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/bencromwell/rust-pwgen
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/bencromwell/rust-pwgen" "work/ex/clippy-test-run/sources/stable/gh/bencromwell/rust-pwgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/bencromwell/rust-pwgen'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/bencromwell/rust-pwgen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bencromwell/rust-pwgen"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bencromwell/rust-pwgen'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 171688e308c9795bf50f49d977ddef106e323f64
[INFO] sha for GitHub repo bencromwell/rust-pwgen: 171688e308c9795bf50f49d977ddef106e323f64
[INFO] validating manifest of bencromwell/rust-pwgen on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bencromwell/rust-pwgen on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bencromwell/rust-pwgen
[INFO] finished frobbing bencromwell/rust-pwgen
[INFO] frobbed toml for bencromwell/rust-pwgen written to work/ex/clippy-test-run/sources/stable/gh/bencromwell/rust-pwgen/Cargo.toml
[INFO] started frobbing bencromwell/rust-pwgen
[INFO] finished frobbing bencromwell/rust-pwgen
[INFO] frobbed toml for bencromwell/rust-pwgen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/bencromwell/rust-pwgen/Cargo.toml
[INFO] crate bencromwell/rust-pwgen has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bencromwell/rust-pwgen against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/bencromwell/rust-pwgen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] edfc0650b55090341e5ab23fabbb03fcfb10a10dcd26d497ed100351c9806fff
[INFO] running `"docker" "start" "-a" "edfc0650b55090341e5ab23fabbb03fcfb10a10dcd26d497ed100351c9806fff"`
[INFO] [stderr]     Checking bcrypt v0.2.1
[INFO] [stderr]     Checking pwrust v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     let mut charsets: Vec<_> = vec![];
[INFO] [stderr] 60 | |
[INFO] [stderr] 61 | |     if matches.is_present("character sets") {
[INFO] [stderr] 62 | |         charsets = matches.values_of("character sets").unwrap().collect();
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> charsets = if matches.is_present("character sets") { matches.values_of("character sets").unwrap().collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     let mut charsets: Vec<_> = vec![];
[INFO] [stderr] 60 | |
[INFO] [stderr] 61 | |     if matches.is_present("character sets") {
[INFO] [stderr] 62 | |         charsets = matches.values_of("character sets").unwrap().collect();
[INFO] [stderr] 63 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let <mut> charsets = if matches.is_present("character sets") { matches.values_of("character sets").unwrap().collect() } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.19s
[INFO] running `"docker" "inspect" "edfc0650b55090341e5ab23fabbb03fcfb10a10dcd26d497ed100351c9806fff"`
[INFO] running `"docker" "rm" "-f" "edfc0650b55090341e5ab23fabbb03fcfb10a10dcd26d497ed100351c9806fff"`
[INFO] [stdout] edfc0650b55090341e5ab23fabbb03fcfb10a10dcd26d497ed100351c9806fff